- 16 Oct, 2018 12 commits
- 
- 
Tom Anderson authoredBUG=881371 R=pkasting Change-Id: I7a351ed115da2a265e74bfd8557c845b7faa3a60 Reviewed-on: https://chromium-review.googlesource.com/c/1281325 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#599796} 
- 
Collin Baker authoredThis allows tabs to be reached by the keyboard. Only tabs are made focusable, not the tab close buttons since tabs can be easily closed from the context menu. This also makes the tabstrip as an accessible pane so it can be reached by F6 and SHIFT+F6. Follow-up changes: - Look into having CTRL+W close the focused tab rather than the active tab when in keyboard accessibility mode. - Make keyboard focus advance to the next tab when closing the focused tab (rather than disappearing as it does now). Bug: 702414 Change-Id: I052ac56a6adfbc317a67c00314fd9259ab83fc2e Reviewed-on: https://chromium-review.googlesource.com/c/1241845 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#599795} 
- 
Chan Li authoredThis reverts commit ba8218bf. Reason for revert: Suspecting this breaks GcpReauthCredentialTest.OnUserAuthenticated on win-asan. Findit analysis: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/win-asan/builds/1834 Original change's description: > Add credential provider unit tests run on the buildbots. > > Fix up the tests so that they run correctly with base::LaunchUnitTests(). > Add the unit test exe to the buildbot configs. > > Bug: 789588 > Change-Id: Ib0ccf2bf965071e6afe2638db1fe3e565799c3e4 > Reviewed-on: https://chromium-review.googlesource.com/c/1274456 > Commit-Queue: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599656} TBR=rogerta@chromium.org,zmin@chromium.org,jbudorick@chromium.org,tienmai@chromium.org Change-Id: I33b666181bbe4234da257b567229c51c9bdf7ee7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789588 Reviewed-on: https://chromium-review.googlesource.com/c/1281880Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599794} 
- 
John Budorick authoredThis reverts commit 382f3853. Reason for revert: crbug.com/895592 Original change's description: > Add Dawn, SPIRV-Cross and GLFW to //third_party > > Dawn is a library implementing WebGPU in native. It uses SPIRV-Cross to > translate shaders from SPIRV to other shading languages, and requires > glfw for testing. > > Adds the Zlib license to the list of allowed license for Android. > > This also adds back shaderc that was very recently removed. So hopefully > a new third_party review isn't required. > > BUG=chromium:870747 > > Change-Id: I506156072f34e70e12797f922a979aa8c743bd6e > Reviewed-on: https://chromium-review.googlesource.com/c/1244817 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: dsinclair <dsinclair@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599740} TBR=dsinclair@chromium.org,cwallez@chromium.org,wfh@chromium.org,kainino@chromium.org,jochen@chromium.org,dominic@google.com Change-Id: I861d000856773e66a6a2c060ae737599b3be3e4d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:870747 Reviewed-on: https://chromium-review.googlesource.com/c/1281879Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#599793} 
- 
Jeremy Klein authoredBug: 881664 Change-Id: If8bc6ea2368c32a4a76d474ed625a0db5da0492d Reviewed-on: https://chromium-review.googlesource.com/c/1279426Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#599792} 
- 
David Trainor authoredRemove date and filter type separators from the new downloads home UI. BUG=893918 Change-Id: Ie52e136d056c6b89f34830de90d4f3701535fa59 Reviewed-on: https://chromium-review.googlesource.com/c/1277967 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599791} 
- 
Kurt Horimoto authoredThis coordinator manages a stack of optionally collapsible toolbars. It manages laying out these toolbars in a top-to-bottom or bottom-to- top order and interpolating the toolbars' heights based on the fullscreen progress. Ultimately, toolbar layout management will be moved from BVC to this coordinator. Bug: 880672 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2b143895d30ce1ec68f58141d7364f1d32ef3f39 Reviewed-on: https://chromium-review.googlesource.com/c/1220722 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#599790} 
- 
Bugs Nash authoredChange-Id: I0f8b8e40e39a9f05c58d410a724a5161aae0101b Reviewed-on: https://chromium-review.googlesource.com/c/1256324 Commit-Queue: Bugs Nash <bugsnash@chromium.org> Reviewed-by: Meggin Kearney <mkearney@chromium.org> Cr-Commit-Position: refs/heads/master@{#599789} 
- 
Justin Donnelly authoredTextfield creates partial selections from the point of the cursor on shift-up/down. Bug: 892216 Change-Id: I3196972dea1abeb5ffbf2d4381d27ca067e41bc6 Reviewed-on: https://chromium-review.googlesource.com/c/1276849Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#599788} 
- 
Chan authoredTBR=wjmaclean@chromium.org Bug: 891155 Change-Id: I27212eee19d0f7f67b4ee5caba3df4562edb30d2 Reviewed-on: https://chromium-review.googlesource.com/c/1281225Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599787} 
- 
Xianzhu Wang authoredRebaseline two tests that no longer produce a blank line. Tolerate failures under fast/events/touch and virtual/paint-touchaction-rects/fast/events/touch because many of the tests are failing or crashing and the tests change very fast. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6d0ad19f419b30059414a0c75b4495d03425633a Reviewed-on: https://chromium-review.googlesource.com/c/1282030Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599786} 
- 
Peter Boström authoredRemoves the need for custom ink-drop highlights. This change (as tested locally) should have no visual impact. It only reduces custom ink-drop usage. Bug: chromium:888204 Change-Id: Iefb2c6adf9f95a6d1265fb1dbd95ff0f0e7ecf97 Reviewed-on: https://chromium-review.googlesource.com/c/1279169Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#599785} 
 
- 
- 15 Oct, 2018 28 commits
- 
- 
Tarun Bansal authoredRemove ShouldBypassMissingViaHeader feature which has never been enabled in DRP, and there are no plans to enable it. Change-Id: Ife6b09da141468a44718e3b6cb43f4515c82ea29 Bug: 806114 Reviewed-on: https://chromium-review.googlesource.com/c/1279124Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599784} 
- 
Ahmed Fakhry authoredMany media and creative suite applications make use of Alt+Click actions, but we always rewrite it to Right-Click without giving the users a way to turn this behavior off. Users of such applications often use external mice, which already have an independent right click button. This CL limits this behavior to events coming from touchpad devices. BUG=890648 TEST=Expanded tests. Change-Id: I1b72eb4d9986e9139d7c6193cc2f808a6d9cad06 Reviewed-on: https://chromium-review.googlesource.com/c/1255605Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#599783} 
- 
Joel Einbinder authoredWithout this, taking a coverage report could be flaky if nothing forced a style recalc. This can happen very often in headless mode. Change-Id: If2bb596736f274d0aeceabec9ff7cf6076886eae Reviewed-on: https://chromium-review.googlesource.com/c/1279293 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599782} 
- 
Sahel Sharify authoredThis cl relands the following cl after excluding the added tests. https://chromium-review.googlesource.com/c/chromium/src/+/1278963 This gives the solution more time to bake on ToT without getting reverted due to flaky tests. Meanwhile I will work on the tests to deflake them. TBR=mcnee@chromium.org,creis@chromium.org Bug: 884728, 249063 Change-Id: Icc1e32ffe493f85d0ee74b0aff37ccdf078d0e8f Reviewed-on: https://chromium-review.googlesource.com/c/1281687 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by: Kevin McNee <mcnee@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#599781} 
- 
Mythri Alle authoredWhen site-isolation is not enabled (for ex: on Android), render process would not be locked to an origin. In such cases it is safe to use code cache by keying it only on the url of the requested resource. Earlier, we prevented any render process that is not locked to an origin from using code caches. Bug: chromium:812168 Change-Id: Ib231bfca19d7e40fdf9d9cdd430bb0aedbe7426f Reviewed-on: https://chromium-review.googlesource.com/c/1264675 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#599780} 
- 
Lei Zhang authoredPaymentRequestUnitTestBase is not a test class, yet it looks like one since it has SetUp() and TearDown(). To make it more obvious that it is not a test class: 1) Prefix SetUp() and TearDown() with "Do". 2) Label the SetUp() and TearDown() overrides in classes that inherit from PaymentRequestUnitTestBase. Typically the methods override PlatformTest. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5c43bd5bf5adee7acd93e40f9a403a90a95180ae Reviewed-on: https://chromium-review.googlesource.com/c/1281238 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#599779} 
- 
Sammie Quon authoredTest: manual Bug: 881483, 891366 Change-Id: I88c5d7a5d41f7ef4013c84debf5c4e963f891d21 Reviewed-on: https://chromium-review.googlesource.com/c/1279356 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599778} 
- 
Sky Malice authoredBug: 894178 Change-Id: I4883559139110accab3646cbd0a4dc5ab9dfdf85 Reviewed-on: https://chromium-review.googlesource.com/c/1278465Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#599777} 
- 
Krishna Govind authoredR=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I90108e14ed0c8efab2fad7cce2d1bd693b1f0ff1 Reviewed-on: https://chromium-review.googlesource.com/c/1282107Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#599776} 
- 
rbpotter authoredMediaRouterElementsBrowserTest.MediaRouterContainerCastModeList MediaRouterElementsBrowserTest.MediaRouterContainerFilterPart1 Bug: 875463 Change-Id: I6037ea16e264307a801840964197c058f33ab2a5 Reviewed-on: https://chromium-review.googlesource.com/c/1279415Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#599775} 
- 
Aleksey Kozyatinskiy authoredThis reverts commit 9c39f918. Reason for revert: break breakpoint in minified sources. Original change's description: > [DevTools] removed Breakpoint._currentState > > Current state on breakpoint shared between different models is hack > that should never work. > > R=lushnikov@chromium.org > > Bug: none > Change-Id: I60a0e5774c47c38a0f5f251f9e9d5f2437ceb9b4 > Reviewed-on: https://chromium-review.googlesource.com/1179262 > Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> > Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583934} TBR=lushnikov@chromium.org,kozyatinskiy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: Id6a170405c0d07658ff5741142dc2b35b7f89c6b Reviewed-on: https://chromium-review.googlesource.com/c/1281688Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#599774} 
- 
Dominick Ng authoredThe IntentPickerBubbleView is provided with a list of app candidates to display to the user for them to choose to open a link. If Chrome can handle a link, it is included in the list of candidates, but it is erased in IntentPickerBubbleView::Init(); users use an independent button in the UI to open the link in Chrome. This led to a browser crash bug in the ArcExternalProtocolHandler, where it was possible for Chrome to be the only candidate available, e.g. in the case of a geo:// URI scheme link. On clicking a geo:// link on a Chrome OS devices with Play enabled and no Android apps available to handle the geo:// URI scheme, the intent picker would try and select the 0th index app candidate during its initialization, but this would be null since the only candidate (Chrome) was erased. This CL fixes the bug by not creating the intent picker at all if the only app candidate is Chrome. The external protocol dialog can only be triggered if Chrome originally decided it couldn't handle the URL, so in this case we simply fall back to the Chrome OS standard dialog (which says that Chrome OS can't handle the URL). BUG=893042 Change-Id: I171d547e51a4dfb37d51c3e71a88a8c84539a8fa Reviewed-on: https://chromium-review.googlesource.com/c/1280090 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#599773} 
- 
Darren Shen authoredCurrently, KeyboardUI has a weird interface where |GetKeyboardWindow| will start loading the keyboard web page if it is called the first time. So this resulted in a lot of places where we were calling GetKeyboardWindow and didn't know whether it would cause a load or not. We change the KeyboardUI interface a bit to explicitly state when we are creating / loading a keyboard window, vs just getting an already loaded one. This removes ChromeKeyboardUIWebContent's dependency on KeyboardController as well. We tried to keep the same behaviour for existing KeyboardUI subclasses. Bug: 845780 Change-Id: I3178c81c382f2c3cd8217eda5a0c9b9d489df5be Reviewed-on: https://chromium-review.googlesource.com/c/1264336 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#599772} 
- 
Michael Spang authoredThis class doesn't support overlays, so "return false" is actually correct. Bug: none Test: run_content_shell --ozone-platform=scenic --enable-vulkan --disable-gpu Change-Id: I8768c2d5cdb3de8b4ce9f50a4efd18848e321bd6 Reviewed-on: https://chromium-review.googlesource.com/c/1281686Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599771} 
- 
Scott Violet authoredNow that there is serialization code for mouse/touch, this code should no longer be needed. BUG=895619 TEST=covered by tests Change-Id: Ia439067d35dd239e914b8bace1164f97bba5c26e Reviewed-on: https://chromium-review.googlesource.com/c/1282032Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#599770} 
- 
Joel Einbinder authoredThis adds the new properties: invisible editable focusable focused settable Bug: 887173 Change-Id: Iaa9dc346d10648ada9d16c6a3568f83fdd83f397 Reviewed-on: https://chromium-review.googlesource.com/c/1244548Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#599769} 
- 
Luum Habtemariam authoredThe use of the IppValidator chrome service has been iterated until it now just a secure parser that passes the rigorously formatted result to the validator. This name change of IppValidator --> IppParser reflects that. Bug: None Test: Behavior N/A and unchanged Change-Id: I3369b59973bb0f55200ed450c8558a8616f92355 Reviewed-on: https://chromium-review.googlesource.com/c/1278585Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#599768} 
- 
Albert J. Wong authoredThis is just a starter file without much in it yet. It came out of a thread on the principles for how one gets added to //base/OWNERS. The summary was originally written by danakj@ and later resummarized and posted by gab@ in to https://chromium-review.googlesource.com/c/chromium/src/+/1216602 Bug: none Change-Id: I4dcb438226c84020de77e4d6873ab9330d891bee Reviewed-on: https://chromium-review.googlesource.com/c/1220677Reviewed-by: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#599767} 
- 
Morten Stenshorne authoredNG does this more correctly than legacy. This is quirks mode, and legacy doesn't drop the block-end margin on the P inside the table cell, like it should. https://html.spec.whatwg.org/multipage/rendering.html#margin-collapsing-quirks In quirks mode, any p element that is the child of a td or th element and has no substantial following siblings, is expected to have a user-agent level style sheet rule that sets its 'margin-block-end' property to zero. TBR=dgrogan@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I075b56d439056546da737b1c08fa80b24dd33314 Reviewed-on: https://chromium-review.googlesource.com/c/1281423 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599766} 
- 
Peter Boström authoredAn earlier refactoring set zero-insets for touchable AvatarToolbarButton instead of insets for TOOLBAR_BUTTON. This API was confusing to use so SetLayoutInsets was changed and renamed to SetLayoutInsetDelta to make it easier to use. Callers no longer need to include the call to GetLayoutInsets(TOOLBAR_BUTTON). CastToolbarButton having incorrect ink-drops was not a regression but has always used a 16dp icon in both touchable and non-touchable modes. This change also calls SetInsetDelta to make up for the missing 8dp. Bug: chromium:895263 Change-Id: I30595913dfb8a19358d198d9f4e0dbcb37993117 Reviewed-on: https://chromium-review.googlesource.com/c/1281903Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#599765} 
- 
Michael Spang authoredAdd a note that explains how to capture device capabilities for tests to avoid errors in manually entered data. Also make the script capture all devices if none are specified, so that it's easier to run. Bug: 895553 Test: ui/events/ozone/evdev/capture_device_capabilities.py Change-Id: I84ca174077cd77a89e8adf59570e9e33e1fd04a9 Reviewed-on: https://chromium-review.googlesource.com/c/1281232 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599764} 
- 
Guohui Deng authoredWhen appropriate, AudioOutputStream uses MixerService for lower latency audio playback. Bug: internal b/29571387 Test: Play a lasting sin wave audio on two devices, to make sure the AudioOutputStream plays fine whether or not MixerService is used. Change-Id: Ieebd53ee5ecdc1c6e249601366d82de30c5d9119 Reviewed-on: https://chromium-review.googlesource.com/c/1271007Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#599763} 
- 
chromium-autoroll authoredThe AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I293419ed726feb3a05ac85ab3d9150744535c285 Reviewed-on: https://chromium-review.googlesource.com/c/1281865Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599762} 
- 
Peter Boström authoredMoves color derivation to GetInkDropBaseColor() and removes ripple and highlight overrides. This change also makes use of the newer FocusRing class instead of using a FocusableBorder. FocusRing automatically follows the highlight path and has a more consistent style with the rest of the UI. This change also removes an override of AddInkDropLayer which clipped the layer to the view bounds. This is not required for this ink drop as it only paints within the highlight path which is within the view bounds. Bug: chromium:888204 Change-Id: I7b388f1fe52aea6b14c32d27c0f39d5e2cff527e Reviewed-on: https://chromium-review.googlesource.com/c/1279289Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#599761} 
- 
Shakti Sahu authored1 - Download home looks black on tablets for certain views such as storage header, date header etc. This is fixed by adding the default background color to the main view, which was also present in old download home. 2 - Share crashes when there is no activity to handle it. Fixed it by wrapping with an intent chooser intent. 3 - Changed images on tablets to use fixed 240dp width instead of going full screen. Bug: 889723 Change-Id: Ib9d582f7f81debd2b588dc901ddfede36829ef33 Reviewed-on: https://chromium-review.googlesource.com/c/1278143 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#599760} 
- 
gogerald authoredThis CL also records script's running status. Bug: 806868 Change-Id: I36adaffce7718d875a2bd0497dc281dd795b12f1 Reviewed-on: https://chromium-review.googlesource.com/c/1281722 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599759} 
- 
Scott Violet authoredBUG=none TEST=none Change-Id: I51c3a93e47157e5b203fc39f72d5f083b305cc80 Reviewed-on: https://chromium-review.googlesource.com/c/1281233Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#599758} 
- 
Mike Wasserman authoredBug: NONE Change-Id: I7616d84159788203ebd0016ba745867d3f09f711 Reviewed-on: https://chromium-review.googlesource.com/c/1281179Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#599757} 
 
-