- 10 Dec, 2020 40 commits
-
-
Markus Handell authored
It was noticed that incoming packets are now handled on the WebRTC signaling thread. This is problematic because many JS WebRTC API calls get indirectly executed there due to WebRTC's synchronous proxies. And vice versa - lots of packet handling can delay API calls. This change adds an enabled-by-default feature called WebRtcDistinctWorkerThread which splices out WebRTC's worker execution into its own thread - decoupling the packet processing from the signal thread. Bug: 1157617 Change-Id: I16998a3ae0df022ffd544f5a3e2d7d8ada1acfb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546006 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#835887}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/c82eeeef0783..ccc67252ffa4 2020-12-10 dneto@google.com spirv-reader: support OpBitCount, OpBitReverse 2020-12-10 dsinclair@chromium.org Cleanup some includes 2020-12-10 dsinclair@chromium.org Update namer to use symbol table. 2020-12-10 bclayton@google.com Implement textureWrite() 2020-12-10 bclayton@google.com Rework the FirstIndexOffset transform 2020-12-10 dsinclair@chromium.org Add a symbol table. 2020-12-10 dneto@google.com spirv-reader: support more integer builtins 2020-12-10 dneto@google.com spirv-reader: remove redundant disabled test 2020-12-10 bclayton@google.com Fix CMake build when TINT_BUILD_FUZZERS=1 2020-12-10 bclayton@google.com Fix HLSL emission of cbuffers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Ic4c73f20260173c38efb289fafca16c79b2bce3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585722Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835886}
-
rbpotter authored
Bug: 1156918 Change-Id: I0d3fcd231a8896aee4d3869cc1bb7b080e1558f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581022 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#835885}
-
Nick Burris authored
* Move ExternalAuthUtils into //components. * This allows it to be used by the downstream GooglePayPaymentAppFactory once it moves to components. This is patch 4/6 for refactoring ExternalAuthUtils into //components. Bug: 1144858 Change-Id: Ib86cc7d7a85a51d5c392f060926ec7d3d8af04e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535936Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#835884}
-
cfredric authored
The suggestions were to use range-based for-loops instead of C-style for-loops. I also noticed some opportunities to use <algorithm> instead of raw loops, and made those changes as well. Change-Id: Ic5bf82090ef6f7b5a0a6908b0df4d4aa9ca9a959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584703 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#835883}
-
Gavin Williams authored
This change adds an ARIA label for the preview area that is updated depending on the current page: -In the initial state, grab the scan preview instructions from the page -While scanning, update the label when the page number increases -When the scan is completed successfully, announce scan is completed and the total number of pages scanned. Bug: 1059779 Change-Id: I1fcdf2552f779737a69d95fe5971c1b98c0a6aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580846 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#835882}
-
Kyle Horimoto authored
This code previously had erroneously stored a DeviceIdPair by reference, meaning that the field could potentially be referring to deleted memory. This is a potential culprit for an issue which causes authentication to fail in the SecureChannel protocol. Bug: 1157278 Change-Id: I97589e7e94865fb0f841a8adbe19dffb9d2e0a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585589 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#835881}
-
Toni Barzic authored
BUG=1142572 Change-Id: I49118e70cc7efa9152c92c4cda48312b2f67e9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585705Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#835880}
-
Jing Wang authored
Bug: 1156385 Test: passed unit tests and browser tests. Change-Id: Iae354b3c46757441ff1cf7f52cd715f831a0213e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577113Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835879}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/b2522b5f9832..79c6ea2a0c44 2020-12-10 jophba@chromium.org Refactor session message sending If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I84069036dab609e48730aff45256ec654dfcf756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585711 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/59df85b5457e..6def748c92e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If9a747e6a06df234076bbde11a94da782dcef27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585664Reviewed-by:
-
My Nguyen authored
We are going ahead with rolling out to 100% of users so enable feature by default Bug: 1049826 Change-Id: I9e838844a0323e502ba79d4f5a706f285081eea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581624Reviewed-by:
-
Illia Klimov authored
Flash is deprecated since M87 and almost entirely removed in M88+. This CL removes ContentSettingsType::PLUGINS from PluginUtils and returns CONTENT_SETTING_BLOCK for any Flash-related request. Bug: 1149393 Change-Id: I7649e568e634556a698edc066efba70b53a1f291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582219 Commit-Queue: Illia Klimov <elklm@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#835875}
-
rajendrant authored
LoginRobotsDeciderAgent is added which is the login and robots checking based decider implementation that overrides PublicResourceDecider. This new agent class maintains a cache of robots rules for different origins, for checking robots.txt eligibility. Change-Id: I58d0cc6afd6131b2f26f26e8aea8757a6c002542 Bug: 1144836 TBR: reillyg@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574073 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#835874}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f83a0f03ccf4..8e3a4ab1fe23 2020-12-10 lalitm@google.com Merge "perfetto: add empty trigger name to match change to proto" 2020-12-10 lalitm@google.com Merge "tp: extract out track event methods from track tracker" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If824fd4f5f2a6151db2833b331618f129feda565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585720Reviewed-by:
-
Robert Ma authored
Breakdown of this big change: 1. Add two WPT builders to builders.json, and a new method to builder_list to check whether a builder runs wptrunner, which is needed to create special cases for WPT (see below). 2. Relax conditions in results_fetcher to include wpt_tests_suite, too. 3. Add a new helper method get_file_path_for_wpt_test to base.py with some cleanup to make param names more consistent. 4. Add a "non-prefix mode" to TestBaselineSet, where added tests are treated as the full test paths without lookup via the port object. This is needed because test paths on WPT builders are not relative to web_tests (but instead to web_tests/external/wpt); it also makes sense as rebaseline-cl always adds specific tests instead of test prefixes. 5. Two special cases for WPT builders in rebaseline.py that will stick: a. _file_name_for_expected_result looks up the real test file of a WPT test (to work with variants, etc.) and add ".ini" instead of "-expected.txt" to the filename. b. _suffixes_for_actual_failures unconditionally returns "txt" for a WPT test, ignoring other artifacts (e.g. png for reftests). 6. Three special cases for WPT builders that need to be reverted when we have full-platform coverage (marked with TODO), all related to the optimizer: a: Skip copy-existing-baselines-internal in rebaseline.py. b: Skip _optimize_baselines in rebaseline.py. c. Directly download to the generic baseline path instead of the platform-specific one in rebaseline_test.py. Drive-by: 1. To make test setup easier, _add_manifest_to_mock_file_system is moved from base.py to test.py as a new public helper. 2. Add or tweak the __repr__ methods of some classes for clearer debug logging. 3. Reformat using "git cl format". Bug: 1154085 Change-Id: I4c4434f73f68d9848267579f1ef544a6b05903cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575859 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#835872}
-
Angela Gyi authored
This CL adds a feature flag for enabling the content previews feature on Chrome OS devices. Bug: 1156343 Change-Id: Idb4b5c4d7d77b7532e7c585759067893a14912eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576987 Commit-Queue: Angela Gyi <angelagyi@google.com> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#835871}
-
Tom Anderson authored
GDK_BACKEND gets set by chrome-remote-desktop [1]. GDK_BACKEND takes precedence over gdk_set_allowed_backends() [2], so this means weston sessions (which inherit GDK_BACKEND) will incorrectly try to use X11, which won't work. To avoid this, manually set GDK_BACKEND during GTK initialization. [1] https://source.chromium.org/chromium/chromium/src/+/master:remoting/host/linux/linux_me2me_host.py;drc=be48a068a67faa7f3bc2ea0d03529d62319f06fb;l=461 [2] https://gitlab.gnome.org/GNOME/gtk/blob/3.24.5/gdk/gdkdisplaymanager.c#L441 BUG=None R=nickdiego Change-Id: I5ae6cae1511e4a7215098a0c291d735303a1827f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586184 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#835870}
-
Brandon Wylie authored
Bug: 1156401 Change-Id: I5a86a197f8d35cd0ae2c5e4878f4070fc844434e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580003 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#835869}
-
Brandon Wylie authored
Bug: 1123209 Change-Id: I7ef370fe1e6b571bec3a3f1a74e2305e46763a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566334 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
Joon Ahn authored
http://screen/BSS3pyv4WRqJY73 Bug: 1156229 Change-Id: I132fd519bfff65b8a7052da90323c64800b1ae89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581883 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#835867}
-
Wenyu Fu authored
* Verify certain options in CCT AppMenu and ContextMenu are disabled; * Verify Contextual Search is disabled. Bug: 1120853 Change-Id: I37a614f35fb3a5781d483e4266ec89db9198cc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582807 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#835866}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d79114a2ed63..c94b21d60ca4 2020-12-10 gavinmak@google.com [owners] Use new API to list owners for file If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Ie57a31ab970833239a57197d07f07003b3d0604a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585716 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Sebastien Marchand authored
This extra complexity isn't needed. Bug: 1144025 Change-Id: I0eaf083401469d1a512b75fb146c9c424d907923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584707Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#835864}
-
Rakib M. Hasan authored
Due to issues with the bot updates step on the skew test refresher builder, I have to manually update the binary versions tested. Bug: 1156861 Change-Id: Idb1b86b0aaaa933dd99699988dd869d2f6752338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585552Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#835863}
-
Charlie Hu authored
Bug: 1151954 Change-Id: I1b5e1ea475605947fad6715b4c24f37a3bb018eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577862Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#835862}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4324.9-1606733211-benchmark-89.0.4343.0-r1 to 89-4342.0-1607345364-benchmark-89.0.4351.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I668fb1438a7a245c04f1e70f39a5555d21a29882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586208Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4324.9-1606737320-benchmark-89.0.4343.0-r1 to 89-4324.22-1607342008-benchmark-89.0.4351.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If3aa4bc39ef1f592a8a2ed94a08a2474fdf81812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585738Reviewed-by:
-
Gordon Seto authored
This reverts commit c641fdaa. Reason for revert: Fix tests that were failing due to nearby_contact_visibility.html being loaded directly in the test at nearby_share_browsertest.js:171. This caused V1 tests to fail because loading the source directly skips loading the strings that are required. In this CL we remove the browsePreload() override so that the nearby_contact_visibility.html source is not loaded directly. This is the same logic NearbyOnboardingPageTest does, which also needs to use string-loading during its tests. Original change's description: > Revert "[Nearby] Update subpage visibility text and fix dialog a11y." > > This reverts commit dc4eea24. > > Reason for revert: It looks like this is causing test failures --> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/21664/ Change-Id: I0e503980ce97d8b8fe3740bba81697c7ed453801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583115Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/505943a6a4cb..bd6d8e4204b5 2020-12-10 wl@gnu.org .mailmap: Add Priyesh. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC thestig@google.com,bungeman@google.com,drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: thestig@google.com,bungeman@google.com,drott@google.com Change-Id: I5a4fe829beb2c74be504834ecb34dd9822311169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585704Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#835858}
-
Ben Joyce authored
Bug: 1157340 Change-Id: I8d261a7811e0c785080e2b80419ea8af98bf53d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585387Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#835857}
-
Alex Leung authored
Modules in //chromecast/media/common are shared with internal repos and cannot have any //media dependencies. I left in targets/headers that redirect to the new targets and will be removed once internal dependencies have been removed. Bug: b/174777644 Change-Id: I8456f8c1315f711a10d98b4c0b9d2490e3462596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578386Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#835856}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0379a1cd635..cfb713273ffa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aaronhk@google.com,bartekg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1156885 Tbr: aaronhk@google.com,bartekg@google.com Change-Id: I110a1fbd0d14add251ea246fb556708570f080d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585725Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This patch implements: - The core of the "generate a counter representation" algorithm [1] for all counter algorithms - The fallback algorithm when a @counter-style fails to represent a given counter value This patch does not implement 'prefix', 'suffix', 'negative', 'pad' descriptors, and also the first symbol value for 'fixed' system. These will be left for future patches. [1] https://drafts.csswg.org/css-counter-styles-3/#generate-a-counter Bug: 687225 Change-Id: I93c8914ab72cbf22f768f0a3e3cada42909975cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581201Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835854}
-
Jeroen Dhollander authored
This unfortunately ended up being a rather big change. It includes: - Adding unittests for chromeos/services/libassistant - Introducing a |StateObserver| to inform the assistant service when the |AssistantManager| has been created. - Rename |ServiceController| to |ServiceControllerProxy|, to prevent confusion with the |ServiceController| in the libassistant service. Bug: b/171748795 Test: chromeos_unittest --gtest_filter="AssistantManagerServiceTest.*:ServiceController*.*" Change-Id: I1dc675aeb1ded0cb2c9a3a35bea57fc03fce4f06 TBR: sky@ Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522332 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835853}
-
Harry Cutts authored
This CL adds a new setting for the pointing stick's primary button, with a corresponding dropdown on the pointers subpage. The setting carries over to the login screen, too. If the flag is disabled, changes to the equivalent mouse setting are copied to the pointing stick setting as well. See go/cros-pointing-stick-settings (Googlers only, sorry) for the design doc. login screen) Bug: 1114828 Test: Check the dropdown changes the primary button (including on the Change-Id: I3f078767bfe703a2f451eac807969e68e5273902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573389 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:Michael Spang <spang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835852}
-
Jiaqi Han authored
The classpaths written by build/android/gyp/create_java_binary_script.py are relative paths to the current working directory, this CL removes the duplication part for the concatenation of source root and the relative paths. Merge-With: eureka-internal/494461 Bug: None Test: CQ Change-Id: I434e2807c86909c86dad9c5ebd528b8fbe56b041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582411 Commit-Queue: Jiaqi Han <jiaqih@google.com> Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#835851}
-
Amr Aboelkher authored
Hash dance timer usually starts off whenever the AutoEnrollmentCientImpl is going to start i.e. AutoEnrollmentCientImpl::Start(). However, as PSM is being executed in the beginning, before Hash dance sequentially, that will make the resulting Hash timer record Hash dance duration + PSM duration. This CL is starting the timer of Hash dance only when preparing and sending off the Hash dance request. Also, it adds its required regression tests. BUG=chromium:1157317 Change-Id: Ie4aa0b8a3bd6cf296e3804995cacc45c23833c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582121 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#835850}
-
Yue Li authored
This is a reland of 8144dae3 Original change's description: > Quick Answers: Add page size options for Search request > > Since we only use the first result from search request, set the page > size to 1 to reduce the delay. > > Bug: b/173239982 > Test: None > Change-Id: Ib2abd92e23b430b837f0556c31bcc0d17873256e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574072 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Yue Li <updowndota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833940} Bug: b/173239982 Change-Id: I357edef540563fdbc8b5ba93bbb78ac127d827b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578262Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/35f077086ef3..0a64a9747555 2020-12-10 swiftshader.regress@gmail.com Regres: Update test lists @ d94a77b3 2020-12-10 nicolascapens@google.com Update dEQP/Cherry setup documentation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0b3163a44bdbfe146dcfdcd142059394452f6a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584694Reviewed-by:
-
