- 06 Feb, 2020 40 commits
-
-
Fredrik Söderquist authored
Change-Id: Ie4c00b4b6b6eba3b55f86793620a502780590864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041270Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#738955}
-
Fredrik Söderquist authored
Bug: 658305, 862716, 968791 Change-Id: I33a0a1648e22c1f51f8eed04219be808110a4083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041472 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#738954}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/438b9bbca2aa..586d923fba12 Created with: gclient setdep -r src-internal@586d923fba12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049528 Tbr: jbudorick@google.com Change-Id: Iea832bcdd8894f486db7d55bffc5195eacb47227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041903Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738953}
-
Anton Bikineev authored
Generational barrier is needed to track inter-generational pointers in the remembered set (which is implemented as a card table). The barrier is implemented under a macro flag BLINK_HEAP_YOUNG_GENERATION and is off by default. Design doc: https://bit.ly/2ZXGU20 Bug: 1029379 Change-Id: I9931c409d119d35e85185970cff0a62f1171fc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000726Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#738952}
-
Hitoshi Yoshida authored
- Uses (CxxFuncDeclNode and) CxxFuncDefNode for all functions. - Makes a function declaration and its definition together. Bug: 839389 Change-Id: I8e0d8c981c03bb5f7ed65478cdf6cdd19e02ab56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040974Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#738951}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4721e067812f..f6e3eaf05150 git log 4721e067812f..f6e3eaf05150 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 rmistry@google.com Change name from skia.primary->luci.skia.skia.primary Created with: gclient setdep -r src/third_party/skia@f6e3eaf05150 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1024947 Tbr: scroggo@google.com Change-Id: I2f3c1fc6cab8147faed27df8443837b541400ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041902Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738950}
-
Andrew Grieve authored
Was broken by b2706770 where the zipfile.ZIP_DEFLATED was removed from when creating the ZipFile object. Rather than add it back, this fixes the problem by being explicit about compression for every file added. Bug: 1049461 Change-Id: I670d733792b5cf4af5fb7821fcc7efe9a670e33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040954 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738949}
-
Maks Orlovich authored
It's always created[1] with null SpecialStoragePolicy, so it doesn't actually do any cleanup, but its base class still does some bookkeeping, wasting memory. The actual cleanup for CONTENT_SETTING_SESSION_ONLY is done by SessionCleanupCookieStore in the network service process with help from its CookieSettings. [1] For the chrome-extension:// cookie jar and for Android Webview when it creates the cookie jar itself. Bug: 488710, 934009 Change-Id: I5bc34551e92e50e9cb799f99c804c24895c290a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906642Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#738948}
-
Brian Osman authored
Change-Id: I90a2e27df04b88fb49a0bf93d54b6391ed73fdf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039312Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#738947}
-
Gauthier Ambard authored
The test is failing on the iOS13 beta bot. TBR= stkhapugin@chromium.org Bug: 1045950 Change-Id: I572729c0d26bab9af450779c18b3c9d264530c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041447Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#738946}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef0d76ae836b..a9e10263044b git log ef0d76ae836b..a9e10263044b --date=short --first-parent --format='%ad %ae %s' 2020-02-06 mbonadei@webrtc.org Make video_replay buildable from Chromium. Created with: gclient setdep -r src/third_party/webrtc@a9e10263044b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:942546 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia9d137ff1805e966ab7276e8a84021420abaea5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738945}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/49346f1e6753..b04bd5953150 git log 49346f1e6753..b04bd5953150 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@b04bd5953150 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I90dfabb7bbeea526b786579f86dc033337bcfdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041901Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738944}
-
Mohamed Heikal authored
missing | between paths Change-Id: Id397e887b584bb5026cb410e5b2297681ad1e84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040047 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738943}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1ffa05369da3..3403d9601aa6 git log 1ffa05369da3..3403d9601aa6 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 mythria@chromium.org Remove UE bucketing in runtimeStatsTotalMetric Created with: gclient setdep -r src/third_party/catapult@3403d9601aa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:958441 Tbr: sadrul@google.com Change-Id: I714bcaefeda2186b1b95550c937d3fe8155a6e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041896Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738942}
-
Rune Lillesveen authored
It is perhaps not super clear from the spec, but the Note in [1] talks about: "single-page vector documents (single-page PDFs, XML files with an SVG document element)". This CL adds a test that checks that external resources are not loaded for SVG documents used as an img source. This matches the behavior of Firefox and Chrome, at least. [1] https://html.spec.whatwg.org/multipage/embedded-content.html#the-img-element Change-Id: I9ab713b24fdea5b7d98c5ca6463de4c3674fb8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041595 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#738941}
-
Mihai Sardarescu authored
This reverts commit 9b7b1b3a. Reason for revert: Fixed downstream compilation Original change's description: > Revert "Use EarlGrey wait condition instead of spinning the runloop." > > This reverts commit 7a4958d3. > > Reason for revert: Downstream code is using signOutAndClearAccounts > > Original change's description: > > Use EarlGrey wait condition instead of spinning the runloop. > > > > The sign-in external URL tests were spinning the runloop while waiting > > for the identities to be removed from the ChromeIdentityService. This > > was consistently failing with EarlGrey2. > > > > This CL uses an EarlGrey wait condition instead of spinning the runloop > > while waiting for the identities to be removed. > > > > Bug: 1031986 > > > > Change-Id: I0bcf6bda55caa506fe3a4d54ee607efc5c2e4d37 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039551 > > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#738916} > > TBR=msarda@chromium.org,sdefresne@chromium.org > > Change-Id: I87b517b4669f02af19c516997eba465f51eb0c22 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1031986 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041753 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738934} TBR=msarda@chromium.org,sdefresne@chromium.org,gambard@chromium.org Change-Id: I5be4d0bad2ac69aade4f9707a55303608bfa3644 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041598Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#738940}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f5d128faa213..7572c967ba08 git log f5d128faa213..7572c967ba08 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src b82ed734e767..656650f461c8 (1 commits) 2020-02-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 9e52bc0d0c1d..1f03ac10270a (1 commits) Created with: gclient setdep -r src/third_party/angle@7572c967ba08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I119356dff6815ed375ac1bea809c010c1e1cf34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041329Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738939}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8b18fef9..928314e9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1ec539460679b0621f8968c49769403185cdbd74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041631Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738938}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2f0985686143..6e49edeb0077 git log 2f0985686143..6e49edeb0077 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 lalitm@google.com Merge "tp: correct omitting sqlite order by for span join" Created with: gclient setdep -r src/third_party/perfetto@6e49edeb0077 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I663d0cb208e1fd0c9b1b133467e0af28d1918cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041891Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738937}
-
Camille Lamy authored
This CL introduces ClientSecurityState, a struct that keeps track of various WebPlatform security properties which need to be enforced on each URLLoaderRequests for a particular fetch client. Change-Id: I91fac078e0a9dd4f5ec06342990dd227a71001ce Bug: 986744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013040 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#738936}
-
Maksim Moskvitin authored
This patch moves TTL logic (crrev.com/c/1950987) to FCMNetworkHandler layer. There should be no behavioral changes. Bug: 1034510 Change-Id: I324073677027065dd50b399351f24479d3d35579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038731 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738935}
-
Gauthier Ambard authored
This reverts commit 7a4958d3. Reason for revert: Downstream code is using signOutAndClearAccounts Original change's description: > Use EarlGrey wait condition instead of spinning the runloop. > > The sign-in external URL tests were spinning the runloop while waiting > for the identities to be removed from the ChromeIdentityService. This > was consistently failing with EarlGrey2. > > This CL uses an EarlGrey wait condition instead of spinning the runloop > while waiting for the identities to be removed. > > Bug: 1031986 > > Change-Id: I0bcf6bda55caa506fe3a4d54ee607efc5c2e4d37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039551 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738916} TBR=msarda@chromium.org,sdefresne@chromium.org Change-Id: I87b517b4669f02af19c516997eba465f51eb0c22 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041753Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#738934}
-
Roman Sorokin authored
The limitation is outdated and there is no reason to limit it anymore. Setting the limit to 50 to have sensible scroll view of users. This has nothing to do with the disk space exhaustion. That handled separetely. Fixed: 1040890 Change-Id: Ib13d065f55cc9cc1d1d6f65a2b4db9d65805bb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041442 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#738933}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I7bc634d2d929b56a0e4626fb32bedef1022bce7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041793Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738932}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/54ed3a9a55df..49346f1e6753 git log 54ed3a9a55df..49346f1e6753 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 yangguo@chromium.org Remove experiments query param from scripts Created with: gclient setdep -r src/third_party/devtools-frontend/src@49346f1e6753 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048124 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If982deaad7650ca3fd100e2ecbec71315b0ebfd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041327Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738931}
-
Alex Chau authored
Bug: 1048704 Change-Id: I29dacfd0d0b0b0f4231160decb82f4ee4099922f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036184 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738930}
-
Mikel Astiz authored
The vast majority of bookmarks have already gone through the USS migrator according to metric Sync.USSMigrationEntityCount.BOOKMARK and it's no longer worth maintaining the historically-problematic USS migrator. Specifically, the proto fields originator_cache_guid and originator_client_item_id and NOT populated by the USS migrator, and this causes issues when it comes to inferring GUIDs for bookmarks, as the code started doing recently in particular with https://chromium-review.googlesource.com/c/chromium/src/+/1948430. Change-Id: I537faa4c19300e12e23ff0a97b1ad52d165d5e3a Bug: 1048381,978430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041290 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738929}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I22d4d88e7db7be3f7f2b345147ad3fd83de6ff96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738928}
-
Luca Hunkeler authored
Currently the title of the onboarding screen is a picture. This cl changes it to a string so that it can be translated. Bug: b/142367194 Change-Id: Icd501c7c9d19eaf88c4c91706250a62fb46a7dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020929Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#738927}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13965cf764df..438b9bbca2aa Created with: gclient setdep -r src-internal@438b9bbca2aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I19413269fd02e0ad5fc76658f97bfd6be0a6b9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041325Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738926}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/250ade1409dc..297e9f7db90b git log 250ade1409dc..297e9f7db90b --date=short --first-parent --format='%ad %ae %s' 2020-02-06 btolsch@chromium.org Add coverage tool setup + documentation Created with: gclient setdep -r src/third_party/openscreen/src@297e9f7db90b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ief8b0553da29b7db24e59ebb31799a8673961bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738925}
-
Dominique Fauteux-Chapleau authored
Replace hard-coded colors with ones taken from the theme and background instead. Also add back some code that set text properties that were removed by mistake in a previous CL. Bug: 999145 Change-Id: I8f43c87b71dc3f4025433058729239e6cdb4ade5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028300Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#738924}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/78c7c5247c3e..ef0d76ae836b git log 78c7c5247c3e..ef0d76ae836b --date=short --first-parent --format='%ad %ae %s' 2020-02-06 ilnik@webrtc.org Add more VP9 header correctness check in RtpFrameReferenceFinder 2020-02-06 eshr@google.com Move quality rampup experiment to overuse module Created with: gclient setdep -r src/third_party/webrtc@ef0d76ae836b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1049129 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3492c44a781e99e9941ab1dcbf83edea22a239d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041326Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738923}
-
Maria Kazinova authored
It is needed ro check the assumption that the data message received and parsed on submission contains only one form at a time. Change-Id: Ibb7af31e283bc67f40be1a46ad4bde4fb9763457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038572 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738922}
-
Stephen Chenney authored
TBR=fs@opera.com Bug=1048765 Change-Id: Idb287f3faf67a9f5f474883c58481de518b7349c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041870Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#738921}
-
Sean Harrison authored
Merge all Privacy page logging tests into one test Test flakiness of UMA logging tests appears to be related to intermittent timeouts. This has been fixed by merging all tests in the suite into one test that navigates around the privacy card instead of separate tests that reinstantiate the browser for each test in the suite, dramatically speeding up the whole test suite. Bug: 1043665 Change-Id: I3332516923dfbfa780fc1dee1561ecdd15bd0774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027333 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#738920}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cbf79b95c2d4..4721e067812f git log cbf79b95c2d4..4721e067812f --date=short --first-parent --format='%ad %ae %s' 2020-02-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@4721e067812f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I8708a22ffae046602c1595762a80c1556503dccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041324Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738919}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/656650f461c8..2d70e98deab2 git log 656650f461c8..2d70e98deab2 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 johnkslang@users.noreply.github.com Merge pull request #2028 from ShchchowAMD/constant_expressions_array_mod Created with: gclient setdep -r src/third_party/glslang/src@2d70e98deab2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: Idfefe3ae6574bb045315397233dfaa922384bf12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041316Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738918}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d2d1b4e4..8b18fef9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I33dda80da936735b8a5bed0b61ec94093fa83ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041630Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738917}
-
Mihai Sardarescu authored
The sign-in external URL tests were spinning the runloop while waiting for the identities to be removed from the ChromeIdentityService. This was consistently failing with EarlGrey2. This CL uses an EarlGrey wait condition instead of spinning the runloop while waiting for the identities to be removed. Bug: 1031986 Change-Id: I0bcf6bda55caa506fe3a4d54ee607efc5c2e4d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039551Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#738916}
-