- 07 Feb, 2020 40 commits
-
-
Xiaohui Chen authored
This is a reland of f7860793 Fix original build error and some additional refactoring. Original change's description: > assistant: add audio ducking for internal media > > Bug: b/135064564 > Test: locally build and run with multiple media playing > Change-Id: I3814cfc3bc619077ca6781493fd369c27d50eb4e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899184 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713200} Bug: b/135064564 Change-Id: Ief51c008cb8dba3e6ae4757405c69fca01a94524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903755 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#739453}
-
Rouslan Solomakhin authored
This patch runs the exploit test both with and without Scroll-to-Expand payment handler feature. Since SmokeTest was failing due to an issue in Chrome Custom Tab, which is not being used with Scroll-to-Expand payment handler, this configuration can run the SmokeTest, thus increasing code coverage overall. Bug: 998737 Change-Id: I8ced750c67d08a93f0733c85ec07884d3c6989c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042293Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#739452}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/87e3bef6f82f..b18578549919 git log 87e3bef6f82f..b18578549919 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 senorblanco@chromium.org Reland "Cleanup program building a bit" 2020-02-07 michaelludwig@google.com Use DrawQuad struct to group device+local coords Created with: gclient setdep -r src/third_party/skia@b18578549919 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: Ia43b68908f808b5fd981b1a78eb65d578f30d0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739451}
-
Koji Ishii authored
Following bot results are included. 1290 1294 1296 1297 1301 1303 1304 1305 1307 1308 1310 1311 1312 11 lines were removed and 8 lines were deflaked by consecutive results since 1286. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I752e143629448213ef6607118a50ae821730a69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040508Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#739450}
-
Maksim Moskvitin authored
This patch changes UpdateSubscribedTopics() behavior in a way it doesn't request access token, when there is no |pending_subscriptions_|. Bug: 1020117 Change-Id: Iaa592f5cf03507c92f7fcc3012b819415c2e6bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044274 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#739449}
-
Vasiliy Telezhnikov authored
TaskForwardingSequence created and destroyed on DisplayCompositor thread. Destruction will cause weak pointers to invalidate. The weak pointers are checked when RunTask happens and it's on Android Render Thread. Weak pointers are not thread safe, so this is incorrect. This CL fixes the issue by not using WeakPtr and binding all necessary data to task. Change-Id: I89ef10ff332bd806d660fa4d7b6d9ec6417fcc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042384 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739448}
-
Leonard Grey authored
Result of running: tools/mac/rewrite_modern_objc.py out/gn ../../chrome/app_shim NB: The above currently needs a locally compiled clang with the rewriting functionality turned on. Since thakis@ walked me through this and there were some hiccups, I'm going to refrain from giving instructions on how to do this until I understand it better. Bug: 324079 Change-Id: I323ce73f8e8b9c4b51f8572849c9d60984d0d754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041877Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#739447}
-
Yuly Novikov authored
Bug: 962876 Change-Id: I3d4ff17f242eb1e481bd4dddfc82f8a2914f521d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040136 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#739446}
-
Philip Rogers authored
This test times out on mac, likely due to the slow-loading image. Bug: 853360 Change-Id: I2cdb14b0660c8e6d331046f35a2466de136c0126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044570 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739445}
-
Leonard Grey authored
On other platforms, user expectation is that a parent window will display as inactive when a modal is showing. This isn't the case on Mac. Additionally, the code that passes key commands up to the parent window uses this status to determine whether to pass keys from child windows up. This change (hopefully) shows a window as active iff a child is active. It plays well with the current code that handles this for bubbles because PaintAsActive is now reference counted. Still outstanding: making a non-key child window key *does* cause the browser frame to be drawn as key and *does* handle hotkeys correctly, but does *not* fix the traffic lights until the browser window has been interacted with. Bug: 1046540 Change-Id: I1629e66457c42b268c2283a8dbeb6823c66b1111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033432 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
-
Mike Frysinger authored
When parsing opening files in text mode for XTB parsing, Python 3 will use the active system locale. If the locale is not UTF-8, we run into errors as Python tries to convert to ASCII. To avoid this, open the XTB files in binary mode before passing to the XML layers. Normally another option would be to use io.open with an explicit encoding='utf-8' setting, and indeed, that works fine for Python 3. Unfortunately Python 2's XML libs don't handle unicode strings well leading to similar ASCII encoding errors. It seems to work fine when opened in binary mode though, so lets go that route. Due to Python 2's implementation of bytes, the xtb_reader.Parse API change shouldn't be noticed. The code didn't work well with Python 3, so there aren't any users there yet :). Not that it seems like a big deal as cs.chromium.org says all API users are internal. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: Idbd282ce9b93c4fcb4bb2dc4cce1dba3a84f6c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043315Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#739443}
-
John Z Wu authored
Change-Id: Iba9f1716404812f2cb4ebb5b302bd04f7eddf8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040610 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#739442}
-
Ian Kilpatrick authored
This check could never be reached as the we never reach this function for a table-part. Tables have their own (complex) rules for min-max sizing so removing this to avoid future confusion. Change-Id: I6345b82754e6e03615d8160e5a2b0738ac44971d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042920Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#739441}
-
yilkal authored
This CL allows enables to notify the user when there are 5 minutes and 1 minute left before the application reaches its set time limit. This CL also allows to notify the user when the app time limit has been updated. Bug: 1034551 Change-Id: If2813adfbe5216de50f87d0410e7c20168e7c686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036887Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#739440}
-
Luke Zielinski authored
This time it's html/semantics/selectors/pseudo-classes/link.html on Win. Adding it to the same recent batch since we haven't had a successful import since those last few flakes were added. TBR=robertma Bug: 1049607 Change-Id: Ied06fa405c95249340a77e3984d9fdc61a14f7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043853Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#739439}
-
Stepan Khapugin authored
Reenables the test. Also fixes the use-after-free of Browser in SideSwipeController that happens sometimes in tests. Bug: 1045950 Change-Id: I8e476c0030f890933861e71a62a7e5111abfd60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036185 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#739438}
-
Colin Blundell authored
With this CL, WebLayer's SSL interstitials now use ContentMetricsHelper rather than the more generic MetricsHelper. This enables them to capture metrics about captive portal detection when that feature is enabled, analogously to how Chrome's SSL interstitials capture these metrics. Bug: 1030692 Change-Id: I0156ad2626304fb5fe6eb6c9e80aca92c89e31be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041609 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#739437}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/693b8a8d95e3..534d12cd4230 git log 693b8a8d95e3..534d12cd4230 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 bclayton@google.com ReactorBenchmarks: Sweep coroutine perf. Created with: gclient setdep -r src/third_party/swiftshader@534d12cd4230 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2e1f823d45f6becde01d787882d5e31ef0fd10e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044372Reviewed-by:
-
Rune Lillesveen authored
With BlockHTMLParserOnStyleSheets enabled, link stylesheets in head block parsing and the body element is not yet parsed when loadHTML resolves. Do a waitForPageLoad() to make sure the document has finished parsing. This is the same issue as for [1]. Bug: 1046354, 891767 [1] https://crrev.com/a42aa07df5e3656489b5cce973e7331d07e3ff50 Change-Id: Iad88470e57e258e0303d3a8613ad605921c08949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043875Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#739435}
-
Robert Ma authored
Bug: 1050060 Change-Id: Ib326d6a0ec2b4497a581c379424c1b5ba0ccf21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043856 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27380a85d035..5dca2f7583ef Created with: gclient setdep -r src-internal@5dca2f7583ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045049,chromium:1049079 Tbr: jbudorick@google.com Change-Id: I29674ffc093cba26ca34ca951b867c0546da5162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043928Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739433}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1ba1334f8d882ab5674fbc518c396b8ab1c625f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044470Reviewed-by:
-
Mohamed Amir Yosef authored
Bug: 1044038 Change-Id: I81f8bbbd6d48fb8dedd3aa7ed4492168f93c7662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043845Reviewed-by:
-
Nate Chapin authored
This is a step in preparation for moving the ExecutionContext from Document to LocalDOMWindow. Using virtual inheritance, this CL leaves several ExecutionContext subclasses (UseCounter, ConsoleLogger, and FeaturePolicyParserDelegate) as public parent classes of Document, while making ExecutionContext private. This exposes all of the places that depend directly on Document being an ExecutionContext, while leaving the long tail of indirect dependencies in place temporarily. Downcasts (most using To<Document>, a few using static_cast) have been converted to use a set of new, temporary static Document::From and Document::DynamicFrom methods. These behave very similarly to To<> and DynamicTo<>, respectively. This is necessary because To<> and DynamicTo<> no longer have the needed visibility of the inheritance relationship between Document and ExecutionContext to be allowed to perform the cast. Added a new Document::ToExecutionContext() helper, and changed implicit upcasts to use that explicitly. This intentionally does not use the existing GetExecutionContext() that Document inherits from Node. ToExecutionContext() should be temporary, and and all ToExecutionContext() will be audited to determine whether they should use GetExecutionContext() or follow a different path to the LocalDOMWindow. Callers of functions that Document inherited from ExecutionContext were handled case by case. For cases where many callers were using the inherited function, I've added a helper on Document. For other cases, the call now requires a Document::ToExecutionContext(). Bug: 1029822 Binary-Size: Increase should only last as long as the transition. Change-Id: I06510b6ed839c0f140f252eb9eec254468d17289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026711 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#739430}
-
Stephen Nusko authored
NOTRY=true TBR=crouleau@chromium.org CC=charliea@chromium.org,sullivan@chromium.org,tdresser@chromium.org,chrome-speed-metrics-dev@chromium.org BUG=1050068 Change-Id: I4a52a8f9596cc7c532ab7cac52b1f3886025b1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043815Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#739429}
-
http://dromaeo.com?dom-modifyStephen Nusko authored
NOTRY=true TBR=crouleau@chromium.org CC=jbroman@chromium.org,yukishiino@chromium.org,haraken@chromium.org BUG=1050065 Change-Id: Idfe300f0f556b73b3ffe419fb8683c8a6cae32a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044155Reviewed-by:
-
Peng Huang authored
The crash is because the gr_context_ in SharedContextState has been abandoned and set to nullptr. Bug: 1049580 Change-Id: I1a179e10fc23f584b111757f3a8a049b5487ba47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043852 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#739427}
-
Callum May authored
The cert chain vulnerability this fix is meant to address is only present in Windows 10 and above, so we can skip this chain walk on other windows platforms Bug: 1048718 Change-Id: Ib27229b947241aff96281e126a9fbf2b7a5f7dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042434Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Callum May <camay@microsoft.com> Cr-Commit-Position: refs/heads/master@{#739426}
-
Morten Stenshorne authored
We gave up when entering a new formatting context. But we should only stop when entering a child that's painted atomically. Bug: 1043787 Change-Id: I83bd88237311aa7edde00e5a3814a555cd56f112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044210Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ab71334c..7be9f465 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6a51ec2936420dde2e190f37016fdda879d90ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043931Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739424}
-
Oriol Brufau authored
Consider <ol><li><span><div>foo</div></span></li></ol> Chromium shows "foo" just next to the list marker. However, in legacy layout, if the <div> was inserted dynamically, then a newline was added between them. Also consider <ul><li><span></span><div style="overflow:hidden">bar</div></li></ul> Chromium shows "bar" just next to the list marker. However, in legacy layout, if the <span> was inserted dynamically, then a newline was added between them. This patch fixes these inconsistent behaviors. BUG=1049633 TEST=external/wpt/css/css-lists/add-inline-child-after-marker-002.html TEST=external/wpt/css/css-pseudo/marker-content-022.html Change-Id: I11a88a6b375436c72a26c5cd7bcedbb7a197b39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041481Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/285f83d47bfd..9b881abea957 git log 285f83d47bfd..9b881abea957 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 yinwa@webrtc.org Enable congestion window pushback to reduce bitrate by only drop video frames. 2020-02-07 danilchap@webrtc.org Add TimeDelta and Timestamp factories 2020-02-07 sprang@webrtc.org Moves RtpSequenceNumberMap from RtpSenderVideo to RtpSenderEgress. Created with: gclient setdep -r src/third_party/webrtc@9b881abea957 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idc9f188a21a214f7ae125a467d03d21b3058b936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044371Reviewed-by:
-
Maksim Moskvitin authored
In the previous form UpdateSubscribedTopics() replaced pending subscription request even if the same request was scheduled and this led to bypassing exponential backoff. This patch ensures that old subscription request preserved and adds early exit from StartPendingSubscriptionRequest(). Bug: 1020117 Change-Id: I0994e8dc4256e9fc5b77ca2d8753f3cb356ddb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043796 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Olivier Robin authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git/+log/35aac79c34be..866cee927378 $ git log 35aac79c3..866cee927 --date=short --no-merges --format='%ad %ae %s' 2020-02-06 featherless [FlexibleHeader] Add missing nullability annotation. 2020-02-06 featherless [ButtonBar] Rolling back "Assign the UIBarButtonItem's tintColor to the button's text color." 2020-02-06 featherless [ButtonBar] Assign the UIBarButtonItem's tintColor to the button's text color. 2020-02-06 featherless [ButtonBar] Refactor title color logic to a single location. 2020-02-06 rockland [NavigationDrawer][A11y] Improve behavior when navigating the bottom drawer with Voice Over. This change makes it possible to navigate back and forth between the `headerViewController` and `contentViewController`, without VO getting stuck, by making the view hierarchy's `accessibilityElements` explicit. 2020-02-05 rockland [NavigationDrawer] Improve swipe-down-to-dismiss behavior for drawers where drawer content is less than `160`. This adjustment ensures that for drawer contents that are quite small (ex. 100pt) the drawer contents to not become undismissable. Without this adjustment it is nearly impossible to achieve a scroll offset of (40pt), the current `kVerticalDistanceDismissalThreshold`, making the drawer effectively undismissable. 2020-02-05 codyleeweaver [ActionSheet] Change default header to be 8pt tall instead of 0. 2020-02-05 andrewoverton This change makes rippleColor null_resettable on MDCBaseCell 2020-02-05 andrewoverton Make padding between title label and detail label smaller 2020-02-04 no-reply internal change 2020-02-04 featherless [ButtonBar] Use CGSizeZero instead of CGSizeMake(0, 0). 2020-02-04 featherless [ButtonBar] Add snapshot tests for title color behavior. 2020-02-04 andrewoverton Reevaluate RTL logic because of internal snapshot testing infrastructure 2020-02-04 andrewoverton Remove unwanted animations from filled style. 2020-02-04 andrewoverton Invalidate intrinsic content size in MDCBaseTextField 2020-02-04 featherless [FlexibleHeader] Add hairline support. 2020-02-03 no-reply Adds availability macro for conditionally compiling OS sensitive code. 2020-02-03 galiak [Dialogs] Adding scuba tests for long, short, text and outlined actions in vertical and horizontal layout, in LTR and RTL. Created with: roll-dep src/ios/third_party/material_components_ios/src Change-Id: I8564f2baa2bc5fc077e0b55af7595e32a7ee74c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044090 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#739420}
-
David Maunder authored
histograms.xml and the code in TabSuggestionsOrchestrator Bug: 1043425 Change-Id: Ic3f65e303ffcdbe1a755bca664e976f9ca54117c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040675Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#739419}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bcd98820a91c..139aa7c89450 git log bcd98820a91c..139aa7c89450 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 rsavitski@google.com Merge "traced_perf: add callstack trie, allow it to be purged manually" 2020-02-07 rsavitski@google.com Merge "profiling: factor callstack trie out into p/common/" Created with: gclient setdep -r src/third_party/perfetto@139aa7c89450 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7891524684d1dc1ec1afe6563976b6797be6a95f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043918Reviewed-by:
-
Volodymyr Riazantsev authored
Images rendering is unnecessary in Cast for Audio only configuration. So let's disable them from rendering. Change-Id: Ibd6e0d20c8c6e2473b29fef5cae0cc18128b7599 Signed-off-by:
Volodymyr Riazantsev <riazantsevv@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042765Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#739417}
-
Ali Juma authored
EG2 tests that call triggerRestoreViaTabGridRemoveAllUndo are flaking because sometimes when they try to tap on the close-all-tabs button, EG2 doesn't think that button is visible. This CL follows the approach used in showTabSwitcher, waiting up to 2 seconds for the button to be visible. This CL also uses this approach for the other button taps in triggerRestoreViaTabGridRemoveAllUndo, since these are otherwise likely to become the next sources of flake. Bug: 1048875 Change-Id: Iad92c6e784a27fc1918eff6e8cd6baa313566c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042541 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#739416}
-
Harald Alvestrand authored
Bug: chromium:1049995 Change-Id: I228a8acb412dd9543f78b91989809e2dc4d21d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043792Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#739415}
-
Xiaocheng Hu authored
This patch plumbs CSSParserContext into ConsumePercent() and ConsumeColor(), so that we can count usage of CSS comparison functions min/max/clamp when they are used in <percent> and <color> values. There are two types of code paths, which are handled differently: 1. A caller takes the CSSParserMode from a CSSParserContext, and passes it through. We change it to pass the CSSParserContext directly. 2. A caller has a CSSParserContext, but passes a possibly different CSSParserMode. We change it to temporarily override the CSSParserMode of the current context. Bug: 1047784 Change-Id: I846ff87f66b444fbcb95f412cdc85d278b2dc5a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036934 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#739414}
-
