- 13 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c7e3af1ad928..428a160dd6bd git log c7e3af1ad928..428a160dd6bd --date=short --no-merges --format='%ad %ae %s' 2018-11-13 terelius@webrtc.org Remove rtc_event_log2text 2018-11-13 Peter) Slatala AudioSource allows implementations to return settings 2018-11-13 kwiberg@webrtc.org Run some peer connection end-to-end tests with an empty audio encoder factory 2018-11-13 nisse@webrtc.org Refactor bitrate configuration in CallTest Created with: gclient setdep -r src/third_party/webrtc@428a160dd6bd The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8656c81da9fb38b624dcd094c7437e480adb85c2 Reviewed-on: https://chromium-review.googlesource.com/c/1334247Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607783}
-
John Abd-El-Malek authored
Remove content::IsOriginSecure call in Domain Reliablity, since GURL::SchemeIsCryptographic should be enough. Domain reliablity only cares about http(s) traffic, so the extra functionality in content::IsOriginSecure (e.g. file/filesystem, UI, local, about, data schemes) aren't needed. Bug: 853251 Change-Id: Ic43672a378722bb1c9c41a85ab78d8d7e466818c Reviewed-on: https://chromium-review.googlesource.com/c/1334277 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#607782}
-
John Abd-El-Malek authored
This reverts commit 4307dceb. Looks like we'll need to run this with the network service enabled, and it would run in the network process in that case. Bug: 853251 Change-Id: I28ebc8b0ef1d208e8855c16e19afa3ce6ab16640 Reviewed-on: https://chromium-review.googlesource.com/c/1334231Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#607781}
-
Eugene But authored
This CL adds OverscrollActionsController to SadTabViewController. OverscrollActionsController requires UIScrollView to work, so SadTabViewController creates a dummy scroll view to hold SadTabView. Bug: 901563 Change-Id: I564ed10b807d774b891d86c21cda58435a5681c2 Reviewed-on: https://chromium-review.googlesource.com/c/1332390Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#607780}
-
Lukasz Anforowicz authored
This is a follow-up to https://crrev.com/c/1318082 - the earlier CL fully fixes and re-enables URLLoaderFactories for extensions, but some additional hygiene improvements are also possible and made in the current, WebUI-focused CL. The current CL adds a new test to help make sure that some (WebUI-focused) test coverage remains even after AppCache deprecation finally happens. The regression test verifies that the default factory wasn't cloberred by ensuring that one of chrome://resources can still be loaded. For an overview of separate URLLoaderFactories for extensions, see https://docs.google.com/document/d/1fuBUmLZj1H319jMkK8waUbf5WdQS0N95J_mWXVzbP7A Bug: 846346 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id1fbfe684514b4cf5e80558df123d78003063632 Reviewed-on: https://chromium-review.googlesource.com/c/1279177 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607779}
-
Joel Hockey authored
Added a new chrome.fileManagerPrivate.onCrostiniSharedPathsChanged function which receives type CrostiniSharedPathsChangedEvent. Changed CrostiniSharePath to be a keyed service class since it now holds state in the form of an ObserverList to receive unshare events. file_manager::EventRouter registers as an observer for UnsharePath events and propogates them to FilesApp. crostiniShare.testSharePathsCrostiniSuccess simulates an unshare event and verifies that it is handled correctly and a folder which is unshared can subsequently be shared again. Bug: 878324 Change-Id: I15ee3d75038f3bb3e127bd4f3effc3829a1854db Reviewed-on: https://chromium-review.googlesource.com/c/1329816Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#607778}
-
David Bokan authored
This feature has been shipping by default since M63. This means the browser-side gesture queue no longer coalesces events so I've removed the related code and unit tests. Bug: 625689 Change-Id: I8b943df47b2623656735f24f98a0b980daadbcce Reviewed-on: https://chromium-review.googlesource.com/c/1332769 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#607777}
-
Mark Pearson authored
This reverts commit 6111392d. Refactoring did do something, but the issue remained. The core problem I think is that the parent class fields are initialized first. This means the parent class's fields like content::TestBrowserThreadBundle get created, which I think will end up looking at field trial state. Adding a base::test::ScopedFeatureList after that happens is too late; the initial field trial state has already been inspected. I could create a separate class that lists the base::test::ScopedFeatureList first, and then all the other variables such as TestBrowserThreadBundle later. That might work. Or not; I think there are other reasons the TestBrowserThreadBundle wants to be listed first in the fields of a testing class. It's not worth the trouble to investigate. I'm happy to have coverage of the single MAYBE_ test on regular bot. I don't think we also need coverage of it on the ASAN (THREAD_SANITIZER) bots as well. Bug: 891959 Change-Id: Iae816dde484982060121c3e667b779d70da00e65 Reviewed-on: https://chromium-review.googlesource.com/c/1334269Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#607776}
-
Renjie authored
WriteMemSlices. Flag protected by quic_reloadable_flag_quic_call_write_mem_slices. Merge internal change: 220883112 Change-Id: I55210e7812ca6e51b860b5df3aa303e49a369df6 Reviewed-on: https://chromium-review.googlesource.com/c/1332773 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#607775}
-
Wez authored
Zircon previously used an option to zx_socket_write() to close the socket for reading, or writing. Migrate to the new zx_socket_shutdown() API. Change-Id: Ia4067c4611713031048271800dd620a9c1b15e72 Reviewed-on: https://chromium-review.googlesource.com/c/1334329Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Adam Barth <abarth@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#607774}
-
Miguel Casas authored
This CL adds CanvasResourceProvider unit tests. Also removes unused method InvalidateSurface(). Bug: 902585 Change-Id: I6602624ea4826d8cd307e4d973430e6c451aebd0 Reviewed-on: https://chromium-review.googlesource.com/c/1334148Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#607773}
-
Pavel Yatsuk authored
Specifics: +753,080 bytes normalized apk size +5 zip entries file count +66,544 bytes main lib size +467,128 bytes main dex size InstallSize: +288,634 bytes APK size +835,174 bytes Estimated installed size (Android Go) +2,175,831 bytes Estimated installed size InstallBreakdown (+2,175,416 bytes): +2,682 bytes unwind_cfi (dev and canary only) size +1,934 bytes Non-compiled Android resources size +66,544 bytes Native code size +351 bytes Package metadata size +2,089,637 bytes Java code size +14,268 bytes Compiled Android resources size Dex: +2,396 entries fields +3,285 entries methods +773 entries types +1,679 entries strings R=pnoland@chromium.org Binary-Size: Adding errors.proto, which is finally compatible with Chromium. Change-Id: I1cf123baf074706ae08e64612f51c36b6380afb6 Reviewed-on: https://chromium-review.googlesource.com/c/1333128 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#607772}
-
Quan Nguyen authored
Bug: 884668 Change-Id: I16dd2c5b0156bf1490b57acd4185c1d80d193a67 Reviewed-on: https://chromium-review.googlesource.com/c/1330206Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607771}
-
Dominic Mazzoni authored
Bug: 903500 Change-Id: I4e55e0323fe642f8af0a79152a52bccc1cb6ac82 Reviewed-on: https://chromium-review.googlesource.com/c/1334195Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607770}
-
Sreerenj Balachandran authored
Without the ffmpeg decoder configured, libavformat is unable to get the codec profile and chromium ffmpeg wrapper code choose some defaults. This will mess up the decode scenarios where non-ffmpeg decoders like vaapi are in use. Fortunately, we can still get hold of the ffmpeg's AVStream extradata param which should contain the H264 AVCDecoderConfigurationRecord (ISO/IEC 14496-15). So we use internal parser for extracting profile information from this AVCDecoderConfigurationRecord. BUG=784610 TEST=media_unittests:FFmpegCommonTest.VerifyH264Profile Change-Id: Id67c7026eefb5bb73e6c5fbbab7a362cb4553ab1 Reviewed-on: https://chromium-review.googlesource.com/c/1292605 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#607769}
-
Sammie Quon authored
Also fix issue where users could not backspace by using keyboard tab and space. Test: manual Bug: 881756, 862924 Change-Id: I0523784ad05d2a02219e95e90cd02b2d275da94f Reviewed-on: https://chromium-review.googlesource.com/c/1329748 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#607768}
-
Alex Newcomer authored
Increase the label size to 14px. Bug: 888610 Change-Id: If7063fafcd8247601e3c7af0bf8b179f76f9df0c Reviewed-on: https://chromium-review.googlesource.com/c/1329672Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#607767}
-
Ben Pastene authored
Looks like no other tot bot uses goma, and the bot's currently failing since the goma client isn't available. Bug: 903078 Change-Id: I14e9a3772f3df464d5e6549fd785b20bc10d0509 Reviewed-on: https://chromium-review.googlesource.com/c/1334272Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#607766}
-
Jay Harris authored
Bug: 904318 Change-Id: I3c0367bc925a5f3b78f3a0457c25ef3b7c807b38 Reviewed-on: https://chromium-review.googlesource.com/c/1333007Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#607765}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c1a5d275..9d32daac Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8e6d7a4ca76ecd267e9288458dfd5ac8a852ead4 Reviewed-on: https://chromium-review.googlesource.com/c/1334205Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607764}
-
Sergey Ulanov authored
This reverts commit 75ffb181. Reason for revert: static initializer in about_flags.cc, see https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/37607 Original change's description: > Add Finch param to control TLS 1.3 Downgrade enforcement on known/unknown roots. > > Change-Id: I88932442b714820944b4608e106eaf47536bf00d > Reviewed-on: https://chromium-review.googlesource.com/c/1329344 > Commit-Queue: Steven Valdez <svaldez@chromium.org> > Reviewed-by: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607712} TBR=davidben@chromium.org,svaldez@chromium.org Change-Id: I638f9065d117b2885fa947c343234981eacfb991 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1334412Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607763}
-
Giovanni Ortuño Urquidi authored
Also remove some unnecessary functions. BUG=897996 Change-Id: I413001df24f29c5ccd4e3ed906727fd8152f0906 Reviewed-on: https://chromium-review.googlesource.com/c/1331287Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#607762}
-
kylechar authored
Don't pass GpuChannelManager to InProcessGpuMemoryBufferManager. Most of GpuChannelManager should only be accessed from the GPU thread so there is the potential for unsafe operations. Both SyncPointManager and GpuMemoryBufferFactory are thread safe so they should be fine. Also ensure that GpuMemoryBuffer destruction callbacks dereference their WeakPtr on the correct thread. GpuMemoryBuffers can be created and used on any thread, even though InProcessGpuMemoryBufferManager isn't used on multiple threads currently. Bug: 902163 Change-Id: I8118def4fabd0307f0a58d403b9f9c08bc72fc6b Reviewed-on: https://chromium-review.googlesource.com/c/1330030 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607761}
-
Vikas Soni authored
Add a GL backed skia representation of SharedImageBackingAHardwareBuffer. Update unit test. Bug: 891060 Change-Id: Ib3b458615be13e7a536a12097e8452052b78a14f Reviewed-on: https://chromium-review.googlesource.com/c/1330205Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607760}
-
Ted Choc authored
Pre-P there is a problem with the ripple now growing with the omnibox as it expands from the fakebox to the omnibox at the top. Limit to P+ while we investigate other solutions to enable this on older versions. Original CL to compare what was enabled: https://chromium-review.googlesource.com/c/chromium/src/+/1054851/ BUG=878135 Change-Id: I2a45b398e7b67cf3a1b95aeea807485bcadc9968 Reviewed-on: https://chromium-review.googlesource.com/c/1334278Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607759}
-
Thomas Tangl authored
Bug: 872673 Change-Id: I7c304ab27f8fe2d4539be3ff99b962aefb392f89 Reviewed-on: https://chromium-review.googlesource.com/c/1333756Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#607758}
-
Thomas Tangl authored
Bug: 872642 Change-Id: I1b067bb722650752c00c43d0b77308214ae50fd1 Reviewed-on: https://chromium-review.googlesource.com/c/1333655Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#607757}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b73027ad4816..02761361bf6a git log b73027ad4816..02761361bf6a --date=short --no-merges --format='%ad %ae %s' 2018-11-13 treehugger-gerrit@google.com Merge "profiling: Check open of /proc/self/{maps,mem}." Created with: gclient setdep -r src/third_party/perfetto@02761361bf6a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibc279e1a2815f86433d69b6dd75b56cdc82c88f2 Reviewed-on: https://chromium-review.googlesource.com/c/1333862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607756}
-
Evan Stade authored
Passes 50x locally in both classic Ash and single process Mash. Bug: 693000 Change-Id: Ibc950f812b6195258609ca5ea1838331bf82aae3 Reviewed-on: https://chromium-review.googlesource.com/c/1334328Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#607755}
-
Sean Gilhuly authored
Create a server socket on the browser process and pass it to the viz process, where the Viz DevTools server is created. The server is enabled with the flag --enable-viz-devtools=<port>. If no port is specified, the default 9229 is used. Once running, you can connect to the server with the following url: chrome-devtools://devtools/bundled/inspector.html?ws=localhost:9229/0 The viz devtools server should be connected on Android and when it runs in-process, but these haven't been tested yet. Bug: 816802 Change-Id: Ica6b98253b49e0658a680a71fa3fe7ad083610a9 Reviewed-on: https://chromium-review.googlesource.com/c/1309135 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607754}
-
Chase Phillips authored
The original CL was reverted due to an IndexedDB stability issue reported in https://crbug.com/899446. The stability issue was fixed as part of commit 48bcb8e3. A test to verify the issue doesn't regress was landed as part of commit 884a9b66. This change was originally a revert of the following commits: - commit 236db709 - commit 63debc65 - commit e14fc0ee Bug: 717812 Change-Id: I2e1d7a12fa30ccb8cdd5d792f8e7c72b40dc30c8 Reviewed-on: https://chromium-review.googlesource.com/c/1316830 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#607753}
-
Cathy Li authored
Null pointer crash is caused by CompositorViewHolder nulled out before onDestroy gets called in some cases. Bug: 904245 Change-Id: I4a8c3347a2bf7f0af2f704bc2e33cadc4534adc7 Reviewed-on: https://chromium-review.googlesource.com/c/1334273 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#607752}
-
Becca Hughes authored
Remove the ScoreAtStartup histogram as it was causing jank and we were not using it. BUG=900679 Change-Id: I004743c48425c9bb3fbbed67004c7616ef290cf9 Reviewed-on: https://chromium-review.googlesource.com/c/1330211 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#607751}
-
Ken Rockot authored
Updates the Connector mojom and C++ APIs with clarifying naming and type usage. Connector has accumulated lots of cruft over the years and its API conveys a number of muddled concepts which have lead to general confusion, misuse, and abuse. This attempts to sort all that out. Namely: - All use of Identity in the Connector API has been migrated to ServiceFilter where appropriate. - StartService (first version) has been renamed to WarmService to convey the correct intent. Bugs filed and TODOs dropped in places where this is being used in an undesirable fashion. - StartService (second version) has been renamed to RegisterServiceInstance to convey more accurately what it does. It also requires a complete Identity to be provided by the trusted caller. - QueryService takes only a service name instead of an Identity, since it only needs to take a service name. It also makes no service connection so it no longer returns a ConnectResult. - FilterInterfaces is marked as deprecated on the mojom interface, because we want to obliterate it. - Test-only methods have been properly suffixed and made public, eliminating the need for the weird TestApi wrapper thing. A follow-up CL will delete TestApi and migrate its users. - Connector methods which have async replies have optional callbacks now instead of the Connector weirdly having a single catch-all (and dubiously named) "StartServiceCallback" to handle all replies. Bug: 902590 Change-Id: I5a986a5c114da914fd624dac7e6fd021cf139958 Reviewed-on: https://chromium-review.googlesource.com/c/1329845Reviewed-by:Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#607750}
-
Ryan Daum authored
Draws an orange ring around the screen while magnification is enabled, as on Android. Bug: internal b/112634030 Test: manual Change-Id: Iac134759c7f6e931c7c4a4407d827fc7a75fedca Reviewed-on: https://chromium-review.googlesource.com/c/1334197Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#607749}
-
Ben Pastene authored
This is in preparation for their move from chromium.lkgr to chromium.fuzz Bug: 903591 Change-Id: Ic01978e91339d71a5e69880274fd91c299cb98b6 Reviewed-on: https://chromium-review.googlesource.com/c/1332770Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#607748}
-
oysteine authored
This reverts commit c9720564. Reverting this; looks like the increased bytes used due to stringtable indices being hashes rather than sequential numbering is causing the trace chunks to fill up quicker and negates the optimization. BUG=903762 Original change's description: > Reland "Perfetto: Optimization to avoid string table lookup for _END events" > > This reverts commit 7acd0b52. > > Reason for revert: Re-landing with crashfix > > Original change's description: > > Revert "Perfetto: Optimization to avoid string table lookup for _END events" > > > > This reverts commit a7afe430. > > > > Reason for revert: I suspect this may have caused crashes on https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi# > > > > Original change's description: > > > Perfetto: Optimization to avoid string table lookup for _END events > > > > > > If we're emitting an _END trace event, we know that the string > > > table entries for the name and the categories have already been > > > emitted and so we don't need to check the string table in this > > > case. > > > > > > R=primiano@chromium.org,skyostil@chromium.org > > > > > > Change-Id: I9107bffb0b48f7b71d0a42961a78a3861ffcb76f > > > Reviewed-on: https://chromium-review.googlesource.com/c/1258043 > > > Commit-Queue: oysteine <oysteine@chromium.org> > > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#600183} > > > > TBR=primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Change-Id: Ia460750fcaf338c4bf24ee7317d58b7aeede9520 > > Reviewed-on: https://chromium-review.googlesource.com/c/1293612 > > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#601586} > > TBR=cbiesinger@chromium.org,primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I8f3b5c21494d66fe9e6c25363627ec156f5abf12 > Reviewed-on: https://chromium-review.googlesource.com/c/1325077 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606308} TBR=cbiesinger@chromium.org,primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I4719cde108d34cee7223615861c1f7cfac31bcd0 Reviewed-on: https://chromium-review.googlesource.com/c/1334199Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#607747}
-
siyua authored
If one migration request is finished and the user submits another migration request in the same tab, the card would be automatically saved. Reason: The member variable user_accepted_main_migration_dialog_ is not correctly reset to false after a request is sent. So when next time the risk data is loaded, a request would be direcly sent to server. This is a bug for M71 code. Need to merge asap. Bug: 897998 Change-Id: Ia77cdddc6d80550e0e23ff327f07a5c7279ba15f Reviewed-on: https://chromium-review.googlesource.com/c/1333122 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#607746}
-
Justin Cohen authored
For native controllers, we don't update the contentInset, so it doesn't make sense to compare the native contentOffset to the CRWScrollViewProxy.contentInset. Change-Id: I4fda19725cecbd70af2a054bd3c2132d5b0a25fd Reviewed-on: https://chromium-review.googlesource.com/c/1333870Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607745}
-
Ian Clelland authored
Bug: 888668 Change-Id: Iec4e28d6f62d8b146b3e5311197e58e4df4b5dc2 Reviewed-on: https://chromium-review.googlesource.com/c/1331630Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#607744}
-