GitLab

This CL also updates the string fot the "Manage passwords" button
according to the new spec.

Bug: 835234
Change-Id: I8d003069fed7734c42ef50c5997f43b319cc45e6
Reviewed-on: https://chromium-review.googlesource.com/c/1482977Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634729}

https://chromium.googlesource.com/angle/angle.git/+log/b9039bf76bf3..cf9b2853a7e7


git log b9039bf76bf3..cf9b2853a7e7 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 jmadill@chromium.org Roll Google Test.


Created with:
  gclient setdep -r src/third_party/angle@cf9b2853a7e7

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I62f283c8870ca3c7c81821b657b0689718f31047
Reviewed-on: https://chromium-review.googlesource.com/c/1483157Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634728}

The main motivation is to make the fuzzers pick up the
BORINGSSL_ALLOW_CXX_RUNTIME define, which (in addition to fixing
-Wextra-semi warnigns) makes the fuzzers use the same setting
we use for regular boringssl.

Making most of the other defines consistent is good too.

One undesired side effect is that the fuzzers now also pick up
BORINGSSL_IMPLEMENTATION but that's incorrecto for boringssl's tests already
and improvements for that are tracked in boringssl:258

Bug: 926235
Change-Id: I21a111f308bccb81e23bbdd96b6ba4e218ffd2d5
Reviewed-on: https://chromium-review.googlesource.com/c/1482566
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634727}

The 'Earth' background is the most popular background, based on requests
from the New Tab Page

Bug: 924176
Change-Id: Icf0b4192a19c289788199ee9b616bf8afb2a31b7
Reviewed-on: https://chromium-review.googlesource.com/c/1481991
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634726}

Bug: None
Change-Id: Ie047d98ae56bc5a4a85483f4e2711fda03d7e0f1
Reviewed-on: https://chromium-review.googlesource.com/c/1482563
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634725}

https://chromium.googlesource.com/chromium/deps/hunspell_dictionaries.git/+log/a9bac57ce6c9..f7ce90e84f5a

$ git log a9bac57ce..f7ce90e84 --date=short --no-merges --format='%ad %ae %s'
2019-02-19 krb [spellcheck] Rename cy-GB bdic correctly
2019-02-14 krb [hunspell] Add cy_GB(Welsh) dictionary files
2017-10-16 hichris123 Delete old English dictionaries

Created with:
  roll-dep src/third_party/hunspell_dictionaries

Bug: 692242
Change-Id: I6ba5262dd68f7b60e12d57754e5bf956244fe7ee
Reviewed-on: https://chromium-review.googlesource.com/c/1481056Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634724}

Note that the main logic to handle focus transitions from status area
--> shelf was added in CL 1475149. This makes some small tweaks and
mainly adds the logic for transitions in the other direction.

This is a little more involved because we need to handle situations
where the overflow bubble is showing.

This also adds some extensive tests covering focus-cycling between all
these elements.

You can see a screencast of what this looks like in
    https://bugs.chromium.org/p/chromium/issues/detail?id=753409#c34

Bug: 753409
Change-Id: Ia903c27f54226b4d67cf796d2d076f9da72225a9
Reviewed-on: https://chromium-review.googlesource.com/c/1477464
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634723}

Bug: 934865
Change-Id: I92ebfc18b621b66aff1ab1d32ccb2bb7f44212c5
Reviewed-on: https://chromium-review.googlesource.com/c/1482945
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Auto-Submit: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634722}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9eb6c534..045e7629

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1de6ee96db0e08664e427896658ab8e7b936fca7
Reviewed-on: https://chromium-review.googlesource.com/c/1482942Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634721}

The methods declared & defined in network_instrumentation.[h|cc] are used
only in a few places in ResourceFetcher and ResourceLoader and there is
little benefit on tracing events through them. Instead, this patch drops
those files and inlines their usage in those few places using them.

Additionally, this CL also moves UrlForTraceEvent() in resource_fetcher.cc
to an anonymous namespace along with the other methods returning unique_ptr
pointers to TracedValue, instead of leaving it as a static function.

Bug: 922151
Change-Id: Ia024909609f1c8b79b8cdc0c673f44ec0499944b
Reviewed-on: https://chromium-review.googlesource.com/c/1477686Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#634720}

https://swiftshader.googlesource.com/SwiftShader.git/+log/b607bc8800c1..7aafb27453d3


git log b607bc8800c1..7aafb27453d3 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 headlessclayton@gmail.com Add CMake flag to treat warnings as errors


Created with:
  gclient setdep -r src/third_party/swiftshader@7aafb27453d3

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/123933266
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: I04b1004089626489fb4e47405695a3611a716a3f
Reviewed-on: https://chromium-review.googlesource.com/c/1483159Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634719}

There is no need for clients to call OnChildResizing() as it does nothing in
mus.

BUG=none
TEST=none

Change-Id: Ia38b2032068ac011325fdf0717e8db07a9943626
Reviewed-on: https://chromium-review.googlesource.com/c/1479290
Auto-Submit: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634718}

It controls kerberos credentials delegation behaviour.

BUG=chromium:930019
TEST=not yet

Change-Id: I363f87177757f422959f9b1c55266de49f0ca1a8
Reviewed-on: https://chromium-review.googlesource.com/c/1479962
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634717}

Bug: 931866
Change-Id: Iad447daafcae5486529784fd40686f517fab1ec7
Reviewed-on: https://chromium-review.googlesource.com/c/1482955
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634716}

Test renders 4 colors in 4 quadrants and use glReadPixels to read the
center pixel of each quadrant and and check if the rendering result
matches expectation.

Change-Id: If7b89506c1b84448e98f18b58c85aecff99f04bc
Reviewed-on: https://chromium-review.googlesource.com/c/1476120
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634715}

https://skia.googlesource.com/skia.git/+log/c6461681d608..18e5841c0dae


git log c6461681d608..18e5841c0dae --date=short --no-merges --format='%ad %ae %s'
2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-02-22 thomasanderson@chromium.org Make SkFontConfigInterface_direct and sysroot-aware


Created with:
  gclient setdep -r src/third_party/skia@18e5841c0dae

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:822737,chromium:908463
TBR=jvanverth@chromium.org

Change-Id: I9bd3e3b98970fd6363c4f4868c53abc303361fab
Reviewed-on: https://chromium-review.googlesource.com/c/1483154Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634714}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a33c0190f771..67e798b11f20


Created with:
  gclient setdep -r src-internal@67e798b11f20

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I0e857226297c5f614936a0192f1b066da65cd13c
Reviewed-on: https://chromium-review.googlesource.com/c/1483290Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634713}

This CL adds two chrome://flags flags for crrev.com/c/1475065.

Bug: 931836
Change-Id: I513f988e36c853383c41f48b1ed0841a5ca10b60
Reviewed-on: https://chromium-review.googlesource.com/c/1481904Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634712}

This adds a test for the case where the start and end circles of a
radial gradient fully overlap (while having non-zero radii).

Bug: 933413
Change-Id: Id059cb607f6fc137111d2306dd9c9eef1f55b6bc
Reviewed-on: https://chromium-review.googlesource.com/c/1483023
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634711}

This patch refactors the relationship between PaymentRequestDialogView
and PaymentRequestState to be more generic. Instead of waiting for the
state event of fetching all payment instruments (specific), the view now
waits for an initialization task (abstraction) to finish initialization
(generic). This will help to add more initialization tasks in follow up
patches. For example, PaymentRequestSpec will become an initialization
task as well, so the view can wait for the spec to completely
initialized, in case if PaymentRequest.show() was called with a promise.

Bug: 817073
Change-Id: I19c133ab3084a7a26628380135c21abeeb1c7436
Reviewed-on: https://chromium-review.googlesource.com/c/1478090
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634710}

R=haraken@chromium.org
CC=blink-reviews-onion-soup@chromium.org

BUG=891908

Change-Id: I2783d2caf8b915a06bb5277d35ca650f079a58c7
Reviewed-on: https://chromium-review.googlesource.com/c/1483173
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634709}

This CL adds a null check to prevent a crash occurring in
MediaSessionImplParamBrowserTest.

Bug: 933742
Change-Id: Ia2d6eaf9a8a8c7ce1e165ad56d09ec3d6830730c
Reviewed-on: https://chromium-review.googlesource.com/c/1481081Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634708}

Change-Id: I21690fe27cb4ea7e256943fe6ffc6ed7e8bb99c1
Reviewed-on: https://chromium-review.googlesource.com/c/1481964
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634707}

This reverts commit f54db458.

Reason for revert: Miscommunication with server team requirements. Need to change some logic

Original change's description:
> HTTPS Previews: Use the DRP experiment instead of a Finch-provided one
> 
> This experiment doesn't actually seem very useful in Finch. It's better
> to reuse the DRP experiment which is accessible in chrome://flags.
> 
> Bug: 934376
> Change-Id: I27a5bdfa4f57fa761eaae62106113e7fc5529ba1
> Reviewed-on: https://chromium-review.googlesource.com/c/1481995
> Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> Commit-Queue: Robert Ogden <robertogden@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634682}

TBR=robertogden@chromium.org,ryansturm@chromium.org

Change-Id: I354e3ca9ccd61617b47031ba0880890084210a9d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 934376
Reviewed-on: https://chromium-review.googlesource.com/c/1482947Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634706}

It's hit when creating a new window in fullscreen. The linked bug
mentions leaving it in place as a reminder to add a test, but I keep
getting bit. The bug should sufficiently document the need for a test.

Bug: 844482
Change-Id: Ibbd1cf24864c8122e82ba189072dcc2711afc326
Reviewed-on: https://chromium-review.googlesource.com/c/1482558
Auto-Submit: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634705}

- This change prevents more than one instance of a UpdateCredential
  dialog for a single mount.
- Each mount, when prompted, will have their own dialog to update
  credentials.
- Previously, it was possible to have multiple dialogs and would crash
  the File App. The cause of the crash is after successfully updating
  the credentials of the share via the first dialog, the second dialog
  is no longer in a stable state and holds stale callbacks.

Bug: 931846
Test: end to end manual test
Change-Id: I09f85c084028943bceed3831e81cefce503f2bb7
Reviewed-on: https://chromium-review.googlesource.com/c/1470726
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634704}

[Sheriff] Expectations for virtual/outofblink-cors-ns/http/tests/security/cross-origin-worker-indexeddb-allowed.html

The test is flaky (crashing) on Mac

Bug: 934866
No-try: True
No-presubmit: True
Change-Id: I8ab29cf258e6b7c80e0c4589c54f6fedab6641db
Reviewed-on: https://chromium-review.googlesource.com/c/1482833Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634703}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1b14cdf2bee..e83100437106


git log b1b14cdf2bee..e83100437106 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@e83100437106

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I3b4597457ac412068081c32fbd0ce0a4e60d6592
Reviewed-on: https://chromium-review.googlesource.com/c/1482937Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634702}

The Content Security Policy specification calls for comparing host
values using an ASCII case-insensitive comparsion. Previously, Chrome
only used an insensitive comparison when the source directive specified
a wildcard.

This CL changes to an insensitive comparison, matching Firefox and Edge.

Bug: 882145
Change-Id: Ibd9ea7cb667e0cd1a9042158858a831e86bb0f42
Reviewed-on: https://chromium-review.googlesource.com/c/1471267Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#634701}

When we have keyboard events and mouse events send together, we should
keep the keys that we are pressing now and set them to the mouse events
that are in the same action sequence.

Bug: chromedriver:1897
Change-Id: I700d7a87d3d0a1b45c1588318ab21314aa284417
Reviewed-on: https://chromium-review.googlesource.com/c/1482009Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634700}

non variant enum is used for alias in variant header
https://cs.chromium.org/chromium/src/out/Debug/gen/third_party/blink/public/mojom/cache_storage/cache_storage.mojom-blink-forward.h?g=0&l=48

This is found by wanderview@chromium.org in
https://bugs.chromium.org/p/chromium/issues/detail?id=922875#c104

Bug: 922875
Change-Id: I94e0c0063d067d085bc964ee37996a9eb40ec2c8
Reviewed-on: https://chromium-review.googlesource.com/c/1481146
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#634699}

Bug: None
Change-Id: Ia0fe5b5f50427e018fbc5d02e613b2ebd7c4b368
Reviewed-on: https://chromium-review.googlesource.com/c/1482564
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634698}

Bug: chromedriver:2773
Change-Id: I663a3a4f280f31e5428c2056d7bdfc64b0c6a048
Reviewed-on: https://chromium-review.googlesource.com/c/1482110Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634697}

Bug: 882892
Change-Id: Id84d55aab6a947f3d36a785d01a705a15e2fed4a
Reviewed-on: https://chromium-review.googlesource.com/c/1482554
Commit-Queue: Brian White <bcwhite@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634696}

BUG=none

Change-Id: If8781725a059b835cd48796e4ccb93244244e59a
Reviewed-on: https://chromium-review.googlesource.com/c/1482145
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634695}

We are seeing frequent issues where phones are connecting to the wrong script server domain, leading to permission errors and abort. This log message should help us in debugging those issues.

Bug: 806868
Change-Id: I49c469d33e924c0cb65db2398c686b6930313098
Reviewed-on: https://chromium-review.googlesource.com/c/1482961Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#634694}

As per local run the WebViewDeviceSideStartupTest.testStrictModeNotViolatedOnStartup
test is passing, see crbug.com/933815 for details.

Verification:
 [4/7] com.android.cts.webkit.WebViewHostSideStartupTest#testStrictMode pass

BUG=933815,841556,923938

Test: run cts -m CtsHostsideWebViewTests --test com.android.cts.webkit.WebViewHostSideStartupTest
Change-Id: I5f34ce7bb867cb44a095f89c8513608bd077261e
Reviewed-on: https://chromium-review.googlesource.com/c/1482457
Auto-Submit: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634693}

Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1481910

Without this, we still get

    In file included from ../../third_party/flatbuffers/src/tests/test.cpp:18:
    ../../third_party/flatbuffers/src/include/flatbuffers/idl.h:332:25:
        warning: extra ';' after member function definition [-Wextra-semi]
      EnumVal() : value(0){};
                        ^

Also add a TODO for undoing this again at some point.

Bug: 934834,926235
Change-Id: I6ad57d7a9973dfdf6ab546daffc2f99bea284e96
Reviewed-on: https://chromium-review.googlesource.com/c/1482561Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634692}

The spec (https://fetch.spec.whatwg.org/#data-urls) states that both
base64 matching (step 11) and charset matching (step 13, then step 11.4
of https://mimesniff.spec.whatwg.org/#parse-a-mime-type) should be case
insensitive. Previously Chrome did both case-sensitive, this CL corrects
that.

Bug: 807562
Change-Id: I336a04abdbe45e41207d131984a15a9f36c1b486
Reviewed-on: https://chromium-review.googlesource.com/c/1480569Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634691}

This makes sure that errors generated in the network service when
offline will trigger the auto-fetch feature. The current tests didn't
catch the bug because they use URLLoaderInterceptor to fail the request,
which prevents the request from reaching the network service.

Bug: 929909
Change-Id: I26f532d3d44331e495cb0e1cba16276bcd0074d9
Reviewed-on: https://chromium-review.googlesource.com/c/1479584Reviewed-by: Dan H <harringtond@google.com>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634690}