GitLab

BUG=webrtc:7475

Review-Url: https://codereview.chromium.org/2898733002
Cr-Commit-Position: refs/heads/master@{#473819}

R=scheib@chromium.org
BUG=None.

Review-Url: https://codereview.chromium.org/2895363002
Cr-Commit-Position: refs/heads/master@{#473818}

According to MD specs for system menu detailed views, there is no
spinner for network/vpn/bluetooth rows that are trying to connect.

BUG=724680
TEST=none

Change-Id: If610554c95b1c35ffbcc32bd6ad9f51927bf558d
Reviewed-on: https://chromium-review.googlesource.com/509231
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473817}

Once I shipped the CL that enabled PerformanceTests/Editing but it was
 reverted because of bot failures:
https://chromium.googlesource.com/chromium/src.git/+/9ddf0ddf5dc89355220874dc29cc9ca1e3501839
Instead of ship all of perf tests under Editing/ at once,
  I try to ship one by one under DOM directory.

BUG=698661

Review-Url: https://codereview.chromium.org/2880203002
Cr-Commit-Position: refs/heads/master@{#473816}

This CL removes SetSelectedRange from ExpandSelectionToGranularity
and instead uses FrameSelection::SetSelection.
This is done to get rid of FrameSelection::SetSelectedRange().

BUG=721190

Review-Url: https://codereview.chromium.org/2897633002
Cr-Commit-Position: refs/heads/master@{#473815}

BUG=724925
TEST=FrameSelectionTest.RangeContainsFocus

Review-Url: https://codereview.chromium.org/2900553005
Cr-Commit-Position: refs/heads/master@{#473814}

1) Change the profile error dialog checkbox to report a feedback when the
   dialog is dismissed to be opt-in instead of opt-out.
2) Change the scary message "DO NOT CHANGE BELOW THIS LINE" to "Please do
   not change below this line".
3) Only show the above message if we actually have some diagnostics data
   to add to the report.

Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=708505#c4

BUG=708505
TEST=On Chrome OS, run 'stop ui', trigger a profile error by
'echo "<some long random text>" > /home/chronos/Default/History'. Run 'start ui'.
Make sure the checkbox is opt in in the error dialog, check the box, and click OK,
the feedback is pre-populated with a message like the one in the screenshots.

Review-Url: https://codereview.chromium.org/2896133002
Cr-Commit-Position: refs/heads/master@{#473813}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/87aaf44..9422979

BUG=
TBR=kbr@chromium.org
TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2903503002
Cr-Commit-Position: refs/heads/master@{#473812}

https://skia.googlesource.com/skia.git/+log/79a1a97db7c4..eee762104c75

$ git log 79a1a97db..eee762104 --date=short --no-merges --format='%ad %ae %s'
2017-05-22 reed add bench for patchutils

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Ieabb0b94df1fd3ef656cc23faa68ad9348d7cf31
Reviewed-on: https://chromium-review.googlesource.com/511864Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473811}

The FPS counter returned bogus negative values as soon as the
sample count reached kNumFrameTimes since it subtracted a zero value
that was never set due to an off-by-one error.

Unfortunately the unit test didn't catch this since it never filled
the sample buffer. Fixed the test to cover this.

Also reduce kNumFrameTimes to 10, smoothing over 200 frames seems
excessive. We just want a bit of smoothing but should be able to
see some reaction to temporary glitches since these are quite visible
in VR.

BUG=

Review-Url: https://codereview.chromium.org/2892813002
Cr-Commit-Position: refs/heads/master@{#473810}

AudioVolumeApplier is a component to apply audio level to the samples, it also
has an AudioSilenceDetector internally to detect whether the samples are silent
before or after applying the level.

It does not rely on a fixed kChannels, which is good to support 5.1 / 7.1
channels.

BUG=669070

Review-Url: https://codereview.chromium.org/2840773004
Cr-Commit-Position: refs/heads/master@{#473809}

Network traffic annotation is added to network requests of:
content/browser/service_worker/service_worker_request_handler_unittest.cc
content/browser/service_worker/service_worker_url_request_job_unittest.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2896793002
Cr-Commit-Position: refs/heads/master@{#473808}

BUG=722513

Review-Url: https://codereview.chromium.org/2890723003
Cr-Commit-Position: refs/heads/master@{#473807}

If a PWA includes a "name" field in their manifest, but explicitly sets
it to the empty string, it would have an app banner displayed with no
text, as well as no title on its splash screen.

This CL fixes the bug by properly checking if the "name" string is
empty, rather than just null. This check is already performed by the
InstallableManager in the process of determining whether or not a site
is a valid PWA. An additional test is added to ensure the correct
functionality.

BUG=722615

Review-Url: https://codereview.chromium.org/2900623002
Cr-Commit-Position: refs/heads/master@{#473806}

This CL removes XHTML content sniff for text/xml and application/xml.

We altered the content-type to application/xhtml+xml if the root tag starts with
the following:

<html xmlns="http://www.w3.org/1999/xhtml"

We stop it.
This behavior has never been applied to

<html xmlns='http://www.w3.org/1999/xhtml'
or
<html  xmlns="http://www.w3.org/1999/xhtml"

because this behavior was introduced to pass some layout tests.

The behavior difference between application/xml and application/xhtml+xml is
document.createElement().  This CL updates some tests.
New behavior is interoperable with Edge, Firefox, and Safari.

* LayoutTests changes
** external/wpt/dom/nodes/Document-createElement-namespace.html
  This CL fixes failing sub-tests.
** fast/dom/Document/xml-document-focus.xml
  Page rendering is changed because of document.createElement() in js-test.js.
** fast/dom/ping-attribute-no-crash.xml
  This assumes document.createElement() has XHTML behavior. This CL renames it
  to html/text_level_semantics/a-ping-no-crash.xhtml.
** http/tests/misc/createElementNamespace1.xml
  This CL fixes a failing sub-test about document.createElement().

BUG=231927, 702084

Review-Url: https://codereview.chromium.org/2883833002
Cr-Commit-Position: refs/heads/master@{#473805}

GPUTracer and CommandExecutor unnecessarily inherit SupportsWeakPtr.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2892923002
Cr-Commit-Position: refs/heads/master@{#473804}

In this CL, we will implement the following in terms of AXPlatformNodeWin:

get_accChild
get_accChildCount
get_accDefaultAction
get_accDescription
get_accFocus
get_accParent
accDoDefaultAction

BUG=703369

Review-Url: https://codereview.chromium.org/2891913005
Cr-Commit-Position: refs/heads/master@{#473803}

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //extensions, //headless, //mojo

Additionally, used TaskScheduler instead of blocking pool
in storage_info_provider.cc referenced to crbug.com/667892.
The blocking pool is being deprecated in favor of TaskScheduler.

BUG=665062

Review-Url: https://codereview.chromium.org/2888053002
Cr-Commit-Position: refs/heads/master@{#473802}

This has been failing on Win 7 Debug (NVIDIA) and given the flakes on
other platforms it seems better to disable it on all Windows bots.

Failures seem to be for different reasons on alternate builds:
- DCHECK in OffscreenCanvasSurfaceReferenceFactory::SatisfySequence, or
- trying to draw invalid mailbox in browser compositor

Recent failures:
https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/52157
https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/52158
https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/52159
https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/52160

TBR=kbr
BUG=720188

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8538f7aa73a3d63feb2afdb0fda03c2a7af6233d
Reviewed-on: https://chromium-review.googlesource.com/511803
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473801}

This allows the existing mojo traits for string16 to be reused for
NullableString16.

Bug: 577685,604860
Change-Id: I69a7be9e14c033ca2c7ab92e7cc0078eaa8a391a
Reviewed-on: https://chromium-review.googlesource.com/509669
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473800}

In order to be notified that page is translated, we simply implement CompactInfobar as observer of Translate Driver.
But now we found from the translate button is clicked to the page is translated, there are many steps. If any step is returned, we are not be notified at all.

In order to fix the loose relationship, we create a responder inside the delegate.
So no matter what delegate is going to do, we will be notified, which keep infobar always consistent with delegate.

What's more, on some corner cases listed in bug/723426, the relationship between infobar and translate driver causes crash. And the new strong relationship will fix it.

BUG=720164,703887,723426, 724428
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2894553002
Cr-Commit-Position: refs/heads/master@{#473799}

Remove the per-detect() UMA counters and use instead constructors,
because in a normal usage pattern the detect() method can be called
many times on the same object, and we don't want to skew the UMA.

Bug: 659138
Change-Id: Ib4aef88c35dd4853ececbf71cc12a96eaca020f3
Reviewed-on: https://chromium-review.googlesource.com/511344
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473798}

https://skia.googlesource.com/skia.git/+log/5592382a7ad1..79a1a97db7c4

$ git log 5592382a7..79a1a97db --date=short --no-merges --format='%ad %ae %s'
2017-05-22 jvanverth Fix TSAN bot

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I81e44d772c5f2d8fb3eb2a62a68d189600fb041c
Reviewed-on: https://chromium-review.googlesource.com/511768Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473797}

Merges google_input_tools extension into google_xkb extension. The google input tools extension relative clean up will be in other CL.

BUG=709360
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

patch from issue 2894793002 at patchset 1 (http://crrev.com/2894793002#ps1)

Review-Url: https://codereview.chromium.org/2898873002
Cr-Commit-Position: refs/heads/master@{#473796}

https://pdfium.googlesource.com/pdfium.git/+log/355954b8f09a..1b02d0180403

$ git log 355954b8f..1b02d0180 --date=short --no-merges --format='%ad %ae %s'
2017-05-22 thestig Remove CBC_HighLevelEncoder::isSpecialB256().
2017-05-22 thestig Use NOTREACHED() in more places.
2017-05-22 tsepez Convert more c-style pointers to CFX_UnownedPtr

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I0d89ce38e35d38bda5d57e0d0cb00726c05aa6cd
Reviewed-on: https://chromium-review.googlesource.com/511823
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473795}

Cr-Commit-Position: refs/heads/master@{#473794}

InputMethodController::SetSelectionOffsets function is
changed to use SetSelection instead of SetSelectedRange.

BUG=721190

Review-Url: https://codereview.chromium.org/2893303002
Cr-Commit-Position: refs/heads/master@{#473793}

BUG=596760
TBR=mkwst

Review-Url: https://codereview.chromium.org/2896443003
Cr-Commit-Position: refs/heads/master@{#473792}

Header files should be listed in the sources list, so gn analyze
can work.

https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0

https://groups.google.com/a/chromium.org/d/topic/chromium-dev/1kK45mVemBc/discussion

BUG=661774

Change-Id: I46e72232a525833bd805a306a4a1e2075f78adef
Reviewed-on: https://chromium-review.googlesource.com/508669Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473791}

Revert of Track task ids for navigations cross multiple tabs. (patchset #4 id:80001 of https://codereview.chromium.org/2868043003/ )

Reason for revert:
crbug.com/725026 and crbug.com/724497

Original issue's description:
> Track task ids for navigations cross multiple tabs.
>
> This is a following step to generate task ids for navigations. Now we
> can track navigation relationship cross multiple tabs. If navigation B
> in tab2 is clicked from navigation A in tab1, then navigation A is B's
> parent task. And this is generalized to more than 2 tabs.
>
> BUG=707978
> R=zea@chromium.org
>
> Review-Url: https://codereview.chromium.org/2868043003
> Cr-Commit-Position: refs/heads/master@{#472667}
> Committed: https://chromium.googlesource.com/chromium/src/+/854b8bcfc787413293c86eddd979a3fd1936fb1a

TBR=shenchao@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=707978

Review-Url: https://codereview.chromium.org/2901533003
Cr-Commit-Position: refs/heads/master@{#473790}

This reverts commit bce55d7b.

BUG=

TBR=mikecase,bsheedy

Review-Url: https://codereview.chromium.org/2896933002
Cr-Commit-Position: refs/heads/master@{#473789}

BUG=723977
TEST=browser_tests --gtest_filter=FileManagerJsTest.DirectoryTree*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2897973002
Cr-Commit-Position: refs/heads/master@{#473788}

This was a regression introduced by my patch https://codereview.chromium.org/2813353002/ for
bugs 665412, 656198. This patch ensured that the parent views get notified when a child adds a layer.

This notification is handled by the scrollview, where we enable layering on the viewport.

We need to call SetFillsBoundsOpaquely() on the viewport layer for the scrollview to ensure that
transparent views like the overflow menu work correctly.

Thanks for timbrown for helping debug on his Linux Box and to sky for
the suggestions.

BUG=722965

Review-Url: https://codereview.chromium.org/2895003002
Cr-Commit-Position: refs/heads/master@{#473787}

This reverts commit 107bc421.

Reason for revert: reenable the benchmark to see which tests are failing.

Original change's description:
> Disable performance_browser_tests on failing bots
> 
> The failing bots are:
> 
> Mac Air 10.11 Perf 
> Mac Pro 10.11 Perf
> Mac Retina Perf
> Win 7 ATI GPU Perf
> Win 7 Nvidia GPU Perf 
> Win 7 Perf
> 
> Bug:722367
> Change-Id: Iffb4d077312a69c3fb2386603183c3737ecb6540
> 
> NOTRY=true (since this doesn't affect any CQ test)
> TBR=sullivan@chromium.org
> 
> Change-Id: Iffb4d077312a69c3fb2386603183c3737ecb6540
> Reviewed-on: https://chromium-review.googlesource.com/509989
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#473326}

TBR=nednguyen@google.com,martiniss@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug:722367

Change-Id: Ife4777108c4318b808d7bf1f8b9ffe2a9dda1ec1
Reviewed-on: https://chromium-review.googlesource.com/511462Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#473786}

Revert of No extra space emission in TextIterator::HandleTextNode (patchset #6 id:100001 of https://codereview.chromium.org/2894543002/ )

Reason for revert:
Breaking this case:

<div class=container id=div4 style="width:30px">
foooooooooooooooo

<span style="white-space: pre">bar</span>
</div>

Original issue's description:
> No extra space emission in TextIterator::HandleTextNode
>
> Due to historical reasons, TextIterator emits an extra space before a text node
> with "white-space: pre" style if the last text node contains only collapsed
> whitespaces. This might be a workaround for some other buggy behavior, which
> no longer exists today.
>
> Hence, this patch removes the extra space emission.
>
> BUG=721957
>
> Review-Url: https://codereview.chromium.org/2894543002
> Cr-Commit-Position: refs/heads/master@{#473072}
> Committed: https://chromium.googlesource.com/chromium/src/+/9b781c354432f97658390c848359d2d70ceb1cb5

TBR=yosin@chromium.org,xiaochengh@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=721957

Review-Url: https://codereview.chromium.org/2896033003
Cr-Commit-Position: refs/heads/master@{#473785}

This makes sure that the VS environment is always properly set when
calling vs_toolchain.FindVCToolsRoot from the bots.

Review-Url: https://codereview.chromium.org/2893293004
Cr-Commit-Position: refs/heads/master@{#473784}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2282ee55..4aaca535

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2895143003
Cr-Commit-Position: refs/heads/master@{#473783}

Android framework does not provide an easy way to remove keyboard app
from the testing (unless you use Robolectric).

So far we have been allowing the current keyboard app to interfere with
test and thus flaked test results. Especially, when you make selection
change, Google Latin Keyboard tries to look at the new status by running

beginBatchEdit() -> getTextBeforeCursor() -> endBatchEdit().

And this disrupted batch edit logic such as mInBatchEditMode.

With this change, onCreateInputConnection() will now return null, so
keyboard app cannot interact with the text. Also, dispatchKeyEvent
will ignore key events when it has to.

Note that the test can still interact with BaseInputConnection's method
and thus affects EditText's Editable through UrlBar#getInputConnection().

In doing so, I've guarded KeyUtils#dispatchKeyEventToView() to work with
UI thread.

BUG=723901

Review-Url: https://codereview.chromium.org/2894073002
Cr-Commit-Position: refs/heads/master@{#473782}

Instead replace it with an appropriately styled div.

As a fortunate side-effect, this CL makes the box-shadow effect work
in Vulcanized mode, because it side-steps https://github.com/Polymer/polymer-css-build/issues/13

BUG=598516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2885363006
Cr-Commit-Position: refs/heads/master@{#473781}

Clarified that the crx_file.* refers to CRX₂, moved verification out of the CRX₂ code to allow callers to specify CRX₃-permissive policies.

Also fixed a potential crash in extension_creator.cc.

BUG=720092

Review-Url: https://codereview.chromium.org/2874503002
Cr-Commit-Position: refs/heads/master@{#473780}