- 13 Aug, 2019 40 commits
-
-
Tetsui Ohkubo authored
In order to reliably test ash split view in Tast, we have to expose some methods in autotestPrivate. Tast side CL: https://crrev.com/c/1716679 TEST=arc.SplitView BUG=135150701 Change-Id: Id957872c168b60910edeaf6221de8060684fa2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717615Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 8/12,13) <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#686297}
-
Fergus Dall authored
org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest#testGridToTabToOtherLiveWithAnimation org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest#testGridToTabToCurrentLiveWithAnimation TBR=yusufo@chromium.org, wychen@chromium.org Bug: 993201 Change-Id: I9da657c67233cd4baf1ed257d3e41d6ef954c886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750465Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#686296}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/412282acf9a9..43faee09e50a git log 412282acf9a9..43faee09e50a --date=short --no-merges --format='%ad %ae %s' 2019-08-12 alexdrake@google.com Implement JNI and objc implementation for Ice Candidate Pair Change event surfacing 2019-08-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 01bf3913..514a5433 (686061:686198) 2019-08-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f0fd984a..01bf3913 (685691:686061) 2019-08-12 sprang@webrtc.org Use unit types in RoundRobingPacketQueue and PacedSender 2019-08-12 titovartem@google.com Add frames_in_flight metric to catch not delivered frames 2019-08-12 yvesg@webrtc.org Roll chromium_revision 8f0166a5..f0fd984a (685582:685691) 2019-08-12 danilchap@webrtc.org Print stack trace when a test crash 2019-08-12 sprang@webrtc.org Make fake network degradation work also for sent audio 2019-08-12 nisse@webrtc.org Let StreamStatistician::GetReceiveStreamDataCounters return counters by value Created with: gclient setdep -r src/third_party/webrtc@43faee09e50a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I881f423b286c69deea462190c57051c57c7a163b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750562Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686295}
-
Brian Sheedy authored
Sets ScreenshotSync_GPURasterWithCanvas to retry on failure on Windows with Intel UHD 630 due to flaky WebSocketExceptions. TBR=kbr@chromium.org Bug: 986939 Change-Id: I334bd5e3ffb4ed9549f1cd50b65f071e1c10c778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750091Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#686294}
-
John Rummell authored
Adding UMAs to collect how long the following EME operations take: - CloseSession - GetStatusForPolicy - RemoveSession - SetServerCertificate - UpdateSession Also logs system code results for failing calls to: - GetStatusForPolicy - SetServerCertificate. CloseSession, RemoveSession, and UpdateSession had previously logged only these results and not the operation time. This CL is manually tested as follows: 1. Build browser_test and run the following: out/Debug/browser_tests --gtest_filter=MSE_ExternalClearKey/EncryptedMediaTest.Playback_VideoAudio_WebM/0 -v=1 where -v=1 will print out all histograms at the end. 2. Made sure we have the following: Histogram: Media.EME.Unknown.TimeTo.UpdateSession recorded 2 samples, ... 0 ... 12 -------------------O (2 = 100.0%) {0.0%} 14 ... Bug: 991373 Test: Ran several EME browser_tests with UMA logging enabled Change-Id: I7dc69e113805a34715932a9b7d5e04d3bfc91c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741639 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#686293}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5d664a903af3..1c632e376ba4 git log 5d664a903af3..1c632e376ba4 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 simonhatch@chromium.org Dashboard - Surface errors from Pinpoint more clearly. Created with: gclient setdep -r src/third_party/catapult@1c632e376ba4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:992532 Change-Id: I686c38cfd2f950b0447dbe4dc511c2a03a4263d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750096Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iaca85ceaae5f2eef3e3cb66420d3b7bb734a8506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750097Reviewed-by:
-
Matt Mueller authored
Bug: 973648 Change-Id: I7c0554de5b20ff4790ae380266f81db102c867a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743306 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686290}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6d27a1e71a89..12c357b447a4 git log 6d27a1e71a89..12c357b447a4 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 thestig@chromium.org Remove |CPDF_CMap::m_PredefinedCMap|. Created with: gclient setdep -r src/third_party/pdfium@12c357b447a4 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: If9743f23d3ae0675de98cc574fd83d2ced9add9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750283Reviewed-by:
-
Sergey Ulanov authored
Now base::fuchsia::ServiceDirectory is a wrapper around OutgoingDirectory. Most code outside of //base/fuchsia still uses base::fuchsia::ServiceDirectory and should continue function the same way as it did before. Bug: 920920 Change-Id: I915454b8fb7929b66bd0cc5ae4372d2e6499ed8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721558 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#686288}
-
Sergey Ulanov authored
Previously SysmemBufferCollection was not compatible with Vulkan drivers that require RAM coherency for memory buffers. Now RAM coherency domain is marked as support when initializing buffers that need to be mapped in memory. Also updated NativePixmapHandle struct to make modifiers field Linux-only. Bug: 942370 Change-Id: I4d46525540e7ea8e82aaa498258dc29c351d65d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716233 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#686287}
-
nancy authored
BUG=988321 Change-Id: Iab698b77ee2aecad12cb1c0842b3bee8eb427799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746515Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686286}
-
Yue Zhang authored
Bug: 992375 Change-Id: I67679acec8aa4be241545c08f003accba5f45df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750193Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#686285}
-
Matt Mueller authored
The initial verification attempt will still use the full input chain. Bug: 992267 Change-Id: Ia26f8400cf76defffd9b46d43badfe5dcf74f379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746961Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#686284}
-
Fergus Dall authored
TBR=vitalybuka@chromium.org, vtsyrklevich@chromium.org Bug: 993168 Change-Id: I0a6724ba91f51de152e17fe52a68a5be6dbd3056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750463Reviewed-by:
-
Yuwei Huang authored
Previously we had a bug such that OnReceiveMessagesStreamClosed() might be called with an OK status. OnReceiveMessagesStreamClosed in that case would not do anything, leaving the signal strategy silently disconnected. Now that crrev.com/c/1745414 has been checked in, OnReceiveMessagesSreamClosed() won't be called with OK. This CL changes the previous if-test to CHECK(!status.ok()) just to be safe. Bug: 992722 Change-Id: I336b603a920a9e0126164ee1d26aa034d9719215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750344 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#686282}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2da2115402df..092dde36abc3 git log 2da2115402df..092dde36abc3 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 tcwang@google.com afdo: Remove samus from eligble AFDO generation boards. Created with: gclient setdep -r src/third_party/chromite@092dde36abc3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I21c53f11f78c3cbdb4b765fcdb54c90c14498ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750094Reviewed-by:
-
Antonio Gomes authored
... by ThreadChecker. Reason: Sequences are not really used in Blink. BUG=704136 R=haraken@chromium.org Change-Id: I9c5f18030eeead5954fd22bac5190d6bc77f7d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749629 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#686280}
-
Kyle Horimoto authored
When navigating to the "Connected devices" subpage, we would previously leave any pending search term in place. This resulted in a bug which could cause the search term to reappear at a later time. This CL eliminates this issue by explicitly clearing the search term during navigation. Bug: 989119 Change-Id: I42a39a9df01cef0a4e188c0830c9e1772dd4eee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750192 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#686279}
-
Fergus Dall authored
This reverts commit 9d00bfef. Reason for revert: Broke the build on win-archive-rel [34793/69495] CXX obj/chrome/updater/win/test/updater_test_process/test_process_main.obj FAILED: obj/chrome/updater/win/test/updater_test_process/test_process_main.obj C:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\thi... ../../chrome/updater/win/test/test_process_main.cc(23,12): error: no member named 'InitializeOSUtils' in namespace 'updater' updater::InitializeOSUtils(); ~~~~~~~~~^ 1 error generated. Original change's description: > Chrome updater: implement support for creating task scheduler tasks. > > This CL implements the updater::TaskScheduler class to allow > creating scheduled tasks using Windows's task scheduler. > > The code is similar to what //chrome/chrome_cleaner/os has for this > purpose. Future refactoring work to eliminate duplicated code is > possible but unknown at this point how such effort could proceed. > > Several dependencies are needed for unit testing this code. The > general idea is that a program is invoked by the unit tests > scheduled tasks. To detect that such program has run, synchronization > with the unit test execution is required. > > Since the MS task scheduler API is finicky, minimal changes were done to > the TaskScheduler class implementation. > > Bug: 992551 > Change-Id: Ia315fa1d2b6d711b0639af20878e96a3659523b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747031 > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686267} TBR=sorin@chromium.org,waffles@chromium.org Change-Id: Ib7ad61b3dfda22281a14f59b550270058e9bd668 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 992551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750522Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a3112d1c5e9f..b875cc709c7f git log a3112d1c5e9f..b875cc709c7f --date=short --no-merges --format='%ad %ae %s' 2019-08-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@b875cc709c7f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: If387750ce0ea9c01b42d98e5f0397e0bd493e448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749765Reviewed-by:
-
Bo Liu authored
For renderer compositors, both are just the process and routing id. FrameSinkId will be used more widely with webview viz. FrameSinkId supports equality check, comparison, and hashing, so everything CompositorID does already. So switch to FrameSinkId and delete CompositorID. Bug: 805739 Change-Id: I64c3f2821aaefba0949db111c3e56bfc1a85bcc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745807Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#686276}
-
Scott Haseley authored
This CL implements more of the postTask API: 1) Scheduler.currentTaskQueue - retrieves the task queue of the current running task. If the current task was not scheduled through window.scheduler, this returns the default priority global task queue. 2) TaskQueue.take - move a task to a different task queue. For additional context, see the explainer (https://github.com/WICG/main-thread-scheduling/blob/master/PrioritizedPostTask.md) and the API proposal/design doc (https://docs.google.com/document/d/1xU7HyNsEsbXhTgt0ZnXDbeSXm5-m5FzkLJAT6LTizEI/edit?usp=sharing). Bug: 979017 Change-Id: I74cb08467cab479f8f305b21a14dd1d1b2deedb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737169 Commit-Queue: Scott Haseley <shaseley@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#686275}
-
Anushruth authored
R=bpastene@google.com Bug: 988587 Change-Id: Ibb108af5589365d74f00572799e10ea7ed227863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749959Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Anushruth <anushruth@chromium.org> Cr-Commit-Position: refs/heads/master@{#686274}
-
Anand K. Mistry authored
SMB network shares support is in active development, so this histogram is still useful. BUG=984218 Change-Id: I733514e11970fc8535258f3c9043cd4b9ff08393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745115Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#686273}
-
Takuto Ikuta authored
In component build, the number of opened file descritors may be different depends on loaded shared library. On Xenial component build, nacl_helper loads libgnutls.so. And libgnutls opens additional /dev/urandom, that makes CheckForExpectedNumberOfOpenFds() fail on Xenial. To prevent such check failure, let me disable libgnutls initialization by passing GNUTLS_NO_EXPLICIT_INIT envvar to nacl_helper. Bug: 973024 Change-Id: I03abd93b2dc48c8c11c3ed70f7c27c953ad16639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713024 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#686272}
-
Wez authored
This reverts commit d4f8b3f6. Reason for revert: Broke the Cast bots, since the fuchsia_package() _build_ rule actually depends on the SDK image being available, even though the output won't actually be _run_. (See https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-cast/47982) Original change's description: > Reland "[Fuchsia] Make hardware boot image downloading opt-in by .gclient." > > This is a reland of 2e2eefbd . > This fixes a bug in the original CL that crashed update_sdk.py when it was > given an empty list of boot images (as on the Cast builders). > > Original change's description: > > [Fuchsia] Make hardware boot image downloading opt-in by .gclient. > > > > Only download SDK system images for target CPU architectures which are > > explicitly configured in .gclient. Attempting to boot the SDK > > system image on a target CPU that was not configured will cause an > > explanatory message to be printed. > > > > If the .gclient variable is not set, then only QEMU images are > > downloaded for x64 and ARM64. This typically reduces the SDK download > > time by 30s, and data transfer/storage footprint by ~2.4GB versus > > the previous defaults, which downloaded boot images for all > > platform types and archs. > > > > This is useful for Chromium developers (e.g. sheriffs) who need to > > be able to build and run tests on Fuchsia, but don't want or need > > physical devices. It also speeds up the "gclient runhooks" step on > > Fuchsia buildbots. > > > > Bug: 990513 > > Change-Id: I55a310830c050f247e37dae8289c472c16ff5dca > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732805 > > Reviewed-by: Wez <wez@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > > Auto-Submit: Kevin Marshall <kmarshall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#685798} > > Bug: 990513 > Change-Id: I9fc1b566364cbbdecace5712d7268ea2c3336631 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748114 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Auto-Submit: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686257} TBR=wez@chromium.org,rockot@google.com,dpranke@chromium.org,kmarshall@chromium.org Change-Id: I5584e6dd955caa24fa2f1761e47fc1ad67a4d349 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 990513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750348Reviewed-by:
-
chrome://make-metroHector Carmona authored
This UI should no longer be shown because setting the default browser is done with the new onboarding flow. Bug: 987063 Change-Id: I2a987e7e3a03583cc08feeae5891eacef3740ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719166 Auto-Submit: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#686270}
-
Joshua Bell authored
The Indexed DB bindings code which converts values to keys is extremely subtle. As a prelude to further work, do some really minor tidying and add a bunch of comments. No functional changes. Change-Id: I18cd8eb33f074e94e979e5ccf57d1a74a124ba98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747737 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#686269}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/aba68fe5a5cc..2da2115402df git log aba68fe5a5cc..2da2115402df --date=short --no-merges --format='%ad %ae %s' 2019-08-12 dhanyaganesh@chromium.org Uprevchrome: change arg name to reflect https://crrev.com/c/1746494 Created with: gclient setdep -r src/third_party/chromite@2da2115402df The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ied60be15bf5a38c6d12d5b9dfa63b07f85a97bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749653Reviewed-by:
-
Sorin Jianu authored
This CL implements the updater::TaskScheduler class to allow creating scheduled tasks using Windows's task scheduler. The code is similar to what //chrome/chrome_cleaner/os has for this purpose. Future refactoring work to eliminate duplicated code is possible but unknown at this point how such effort could proceed. Several dependencies are needed for unit testing this code. The general idea is that a program is invoked by the unit tests scheduled tasks. To detect that such program has run, synchronization with the unit test execution is required. Since the MS task scheduler API is finicky, minimal changes were done to the TaskScheduler class implementation. Bug: 992551 Change-Id: Ia315fa1d2b6d711b0639af20878e96a3659523b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747031 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#686267}
-
Noel Gordon authored
Per crbug.com/798943#c9 zlib_bench contains the snappy bench verbatim, for the reasons explained there. However, subsequent code changes were not cc-ed to me. Add an OWNERS file to vet changes. Bug: 798943 Change-Id: I51b68f78190b1277882e5aeeffdc7b4e377c630d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746510 Commit-Queue: Chris Blume <cblume@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#686266}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/74e4834d3d25..9b45b5aafa37 git log 74e4834d3d25..9b45b5aafa37 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 bryan.bernhart@intel.com Handle staging buffer map failure on Metal. Created with: gclient setdep -r src/third_party/dawn@9b45b5aafa37 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ia91a71b928104ac43f663a35ffda5e10dfaae009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749655Reviewed-by:
-
Fergus Dall authored
TBR=sophiechang@chromium.org Bug: 993156 Change-Id: I6ad8e80db19cec7092f9861e568ddace4f940a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748973Reviewed-by:
-
Rafael Cintron authored
This change removes driver_date from the gpu fallback list mechanism. Entries that were previously using driver_date are changed to use the corresponding driver_version. Unfortunately, the driver date is very unreliable indicator of driver quality. It can get bumped during a republishing of a driver (perhaps by an OEM) or re-building an old driver with a targeted point fix. Driver version is the preferred method of blocking bad drivers. A future change, will be switching Chromium's GPU fallback code on Windows to use DXGI enumeration, which doesn't have access to driver_date. This change is also in preparation for that. Bug: 973695 Change-Id: Ia5cfa8fe3f3520680a3acb2bd26e6505dcecc6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745718Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686263}
-
Jeremy Roman authored
This allows "currying" of WTF cross-thread functions to be done using CrossThreadBindOnce and CrossThreadBindRepeating (but not with base::Bind). This is a reasonably common pattern to do with base callbacks and is a reasonable thing to want from WTF's wrappers. Bug: 992422 Change-Id: I9d3311e0362ef25657c31ce952becdfb7d0bc81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750043 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
lgcheng authored
After landing cl to fix flakiness of IsArcAllowedForProfile Trying to re-enable flaky CrSettingsCrostiniPageTest. Will need track if the flakiness is fixed. Note even before the fix, running a single browser_test always succeed. The test only failed when running the test suite. Bug: 962114 Change-Id: I174351d868f00a86e2d175072106976ee3568a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748588Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#686261}
-
Antonio Gomes authored
Both classes are now in Blink, and the later is the only child class of the former, so the abstraction is not strictly needed any more. BUG=704136 R=haraken@chromium.org Change-Id: I55323103ff861af11fa448ea23fa38e60c3a5d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749250 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/682a230..9a5af81f5 9a5af81 Update IANA timezone db to 2019b Bug: chromium:991739 Change-Id: I9b4fbc96932a2ce7fc15528ae107e757905dee30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747366Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686259}
-
James Cook authored
UX wants to use the plural. This better matches the section header. http://screen/BxGwHyw9fdr Bug: 982299 Change-Id: I9818562067614b4a4afe760babd276bb90e79a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750150 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686258}
-
