GitLab

Time taken to load Web Assembly module causes the test to timeout.

Bug: 920684
Change-Id: I6d16428cf8716e8d4203523a55dcd2b2fbfe50b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508015
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Auto-Submit: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638562}

This reverts commit 78d6b995.

Reason for revert:

This broke the coverage builds, see e.g.
https://ci.chromium.org/p/chromium/builders/ci/ToTLinuxCoverage/6258
which fails with:
"/bin/sh: 1: ../../build/toolchain/clang_code_coverage_wrapper.py--target-os=linux: not found"

I guess there's a missing space before --target-os.

Could this have been found in testing?


Original change's description:
> Use the wrapper script in all coverage builds.
> 
> Previously the wrapper script would only be used for coverage builds
> that required selective instrumentation of specific files. Now it
> will also be used for any coverage builds.
> 
> Since the script's job is to remove flags from files that shouldn't
> have them the default_coverage config now adds to cflags even in a
> CQ build.
> 
> Bug: 918215
> Change-Id: I012c5732d46bf5cff9eaf8f50615739bb781cc29
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496002
> Commit-Queue: Sajjad Mirza <sajjadm@google.com>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Max Moroz <mmoroz@chromium.org>
> Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638321}

TBR=stgao@chromium.org,dpranke@chromium.org,robertocn@chromium.org,mmoroz@chromium.org,liaoyuke@chromium.org,sajjadm@google.com

Change-Id: I8a945239dadc84d5e1c55a94ee84e34f413e54d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 918215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508457Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638561}

This is a roll-back to V8 7.4.288. This is the most stable candidate out of the latest Canaries.

If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back.

When in doubt please try to contact the committer and reviewers of this CL before reverting it.

TBR=machenbach@chromium.org

Change-Id: Ia8f8d42dbdeb270b72ffa21399257552628b062b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508095Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638560}

Remove unused includes and members from NavigationHandleImpl.

Change-Id: I8aca71e2d8044623ca88c9c166616d31172e357c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505436Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Mohamed Abdelhalim <zetamoo@google.com>
Cr-Commit-Position: refs/heads/master@{#638559}

https://android.googlesource.com/platform/external/perfetto.git/+log/cc1308550f58..c0eace27e740


git log cc1308550f58..c0eace27e740 --date=short --no-merges --format='%ad %ae %s'
2019-03-07 taylori@google.com perfetto-ui: Show time with units


Created with:
  gclient setdep -r src/third_party/perfetto@c0eace27e740

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Iacf960e98218dbb88e76ffbbf9ee90756938d296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508492Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638558}

Header generating action needs to be in public_deps

Bug: 931596
Change-Id: Ie69a72a1ab22d839f337e9a3cb7cf105fec43163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508472
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638557}

Bug: 924118
Change-Id: I4a2420ba610a7e47cc4ca3ec90eef825081a0ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479331Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638556}

Using wpt-import in Chromium 689d7721.
With Chromium commits locally applied on WPT:
68d5240e "[ChromeDriver] Set key modifiers with mouse actions"
682affef "Implemented setPlaybackRate for scroll-linked Worklet Animations."
2b037bdc "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html"
fc735f1b "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB"
ab40da96 "Isolation: Remove isolation if we have non-svg replaced content."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ib6bf6d90b468c369584d691af024594fd9066ba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508033Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638555}

Create interface URLCheckerClient to request server and check URL.
Create SafeSearchURLCheckerClient to check url using safesearch.
Leave only the synchronous logic in URLChecker.

BUG=934444

Change-Id: I53106ead0a478227960b49faa27a5d5c9d5c982e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479971
Commit-Queue: Caio Lima <caiol@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638554}

This is a reland of 96c748b0

Robustified the flaky test by using TestingPlatformSupportWithMockScheduler
to run the scheduler until exhaustion (fun fact, seems that the live version
of the script streaming wasn't being tested by this unit test :/ )

Original change's description:
> [blink] Remove old script streamer thread
>
> The script streamer thread has now been replaced with posting tasks to
> the scheduler, so remove the flag picking between the two options and
> the dedicated streaming thread itself.
>
> Also, remove the streaming task re-posting now that the blocking/
> non-blocking worker pools are merged.
>
> Bug: 874080
> Change-Id: Ib9dabb91deddcc616d4edfe5efb13d8e584c0691
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503420
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Auto-Submit: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638031}

TBR=mlippautz@chromium.org,holte@chromium.org,haraken@chromium.org,kinuko@chromium.org

Bug: 874080
Change-Id: I5be59d64fc2d6074094ce57cf884bcd0bdffd3ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507874Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638553}

[Password Generation] Button titles should be crowdsourced only if AutofillFieldMetadata experiment is enabled.

Bug: 910546
Change-Id: If09ec89ded92f21a733b4f22b9e456f8e3365109
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508252
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638552}

This CL eliminates FakeAccountFetcherService, which provides no
functionality over AccountFetcherService following recent changes.

The TestImageDecoder class that was contained in
fake_account_fetcher_service.* is retained, as it has usage in the
codebase. It looks like that usage could potentially be replaced by
usage of FakeImageDecoder, but that project is orthogonal to the
project of eliminating FakeAccountFetcherService.

TBR=droger@chromium.org

Bug: 935998
Change-Id: I4eed6e8f4b3a9474076eeed27e7641cd88b25458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503331Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638551}

Bug: 938695
Change-Id: I7c67ffb827e483a253d92ad98d90e7e02a5c1d63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507295
Auto-Submit: calamity <calamity@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638550}

https://chromium-review.googlesource.com/c/chromium/src/+/1496304 made a
skia change and rebaselined most test expectations, but not those
specific to LayoutNG.

TBR=kojii@chromium.org,reed@google.com

Bug: skia:8793
Change-Id: I675bb9449be7e8793c692ce7fb132b61b42fafed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508099Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638549}

This CL groups the methods related to NativeContent in CRWWebControler.

Bug: 938255
Change-Id: I4d375f6c156e0ef39a135542c17f542c5d37d6cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506072
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638548}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dcb547de1a5c..310f45e6d446


Created with:
  gclient setdep -r src-internal@310f45e6d446

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org

Change-Id: Ia33f26eff636df5b76b71f0618dddeffcb113faf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508192Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638547}

This makes tainting for many filter primitives less pessimistic, by
implementing the "Tainted Filter Primitives" section [1] from the
specification.

For feFlood/feDropShadow:

  A value of 'currentcolor' for 'flood-color' taints.

For feSpecularLighting/feDiffuseLighting:

  A value of 'currentcolor' for 'lighting-color' taints.

For the other primitives (which currently lack any specific logic), i.e:

  feBlend, feComponentTransfer, feComposite, feConvolveMatrix,
  feDisplacementMap, feGaussianBlur, feMorphology, feOffset and feTile

no local tainting is performed (the TaintsOrigin() override is returning
false).

The signature/convention of the TaintsOrigin() is changed by removing
the |inputs_taint_origin| argument, and always taint the
primitive if it (the flag returned by FilterEffect::InputsTaintOrigin)
is true. This saves each primitive to have to relate to this flag. (For
primitives that have no inputs this flag would always be false
regardless.) This means that TaintsOrigin() for each primitive is now
essentially computing the "local" tainting state.

[1] https://drafts.fxtf.org/filter-effects/#tainted-filter-primitives

Bug: 792518
Change-Id: Ie2d45eeb1ae8478009b88b8b87b3c4c325ede306
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503257
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638546}

Bug: 860467
Change-Id: Ifced401ce4b0fa34f3d3da6b69370fdb6952f4d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506076
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638545}

https://swiftshader.googlesource.com/SwiftShader.git/+log/952d27384a7e..45faa0849352


git log 952d27384a7e..45faa0849352 --date=short --no-merges --format='%ad %ae %s'
2019-03-07 bclayton@google.com VKPipeline: Log any errors produced by the SPIR-V optimizer


Created with:
  gclient setdep -r src/third_party/swiftshader@45faa0849352

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/127454276
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: Ie9118f68c42152d1e26d5fc0e3b11c8ec2048158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507812Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638544}

PaintWorkletInput should not need to know how
PaintWorkletStylePropertyMap is created.

Bug: None
Change-Id: I44cfe3819bcd305ca0ec077f6bd00e376eb59609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506653Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638543}

AEC3 has now been launched to 100% via Finch and has fully replaced
the legacy AEC. To make the launch complete this CL
-Removes the finch experimentation code for controlling AEC3.
-Removes the chrome flag for controlling AEC3.
-Defaults all cases of Browser AEC (AEC2/AEC3 in the code) to use AEC3.

What this CL does not do is to remove all the code that distinguishes
between AEC3 and AEC2. That is intended for an upcoming CL and requires
many more changes. An example of such a CL is available at
https://chromium-review.googlesource.com/c/chromium/src/+/1495518

Bug: chromium:696930
Change-Id: Ia6a92a4e759d2319d2fa2d0f08936788645ab2d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495528Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Per Åhgren <peah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638542}

Don't use Jinja's trim_blocks feature right before the closing brace for the
bodies of inline functions in generated header files for CSS properties, so
that the closing braces for those functions' bodies are always placed in a
new lines, in order to prevent build failures with empty bodies that are
filled with one-line C++ comments.

Bug: 937861, 919875
Change-Id: I156d6d0eed6413c3db6e5fc12ecca7fdaca14805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499516Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#638541}

Bug: 930019
Change-Id: I9c52bdfa4b458a1cee553d90518de880a72e4954
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507632
Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638540}

The policy was not included in that group by mistake, which would make
it harder to find in the ADMX templates.

Change-Id: I6852208b73d812a9ea3c548f900625d0df323df8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505995
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638539}

https://skia.googlesource.com/skia.git/+log/8e9850cc9584..4c1ea43a79b5


git log 8e9850cc9584..4c1ea43a79b5 --date=short --no-merges --format='%ad %ae %s'
2019-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 952d27384a7e..45faa0849352 (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@4c1ea43a79b5

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: I348e9abdba7b6c80be9dc93e68f23f2f3c7f8d26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507934Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638538}

This implements COLOR_SCHEME_LIGHT and COLOR_SCHEME_DARK support for
custom tabs. Support for COLOR_SCHEME_SYSTEM, which will fall back to
system settings, will be implemented in a follow-up CL.

Bug: 937259
Change-Id: I7f7599eca596f3cd5323d73ed71981778587b88a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499537Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638537}

Used to setup and work with LocalPolicyTestServer.
Chrome OS tests are migrated.

TBD:
Enable disabled migrated tests
Migrate Chrome tests when mixins are Chrome-wide

Bug: 934224, 912704
Change-Id: I5fef3d20e3ec8dd23f6307139fab1fbc1517d3d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495532
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638536}

Syncing changes from CL
https://critique.corp.google.com/#review/236764935 to the client.
Reference: go/customer-logo-policy-one-pager

Bug: none
Change-Id: I31b1c06f6c8e7a7a780b5aa8216061ddb93afb45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505509
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Auto-Submit: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638535}

Bug: 938867
Change-Id: I8c146af675d085d0784d5ff7c54670d0f6597c80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507912Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638534}

With this change, TouchEventFilterView sets a clip rectangle that
avoids the top and bottom bars when drawing.

This avoids ever drawing on top of either bars and is also more
efficient than the previous implementation, which would draw then
clear out some section.

Additionally, it uses the top visible offset for drawing, instead
of the top content offset. There's a difference of a few pixel,
which is visible now because of the presence of the blue border.

This change also address the CanvasSize lint warning and stops
using canvas.getWidth(), as recommended.

Bug: b/125245127
Change-Id: I0ced7df06f1ace285525f9b7328204cc79bbad3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505944
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638533}

This CL also implements "most-specific wins" rule.
https://github.com/WICG/import-maps/issues/102

Bug: 928149
Change-Id: I484266086bbe244de8b43ceeddacc8552307b7f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475049
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638532}

This reverts commit 1bda93b7.

Reason for revert: Blocks roll of V8 https://chromium-review.googlesource.com/c/chromium/src/+/1508095/1

Original change's description:
> Adopt to new MicrotasksCompletedCallback signature
> 
> V8 updated the signature of MicrotasksCompletedCallback to take a void
> pointer user data, and is deprecating the old signature.
> This CL updates its user to use the new one.
> 
> Change-Id: I24990f68b2964fa80554689947746636958f59cc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504660
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638471}

TBR=peria@chromium.org,haraken@chromium.org,tzik@chromium.org

Change-Id: I7a5134b417be5c8b2e189e30a488ce09929d5e6e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507875Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638531}

This CL groups the helpers methods for WKNavigationDelegate and WebView.

Bug: 938255
Change-Id: Ie8b2142ca16a0d3b07b0eb42bfe6d7046d914150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505507
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638530}

Hide feature using feature flag.

Bug: 927331
Change-Id: I76edb713c491c75d89484c345b763615c22133b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505948
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638529}

This CL merge the -setWebView: method to its readonly property.
It moves loadHTML: close to its public declaration as it is only here
for testing purpose.
It also remove +webControllerCanShow, putting its code in its call
site.

Bug: 938255
Change-Id: If8970a58a5eb99b8be5e67eb1006b088d0dd05d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505444
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638528}

https://android.googlesource.com/platform/external/perfetto.git/+log/df42f3b1d646..cc1308550f58


git log df42f3b1d646..cc1308550f58 --date=short --no-merges --format='%ad %ae %s'
2019-03-07 fmayer@google.com Merge "Use the SharedRingBuffer for sending payload from client to service."


Created with:
  gclient setdep -r src/third_party/perfetto@cc1308550f58

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ifcf2991cd2029a304c91e7e010e9619a692b49f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507932Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638527}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b3e27ce9a43..dcb547de1a5c


Created with:
  gclient setdep -r src-internal@dcb547de1a5c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org

Change-Id: I799aff9eb20a524fb27c6bcd74a719fb1304f70f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507933Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638526}

https://drive.google.com/open?id=1942lUZ9_kpjOzIvlrk0I9OBfYpa-pO8A
https://drive.google.com/open?id=1atZHLclvCjd3xajAuJW7GCF5N4gtaTVX

Bug: 939056
Change-Id: If9480112f5b1174ffa11de35e63f9c719d8fcd4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506772Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638525}

AlsReaderImpl previously checked number of ALS config steps to determine if a
device should be supported. We now use ModelConfigLoader to load model config
that will tell us if a device is supported, hence this cl removes config
verification from AlsReaderImpl.

Bug: 881215
Change-Id: I273a1b1b518970ae49632622acb25a8cfd69c5f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505747
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638524}

Few last minute upates on the icon.

Signed out:
https://drive.google.com/open?id=1aZ0zKE8j04pqDtj7fHKOR_IRT421GXZg
Sync error:
https://drive.google.com/open?id=10ugnfgeh5wBT2mKweRSVA0UQ-z-_mdx_

Bug: 889470
Change-Id: Ie22e8af005729841a78517e733b55e4acedbe14a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505451Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638523}