- 18 Sep, 2018 40 commits
-
-
sahel authored
This cl changes the Autoscroll middle click logic to wait for the first GFS with none-zero velocity before sending the GSB. This is to make sure that the generated GSB has the proper delta hints for hit testing. In autoscroll browsertests I increased the mouse move deltas to make sure that the fling velocity is large enough and the tests are stable. Bug: 249063 Test: AutoscrollBrowserTest.AutoscrollFlingGSBDeltaHints Change-Id: I1714b70439fcc5abea28938e272f64ff27b4bc66 Reviewed-on: https://chromium-review.googlesource.com/1230582 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592217}
-
inglorion authored
content_browsertests UtilityProcessHostBrowserTest.LaunchProcessAndCrash is flaky on Windows. Disabling the test so that it doesn't cause build bots to be red on non-breaking changes. Bug: 879555 Change-Id: If2aff8e69d240adf09173b82472db6c86eb6aa91 Reviewed-on: https://chromium-review.googlesource.com/1227303Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#592216}
-
Sahel Sharify authored
This cl adds threaded tests suites for fast/events/touch|wheel/* layout tests. Other than the following tests the rest of the tests are passing without any issues: Touchpad fling related tests: these tests are skipped since touchpad swipe is recently added to gpu benchmarking. I already have a bug for converting these tests to use gpu benchmarking. see crbug.com/857490 -virtual/threaded/fast/events/touch/gesture/pad-gesture-cancel.html -virtual/threaded/fast/events/touch/gesture/pad-gesture-fling.html -virtual/threaded/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html -virtual/threaded/fast/events/wheel/mainthread-touchpad-fling-latching.html -virtual/threaded/fast/events/wheel/wheel-fling-cancel.html The following test is flaky, but checking flakiness dashboard showed that its other variations are flaky as well. see crbug.com/884312 -virtual/threaded/fast/events/touch/multi-touch-user-gesture.html The following two tests are failing, but again so are their other variations. I updated all the expectations to point to the same bug and added expectations for the threaded versions. see crbug.com/876305 -virtual/threaded/fast/events/touch/compositor-touch-hit-rects-list-translate.html -virtual/threaded/fast/events/touch/compositor-touch-hit-rects.html Only the threaded version of the following tests are failing since they are using event sender. I filed a bug to convert it to use gpu benchmarking: crbug.com/884332 -virtual/threaded/fast/events/touch/gesture/gesture-tap-active-state-hidden-iframe.html -virtual/threaded/fast/events/touch/gesture/gesture-tap-frame-removed.html -virtual/threaded/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html -virtual/threaded/fast/events/touch/gesture/gesture-tap-active-state.html -virtual/threaded/fast/events/touch/gesture/focus-selectionchange-on-tap.html One additional test is failing when running with --additional-driver-flag=--enable-blink-gen-property-trees, for which I have filed a bug: crbug.com/884846 Bug: 874995, 884332, 884312, 876305 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifbc4ca54b48307320fe3a703b93cff1620dd1878 Reviewed-on: https://chromium-review.googlesource.com/1227331 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592215}
-
Francois Doray authored
Bug: 833989 Change-Id: If8927d294fc3e28791bdaac07294eace6b21c8ba Reviewed-on: https://chromium-review.googlesource.com/1231298 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592214}
-
Xiaoqian Dai authored
For fling event, we also should do proper drag ending if splitview mode is active at the moment. Otherwise, the splitview divider bar won't be able to place on top properly. Bug: 885261 Change-Id: I992c2502090c2f4d6fd9e4f0401ca172f9041823 Reviewed-on: https://chromium-review.googlesource.com/1231893Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#592213}
-
Dave Tapuska authored
Use wtf_size_t when dealing with WTF types. BUG=879657 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic2d84e1ef5c07481c45d987a1ca1140ec4975442 Reviewed-on: https://chromium-review.googlesource.com/1228780Reviewed-by:
-
chrome://sys-internalsDave Tapuska authored
s/kernal/kernel BUG=884319 Change-Id: Ifd5c6470e62d2d15992253df65d1725d2b8b95df Reviewed-on: https://chromium-review.googlesource.com/1231977Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#592211}
-
John Delaney authored
THere metrics are now gated on there being non-zero ad bytes on page. Reflect this condition in the histogram descriptions. See: https://chromium-review.googlesource.com/c/chromium/src/+/1228433 Bug: 884678 Change-Id: I5320c4b8fff1e3e57ba45cb2c0100db9ea577d62 Reviewed-on: https://chromium-review.googlesource.com/1231154Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592210}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57efeca83c87..1904775ac35b Created with: gclient setdep -r src-internal@1904775ac35b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I56870fadcb526ba8967914bc5a27261b16b2ddfe Reviewed-on: https://chromium-review.googlesource.com/1231928Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592209}
-
Joel Hockey authored
Note that this feature is being added to read any persisted shares, however support to write shares as persisted will not be added until the management UI where shares can be removed is completed. * prefs: crostini.shared_paths will be a list of filesystem path strings. * New function CrostiniSharePath::GetSharedPaths() reads from prefs. * New fileManagerPrivate.getCrostiniSharedPaths executes callback to receive list of Entry. * FileManager.setupCrostini_ loads persisted shares at startup. * FileManagerApiTest.Crostini verifies reading from prefs and correct conversion of filesystem paths to FileEntry. * New integration test for fileManagerPrivate.getCrostiniSharedPaths(). Bug: 878324 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5c8ee8193eb2fda94e5505d79b449797fbab9449 Reviewed-on: https://chromium-review.googlesource.com/1220411Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#592208}
-
Dale Curtis authored
When disabling a video track we send an end-of-stream buffer but no true decoded frame, this prevents stats from being updated because the decoded frame count hasn't changed. So histogram metrics around memory still report a full video frame queue instead of 0-1 frames. BUG=709302 TEST=disable track reports lower memory usage now; updated test. R=tmathmeyer Change-Id: I15fcd286f9420d4453a03c2c28503858d96f7841 Reviewed-on: https://chromium-review.googlesource.com/1231697 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#592207}
-
bsheedy authored
Adds support for dumping VR frame buffers to disk during tests instead of relying on Android's screenshot capabilities. This works around any potential flakiness in image diff tests that could be caused by asynchronous reprojection or distortion. Also refactors the code used to be notified of when the native UI reaches quiescence to be applicable to any type of event that tests need to block on. In this case, it is used to block until the frame buffers have been fully dumped, as otherwise images could get corrupted by the test ending during a dump. Bug: 883940 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1b18deaabfe54ccc4890f3345a19402bbccefe9a Reviewed-on: https://chromium-review.googlesource.com/1213925 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#592206}
-
Zhenyao Mo authored
BUG=876523 TEST= R=piman@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iab87d6e97a1c320867aec476cabe26dd8bda32a6 Reviewed-on: https://chromium-review.googlesource.com/1231938Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#592205}
-
Dmitry Gozman authored
Instead of exposing NavigationState, observers get two additional values in Did{Start,Commit}ProvisionalLoad callbacks. This will allow us to remove NavigationState entirely to simplify navigation tracking between blink and content. As a first step, we can stop tracking transition type. TBR=boliu@chromium.org,thakis@chromium.org,rockot@chromium.org,blundell@chromium.org Bug: 855189 Change-Id: I6344ca4716121af9513c9bc672e5e9b28d49f055 Reviewed-on: https://chromium-review.googlesource.com/1226198 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#592204}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1aa405fd859a..dd2ce986ce25 git log 1aa405fd859a..dd2ce986ce25 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 nodir@google.com [gclient] Update set_patch_project_revision 2018-09-18 ehmaldonado@chromium.org gclient: delete unversioned directory before adding cipd dep for the same path 2018-09-18 nodir@google.com [bot_update] Update examples to use buildbucket module Created with: gclient setdep -r src/third_party/depot_tools@dd2ce986ce25 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:694348,chromium:882611,chromium:694348 TBR=agable@chromium.org Change-Id: I51d6fc4125e76f9f2435e9650e7434fe61ced729 Reviewed-on: https://chromium-review.googlesource.com/1232057Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592203}
-
Hal Canary authored
Also, remove some unneded ones. Change-Id: If2d25bb255b1e4f3e67405a303d7daaf215b148e Reviewed-on: https://chromium-review.googlesource.com/1219906Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Hal Canary <halcanary@google.com> Cr-Commit-Position: refs/heads/master@{#592202}
-
kylechar authored
Remove outdated comment and cleanup #ifdef. Bug: none Change-Id: I2f02dcc4aaa496e4b8f773a31d24011bd409a792 Reviewed-on: https://chromium-review.googlesource.com/1227223Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592201}
-
Che-yu Wu authored
Add files to define all constants related to the quarantine feature. Bug: crbug.com/884734 Change-Id: I254cd63f1ae48596abb15c10b996c7969d50a63e Reviewed-on: https://chromium-review.googlesource.com/1228299Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Che-yu Wu <cheyuw@google.com> Cr-Commit-Position: refs/heads/master@{#592200}
-
CJ DiMeglio authored
Previously, when one gave a media control accessibility focus (swiping to it in TalkBack for example), the controls would continue to hold a11y focus, but hide. This was confusing. Now they continue to show when given a11y focus. Bug: 841218 Change-Id: I0a589bc3c51b4c3dad23ab666b94470d5991c9d1 Reviewed-on: https://chromium-review.googlesource.com/1228989 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#592199}
-
Khushal authored
The ImageDecoder should decode to external memory if provided an allocator. The ICOImageDecoder was missing forwarding this allocator to a png decoder it uses internally. R=chrishtr@chromium.org Bug: 884136 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iacad54e2640bc4f91d48e9a3c28bc6073b95ba6a Reviewed-on: https://chromium-review.googlesource.com/1227397Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592198}
-
Asanka Herath authored
This reverts commit 355a3311. Reason for revert: A couple of tests crashing on Win7 and Win-ASAN 2 tests crashed: Tests/QuicUnackedPacketMapTest.CannotAggregateIfDataLengthOverflow/0 (../../net/third_party/quic/core/quic_unacked_packet_map_test.cc:169) Tests/QuicUnackedPacketMapTest.CannotAggregateIfDataLengthOverflow/1 (../../net/third_party/quic/core/quic_unacked_packet_map_test.cc:169) Original change's description: > Landing Recent QUIC changes until 2:35 PM, Sep 14, 2018 UTC-4 > > Turn on FLAGS_quic_reloadable_flag_quic_fix_is_useful_for_retrans > https://chromium-review.googlesource.com/c/chromium/src/+/1228857 > > Update IETF QUIC Transport Error codes > The IETF QUIC transport error codes are updated to reflect > version 14 of the QUIC transport IETF draft: > - SERVER_BUSY is added > - FRAME_FORMAT_ERROR is changed to FRAME_ENCODING_ERROR > - UNSOLICITED_PONG is removed > - INVALID_MIGRATION is added > Merge internal change: 213016352 > https://chromium-review.googlesource.com/c/chromium/src/+/1228548 > > Fix a ACK frame reporting issue caused by unsigned integer wrap around. Protected by flag FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames_2. > Flag FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames_2 is the v2 of the existing flag FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames. > Merge internal change: 212991266 > https://chromium-review.googlesource.com/c/chromium/src/+/1228894 > > Implement support for framing QuicCryptoFrames from IETF QUIC. > Merge internal change: 212917548 > https://chromium-review.googlesource.com/c/chromium/src/+/1228436 > > Turn on FLAGS_quic_reloadable_flags_quic_fix_reset_zombie_streams in quartc. > Merge internal change: 212810521 > https://chromium-review.googlesource.com/c/chromium/src/+/1228435 > > In QUIC, fix a bug that zombie streams cannot be closed when gets reset locally. Protected by FLAGS_quic_reloadable_flag_quic_fix_reset_zombie_streams. > Merge internal change: 212676554 > https://chromium-review.googlesource.com/c/chromium/src/+/1228434 > > Split QUIC's FramerVisitor into two methods, OnAckRange and OnAckFrameEnd(). No functional change, not flag protected. > Merge internal change: 212629799 > https://chromium-review.googlesource.com/c/chromium/src/+/1228394 > > Move multiple (repeated) definitions of QuicConnectionArena to a single place in quic_one_block_arena.h. Move only, not protected. > Merge internal change: 212626492 > https://chromium-review.googlesource.com/c/chromium/src/+/1228393 > > Change-Id: I675e3fbaa9c01aa3e5749f44323ddac6eb45a9d8 > Reviewed-on: https://chromium-review.googlesource.com/1228858 > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Fan Yang <fayang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592135} TBR=rch@chromium.org,fayang@chromium.org Change-Id: Ib6288002eb8b8e5704c901a3fe1f771d5665049e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1232038Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592197}
-
Bill Orr authored
This change introduces a mojo interface for browser tests to control the behavior of OpenVR running in the XR device service. BUG=795510 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I95a6a0c9a57ff0e174b337026b34866c43fff058 Reviewed-on: https://chromium-review.googlesource.com/1166468 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#592196}
-
Robbie McElrath authored
This migrates BackgroundSyncNetworkObserver from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 868015 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I80ea69e7a5ffc07fc3c79eb1052223f972babd01 Reviewed-on: https://chromium-review.googlesource.com/1214564 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
-
Evan Stade authored
This splits the immersive related code out of ResizeHandleWindowTargeter into its own class, which is installed whenever the window is in immersive mode. It makes use of aura::WindowTargeter::SetInsets and move the class into window_util.cc as a file local. Docs are added to clarify the roles of EasyResizeWindowTargeter, ResizeHandleWindowTargeter, and so forth. Change-Id: I8664dbc1a4b420ab04981cd1a15dc177b02edf00 Reviewed-on: https://chromium-review.googlesource.com/1226267 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#592194}
-
Dave Tapuska authored
The origin trial was a little slower than anticipated in starting. Since we don't have data analysis back yet give us three more releases. I anticipate that this will likely cover the intent to ship (hopefully will be in M72). BUG=884866 Change-Id: Ib924b3862ea9da3c8df76f3c4065255f218a02f5 Reviewed-on: https://chromium-review.googlesource.com/1230533Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#592193}
-
Yue Li authored
Bug: b/115781013 Test: Manual Test Change-Id: I5aca7c8befd30ca65cc92bdee32bf7a0c7eb87b4 Reviewed-on: https://chromium-review.googlesource.com/1231694Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#592192}
-
Vikas Soni authored
This is a new test which was marked as failing as it uses a reference image. Unmarking it as fail since reference images are produced by all of the GPU bots. Bug: 883500 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I311f8e4a896de0c409772e18efcaf1ee5c29a04e Reviewed-on: https://chromium-review.googlesource.com/1231934Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/874b57542941..c968ea0b6538 git log 874b57542941..c968ea0b6538 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 ntfschr@google.com devil: add pie SDK constant Created with: gclient setdep -r src/third_party/catapult@c968ea0b6538 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9c4e3276a97029dbfb19483c072502576eb9ee5f Reviewed-on: https://chromium-review.googlesource.com/1231974Reviewed-by:
-
Samuel Huang authored
This CL refactors resource_sizes.py so Super Size can use it to get normalized APK size. Previously size extraction and output are done by PrintApkAnalysis(). This CL decouples extraction and printing by extrating most of the function into GenerateApkAnalysis(), which becomes a generator that yields the required data into a 4-array [title suffix, trace title, value, units]. PrintApkAnalysi() then pumps the generator output into perf_tests_results_helper.ReportPerfResult(). Small wrinkle: PrintApkAnalysis() prints unknown symbols. For GenerateApkAnalysis(), this is delegated to an optional callback. The above is repeated for _PrintDexAnalysis(). So resource_size now exports two new functions: GenerateApkAnalysis() GenerateDexAnalysis() Also change print to the function form, as a clean up. Bug: 880671 Change-Id: Ie572c5f14345511473ab73266cc305ebc87fcab5 Reviewed-on: https://chromium-review.googlesource.com/1231381Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#592189}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/devtools. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=caseq@chromium.org Bug: 874080 Change-Id: I09d16aad817f3f9cc756d32f93a0c589c8d52782 Reviewed-on: https://chromium-review.googlesource.com/1191812Reviewed-by:Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#592188}
-
Zach Helfinstein authored
Bug: 884297 Change-Id: I268e11dc5c71a78208fb07afd8dcc86c26964c05 Reviewed-on: https://chromium-review.googlesource.com/1229773Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#592187}
-
chaopeng authored
This pref regression is because after we add the scroll and transform node for layout view the transform structure changes. Before crrev/c/1156002 the layers in this test has transform node which is children of root transform node. After that CL, the layers has root scrolling transform node. Bug: 875991 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I303ca698e1e3f1a8e3c87d9eb061752b7dd6eb39 Reviewed-on: https://chromium-review.googlesource.com/1210384Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Jian Li authored
We've added several more reason values that should force loading offline page. So update the check in ShouldFallbackToLoadOfflinePage. Bug: 874791 Change-Id: I8d7d221620137432fe38363cdd35340e55e9e9c2 Reviewed-on: https://chromium-review.googlesource.com/1229416 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#592185}
-
Rintaro Kuroiwa authored
- Use partion decryption so that it doesn't decrypt the rest of the buffer that is not relevant. - Most audio samples are significantly smaller than the current buffer size, e.g. < 1KB. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I22d2d1f36d2dbc0cd088fab097a3ab8ee684e0e3 Reviewed-on: https://chromium-review.googlesource.com/1227218 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592184}
-
mark a. foltz authored
MRDCV may outlive the CastDialogView widget, in which case it should remove itself as an observer on widget destruction. Bug: 883976 Change-Id: I511909a679da9d6f6639713726f3589e1723ee56 Reviewed-on: https://chromium-review.googlesource.com/1226360 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592183}
-
Clark DuVall authored
ResourceThrottles do not work with network service enabled, a NavigationThrottle will work both with NS enabled and disabled. Bug: 884006 Change-Id: Ifea0e59bd67d70b593b46c2a2a2bd4be0e3f98f0 Reviewed-on: https://chromium-review.googlesource.com/1227358Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
Adds a test to verify that constraints.fixedBlockSize is set to the correct value, in quirks mode, with a percentage block-size. Bug: 726125 Change-Id: I97a1e946cdbb4443d70803bfd4ace7f8d3df2ce1 Reviewed-on: https://chromium-review.googlesource.com/1231385Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#592181}
-
Eugene But authored
Remove comment related to UMA_HISTOGRAM_COUNTS_100 which used to say about UMA_HISTOGRAM_EXACT_LINEAR limitations. Bug: 877671 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5ccd18c22386d82fd7669494700654221eecdfbe Reviewed-on: https://chromium-review.googlesource.com/1230933Reviewed-by:
-
Min Qin authored
This CL is based on https://chromium-review.googlesource.com/c/chromium/src/+/1199944 When ServiceManager launches, ChromeFeatureListCreator will be created to load the user pref store and a simple local state. Later on the user pref store will be passed to BrowserProcessImpl to create a new local state. This CL simplifies the process by passing ChromeFeatureListCreator to BrowserProcessImpl, so that the simple local state can be transformed into g_browser_process->local_state. BUG=866028 Change-Id: Ia2e6f67bc6dc54f31b6efc2cdabe6c7d4d6158ae Reviewed-on: https://chromium-review.googlesource.com/1204926 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
-
Eugene But authored
Follow up for http://crrev.com/c/1225697/6/ios/web/navigation/navigation_manager_impl.mm#21 R=mpearson@chromium.org Bug: 877671 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I390bef0562886d5f02469a184ddb6c86f3f62563 Reviewed-on: https://chromium-review.googlesource.com/1229617Reviewed-by:
-
