- 17 Aug, 2018 40 commits
-
-
Ramin Halavati authored
Suggestions and Feed preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ibe4c2545c0d9bab6efd82f1d0972c22bec176c1b Reviewed-on: https://chromium-review.googlesource.com/1176804Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583965}
-
Ramin Halavati authored
ChromeOS Audio preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. This CL won't affect changes from Settings page. Bug: 861722 Change-Id: Id4f4bf82494188ac4501248ffdf4867187b77d3d Reviewed-on: https://chromium-review.googlesource.com/1176807Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583964}
-
Siddhartha authored
This CL sets up a preference for enabling startup tracing if needed. Early java tracing is enabled if the preference is set. This will be used by background tracing to setup startup tracing. BUG=859260 Change-Id: Idf2c6cbfb8c2a4d5e1765a1d2c3256abe69368fe Reviewed-on: https://chromium-review.googlesource.com/1159116 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#583963}
-
Eric Foo authored
Bug: 862864 Change-Id: Idacfb439011488cfb472907c480fb49a704e24fc Reviewed-on: https://chromium-review.googlesource.com/1173760 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#583962}
-
Carlos Knippschild authored
I had local build errors requiring explicit constructors and destructor implementations of the PrefetchSuggestion struct but I forgot to add the .cc file containing them to the CL that introduced that class. This change fixes that mistake. TBR: skym@chromium.org, harringtond@chromium.org Bug: 841516 Change-Id: If81f9a3db128b9224d835af5cb7aa40959f093d3 Reviewed-on: https://chromium-review.googlesource.com/1179362Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#583961}
-
Eriko Kurimoto authored
Reference https://chromium-review.googlesource.com/c/chromium/src/+/1158315 Bug: 821926 Change-Id: Iaf50ca97a9cceed98a915971b816ca7bdbcd515a Reviewed-on: https://chromium-review.googlesource.com/1172307 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#583960}
-
Eliot Courtney authored
with it did not activate it. Bug: b/112629940 Test: Put app into PIP mode, it no longer was activated. Interacting Change-Id: I88cb307afe5a6aba573c27a5fc9d3f150c430649 Reviewed-on: https://chromium-review.googlesource.com/1175751 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#583959}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9faabc5fc371..21068062a038 git log 9faabc5fc371..21068062a038 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 tsepez@chromium.org Remove optionals in CXFA_LayoutPageMgr methods. 2018-08-17 tsepez@chromium.org Remove optionals from CXFA_NodeHelper::NodeAcc_TraverseSiblings(). Created with: gclient setdep -r src/third_party/pdfium@21068062a038 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic71642b01304c9737281e01af5f0fba09b738f54 Reviewed-on: https://chromium-review.googlesource.com/1179325Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583958}
-
Kai Ninomiya authored
This adds a new perf test case for camera-to-WebGL uploads. This new case is intended to detect the performance improvements being made in issue 867368. Bug: 867368 Change-Id: Ia8b05f422e15bb7625491ac10f33903dcc1c55d0 Reviewed-on: https://chromium-review.googlesource.com/1170033Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#583957}
-
rbpotter authored
The test is failing (flaky?) on Mac 10.12. Bug: 874976 Change-Id: I913c6d39d7650e8298cd83eb2236f0f0d027f5d1 Reviewed-on: https://chromium-review.googlesource.com/1178639 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583956}
-
Kentaro Hara authored
This reverts commit dccf844a. Reason for revert: Broke some browser_tests on Mac. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/4738 Original change's description: > Convert dns_api.cc to mojo host resolver > > Bug: 874658 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I576d2877ec71df8e489d349916f758ba6fe74263 > Reviewed-on: https://chromium-review.googlesource.com/1176725 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583878} TBR=jam@chromium.org,wfh@chromium.org,ericorth@chromium.org,cduvall@chromium.org Change-Id: Id845006ad303fca63c7c681fd259d3db379dfddd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874658 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1179383Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#583955}
-
Kentaro Hara authored
This reverts commit 8fd04b5f. Reason for revert: TextSuggestionsTouchBarControllerTest.InvalidRange started failing https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28606 Original change's description: > [Mac] Moved TextSuggestionsTouchBarController's Range Validity Check > > Previously, -updateTextSelection:range:offset: could receive an invalid > range from WebContentsTextObserver::DidChangeTextSelection(). This > invalid range would then cause a crash in -requestSuggestions. > > A check has been added to -updateTextSelection:range:offset: to make > sure that a selection with an invalid range is not passed to > -requestSuggestions. This should prevent future crashes. > > TextSuggestionsTouchBarControllerTest.InvalidRange tests that an > invalid range does not crash the controller and is handled > properly. > > Bug: 717553 > Change-Id: I69f49cb1f1819e1d528837767dfb894d8652e84d > Reviewed-on: https://chromium-review.googlesource.com/1178467 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Sarah Chan <spqchan@chromium.org> > Commit-Queue: Tessa Nijssen <tnijssen@google.com> > Cr-Commit-Position: refs/heads/master@{#583815} TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com Change-Id: I7735c373052037bb377c1beac79d7b1132f3bc86 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 717553 Reviewed-on: https://chromium-review.googlesource.com/1179382Reviewed-by:
-
Charles Zhao authored
(1) A SearchResultRanker class with a simple AppLaunchPredictor is added. (2) SearchResultRanker lives inside AppSearchProvider and re-rank the suggested apps. (3) training signal is passed from AppListClientImpl to SearchController, then to all SearchProviders; but only AppSearchProvider responds to that training signal by passing the signal to SearchResultRanker. Change-Id: I9879bcf1932e2928720c43680ca37edf35c3a785 Bug: 871674 Change-Id: I9879bcf1932e2928720c43680ca37edf35c3a785 Reviewed-on: https://chromium-review.googlesource.com/1164863 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#583953}
-
Robert Liao authored
BUG=842291,875122 TBR=kylixrd@chromium.org,sky@chromium.org Change-Id: Ieef37d1c681f109c41ef2451ed68f341b59531b1 Reviewed-on: https://chromium-review.googlesource.com/1066803 Cr-Original-Commit-Position: refs/branch-heads/3396@{#660} Cr-Original-Branched-From: 9ef2aa86-refs/heads/master@{#550428}(cherry picked from commit 76c3965de85bcd28a57293cef653a88cbb6061af) Reviewed-on: https://chromium-review.googlesource.com/1179341Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#583952}
-
Eric Willigers authored
M65 removed the ability to manipulate a host's cookies via markup. https://chromium-review.googlesource.com/800290 https://www.chromestatus.com/feature/6170540112871424 BUG=767813 Change-Id: Ib201015bb2cf570da299630c9edaaf674068114c Reviewed-on: https://chromium-review.googlesource.com/1166264Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#583951}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I6e350b1da9a0941f58481f5784d93b6af6cd7f77 Reviewed-on: https://chromium-review.googlesource.com/1179092Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#583950}
-
Wei-Yin Chen (陳威尹) authored
The file python/plugin_pb2.py generated by newer version of protobuf cannot be consumed by older versions on some bots. Bug: 874509, 764774 Change-Id: I3045ba021263b204fbf6f0ab6af9a5da2bd96121 Reviewed-on: https://chromium-review.googlesource.com/1176823Reviewed-by:
-
Hwanseung Lee authored
When InsertedInto is called, ContainerNode object was passed as a parameter. and it is never nullptr. so it can be changed to reference instead of pointer. Bug: 874385 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If6eb4e4d0a927d4f6954bd177c16e58798292886 Reviewed-on: https://chromium-review.googlesource.com/1177530 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#583948}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/136342d950c9..9faabc5fc371 git log 136342d950c9..9faabc5fc371 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 tsepez@chromium.org Remove optionals from CXFA_TextLayout methods. Created with: gclient setdep -r src/third_party/pdfium@9faabc5fc371 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I738d3a02b49c16a9918d59e78eda9b2dae94dc15 Reviewed-on: https://chromium-review.googlesource.com/1179323Reviewed-by:
-
Nico Weber authored
Needed to be able to send try jobs for win-asan. Bug: 869973 Change-Id: I8635fb79b298596de0b4488b911f98db320b66fc Reviewed-on: https://chromium-review.googlesource.com/1179090Reviewed-by:
-
Nico Weber authored
Reland "win: write a deterministic-ish timestamp into the PE/COFF header instead of the current time" This reverts commit 2df0c83a. Reason for revert: official android should be fine with this after #583420 Original change's description: > Revert "win: write a deterministic-ish timestamp into the PE/COFF header instead of the current time" > > This reverts commit ef36dc19. > > Reason for revert: This turns out to break the official android build, which apparently was relying on a broken aspect of the build that this fixed :(. See https://crbug.com/871173. > > Original change's description: > > win: write a deterministic-ish timestamp into the PE/COFF header instead of the current time > > > > We used to set the timestamp to a hash of the binary, similar to > > https://blogs.msdn.microsoft.com/oldnewthing/20180103-00/?p=97705 > > However, that caused an appcompat warning on Windows 7 to appear, which > > interpreted the hash as a timestamp. (It's possible that https://llvm.org/PR38429 > > could help with that, but my guess it won't have an effect on Windows 7, > > which likely always believes that the the coff timestamp field always stores > > a timestamp). > > > > So currently we write the current time during linking in that field, but that's > > bad for build determinism and that in turn is bad for swarming test result cachability. > > > > build/write_build_date_header.py already creates a deterministic BUILD_DATE > > with several tradeoffs. Cachability wants this to change infrequently, but > > things like HSTS need a "real" build date and want this to change frequently. > > The compromise is: The date changes once per day in official builds, and > > once a month in regular builds. > > > > (We could use /Brepro in ldflags instead of /TIMESTAMP for unofficial builds to get > > the binary hash in the timestamp, but having the header timestamp match the BUILD_DATE > > define seems nice.) > > > > So let's use that same time as timestamp in the PE/COFF header. lld-link has a > > /TIMESTAMP: flag we can use to pass in an explicit timestamp. > > > > Since tools can't have deps, we need to compute the timestamp at gn time, > > so split write_build_date_header.py in two pieces: build/compute_build_timestamp.py > > that just prints the timestamp we want to use, and the old write_build_date_header.py, which > > now takes that timestamp and writes the header file. > > > > Call compute_build_timestamp.py at gn time so that we can pass it in ldflags, and > > pass the resultl to write_build_date_header.py which keeps running as an action > > during build time (so that we at least don't need to write a file at gn time). > > > > An additional wrinkle here is that the PE/COFF timestamp is used as one of just two > > keys per binary for uploading PE binaries to the symbol server, the other being file size. > > https://bugs.llvm.org/show_bug.cgi?id=35914#c0 has a good description of this, and > > tools/symsrc/img_fingerprint.py's GetImgFingerprint() is our implementation of it. > > But since we only upload binaries with symbols for official chrome builds to the symbol server, > > a timestamp that changes once a day should be still enough. (32-bit and 64-bit chromes > > have the same filename, and we might rarely build canary and beta and stable all on the > > same day, but them all being the same size seems highly unlikely.) > > > > Bug: 843199,804926,330260 > > Change-Id: I1d4193cc537ae0c4b2d6ac9281fad29de754dd6c > > Reviewed-on: https://chromium-review.googlesource.com/1161104 > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Reviewed-by: Hans Wennborg <hans@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580585} > > TBR=thakis@chromium.org,hans@chromium.org,dpranke@chromium.org > NOTRY=true > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 843199, 804926, 330260 > Change-Id: Ib93697a82f8a9d3fb303b763609e82e0612887cd > Reviewed-on: https://chromium-review.googlesource.com/1166203 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581485} TBR=thakis@chromium.org,hans@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843199, 804926, 330260 Change-Id: I136e405c84eba3f61a4ac96b2017a34ade0cfba6 Reviewed-on: https://chromium-review.googlesource.com/1179281 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/15b1778c2c45..ed0d273bfa51 git log 15b1778c2c45..ed0d273bfa51 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@ed0d273bfa51 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I8b10a74eabfae5d173fce36ba3a7b9aa5001a0d0 Reviewed-on: https://chromium-review.googlesource.com/1179321Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583944}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/c43b409d9688..6e5fd1672be5 git log c43b409d9688..6e5fd1672be5 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 dschuff@chromium.org Use gsutil from PATH instead of assuming its location Created with: gclient setdep -r src/native_client@6e5fd1672be5 The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mseaborn@chromium.org Change-Id: I079fd686f601d4d398ee86f1cc9d0ac1860389d5 Reviewed-on: https://chromium-review.googlesource.com/1179322Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583943}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cd8689f00427..0edb982602c6 git log cd8689f00427..0edb982602c6 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 stephana@google.com Upgrade to iOS 11 2018-08-16 mtklein@google.com Revert "avoid illegal enum values in GrGLGpu" 2018-08-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-16 allanmac@google.com Documentation update. 2018-08-16 reed@google.com can't normalize non-finites 2018-08-16 djsollen@google.com Revert "Add ability to specify different GP textures for each mesh in a draw." 2018-08-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-16 mtklein@google.com don't adapt any gray colors to 565 2018-08-16 robertphillips@google.com Adjust canFilterMaskGPU to only reject small rect blurs 2018-08-16 mtklein@google.com add p3 and ep3 configs to DM 2018-08-16 mtklein@google.com avoid illegal enum values in GrGLGpu 2018-08-16 allanmac@google.com Merge Vulkan Compute work into master. 2018-08-16 kjlubick@google.com Make verbose.log optional in upload_dm_results 2018-08-16 reed@google.com move patheffect virtuals to protected and rename 2018-08-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@0edb982602c6 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I3b6e0d49f9639d916aa1c8e428219880e4c9bde2 Reviewed-on: https://chromium-review.googlesource.com/1178943Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583942}
-
Erik Luo authored
Screenshot: https://imgur.com/a/SxeRAu8 Bug: none Change-Id: I9c11677b4a0e4bd24be5a5b43f3b9d1487458c55 Reviewed-on: https://chromium-review.googlesource.com/1173270Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#583941}
-
Alexei Filippov authored
Do not generate multiple TracingStatedInPage events. It was causing N^2 passes over CPU profiles slowing down execution and consuming lots of memory. Change-Id: Id8c3293a7cc92a2cc611746f68c92a2c9a0b63f6 Reviewed-on: https://chromium-review.googlesource.com/1179239 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583940}
-
Asanka Herath authored
Bug: 852590 Change-Id: I78e5723c29974aa43b48e1559a258c5830a7d220 Reviewed-on: https://chromium-review.googlesource.com/1178809Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#583939}
-
Joe Downing authored
This reverts commit d9fad9a3. Reason for revert: Our Windows and Mac packages started failing the signing process the day after this CL was landed. I would like to revert and see if our build succeeds tonight. Original change's description: > Reland "Generate deterministic zip file for remoting" > > This is a reland of a9dac60b > > I added an optional arg to ZipDir not to change zipped path. > > Original change's description: > > Generate deterministic zip file for remoting > > > > build_utils.ZipDir uses fixed timestamp and this makes zipped file deterministic. > > > > This is a part of effort to utilize cache of test execution on swarming. > > > > Bug: 870611 > > Change-Id: Ie370f1f5a3e08834c6280b0088f90b31d038e3be > > Reviewed-on: https://chromium-review.googlesource.com/1163349 > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581034} > > Cq-Include-Trybots: master.tryserver.chromium.win:win_chrome_official > Bug: 870611 > Change-Id: Iffa3c8e2c4fd22b60c120052612f22491d588951 > Reviewed-on: https://chromium-review.googlesource.com/1164682 > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581590} TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,thakis@chromium.org,yuweih@chromium.org,tikuta@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870611 Change-Id: I27fa4b1ae9e3c93781e2a6de508695a775a5e57a Cq-Include-Trybots: master.tryserver.chromium.win:win_chrome_official Reviewed-on: https://chromium-review.googlesource.com/1179242Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#583938}
-
Shakti Sahu authored
Bug: 872369 Change-Id: I49e1b0398c93ae42acb57228050d0b56d779b002 Reviewed-on: https://chromium-review.googlesource.com/1178635Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583937}
-
Shu Chen authored
So that the input_method_manager_impl_unittest won't depend on ash/. Bug: 756059 Change-Id: Ibba9f87a05d322489a1778658c5bc4adffd908e4 Reviewed-on: https://chromium-review.googlesource.com/1177217Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583936}
-
Mohsen Izadi authored
This is essentially a revert of crrev/c/544480 as the function is not used anymore; in preparation of moving viz::mojom::GpuHost implementation to //components/viz/host/. BUG=709332 Change-Id: Ib3b73a7250f3f838d2699a06261bb8079b93db3c Reviewed-on: https://chromium-review.googlesource.com/1178327Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583935}
-
Alexey Kozyatinskiy authored
Current state on breakpoint shared between different models is hack that should never work. R=lushnikov@chromium.org Bug: none Change-Id: I60a0e5774c47c38a0f5f251f9e9d5f2437ceb9b4 Reviewed-on: https://chromium-review.googlesource.com/1179262Reviewed-by:
-
Travis Skare authored
Bug: 869687 Change-Id: Idb36fefc8809144809b2ef049e6d607d5bf27654 Reviewed-on: https://chromium-review.googlesource.com/1165944 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583933}
-
rbpotter authored
When a select is set in JS, if the user later changed it to its previous value, onProcessSelectChange() was not being called. Fix this by using a Polymer property and observer instead of tracking the last value in the behavior. Also change to use debounce instead of setTimeout(). Bug: None Change-Id: I8f17e00900d130df68aeffd0a51ab2ee72c61aee Reviewed-on: https://chromium-review.googlesource.com/1173667 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583932}
-
Max Rebuschatis authored
Bug: 875093 Change-Id: I7c2556c1a1ee64e77dc75bbe1562c22198050f56 Reviewed-on: https://chromium-review.googlesource.com/1179073 Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#583931}
-
Anna Offenwanger authored
This happens when AR device is the only device, because we were asking for a non-immersive device, and if that didn't exist, default to the immersive device, and if that didn't exist, reporting no devices, which misses out any AR devices. Bug: 875099 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I94f91c007694685551db07cdafa61d4aaca4aabe Reviewed-on: https://chromium-review.googlesource.com/1179271 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583930}
-
Ken Rockot authored
This (probably) fixes rare flake in SharedBufferTest.CreateAndPassReadOnlyBuffer and SharedBufferBufferTest.CreateAndPassFromChildReadOnlyBuffer. Right now the child process expects to receive a "quit" message at the end, and then it fires an "ok" to acknowledge that. The parent process sends "quit" and waits to hear "ok" before terminating the test. The problem is that the child process may terminate itself before its IPC thread has had a chance to forward the outgoing "ok" message. This is normal behavior for the system, and the test should not rely on any contrary delivery guarantees. This basically just swaps the order of operations: now the child sends its "ok" and waits to read a "quit" message before terminating. The parent waits to receive an "ok" and then fires a "quit" message before waiting on the child process's death. Everything works out just fine. This re-enables the latter test on Fuchsia, and both tests on Android where they were disabled a long long time ago for unrelated and no-longer-relevant reasons (see https://crbug.com/666356). Bug: 874719,666356 Change-Id: I2977b5a00b5dd0f0653289fb550bac17cfbeb21a Reviewed-on: https://chromium-review.googlesource.com/1179201Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#583929}
-
Mao Huang authored
Original CLs: - https://codereview.chromium.org/7671034 tcmalloc doubly-linked free-lists for thread caches Added the ability for free lists to be built out of doubly-linked lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set in order for doubly-linked lists to be used. By default flag is only set in Debug builds. BUG=None TEST=None - http://codereview.chromium.org/8000001 Catch some "easy to spot" double frees in TCMalloc This will only work when the double frees happen to be close enough in time, and both happen on the same thread... ...but it should have almost zero cost to do the check. r=jschuh BUG=75921 - http://codereview.chromium.org/8242017 Enable TCMalloc doubly-linked freelist in release builds BUG=None TEST=None - http://codereview.chromium.org/10262029 Fix the logging. TCMalloc Log() does not recognize printf formatter. It also appends new line automatically. - https://chromiumcodereview.appspot.com/10944024 Mask freelist entries in tcmalloc The goal here is to prevent freelist spraying in exploits, and as a bonus to make UAF fail a bit more early and obviously. - https://chromiumcodereview.appspot.com/10957067 Ensure we mask freelist pointers properly on 32-bit Linux - https://chromiumcodereview.appspot.com/11362046 Tweak TCMalloc freelist pointer masking Previously I wasn't masking NULL freelist pointers because I didn't want to potentially leak address information. However, the branch for this is a hot point, and the leakage risk is still there for non-NULL known values. - https://chromiumcodereview.appspot.com/12619004 Speed up tcmalloc by allowing more inlining. Move some small functions in free_list.cc to free_list.h to improve the chance of intelligent inlining decisions. No functional changes. This is a performance tuning change. From the ChromeOS point of view, this is clearly a good change. I didn't try it on Windows, but I suspect it will help there too. In any case, it shouldn't hurt. Preliminary results for the BloatFile benchmark, for example, are around a 3.2% speedup (averaged across a few runs on different platforms). I am collecting more data now. BUG=111726 TEST=none BUG=724399,b:70905156 Change-Id: Ib1fb6f83bb67448eb13606f92ac428cde62c39b7 Reviewed-on: https://chromium-review.googlesource.com/1130784 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#583928}
-
Michael Giuffrida authored
When a device is "derelict" (idle at OOBE), we currently auto-launch a very old Kiosk demo app. This CL changes the idle detector to enroll into offline Demo Mode instead if Demo Mode and offline Demo Mode are enabled. More specifically, "derelict" is defined as: * Spending a total of 8 hours on the Welcome screen, followed by * Being idle on the Welcome screen for 5 minutes So a device that has progressed past the Welcome screen shouldn't be considered derelict; nor should a device that goes idle for 5 minutes but has only been in OOBE for <8 hours. We will follow this CL with actual derelict policies; until then it will fail to enroll and simply return to the Welcome screen. Bug: 869273 Test: browser_tests, and manually at OOBE with the following command line: --enable-demo-mode --enable-offline-demo-mode --derelict-idle-timeout=1 --derelict-detection-timeout=1 --oobe-timer-interval=1 (manual testing requires copying policies from /usr/share/chromeos-assets/demo_mode_resources/policy/ to /usr/share/chromeos-assets/demo_mode_resources/derelict_policy/) Change-Id: I81572e447ce5082c0bf534ab32b0c4b34f0570a0 Reviewed-on: https://chromium-review.googlesource.com/1164398 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#583927}
-
Tom Anderson authored
BUG=874793 R=pkasting Change-Id: I594189d310393c86bae4d8f4839b3ffcd43e220b Reviewed-on: https://chromium-review.googlesource.com/1179276 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#583926}
-
