GitLab

BUG=310837

Review URL: https://codereview.chromium.org/59573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233461 0039d316-1c4b-4281-b951-d872f2087c98

PDFs in particular are safer to open in the browser. This patch changes
the handling of downloads to open such files in the browser by default
instead of the system handler for the file type. A "Open with system
handler" menu item will be available so that users can still use the
system application if needed.

The determination that a file is safer to handle in the browser is done
as follows:

a) DownloadTargetDeterminer determines whether the MIME type
   corresponding to the target filename of the download is one which is
   handled by the renderer or one that is handled by a sandboxed pepper
   plugin. If so, then the file is considered safely handled by the
   browser.

b) ChromeDownloadManagerDelegate determines whether opening in the
   browser is preferred for the file type assuming the browser is able
   to handle it safely. Currently this is true for .pdf files.

Opening behavior for a download will default to opening in the browser
if both results from a) and b) are true.

BUG=148492

TEST=(1) Make sure Chrome PDF Viewer is enabled in chrome://plugins.
     (2) Download a .pdf file.
     (3) Download shelf context menu should show "Open" and "Open with
         system handler" options.
     (4) "Open" as well as clicking on the shelf icon and clicking on
         the download in chrome://downloads should all result in opening
         the file within the browser.
     (5) "Open with system handler" should open the .pdf with the
         application that's set up as the default handler for .pdf files
         on the users' machine.

Review URL: https://codereview.chromium.org/55063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314733
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/59353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233459 0039d316-1c4b-4281-b951-d872f2087c98

In the short term, this addresses the issue of messages that are too long
to fit in the dialog - the window will extend outside the dialog. In the
long run, this also prepares for further changes around the error bubble
that do require the BaseBubble machinery.

R=rsesek@chromium.org
BUG=308200

Review URL: https://codereview.chromium.org/49063012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233458 0039d316-1c4b-4281-b951-d872f2087c98

This class will be used to handle prerender requests coming from external applications.
For better tracking and also supportig referrer, a separate PrerenderManager API is
added.

BUG=297859

Review URL: https://codereview.chromium.org/45693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233457 0039d316-1c4b-4281-b951-d872f2087c98

every gaia webview should always have its own clean and isolated cookie jar. This will fix the bug that when a user signs in to chrome and then tries to add a secondary account to the profile in the same browser session, the embedded gaia webview will show a reauth page instead of a sign in page.

BUG=

Review URL: https://codereview.chromium.org/45463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233456 0039d316-1c4b-4281-b951-d872f2087c98

To RenderviewCreated, so in theory there we can
catch cases that we are missing, because we have a crash
which is trying to reparent an NPAPI plugin in metro
ash which should not be happening (should be blocked).

BUG=315565
TEST=see bug
R=jam@chromium.org

Review URL: https://codereview.chromium.org/62373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233455 0039d316-1c4b-4281-b951-d872f2087c98

This re-introduces a smaller bug fixed by r231370 until the underlying
problem in WebDataSource::replacesCurrentHistoryItem is resolved.

BUG=313572, 311271
TEST=Try to add an app in CWS when not signed in.  Go back from signin page.
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/59073010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233454 0039d316-1c4b-4281-b951-d872f2087c98

Make sure we don't call into native after the native pointer has been
destroyed.

Internal bug b/11555111

BUG=
NOTRY=true
R=kristianm@chromium.org

Review URL: https://codereview.chromium.org/61763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233453 0039d316-1c4b-4281-b951-d872f2087c98

Prevent startup infobars (e.g. when running with --no-sandbox) from interfering with tests which assume no pre-existing infobars.

BUG=315059
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/59073006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233452 0039d316-1c4b-4281-b951-d872f2087c98

Support /privet/printer/createjob. Currently does not correctly fall back for
all error conditions. Also, simplify PrivetLocalPrinterOperation by removing the
callback for current request (since it was used only by the retry system, which
was moved to PrivetURLFetcher).

BUG=

Review URL: https://codereview.chromium.org/59033010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233451 0039d316-1c4b-4281-b951-d872f2087c98

This is different from https://code.google.com/p/chromium/codesearch#chromium/src/base/process/process_metrics_mac.cc&l=216 as it gets the per-thread CPU time while process metrics gets all-thread CPU usage.

BUG=280744

Review URL: https://codereview.chromium.org/56973012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233450 0039d316-1c4b-4281-b951-d872f2087c98

UpdateTextInputType should be called before SyncSelectionIfRequired.
UpdateTextInputType may send TextInputTypeChanged to notify the focus
was changed, and SyncSelectionIfRequired may send SelectionChanged
to notify the selection was changed.  Focus change should be notified
before selection change.

BUG=310562

Review URL: https://codereview.chromium.org/33323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233449 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233447 0039d316-1c4b-4281-b951-d872f2087c98

These archive files were supported for internal test tools,
but it should be ready to drop support for them now.

BUG=271300
TEST=none
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/59713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233446 0039d316-1c4b-4281-b951-d872f2087c98

BUG=298789
R=satorux@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/59083013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233445 0039d316-1c4b-4281-b951-d872f2087c98

8f24a14 Only trim leading whitespace for #line directives.
440b476 Update OSX x64 config files.

BUG=315789
TEST=mac_x64_rel passes
NOTRY=true
R=ihf@chromium.org

Review URL: https://codereview.chromium.org/62963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233444 0039d316-1c4b-4281-b951-d872f2087c98

around directly use window_ and GetWidget() would simply return window_.

BUG=None

Review URL: https://codereview.chromium.org/58883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233443 0039d316-1c4b-4281-b951-d872f2087c98

The "implemented_in" key format like this:
  [implemented_in="path/to/implemented_file"]
  namespace Foo {...};

BUG=313579
TEST=pass idl_schema_test

Review URL: https://codereview.chromium.org/56543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314181
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/56533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233441 0039d316-1c4b-4281-b951-d872f2087c98

Renamed the method and variable name in derived class so that the method in based class will not be overridden. 

BUG=270888

Review URL: https://codereview.chromium.org/51113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233440 0039d316-1c4b-4281-b951-d872f2087c98

This patch introduces use of WebServiceWorkerError as a means to propagate an
error from the browser to the renderer, and further reflect this error via
WebCallbacks into Blink

BUG=285976
R=jam@chromium.org, michaeln@chromium.org, tsepez@chromium.org
TBR=abarth

Review URL: https://codereview.chromium.org/26442004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233438 0039d316-1c4b-4281-b951-d872f2087c98

This was triggered by the change to restart in desktop mode when running
with the software compositor. But in general, it's possible for a channel
error to happen before SetTargetSurface which sets the host_. Since the
CHECK isn't accomplishing too much, just remove it.

R=cpu@chromium.org, sky@chromium.org
BUG=315057

Review URL: https://codereview.chromium.org/62853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233437 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297210
TEST=included
NOTRY=True

Review URL: https://codereview.chromium.org/58623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233436 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297671

Review URL: https://codereview.chromium.org/55633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233435 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267510

Review URL: https://codereview.chromium.org/54273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233434 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an issue with the profile icon not showing up if the user
has pinned the default chrome shortcut to the taskbar.

Using the runtime badging on top of the taskbar icon's badge causes the badge to look slightly darker around the edges at runtime.

BUG=313800

Review URL: https://codereview.chromium.org/54053008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233433 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314801

Review URL: https://codereview.chromium.org/58513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233432 0039d316-1c4b-4281-b951-d872f2087c98

The touchscreen crashes because of BTN_TOUCH events that hit NOTREACHED.

The touchpad crashes for similar reasons. We don't have touchpad support
here at all, so ignore these devices.

NOTRY=true

Review URL: https://codereview.chromium.org/58473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233431 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314842
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/58683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233430 0039d316-1c4b-4281-b951-d872f2087c98

BUG=309121
NOTRY=true

Review URL: https://codereview.chromium.org/57833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233429 0039d316-1c4b-4281-b951-d872f2087c98

Verify that after parsing 1xx response with 
ReadResponseHeaders, HttpResponseInfo contains the parsed 
headers and the response buffer contains the response that 
follows.

Review URL: https://codereview.chromium.org/45823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233428 0039d316-1c4b-4281-b951-d872f2087c98

rather than last, so that they can be parallelised and have the most effect.
Implement a few of the more trivial Cron methods, including moving most
FeaturesBundle methods to return Futures.

BUG=305280
R=jyasskin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/63203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233427 0039d316-1c4b-4281-b951-d872f2087c98

safe_browsing_service.cc.  Hopefully this will fix the "pure virtual method
called" errors seen in various ExtensionService tests that use safe browsing;
both those reverted as part of bug 233290, and the ones that are still live.

BUG=233290
R=jyasskin@chromium.org
TBR=shess@chromium.org

Review URL: https://codereview.chromium.org/60833007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233426 0039d316-1c4b-4281-b951-d872f2087c98

Ifdefs weren't quite right.

BUG=315195
TEST=run chrome (aura) in metro mode, touch the tabstrip and move tabs
     around, make sure tabs enter stacked mode.

R=ben@chromium.org

Review URL: https://codereview.chromium.org/60353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233425 0039d316-1c4b-4281-b951-d872f2087c98

Move mergesession from SigninManager to reconcilor.
Implement ListAccounts.
Start implementing reconcile action, but still a noop for now.

This CL depends on https://codereview.chromium.org/57103002/

Alan: here is an implementation of the ListAccounts.  I also added lots of
DVLOG() to the code.  Let me know if you'd rather I took those out and put
in a separate CL.

Hui: please review.  This CL adds more functionality to the reconcilor but
its still not complete.  However, it enables AC behind the flag for merge
session so you don't need to do that manually.

BUG=305249

Review URL: https://codereview.chromium.org/57363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233424 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314799
NOTRY=true

Review URL: https://codereview.chromium.org/55293006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233423 0039d316-1c4b-4281-b951-d872f2087c98

In order to avoid an ugly flash of white pixels when a new app window is
shown, this patch defers showing a window until a non-empty backing
store update has completed.

The feature is behind the "enable-apps-show-on-first-paint" flag.

BUG=225843, 254152

Review URL: https://codereview.chromium.org/55293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=308191

Review URL: https://codereview.chromium.org/27563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233421 0039d316-1c4b-4281-b951-d872f2087c98

BUG=307107

Review URL: https://codereview.chromium.org/54053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233420 0039d316-1c4b-4281-b951-d872f2087c98