- 27 Feb, 2019 40 commits
-
-
Fernando Serboncini authored
We may have pending mojo messages after GC, so we want to drop the dispatcher as soon as possible. Bug: 929757,913964 Change-Id: I5789bcbb55aada4a74c67a28758f07686f8911c0 Reviewed-on: https://chromium-review.googlesource.com/c/1489175Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Auto-Submit: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635833}
-
Stefan Zager authored
It makes sense to have someone from the rendering team in OWNERS. I'm nominating myself because my code review load is not too heavy, I'm reasonably familiar with the code, and I anticipate working more in this area going forward. R=dcheng,haraken,eae,chrishtr Change-Id: Id3141c2aa100a26afaef1dd07980fbb63dea7945 Reviewed-on: https://chromium-review.googlesource.com/c/1490632Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#635832}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a502bde5ced6..ee85330e0ea1 git log a502bde5ced6..ee85330e0ea1 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 rsavitski@google.com shared ring fuzzer: clear spinlock field to not make fuzzer's read spin indefinitely. Created with: gclient setdep -r src/third_party/perfetto@ee85330e0ea1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I942ffa9f05af2a133dbf3aa33166391d570e67fd Reviewed-on: https://chromium-review.googlesource.com/c/1490674Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635831}
-
kylechar authored
Post[Delayed]TaskWithTraits() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?TaskWithTraits)\((?:\n\s*)?FROM_HERE,\n?\s*(\{.*?\n?.*?\}),(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=seantopping@chromium.org Bug: 714018 Change-Id: I5d71bfb093f9358dace00438d21cf2d861451399 Reviewed-on: https://chromium-review.googlesource.com/c/1486152 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:Sean Topping <seantopping@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#635830}
-
Piotr Pawliczek authored
A list of enterpise printers is not ready immediately after creation of CupsPrintersManager. It caused a problem for testing procedure since from the level of autotest_private_api we do not know if the final list is ready or there are still some ongoing calculations. A new method called OnEnterprisePrintersInitialized() was added to the observer of CupsPrintersManager to solve this issue. Also whole code related to enterprise printers were refactored, large part of functionality was moved from SyncedPrintersManager to new class EnterprisePrintersProvider. Classes ExternalPrintersPrefBridge and DeviceExternalPrintersSettingsBridge have been merged into one class called CalculatorsPoliciesBinder. BUG=chromium:816996 TEST=Tested on nautilus with the use of CL:1451591 Change-Id: I50745f18beacab213216e5f367db0d023190e9e4 Reviewed-on: https://chromium-review.googlesource.com/c/1220547 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#635829}
-
John Rummell authored
When unable to pre-provision origin IDs, it may be due to the device not being able to connect to a provisioning server. Updating the code to watch for network events. When connected to a network, try again to pre-provision origin IDs. BUG=917527 TEST=new unit_tests pass Change-Id: Ia41bbedf543556e59ecd03bef51d989c6c0f7210 Reviewed-on: https://chromium-review.googlesource.com/c/1475005 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#635828}
-
Paul Dyson authored
* Add more metrics to UKM event AppListAppLaunch. * Add a new UKM metric AppListAppClickData to send the accumulated click data for an app. On an app launch click, an AppListAppClickData event is sent for the app clicked on and for five other apps chosen at random. Also makes user_activity_ukm_logger_helpers a public_dep so it can be used here. Bug: 899123 Change-Id: Ie1d6f17673b9548ef6823d05a362fea8992126b9 Reviewed-on: https://chromium-review.googlesource.com/c/1460750Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#635827}
-
rbpotter authored
Bug: 935625 Change-Id: Ib2e8c1e934f213916b90354686ab42a2da3a078c Reviewed-on: https://chromium-review.googlesource.com/c/1487521Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#635826}
-
git config --global authored
There are still purple builds for fyi/ios12-sdk-simulators https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios12-sdk-simulator Bug: 933450 Change-Id: If1bdc09f9a8c4dc0d5665eeb1e40ecd927814980 Reviewed-on: https://chromium-review.googlesource.com/c/1490393Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#635825}
-
Ryo Hashimoto authored
Exo window uses custom event targter so we need to explicitly set the default targeter to correctly handle input events. Bug: 925769 Test: manually Change-Id: Ia596bd4524d2a3e8dae86e8be34821822edf9626 Reviewed-on: https://chromium-review.googlesource.com/c/1488485Reviewed-by:
Mitsuru Oshima (Slow) <oshima@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#635824}
-
Mei Liang authored
This patch adds a method in FeatureUtilities to check whether the tab group feature is enabled and available for use. Bug: 934557 Change-Id: I06677c81b772d905e5a5689536de2c1e362aa08c Reviewed-on: https://chromium-review.googlesource.com/c/1489973 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635823}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5da3a7e01dc2..f6100576bcc4 git log 5da3a7e01dc2..f6100576bcc4 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 nathanrogers@google.com Include category and name as part of flow ids 2019-02-26 benjhayden@chromium.org Add ChartBase.reducers.boldLine. 2019-02-26 rmhasan@google.com Changes the number of isolated tests sent to a job pool in Typ 2019-02-26 simonhatch@chromium.org Dashboard - Choose vr_perf_tests target for chromevr tests. 2019-02-26 benjhayden@chromium.org Add generateColors() for spa Created with: gclient setdep -r src/third_party/catapult@f6100576bcc4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193,chromium:935814,chromium:935615,chromium:918193 TBR=sullivan@chromium.org Change-Id: Id03ee99f80eca3aab1790f582727009f22f3c059 Reviewed-on: https://chromium-review.googlesource.com/c/1490673Reviewed-by:
-
Yuly Novikov authored
TBR=jschuh Bug: 926235, 936194 Change-Id: I28a335b061cd1bba070e0b5c8197b82a2cf834e6 Reviewed-on: https://chromium-review.googlesource.com/c/1490510Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#635821}
-
Ben Smith authored
See intent to ship blink-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tD6np-OG2PU Bug: chromium:754910 Change-Id: Ic46c0404bd9b783845fbaa1e412d8b9332f65a91 Reviewed-on: https://chromium-review.googlesource.com/c/1487808 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#635820}
-
Eric Stevenson authored
This reverts commit 9b5e9e3c. Reason for revert: https://crbug.com/935964 Original change's description: > Trichrome: Remove webview deps from trichrome_chrome_apk. > > These were pulled in because trichrome uses monochrome > templates. Since Trichrome still shares the same native library > logic with monochrome it makes sense to continue using monochrome > templates, but using a variable |is_trichrome| to differentiate > trichrome from monochrome. > > This CL removes Java deps, some Java resource deps, and webview's > locale pak files from TrichromeChrome.apk. > > Validated CL changes by: > * Building the 3 trichrome apks and their downstream variants > * Installing/launching TrichromeChrome.apk > * Manually inspecting the .build_config and "unzip -l" changes > > | old (c)| new (c)| diff (c)| > total| 24.8 MiB| 23.6 MiB| -1.2 MiB| > dex| 6.8 MiB| 6.4 MiB| -392.1 KiB| > arsc| 4.9 MiB| 4.8 MiB| -101.8 KiB| > xml| 344.9 KiB| 344.9 KiB| -6 B| > res| 912.3 KiB| 908.2 KiB| -4.1 KiB| > native| 254.6 KiB| 254.6 KiB| +0 B| > asset| 11.1 MiB| 10.4 MiB| -698.0 KiB| > misc| 145.3 KiB| 142.4 KiB| -2.9 KiB| > > Bug: 932253 > Change-Id: Iedb427aa5ec05ad3bc905ac61b23f615349d579e > Reviewed-on: https://chromium-review.googlesource.com/c/1481019 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634385} TBR=torne@chromium.org,agrieve@chromium.org,estevenson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 932253, 935964 Change-Id: Ib96734d9bba049b72735f0fffd0ac31d4aea914b Reviewed-on: https://chromium-review.googlesource.com/c/1490493Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#635819}
-
Ryo Hashimoto authored
View hierarchy takes the ownership of the remote view host. Replace unique_ptr with raw pointer to avoid double-free. BUG=925769 TEST=manually Change-Id: Ic34a87081782d10e4ad42ecfaa9fb6127abf52cb Reviewed-on: https://chromium-review.googlesource.com/c/1488403Reviewed-by:
-
David Trainor authored
Show a toast to the user when an inline update starts downloading. This currently has the side effect of reshowing whenever Chrome is started if we're in the downloading state. Bug: 934356 Change-Id: Ib83ac5cab8a1d66e234b5b55c0af76adbc92f72d Reviewed-on: https://chromium-review.googlesource.com/c/1483706 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#635817}
-
Yuwei Huang authored
This CL implements a helper class that adapts gRPC's async unary call paradigm (i.e. the completion queue) into Chromium's callback-based paradigm. Bug: 927962 Change-Id: I15c58748a0d024dc5f6953b0312e629fcf8c24b5 Reviewed-on: https://chromium-review.googlesource.com/c/1484736 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#635816}
-
Jenny Zhang authored
Bug: 933906 Change-Id: Ic8a957750e5ce4747eb7b22762c0fc7917240f6c Reviewed-on: https://chromium-review.googlesource.com/c/1487201Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#635815}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/54c4772e855c..7f6f891204d0 git log 54c4772e855c..7f6f891204d0 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 sugoi@google.com VS build fix Created with: gclient setdep -r src/third_party/swiftshader@7f6f891204d0 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ibdf8323240c404fa8a004054944b914a18a20e69 Reviewed-on: https://chromium-review.googlesource.com/c/1490374Reviewed-by:
-
John Delaney authored
We should determine if an ad frame size intervention would disproportionately affect video ads over other ad creatives. Measure whether ad iframes that triggered the intervention had media play in the frame at any point in it's lifetime. This will not measure frames that load video but never play. The OnMediaStartedPlaying method must be updated to propagate the RFH it occurred in to observers so we can attribute it to the frame. The is_in_main_frame flag is currently unused and will be removed. Bug: 878393 Change-Id: Ie2be74206b83da43d9e73af93b72a5092bd7688a Reviewed-on: https://chromium-review.googlesource.com/c/1481619 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#635813}
-
Xing Liu authored
This CL adds a proto to serialize dynamically generated data to schedule a notification and display later. Bug: 930968 Change-Id: Iadd7ca8f820097db2dee47d664ddbf0ca4528cbf Reviewed-on: https://chromium-review.googlesource.com/c/1468341 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#635812}
-
chrome://safe-browsingDaniel Rubery authored
Changing tabs on chrome://safe-browsing updates the hash, and navigating to chrome://safe-browsing with a hash will select that hash directly. Bug: 930207 Change-Id: If19a53b1432ecf90df2b54e70d747d3f018082dc Reviewed-on: https://chromium-review.googlesource.com/c/1490218 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635811}
-
John Abd-El-Malek authored
Bug: 934983 Change-Id: Ib74d45089dc9e45ea5395be2e2ce6df43c42fccb Reviewed-on: https://chromium-review.googlesource.com/c/1490220Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#635810}
-
Jay Harris authored
This CL also introduces a CalculatePreferredSize function, as the FlexLayout has a DCHECK ensuring that GetPreferredSize is at least as big as GetMinimumSize (which previously, was not true when the title and origin of the current page was less than 20 characters). Bug: 934782 Change-Id: I6e61b43c1486eab50fa7f237a041fbd92c7bb6fb Reviewed-on: https://chromium-review.googlesource.com/c/1485692Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#635809}
-
Xianzhu Wang authored
This prevents unnecessary raster scale change during a composited transform animation. Bug: 933903 Change-Id: I2901f80d97b1f15807e19c3797a9817af1033621 Reviewed-on: https://chromium-review.googlesource.com/c/1482330 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#635808}
-
Erik Chen authored
This reverts commit 1986f3a9. Reason for revert: This CL is suspected to cause a very large memory leak. See https://bugs.chromium.org/p/chromium/issues/detail?id=935709#c23 for more details. Original change's description: > Improve handling of Skia images by gfx::Image > > Removed unnecessary indirection and allocation via std::unique_ptr for > storage of value types in cached image data (both gfx::Size and > gfx::ImageSkia are value types). > > Added unit tests checking assumptions and ensuring that we will not > break said assumptions about how image data is cached/image data > duplication is prevented in the future. > > Change-Id: I59a70aa1ccb2e00fbc1a69ad92e48374643b6d20 > Reviewed-on: https://chromium-review.googlesource.com/c/1471514 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632315} TBR=rsesek@chromium.org,dfried@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I1b13d4fa6c00c84f8788782e6fc6b70bea060974 Reviewed-on: https://chromium-review.googlesource.com/c/1490431Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Joel Einbinder authored
Without shadow dom, the shadow-TextPrompt, the _proxyElement now contains a <style> tag Bug: 934813 Change-Id: I5e3c9f33b94bae244587e549d6869055f08ee833 Reviewed-on: https://chromium-review.googlesource.com/c/1490193 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#635806}
-
Leon Han authored
If a navigation commit IPC carries an invalid service worker provider id, it means this navigation is supposed to not involve with Service Workers at all for some security reasons. In such case we do not need to initiate a SW provider creation in the renderer process, which is believed to be just a wasteful operation. After this CL, the only one code path making renderer-initiated SW provider creation is for Shared Workers in the non-S13SW case. BUG=931092 Change-Id: I8127c1d0a5f80aa0b47bc036812b15e9f3f16f60 Reviewed-on: https://chromium-review.googlesource.com/c/1480639Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#635805}
-
Robert Sesek authored
The two types of Mach port rights, send and receive, require distinct handling. This CL deprecates the TYPE_MACH_PORT name, since it does not specify the underlying right's type. Bug: 932175 Change-Id: I4d49eaba1566d8742b7e8235cacc54e0a0075202 Reviewed-on: https://chromium-review.googlesource.com/c/1489176 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib4b1355f3e5cffea831f5f14f788999fc6d28c58 Reviewed-on: https://chromium-review.googlesource.com/c/1490376Reviewed-by:
-
Daniel Rubery authored
The request_ap_verdicts field was set after the serialization of the the ClientDownload request, so it was not send to the backend. I also add this field to the chrome://safe-browsing page, for testing. Change-Id: I578aed3aa2c9dba791b8689ac06a0acb2b3b7eea Reviewed-on: https://chromium-review.googlesource.com/c/1490498 Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
This allows the string to be shared between Files app and ARC++. Bug: b:123362537 Change-Id: I9aedc65e4799ba1363e1c6981459ab25a08ce303 Reviewed-on: https://chromium-review.googlesource.com/c/1476887Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#635801}
-
Ian Kilpatrick authored
I noticed inside the stack-sampled metrics, we were burning a bunch of time hopping through these calls. Bug: 635619 Change-Id: Ic7788a666aafdf0630fd441e2762e7b7d4302879 Reviewed-on: https://chromium-review.googlesource.com/c/1489303Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#635800}
-
Ce Chen authored
Result from on device head will be set as [AutocompleteProviderType::TYPE_ON_DEVICE_HEAD|AutocompleteMatchType::SEARCH_SUGGEST|subtype_identifier=271]. Bug: 925072 Change-Id: Iac72e0df2ab03bb331efab68b71a2f9e26f81eee Reviewed-on: https://chromium-review.googlesource.com/c/1484502 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33105789ee1e..f9240dad68dd Created with: gclient setdep -r src-internal@f9240dad68dd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:928475,chromium:894099,chromium:888864,chromium:883361,chromium:845990 TBR=mmoss@chromium.org Change-Id: I9541beee4dbe62f455559e1e9830c1fea99041ae Reviewed-on: https://chromium-review.googlesource.com/c/1490373Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635798}
-
Caitlin Fischer authored
Change-Id: I4d0d15aef5a0596cf9da45609a00645fbe1168bd Reviewed-on: https://chromium-review.googlesource.com/c/1482555Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#635797}
-
Danyao Wang authored
Spec: https://w3c.github.io/payment-request/#merchantvalidationevent-interface Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/fXwI0c6m0lE/cEZzhSSYAQAJ This CL adds the MerchantValidationEvent interface behind a new runtime flag. The .complete() method will be implemented in a separate CL. IsValidMethodFormat() is extracted from PaymentRequests to PaymentValidators to allow code reuse. Bug: 867904 Change-Id: I7b504e365da1198b14c78b1f4e58c4c9f052df8f Reviewed-on: https://chromium-review.googlesource.com/c/1480636 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635796}
-
Ryan Hansberry authored
This is a necessary change now that Polymer 2 is enabled. Previously, Multidevice and Smart Lock pages were being informed of an authToken change by their child element passwordPrompt, but that is no longer bubbling up to the parent. Now, explicitly bind to the authToken of passwordPrompt as a property, and use it when the dialog close event is fired. As a consequence of this, the authTokenChanged() callbacks in both parents is unnecessary and has been removed. Bug: 934987 Change-Id: Ie0d624dde09f895a7076122aaed9eb224a629a1a Reviewed-on: https://chromium-review.googlesource.com/c/1484495Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#635795}
-
Xiaocheng Hu authored
[Sheriff] Disable org.chromium.chrome.browser.fullscreen.FullscreenManagerTest#testManualFullscreenDisabledForChromePages Bug: 936252 NoTry: True Tbr: skyostil@chromium.org Change-Id: I4748aff78894faf2472a4fc958aad3fb0bcb9d5f Reviewed-on: https://chromium-review.googlesource.com/c/1490896Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635794}
-
