GitLab

Add FileManageBrowserTestBase private helper routines: IsGuestModeTest
and IsIncognitoModeTest to return true when the test extension browser
test has that GetGuestMode(). Use the helpers everywhere.

The "isInGuestMode" command actually wants to know if the test runs in
guest or incognito mode, or not. Write that out explicitly in its code
and add LOG(INFO) and ASSERT_EQ() for even more explanation.

Move "isInGuestMode" command so it's the first, move "getTestCaseName"
command so it's third, to match the call order the test extensions use
to call them: isInGuestMode, getRootPaths, getTestCaseName [1].

Minor change to getRootPaths: call the variable downloads_root.

[1] The test extensions call in this order always and once these three
are done, the test extensions start running the test case. Another way
to think about it is: these three commands are preliminary set-up that
every Files.app browser test case requires. All remaining commands are
specific to the current test case.

Bug: 833834
Change-Id: Ida01b88e745df6bf4b760aa421d36c5d8e872ecd
Reviewed-on: https://chromium-review.googlesource.com/1043672Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556362}

Bug: 833834
Change-Id: I4eb15bf48c996adad73f72597718b82af1069654
Reviewed-on: https://chromium-review.googlesource.com/1045948
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556361}

R=rch@chromium.org

Change-Id: Icd0d30ca1665e843d13c9d3521d3038a08a8488b
Reviewed-on: https://chromium-review.googlesource.com/1043007
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556360}

Does the connection setup in a specific sequence that historically
triggered a deadlock (https://crbug.com/736725). The test simply
verifies this specific sequence completes without errors.

Verified it fails on the deadlock by running the test on the parent commit
(2485344d)of the original bug fix.

BUG=chromium:818584

Change-Id: I3245de0b8f824a83f26a310d8f12bba45aea0958
Reviewed-on: https://chromium-review.googlesource.com/1044196
Commit-Queue: Kristoffer Erlandsson <kerl@google.com>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556359}

- Disable virtual/video-surface-layer/ and
  virtual/threaded/fast/animationworklet/ because most of the tests
  under the (virtual) directories fail, to save our time to update
  expectations for individual tests when new tests are added.
- Rebaseline paint/invalidation/table/replace-col.html
- Add 3 failures.

TBR=trchen@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8740d4451fb77ba4b8c6df1c99cf9aaa72d09603
Reviewed-on: https://chromium-review.googlesource.com/1046149
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556358}

TBR=mmoroz@chromium.org

Bug: 784464, 836663
Change-Id: I09c05445b1a86de19ef41d40e7e6fa72ce361390
Reviewed-on: https://chromium-review.googlesource.com/1046151Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556357}

https://skia.googlesource.com/skia.git/+log/32d8f883bd4e..95e2b91d76d6

$ git log 32d8f883b..95e2b91d7 --date=short --no-merges --format='%ad %ae %s'
2018-05-06 egdaniel Revert "Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice"
2018-05-06 egdaniel Revert "Restore old SkBitmapDeviceFilteredSurfaceProps"

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: Ie12bb6049116e432d57c9e7fa3b3d21e8ddcbd1a
Reviewed-on: https://chromium-review.googlesource.com/1046147Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556356}

Select menu dropdowns use LocalFrameView::ContentsToViewport to
determine what part of the menu intersects with the window viewport.
This doesn't work in OOPIFs because LFV::ContentsToRootFrame only
converts coordinates into the local frame root's coordinates, not the
main frame. The consequence is that menus in large iframes that have
been scrolled into view will falsely report to be out of view.

This patch changes the intersection calculation to use
LayoutView::MapToVisualRectInAncestorSpace(), which determines the
viewport intersection while accounting for OOPIF containers.

Bug: 837639
Change-Id: If265e24ad4cbee967fdb97ae85002a81e75033a7
Reviewed-on: https://chromium-review.googlesource.com/1036232Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556355}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I1884f38a68ea2d32c1c874d9896416455e3ba9ef
Reviewed-on: https://chromium-review.googlesource.com/1046148
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556354}

The tests are not expected to timeout anymore with TSC clock

Bug: 731302
Change-Id: I747383b85fec029b9edfe375ed436b1586a2a544
Reviewed-on: https://chromium-review.googlesource.com/1045620Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556353}

BUG=762641
TBR=alemate@chromium.org

Change-Id: I89364cc511cbf1ab12f638d0ab31611ea34378f8
Reviewed-on: https://chromium-review.googlesource.com/1046131Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556352}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I07051aa0107be16f466b94841c1f056b6ebfc685
Reviewed-on: https://chromium-review.googlesource.com/1046113
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556351}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/70d24bb2..0cb7b82e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I73b2d7e224987fd3505cf6f3e79154be9e2b365f
Reviewed-on: https://chromium-review.googlesource.com/1045993Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556350}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: Icd09aea13117af1c4bf03846d3a7d61556bafffe
Reviewed-on: https://chromium-review.googlesource.com/1046129Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556349}

Also write output of llvm-cov export program on the disk (needed for the bot).

Plus some refactoring for logs from target programs:
- redirect stderr from targets into stdout to be written into a .log
- write logs into its own subdir for better output structure

Not output folder structure look as follows:

$ ls -l out/zreport15/
total 8
drwxr-x--- 5 mmoroz primarygroup 4096 May  4 10:53 linux
-rw-r--r-- 1 mmoroz primarygroup 2519 May  4 10:53 style.css

$ ls -l out/zreport15/linux/
total 48
drwxr-xr-x 2 mmoroz primarygroup 4096 May  4 10:53 components
-rw-r--r-- 1 mmoroz primarygroup 1627 May  4 10:53 component_view_index.html
-rw-r--r-- 1 mmoroz primarygroup 4672 May  4 10:53 coverage.profdata
-rw-r--r-- 1 mmoroz primarygroup  241 May  4 10:53 directory_view_index.html
-rw-r--r-- 1 mmoroz primarygroup 7416 May  4 10:53 file_view_index.html
-rw-r--r-- 1 mmoroz primarygroup  200 May  4 10:53 index.html
drwxr-xr-x 2 mmoroz primarygroup 4096 May  4 10:53 logs
-rw-r--r-- 1 mmoroz primarygroup 7483 May  4 10:53 summary.json
drwxr-x--- 3 mmoroz primarygroup 4096 May  4 10:53 usr


Bug: 784464, 836663
Change-Id: I3283f16b62cfeb267bb2b3092fa469d5ff39ef14
Reviewed-on: https://chromium-review.googlesource.com/1044652
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556348}

Using wpt-import in Chromium 9be6ec5e.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16966

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I384b7df6d0e870e2fdfcaef877cc59f4cbfa93ea
Reviewed-on: https://chromium-review.googlesource.com/1045803
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556347}

We already DCHECK that |ptr_| is valid in GetWeakPtr(), but this extra
check ensures we catch mis-use earlier.

Change-Id: Id62dc3cbe6c4e33f08bb1d5c5c2e304aa01c53a8
Reviewed-on: https://chromium-review.googlesource.com/1042485Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556346}

Using wpt-import in Chromium 690f3329.
With Chromium commits locally applied on WPT:
ca0aa292 "Support groupId constrainable properties in MediaDevices.getUserMedia()"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16965

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/IndexedDB

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I00f8564beca7667e679bbf7124c8ef9b5205e289
Reviewed-on: https://chromium-review.googlesource.com/1045987
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556345}

This reverts commit 707f4d3e.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 556340 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzcwN2Y0ZDNlNzgxZGIwZjUxZjQ5MzBjNTAxOTRkMmNkMWU3YWUyZDYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5528

Sample Failed Step: interactive_ui_tests

Original change's description:
> Fully integrate the Select-to-Speak tray button with the extension.
> 
> This change lets taps to the tray button control changes in the Select-to-Speak
> extension page. It also adds integration tests.
> 
> A large part of this change is adding a mojom test API to allow the ChromeOS
> integration test to find and tap the Select-to-Speak button in Ash.
> 
> Bug: 753018
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I1593d4f8ac70c9bd321af843d6a71de6381f65f6
> Reviewed-on: https://chromium-review.googlesource.com/1041210
> Commit-Queue: Katie Dektar <katie@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556340}

Change-Id: I7a62f01228147f07a681275916533cf53d339332
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 753018
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1046026
Cr-Commit-Position: refs/heads/master@{#556344}

Based on CL 1033824

This patch adds three tests and test the following:
- Filtered block establishes a container for fixed and abs pos.
- Filtered inline establishes a container for fixed and abs pos.
- Filtered <html> does not establish a container for fixed pos.

Bug: 795549
Tbr: vmpstr@chromium.org
Change-Id: I3fa13cc7f478503583a191bfb434cdab860862ef
Reviewed-on: https://chromium-review.googlesource.com/1045727
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556343}

RecyclableCompositorMac owns a ui::Compositor, but the surface id
generation was owned by BrowserCompositorMac.

A RecyclableCompositorMac will be recycled by many different
BrowserCompositorMac, and as a result, it may have a non-monotonic-
increasing surface id.

Scope the surface id information to RecyclableCompositorMac, and
throw some of the related logic into a helper function.

Bug: 772576, 817827
Change-Id: Ic4299afa5670c96b51260917a3fafb2b692b3465
Reviewed-on: https://chromium-review.googlesource.com/1046045Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556342}

This is a simple test utility that will be used in upcoming tests to act
as a final consumer of audio in loopback unit tests. It records all the
audio samples given to it, and then provides useful utility methods to
analyze/interpret the signal.

Bug: 824019
Change-Id: I0ef3476b2e8004c77265a85d51f5dd69a3b309b3
Reviewed-on: https://chromium-review.googlesource.com/1041653Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556341}

This change lets taps to the tray button control changes in the Select-to-Speak
extension page. It also adds integration tests.

A large part of this change is adding a mojom test API to allow the ChromeOS
integration test to find and tap the Select-to-Speak button in Ash.

Bug: 753018
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1593d4f8ac70c9bd321af843d6a71de6381f65f6
Reviewed-on: https://chromium-review.googlesource.com/1041210
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556340}

Using wpt-import in Chromium 6f3313d8.
With Chromium commits locally applied on WPT:
ca0aa292 "Support groupId constrainable properties in MediaDevices.getUserMedia()"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16955

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I667e88e5e25093acc6314240ee38bbf574992c48
Reviewed-on: https://chromium-review.googlesource.com/1045802
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556339}

This makes it so that if an app requests the WindowService it's
launched in Ash. This is only enabled if --mash and --mus is not
specified.

BUG=837686
TEST=none

Change-Id: Ic01879e0aff8828b17c0652bd74078daba628d40
Reviewed-on: https://chromium-review.googlesource.com/1045248
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556338}

Following bot results are included.
5157 5161 5163 5181 5182 5187 5195 5200 5206 5207 5208 5209

108 lines were removed and 21 lines were deflaked by consecutive
results since 5129.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I7fac4144cc97aaec933727bf2994edd7b0b37e81
Reviewed-on: https://chromium-review.googlesource.com/1042665
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556337}

LocalSurfaceId is plumbed to WebContents for auto-resize but never used.

This CL deletes that plumbing.

Bug: 672962
Change-Id: I851c17d856fc72405e5893ddbe80e36bc068af49
TBR: piman@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1045911Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556336}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Idbbf9c9004ecaa158de95a9d496b84d1070dfd50
Reviewed-on: https://chromium-review.googlesource.com/1045914Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556335}

The DelayBuffer records and maintains a recent history of an audio
signal, then allows read-back of any part of the recording. While this
looks a lot like "yet another FIFO," it is not because the reads will
typically be somewhere in the middle, not the end, of the circular
queue.

This will be used in a later change to support loopback functionality in
the Audio Service.

Bug: 824019
Change-Id: I5321724ac3a55929318d411a08d33344a39c2272
Reviewed-on: https://chromium-review.googlesource.com/1029617Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556334}

This CL is a refactor with no intended behavior change.

Bug: 832879
Change-Id: Idd49d49da49f09e8fb72c1143fbb27c485eb7a14
Reviewed-on: https://chromium-review.googlesource.com/1045228
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556333}

There exists plumbing to send gfx::CALayerParams (the parameters for
displaying content on macOS) from the viz::Display to the browser
process via that viz::DisplayClient interface.

In GPU compositing, this comes in via viz::Display's implementation of
viz::OutputSurfaceClient::DidReceiveCALayerParams.

Make viz::Display also implement a new interface,
viz::SoftwareOutputDeviceClient, and add a method to this interface,
SoftwareDeviceUpdatedCALayerParams, which the SoftwareOutputDeviceMac
calls when a frame is drawn. Route this to the same paths that the
GPU compositing path takes to send it to the browser process.

Delete the now-unneeded gfx::AcceleratedWidgetMac interfaces in
SoftwareOutputDeviceMac.

Bug: 730660, 772576
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I03a21c5b1c1e5333aec94b5a0d1e88811fbbaf34
Reviewed-on: https://chromium-review.googlesource.com/1042312Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556332}

This CL is a refactor with no intended behavior change.

Bug: 832879
Change-Id: I18a970240c9abcf38879c8b4d15aae848d2dd893
TBR: avi@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1040471Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556331}

Using wpt-import in Chromium cdd10462.
With Chromium commits locally applied on WPT:
ca0aa292 "Support groupId constrainable properties in MediaDevices.getUserMedia()"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16954

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I9fbcd610b69ee5b2f6bbdaec29d2f9ba66284e46
Reviewed-on: https://chromium-review.googlesource.com/1045985
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556330}

Kill the lowest ranked connection when there are no more service slots
when trying to allocate a new connection.

Remove the hack solution that passed down the number of service slots
to RenderProcessHost::GetMaxRendererProcessCount.
Remove releaseAllModerateBindings when the last service is allocated.
Add a test in content that verifies intentional kill works.

Refactored ChildConnectionAllocator to make the queuing of requests
explicit. Then add a callback when Allocator runs out of slots for
allocation which content layer handles by killing the lowest ranked
connection. This implementation ensures there is only one connection
being killed waiting to be noticed.

Change-Id: I5f670dfcf6ce645ab2681ec97d095eca98b2b5a2
Reviewed-on: https://chromium-review.googlesource.com/1002193
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556329}

Original change's description:
> Fix hosted app crash when started in tablet mode
> 
> The code was written with the expectation that
> HostedAppButtonContainer::StartTitlebarAnimation()
> is called before
> HostedAppButtonContainer::OnImmersiveRevealStarted().
> 
> This is not the case when in tablet mode and results
> in crashes.
> 
> This CL updates HostedAppButtonContainer to allow these
> methods to be called in either order.
> 
> Bug: 836482
> Change-Id: I658578ca79599e21566fffd3986a6dc852cb6489
> Reviewed-on: https://chromium-review.googlesource.com/1029882
> Commit-Queue: Alan Cutter <alancutter@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556327}

TBR=jamescook@chromium.org,sky@chromium.org,alancutter@chromium.org

Change-Id: I8adc788a94cb297a86e2e8b6d04e733e8092e3ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 836482
Reviewed-on: https://chromium-review.googlesource.com/1045872Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556328}

The code was written with the expectation that
HostedAppButtonContainer::StartTitlebarAnimation()
is called before
HostedAppButtonContainer::OnImmersiveRevealStarted().

This is not the case when in tablet mode and results
in crashes.

This CL updates HostedAppButtonContainer to allow these
methods to be called in either order.

Bug: 836482
Change-Id: I658578ca79599e21566fffd3986a6dc852cb6489
Reviewed-on: https://chromium-review.googlesource.com/1029882
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556327}

Using wpt-import in Chromium 2c5e4b87.
With Chromium commits locally applied on WPT:
ca0aa292 "Support groupId constrainable properties in MediaDevices.getUserMedia()"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16945

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mkwst@chromium.org:
  external/wpt/x-frame-options
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I7403b2ee2fd7fe2bda44cc02e7085bac1e1fb92f
Reviewed-on: https://chromium-review.googlesource.com/1045801
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556326}

Added "Add property path to watch" for quickly adding an
inspected object property expression to watch.

This is not smart enough to infer the original expression
that triggered the property list, but it works without a user
intervention for the scope variables section.

Also -
- Removed a redundant . that is prepended to every
property path.
- Escaped the property name when it is a string.

R=pfeldman@chromium.org

Bug: none
Change-Id: I984bad781786668bb708084dbb1a8537dabf02a3
Reviewed-on: https://chromium-review.googlesource.com/1001232Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: PhistucK <phistuck@gmail.com>
Cr-Commit-Position: refs/heads/master@{#556325}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b0fd27b6..70d24bb2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: If8ce01913ad63ac5758596903ca0f2e429b9a4e0
Reviewed-on: https://chromium-review.googlesource.com/1045799Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556324}

The current draw occlusion cannot handle 3d object yet. This patch allows
DrawOcclusion to skip draw quads from a 3D objects.

Bug: 833748
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I08d12c794d4acff0e1f584f4c74857bc5df83fee
Reviewed-on: https://chromium-review.googlesource.com/1044781
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556323}