GitLab

'Downloading list of known revisions' step is faster. If the script is run with
--use-local-repo option, it will use "git svn find-rev <SHA1>" command to convert git hash 
to svn revision. This method is significantly faster than running the script
without git checkout.

Eg: Command to run:
time ./tools/bisect-builds.py -g 280588 -b 280590 --archive linux64 --use-local-repo

Output:
real	5m16.089s
user	3m50.326s
sys	1m1.190s

time ./tools/bisect-builds.py -g 280588 -b 280590 --archive linux64

Output:
real	10m51.194s
user	0m10.248s
sys	0m1.419s


BUG=390547
NOTRY=True

Review URL: https://codereview.chromium.org/378713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281936 0039d316-1c4b-4281-b951-d872f2087c98

It has no business being in there. Instead let Pipeline track duration
and cap interpolated time values as needed.

BUG=370634

Review URL: https://codereview.chromium.org/375003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281935 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/377693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281934 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/375703008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281933 0039d316-1c4b-4281-b951-d872f2087c98

Currently only hostname is given and it assumes IPEndPoint will have the port number. But
the assumption is wrong.

TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/378013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281932 0039d316-1c4b-4281-b951-d872f2087c98

This change plumbs '.installing' and you will be able to access
an installing worker via 'navigator.serviceWorker.installing'.


BUG=379012
TEST=content_unittest --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py  http/tests/serviceworker/installing.html (http://crrev.com/372453002)
TEST=run_webkit_tests.py http/tests/serviceworker/waiting.html

Review URL: https://codereview.chromium.org/369013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/374163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281930 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/373013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281929 0039d316-1c4b-4281-b951-d872f2087c98

Many 32bit bots fail with "bits/predef" not found. Examples:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/builds/25814/steps/compile/logs/stdio
http://build.chromium.org/p/chromium/builders/Linux/builds/51225

BUG=360311
NOTRY=true
NOTREECHECKS=true
TBR=ajwong@chromium.org

Review URL: https://codereview.chromium.org/378183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281928 0039d316-1c4b-4281-b951-d872f2087c98

We weren't respecting the full timeout specified by the Reboot() method. And
apparently timing is different enough on the L-release preview that reboots
get stuck forever without the timeout.

BUG=389362

Review URL: https://codereview.chromium.org/375973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281927 0039d316-1c4b-4281-b951-d872f2087c98

* Only change parent id when normalizing entry. Use PutParentIdPropertyOnly() instead of PutParentId() because the latter resets predecessor and changes ordering.
* Don't create sync node for mobile bookmarks, which only exists with sync enabled.

BUG=385731

Review URL: https://codereview.chromium.org/374183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281926 0039d316-1c4b-4281-b951-d872f2087c98

Remove SetupPangoLayout() and
SetupPangoLayoutWithoutFontDescription().
Rename SetupPangoLayoutWithFontDescription() to
SetUpPangoLayout() and pass a FontList to it instead of a
PangoFontDescription, along with removing an unused "width"
parameter.

BUG=125235

Review URL: https://codereview.chromium.org/374833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281925 0039d316-1c4b-4281-b951-d872f2087c98

All permutations of three fingers pressing, moving, and releasing are now being tested. Fingers that were recorded as pressed during the permutation but not released yet are released, and then there is a check for no fingers down.

BUG=388520

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281195

Review URL: https://codereview.chromium.org/358693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281924 0039d316-1c4b-4281-b951-d872f2087c98

Revert reason:
- the change seems okay, the compile error is caused because
  the builder doesn't recomile about_flags. Clobber might fix the
  issue.
- this should be reverted again if it still causes the error
  after clobber.

> Revert of Remove disable-app-list-voice-search flag. (https://codereview.chromium.org/353793003/)
> 
> Reason for revert:
> Caused compile error on Blink GPU Mac Builder:
> http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder
> 
> Original issue's description:
> > Remove disable-app-list-voice-search flag.
> > 
> > BUG=367341
> > R=xiyuan@chromium.org
> > TEST=compile
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281904
> 
> TBR=xiyuan@chromium.org,mukai@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=367341
> 
> Review URL: https://codereview.chromium.org/379673003

TBR=yutak@chromium.org

Review URL: https://codereview.chromium.org/374293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281923 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392096
TEST=visual

Review URL: https://codereview.chromium.org/372373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281922 0039d316-1c4b-4281-b951-d872f2087c98

This test confirms that incidents are coalesced into a report properly.

BUG=none
R=mattm@chromium.org

Review URL: https://codereview.chromium.org/365983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281921 0039d316-1c4b-4281-b951-d872f2087c98

For number of reasons:

* The previous code implicitly relied on the fact that the Observer
events are notified to MountedDiskMonitor before VolumeManager
(otherwise VolumeManager::OnDiskEvent misses the hard-unplug event.)
It indeed holds, but it is not a part of explicit contract of base::ObserverList.
We should not rely on the detail.

* It simplifies MountedDiskMonitor (see the number of lines.)

* It simplifies the initialization process of VolumeManager/DiskMountManager,
i.e., removes duplicated RequestMountInfoRefresh calls.
This is desired for Bug 356583.

BUG=356583

Review URL: https://codereview.chromium.org/372853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281920 0039d316-1c4b-4281-b951-d872f2087c98

BUG=352790
TEST=manually compile (chrome, brower_tests, unit_tests)

Review URL: https://codereview.chromium.org/356383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281919 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384495

Review URL: https://codereview.chromium.org/363133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281918 0039d316-1c4b-4281-b951-d872f2087c98

Replace all instances of viewport_size with scrollable_viewport_size,
as this deceptive variable name was root cause of the bug.

BUG=391386

Review URL: https://codereview.chromium.org/373903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281917 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/373033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281916 0039d316-1c4b-4281-b951-d872f2087c98

We can add this back when we figure out why it was causing
flickering on some devices.

BUG=317928

Review URL: https://codereview.chromium.org/323423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281915 0039d316-1c4b-4281-b951-d872f2087c98

This is mostly to collect performance and size data for now. Unless things
look really good, I'm going to revert this by wednesday morning (PDT).

BUG=360311
TBR=awong@chromium.org

Review URL: https://codereview.chromium.org/380573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281914 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=drm-i#1586

Review URL: https://codereview.chromium.org/377133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281913 0039d316-1c4b-4281-b951-d872f2087c98

Commited by mistake.

> Revert 272463 "Revert 272458 "Adding more guts to the mojo spy.""
> 
> > Revert 272458 "Adding more guts to the mojo spy."
> > 
> > Compilation on Mac Builder (dbg)
> > FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/mojo/spy/mojo_spy.websocket_server.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=206824 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -DMOJO_USE_SYSTEM_IMPL -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -O0 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene -Wno-c++11-narrowing -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-deprecated-register -Wno-selector-type-mismatch -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -fno-strict-aliasing -fstack-protector-all  -c ../../mojo/spy/websocket_server.cc -o obj/mojo/spy/mojo_spy.websocket_server.o
> > ../../mojo/spy/websocket_server.cc:30:16:error: no member named 'SetClient' in 'mojo::spy_api::SpyServer'
> >   spy_server_->SetClient(this);
> >   ~~~~~~~~~~~  ^
> > 
> > > Adding more guts to the mojo spy.
> > > 
> > > This CL fleshes out the basic architecture of the spy. Introducing SpyServerImpl and enough code to operate the "start" and "stop" commands of the front-end.
> > > 
> > > Still a quite a few loose ends, specially on teardown.
> > > 
> > > I updated the design doc to reflect this CL:
> > > https://docs.google.com/a/chromium.org/document/d/11FKYXf9mSohlsgl4JmGlyWE1ScX3DKdssdjub63tkwA/edit?usp=sharing
> > > 
> > > 
> > > BUG=360188
> > > TEST=manual via test/spy_repl_test.html
> > > 
> > > Review URL: https://codereview.chromium.org/284743002
> > 
> > TBR=cpu@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/296453021
> 
> TBR=vasilii@chromium.org
> 
> Review URL: https://codereview.chromium.org/381513002

TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/374243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281911 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 272458 "Adding more guts to the mojo spy."
> 
> Compilation on Mac Builder (dbg)
> FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/mojo/spy/mojo_spy.websocket_server.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=206824 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -DMOJO_USE_SYSTEM_IMPL -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -O0 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene -Wno-c++11-narrowing -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-deprecated-register -Wno-selector-type-mismatch -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -fno-strict-aliasing -fstack-protector-all  -c ../../mojo/spy/websocket_server.cc -o obj/mojo/spy/mojo_spy.websocket_server.o
> ../../mojo/spy/websocket_server.cc:30:16:error: no member named 'SetClient' in 'mojo::spy_api::SpyServer'
>   spy_server_->SetClient(this);
>   ~~~~~~~~~~~  ^
> 
> > Adding more guts to the mojo spy.
> > 
> > This CL fleshes out the basic architecture of the spy. Introducing SpyServerImpl and enough code to operate the "start" and "stop" commands of the front-end.
> > 
> > Still a quite a few loose ends, specially on teardown.
> > 
> > I updated the design doc to reflect this CL:
> > https://docs.google.com/a/chromium.org/document/d/11FKYXf9mSohlsgl4JmGlyWE1ScX3DKdssdjub63tkwA/edit?usp=sharing
> > 
> > 
> > BUG=360188
> > TEST=manual via test/spy_repl_test.html
> > 
> > Review URL: https://codereview.chromium.org/284743002
> 
> TBR=cpu@chromium.org
> 
> Review URL: https://codereview.chromium.org/296453021

TBR=vasilii@chromium.org

Review URL: https://codereview.chromium.org/381513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281910 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Caused compile error on Blink GPU Mac Builder:
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder

Original issue's description:
> Remove disable-app-list-voice-search flag.
> 
> BUG=367341
> R=xiyuan@chromium.org
> TEST=compile
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281904

TBR=xiyuan@chromium.org,mukai@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=367341

Review URL: https://codereview.chromium.org/379673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281908 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281906 0039d316-1c4b-4281-b951-d872f2087c98

Revert of NaCl: Update revision in DEPS, r13441 -> r13452 (https://codereview.chromium.org/371413003/)

Reason for revert:
Suspect this is causing PPAPINaClNewlibTest.FileIO to crash on Mac:

http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%283%29/builds/3112

Original issue's description:
> NaCl: Update revision in DEPS, r13441 -> r13452
> 
> This pulls in the following Native Client changes:
> 
> r13442: (dyen) Added support for log uploading for commands in toolchain_build.
> r13443: (noelallen) Rolls DEPS file to get deps aware toolchains.
> r13445: (dyen) Added a log_url field to package archs and recalculated revision hashes.
> r13446: (ncbray) Factor arg parsing in sel_ldr into its own function.
> r13447: (ncbray) Add my chromium account to OWNERS with my google account.
> r13448: (dyen) Fixed repo_tools invalid reference to pynacl.
> r13449: (thakis) Undo cros-specific hack now that r13435 seems to have stuck.
> r13450: (ncbray) Consolidate sel_ldr's configuration logic.
> r13451: (dyen) Package Version script now supports downloading build logs.
> r13452: (hamaji) Non-SFI Mode: Add isatty interface
> 
> BUG=none
> TEST=browser_tests and nacl_integration
> CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281849

TBR=bradnelson@google.com,ncbray@chromium.org,mseaborn@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/379663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367341
R=xiyuan@chromium.org
TEST=compile

Review URL: https://codereview.chromium.org/353793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281904 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281903 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=gpu bots green
TBR=kbr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/379633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281902 0039d316-1c4b-4281-b951-d872f2087c98

Test to remove calls to tab idleNotification, to try and diagnose a bug.  This will be removed after a Canary run.

BUG=381820

Review URL: https://codereview.chromium.org/371293006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281901 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch
* Possibly-uninitialized local variable

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/375733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281900 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390108
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/367163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281899 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/368903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281898 0039d316-1c4b-4281-b951-d872f2087c98

Android webview is missing initialization of ServerBoundCertService. Add
logic to initialize it.
Internal bug: b/1405093
BUG=392235

Review URL: https://codereview.chromium.org/373203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281897 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386390, 357233

Review URL: https://codereview.chromium.org/344033008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/379613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281895 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/375703007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281894 0039d316-1c4b-4281-b951-d872f2087c98