- 19 Nov, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change adds an entry for EnablePasswordGenerationForClearTextFields to the testing/variations/fieldtrial_testing_config.json. Bug: 1021897 Change-Id: I0e328629babc5f81c7bee05ea669598fd7ff69ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543392 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#829071}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605722062-63dbc729233b875bed4d9f1fa158097610c580cf.profdata to chrome-linux-master-1605743960-c6eb23d92bd5ebb2b738686f930937312c075c5e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic85ed2d9e064b956db22e20ebd80723e97202a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548411Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829070}
-
Joey Arhar authored
The UKM this goes next to doesn't get emitted in iframes due to the UKM policy, so this UseCounter will let us get the same metric from iframes. Bug: 1150619 Change-Id: Ib892978142f34010d8a8f3f489cd95957e362603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548346 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#829069}
-
Yicheng Li authored
This enables WebAuthn flow to be properly cancelled on ChromeOS. timeout and observe that ChromeOS UI is dismissed (and Chrome shows the timeout message). Bug: 1150656 Test: Started MakeCredential with test website then waited till Change-Id: I5403b03dd99fe329ea9009f7544bfefade39815c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548185 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#829068}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7e050e9a..458ab69a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3fc7b3a2f2152ee94b9fe55848c2901c1991fc83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548760Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829067}
-
Ben Joyce authored
Certain suites like ui_junit_tests and base_junit_tests need less shards, time differences are more apparent on bots than when run locally. Bug: 1138506 Change-Id: I5c5cbf019300f9b438c5d23b996e7d326e8e050d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545570 Auto-Submit: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#829066}
-
Joel Hockey authored
This reverts commit 8fd7b85d. Reason for revert: relanding after creating fix for M88 Original change's description: > Revert "Support Arc, crostini, and Plugin VM in drag drop FileHelper" > > This reverts commit 54e85384. > > Reason for revert: Reverting in order to create a patch for M88. > > Original change's description: > > Support Arc, crostini, and Plugin VM in drag drop FileHelper > > > > The current code in FileHelper assumes all windows are Arc. We now > > check the source and target aura::Window to detect and do the > > appropriate path translations and share files when necessary with > > crostini/pluginvm. > > > > For example, when crostini is the drag source, we will convert paths > > such as: > > > > <homedir>/file => /media/fuse/crostini_<hash>_termina_penguin/file > > > > And do the opposite translation when crostini is the drop target. > > > > We also convert paths and share files such as: > > > > <cryptohome>/MyFiles/file => /mnt/chromeos/MyFiles/file > > /media/removable/MyUSB => /mnt/chromeos/removable/MyUSB > > > > For PluginVM, the translation is > > > > <cryptohome>/MyFiles/file => //ChromeOS/MyFiles/file > > /media/removable/MyUSB => //ChromeOS/removable/MyUSB > > > > Bug: 1144138 > > Change-Id: I2bb38336537acf13c4797374d6dabe6e518d689e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517346 > > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > > Reviewed-by: Jason Lin <lxj@google.com> > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827956} > > TBR=oshima@chromium.org,joelhockey@chromium.org,niwa@chromium.org,lxj@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1144138 > Change-Id: I212ae8759e9069e52837fd1bc324ea5f9046b6b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547743 > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829031} TBR=oshima@chromium.org,joelhockey@chromium.org,niwa@chromium.org,lxj@google.com # Not skipping CQ checks because this is a reland. Bug: 1144138 Change-Id: I0a735fb4e17679f735c11ecab427f7ba624db399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547844Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#829065}
-
Nicholas Verne authored
This is a reland of 7b6fabaa We appear to be going for a record of reland/revert of strings. The relevant tast tests are submitted and have survived rollback. The chromeos LKGM uprev is stil not successful (for the last two weeks). I'll wait for that before submitting. Original change's description: > Reland "Reland "Crostini settings string changes."" > > This is a reland of 6b11534a > > OK, this time for sure. The tast-test change below was submitted, but the > relevant ChromeOS uprev was blocked for days. This is now through so we > can reland again, for real this time. > > Original change's description: > > Reland "Crostini settings string changes." > > > > This is a reland of da531d49 > > > > Now that https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2505407 > > is landed, this should be safe. > > > > Original change's description: > > > Crostini settings string changes. > > > > > > Instead of "Linux (Beta)", now shows as "Developers" > > > > > > Bug: 1140370 > > > Change-Id: Id4e076b5d918e41e22e5c59d65958da9e75a3f55 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486528 > > > Commit-Queue: Nicholas Verne <nverne@chromium.org> > > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > > Reviewed-by: David Munro <davidmunro@google.com> > > > Auto-Submit: Nicholas Verne <nverne@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#820205} > > > > Bug: 1140370 > > Change-Id: Ibb5bd28f9647847dddaf109e9da86d91b17dd863 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505324 > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Reviewed-by: David Munro <davidmunro@google.com> > > Commit-Queue: Nicholas Verne <nverne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822525} > > Bug: 1140370 > Change-Id: I76e0dfa45877db5d633a70126c0f5bd2a70a15f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515799 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823503} Bug: 1140370 Change-Id: Id55048b7c50b3eaa3e13572d1dbde544708a4dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526864Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#829064}
-
Yuki Shiino authored
Runs PartitionAllocMemoryReclaimer for the PartitionRoot used by ShimMalloc, etc. (partition alloc as malloc). Change-Id: I636b7b2ca4fdda7de7b3a178e6193dea7c0605cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532476Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#829063}
-
Michael Crouse authored
This change adds tflite and its dependencies to third_party. The design and approval can be seen here: https://docs.google.com/document/d/1mT__9_vMhAPTov6O7ULNV5lyk_c83dAufveAhPXZPcE/edit Bug: 1121333 Change-Id: I0cd9da80d6c6a83a733b28d0055d09a2d71865cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523426Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#829062}
-
Jeroen Dhollander authored
Gaia id should never be an email address, and there is a dcheck to guard against this: https://source.chromium.org/chromium/chromium/src/+/master:google_apis/gaia/core_account_id.cc;l=34 I have no idea why this was not triggering previously. Bug: None Test: browser_tests --gtest_filter="Assistant*" Change-Id: I47775ec00afd67ea31d92ea09bdf02267ba06672 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548294 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#829061}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dda9c164cb3b..2d31db0b3751 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I89b1afd37600dd91b57a17828f3bc1169fca0bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548422Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829060}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/444733610032..5589652282f5 2020-11-19 linxinan@chromium.org Revert "Improve the setup logic for tryserver" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1146487 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I7fe2b46838ea28629eb25ae71aa7efda6dfc7440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548722Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829059}
-
Dirk Pranke authored
This fixes various Python3 incompatibilities and updates the plist files to the new Python3 APIs. Bug: 1112471 Change-Id: Ie6239ab4454b39e7e65d02d3a2da4b3a1967a6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522676 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#829058}
-
Hiroki Sato authored
Starting ARC R, ARC natively supports display density. As a result, when the client is ARC P, the bounds are always scaled by the default device scale factor, and when the client is ARC R and later, the bounds are always scaled by the screen scale of the display, which matches the browser behavior. This CL addresses the above change in accessibility layer. AX-Relnotes: n/a. (a part of preparation for ARC R) Bug: b:17251157 Test: manual. Open PlayStore and change scale factor by ctrl+shift+(+/-) with P and R. Change-Id: Iae39adaed7b3fc7a00962edc9da617b89dea7202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540266 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#829057}
-
Clark DuVall authored
This is a reland of c7a74ee0 Fix for Play Store upload issue is in http://crrev.com/c/2545725. Will submit this after that lands. Original change's description: > Enable isolated splits in canary and dev > > All major crashes have been fixed and numbers look good. M88 branch was > just cut, so should be safe to enable now. > > Bug: 1126301 > Change-Id: I351d565e68f14af2411c71fa80f34852bab5455a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529729 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827387} Bug: 1126301 Change-Id: If28e00dae4bf5e81ef22751ae394c3bb4a200908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545870Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#829056}
-
Shakti Sahu authored
This CL adds various IPHs for the read later feature. 1 - IPH to educate user about using the bookmark button on the app menu for saving articles to reading list. 2 - IPH to educate user about location of bookmarks in app menu. 3 - Notify IPH backend whenever read later option is selected in context menu. 4 - Notify IPH backend whenever user navigates to the read later folder in bookmarks. Bug: 1139076 Change-Id: Ib81e43a9746c3493bdd6f299e6a9e117aacc472c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537390Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829055}
-
Maksim Ivanov authored
Fix the CHECK expression in color_space.cc to compare two signed ints, instead of a signed with an unsigned one. Excerpt from the error message: ../../base/check_op.h:191:26: error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare] ../../components/exo/wayland/clients/color_space.cc:33:3: note: in instantiation of function template specialization 'logging::CheckEQImpl<int, unsigned int, 0>' requested here CHECK_EQ(gbm_bo_get_plane_count(bo), 1u); This was seen in the clang-tidy builds (probably they're using slightly different build settings than the regular Chrome builds). Bug: none Change-Id: I8e929691560b1485e4fd5c05a4fb83f2c4c1a5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548464 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#829054}
-
James Hollyer authored
If Wifi is disabled Core Location does not work. In this case we will fallback to the Network Location Provider which can use the IP address to get an much less precise location. Bug: 1135766 Change-Id: I3f5fa8e78fbb34bcec36dbd6eeb0e6adc06c64c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453437Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#829053}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d31db0b3751..021b77e7f0c7 2020-11-18 treehugger-gerrit@google.com Merge "Prevent traced from blocking on a unresponsive producer." 2020-11-18 primiano@google.com Merge "build: pass explicitly --changelog to write_version_header.py" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If112e0bfa7a35f9af56dc752648b7e05f5341aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547982Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829052}
-
Mike Wasserman authored
Remove the fake scanning prompt; reply with kAllow automatically. This seems to resolve flaky crashes around prompt show/accept timing. Bug: 1147582 Test: No automated test flakes Change-Id: I889f9c97400901f235d6beebfa6a40e43bc8dc93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547842Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#829051}
-
Michael Hansen authored
This clears the controller in the OnClose() method to prevent a crash in the event that the OnClose() callback runs more than once before the animation is complete. This surfaced as a crash when sending a file. Fixed: 1150176 Change-Id: I13aa8eaf3bf3f5e382d31376825f647ab287a7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548373 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#829050}
-
Jeffrey Kardatzke authored
BUG=b:153111783,chromium:1150515 TEST=Fuzzer passes now Change-Id: I0ef8a8a5dde0cf87ca70e0889e4d5707bc5ac2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548348Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#829049}
-
Ana Salazar authored
We want to give users a quick shortcut to access recent screen recording files within Tote. As the capture mode controller ends screen video recording and a file is generated, we should be able to show it in the holding space tray. Bug: 1144927 Change-Id: Ia0b33e0d739705e3ac7bf1117adcff1369dac26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527855 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#829048}
-
Peter Kotwicz authored
This CL fixes the chrome_test_apk compile which was broken by https://chromium-review.googlesource.com/c/chromium/src/+/2530747 Bug: 1147581 Change-Id: I1bf919c8f7a72d58084a09ef45367d019acf7b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548349Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#829047}
-
Hiroki Sato authored
This change adds AXTreeSourceArc#GetWindow so that we will use it later for calculating scale factors. With the change, AXTreeSourceArc no longer need to track a device scale factor because it can be extracted from the window, and this CL deletes related codes as well. This is a preparation of the next patch. AX-Relnotes: n/a. (a part of preparation for ARC R) Bug: b:17251157 Test: unit tests still passes. Change-Id: I3c3df7801bec70c09a20c86df7b7033b55dafa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543524 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#829046}
-
Andres Medina authored
This is a reland of 35f1e6ba Original change's description: > [third_party] Uprev grpc to v1.33.0+ > > Bug: b/132440534 > Test: CQ and manual size check. > Change-Id: Ie892c66dd5773e93ed154d3754add455e1f47041 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518775 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Sean Topping <seantopping@chromium.org> > Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org> > Commit-Queue: Andres Medina <medinaandres@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828763} Bug: b/132440534 Change-Id: I0e8b880a6b3edf3540716146e741024c36856fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548502 Commit-Queue: Andres Medina <medinaandres@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#829045}
-
Joel Hockey authored
M89 branch came along midway through some work, so this partially reverts the VM file drag and drop for M88. The work will be completed in M89. This CL will ignore any exo file drops except from arc. Bug: 1144138 Bug: 1146319 Change-Id: I35e2f6674976ac76d89e92253b62e26c0ae82a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548580 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#829044}
-
Ahmed Mehfooz authored
Bug: 1145295 Change-Id: I8c3f2cb0a07895af16ac6c7ea24d3b4ae2f7c2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545643Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#829043}
-
Jeffrey Cohen authored
Change-Id: I207a3b1bf4f6b80dbdde455d80fa5f51899c4214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548521Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#829042}
-
Ahmed Mehfooz authored
This CL applies a gradient mask to fade the label so that the pin icon appears to cover the label instead of resizing the label. Bug: 1137959 Change-Id: I6bbfed603bc7f41b8a266e72a00ed55a74849556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543370 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#829041}
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: I338ac32bf6de0d248a93506ccbe9c832ffea0430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532870 Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#829040}
-
Melissa Zhang authored
This relands commit 571bc134. This CL adds animation to Sharesheet appear and disappear. Appear has a opacity fade in from 0 - 100 in 100ms with linear curve and scale fade in 80-100% in 150ms with curve (0.4,0,0.2,1). Disappear is a 100-0 in 80ms linear opacity fade out. In this CL we also disable sharesheet close on deactivate when ShareActions have been selected. The original CL caused a crash when calling CloseBubble twice in quick succession. To prevent this we are adding a check if the bubble is already closing and do not try to close the widget a second time. Bug: 1148692 Change-Id: I19ebe2d34786d51b625bef670c3567f112c50671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548581Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829039}
-
Esmael El-Moslimany authored
Bug: 1076506 Change-Id: I167596f3b470adbd015ceb1a72ea25abfe6268e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542669 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829038}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d361e6028c27..2d31db0b3751 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6619f284224e6c21131b555b2822e7b163b4ccd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548382Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829037}
-
Alex Newcomer authored
Paste the html markup into the WebContents instead of loading it via a data URL. This ensures the markup is sanitized before rendering it. Bug: 1148077 Change-Id: I43e6a1607e73602a1d099b087b6db3da27ef2b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523647Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#829036}
-
Yicheng Li authored
The user display name will be used to managed credentials. Bug: 1150639 Change-Id: Ie7137255cc3e5450f71e0b74e56f8cfca5390860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547625 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#829035}
-
Jeffrey Kardatzke authored
This adds usage of the protected media VAAPI APIs to VaapiWrapper. This is currently based on an upstream pull request located here: https://github.com/intel/libva/pull/457 That pull request will be patched onto the ChromeOS version of libva before this CL is merged. BUG=b:153111783,b:155509236 TEST=Builds, protected playback works w/ full set of changes, vaapi_unittest, also verified vaapi playback & vaapi_unittest on eve Change-Id: Id086dd33d692b86d810ea56645a63fb977d6bfc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526171 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#829034}
-
Nate Fischer authored
No change to logic. This adds bug numbers for all disabled tests so we can easily determine if these bugs are correctly triaged. This does not change which tests are disabled. I did the same search for @FlakyTest, but these seem to all have a bug number listed, so there was no work to do. Test: run_webview_instrumentation_test_apk Change-Id: I983e2ccc4addf51afe70724b69b9e96cde81beab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548182 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#829033}
-
Tal Pressman authored
Change-Id: I08cc79651c2bfabcbaa64372bac54b732c33eae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538868 Auto-Submit: Tal Pressman <talp@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#829032}
-