- 24 May, 2019 40 commits
-
-
Mason Freed authored
http/tests/devtools/a11y-axe-core/elements/main-tool-test.js failing since: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20MSAN/14679 TBR=masonfreed@chromium.org NOTRY=true Bug: 966932 Change-Id: Id7001fdb2ff59498256c6297f696f33c9d456692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628029Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#663152}
-
Dave Tapuska authored
The execution context state was never adjusted when a page was frozen. ContextStateChangedListeners fire when the state of execution context changes. This adds a number of things that are desirable for background tab freezing: - Workers being frozen as well - Mojo channels are appropriately dropped for IPCs while in the frozen state Add PauseExecutionContextOnBackgroundFreeze feature to control this and enable feature experimentally for now. Added a content feature kill switch for this as well. The desire is that bfcache, iframe freezing, sync event calls (window.print()) and background tab freezing all will share the same code paths for task scheduling adjustment. Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/KwDF6Eavfek/Qb48J5ceAwAJ BUG=957589 Change-Id: Ic5b94ed971f4fe0883c39039534efd64ffd290f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588158Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#663151}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8207b641f56e..8da1e6560222 git log 8207b641f56e..8da1e6560222 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 ethannicholas@google.com restructured SkSL include files 2019-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 1578d6b6f5dd..622c42a2cf22 (1 commits) 2019-05-24 halcanary@google.com add SkNamedTransferFn::kRec2020 2019-05-24 bsalomon@google.com Enable GL by default if GPU enabled and no backend selected. 2019-05-24 halcanary@google.com replace SkFont::glyphsToUnichars with SkFontPriv::GlyphsToUnichars 2019-05-24 fmalita@chromium.org [skottie] Add kBottom text alignment extension 2019-05-24 bsalomon@google.com Reland "Allow swapping out of GrBackendTexture used by SkSurface" Created with: gclient setdep -r src/third_party/skia@8da1e6560222 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: I6d7e4456e77229da5fb06a7c115743d7470aa6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628660Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663150}
-
Ben Pastene authored
Slightly cleaner this way. Bug: 947531 Change-Id: I9dcc66d92562ddae8adcbf58b7e0bf9a2ffdc481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625812Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#663149}
-
Annie Sullivan authored
Bug: 966921 Change-Id: I9308c3171f2c20df9dbca70853094fd5847dca12 TBR: crouleau@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627565Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#663148}
-
arthursonzogni authored
RenderFrameHostManager::GetOuterRenderWidgetHostForKeyboardInput() is no more used. Remove it. Bug: None. Change-Id: I552ae9a4f54370463bc44919ad4064229e65d8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626413Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#663147}
-
Jonathan Backer authored
Currently there are only a couple of ways to create a SharedImage from pixel data: (a) using and SharedImageBackingFactoryGLTexture or (b) using WrappedSkImageFactory We prefer WrappedSkImageFactory when using SkiaRenderer for potential performance benefit. This CL changes the logic inside InProcessCommandBuffer to enable_wrapped_sk_image if (a) is not possible. This supports running viz_unittests with --enable-vulkan. Bug: 966016 Change-Id: I84a77802653b689da92f8697cf2394b429e59d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627938 Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#663146}
-
Eric Karl authored
MomentumScrollJankTracker logic assumed that a kGestureScrollUpdate would always occur betweek kGestureScrollBegin / kGestureScrollEnd. It seems like we can hit a kGestureScrollUpdate in other cases, leading to a crash where we tried to use a null object. We now handle this case. Bug: 965422 Change-Id: I5538f52ff410e22334e0c0affcea5e987aa00803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625822 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#663145}
-
Lindsay Pasricha authored
Bug: 939373 Change-Id: Ib8c3827399238e3cce7ea307a37923f76f7832e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628033Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#663144}
-
Aaron Gable authored
The android, win, and win32 release archive bots (and all of the debug archive bots) have been using minimal_symbols since the very beginning of the switch to GN. I'm not aware of any reason to continue producing these extra symbols on these bots, and it's causing disk-space issues (see bug below), so we might as well make the configs more unified. Bug: 966293 Change-Id: I663af34e11e6ea3f9979563b2bedf0d124b476c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625847Reviewed-by:
-
Annie Sullivan authored
Bug: 966913 Change-Id: I2d5e1ff11a7762ec69b56c1e07873f101394fd93 TBR: crouleau@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628933Reviewed-by:
-
Ken Rockot authored
This removes content_packaged_services entirely, switching instead to a direct delegate interface on Service Manager, allowing the Content layer to directly field service process launching requests. Follow-up CLs will further simplify in- and out-of-process service configuration, and this is ultimately a step towards migrating process launch out of Content and into Service Manager and removing other things like content::ServiceManagerConnection. Bug: 781334,895615 Change-Id: I9243eb24b0152c2b353909718d8d3de223a6af9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604203 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#663141}
-
Rohit Rao authored
This reverts commit daad88b5. Reason for revert: Breaks internal compile. Original change's description: > Create //ios/web/public/security/BUILD.gn. > > This CL creates //ios/web/public/security/BUILD.gn and removes the > temporary header //ios/web/public/certificate_policy_cache.h > > Bug: 956511,942244 > Change-Id: I7f70539cb2ce2d504e058a94a585124d265e12a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624809 > Reviewed-by: Christopher Thompson <cthomp@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Yi Su <mrsuyi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663093} TBR=marq@chromium.org,eugenebut@chromium.org,mahmadi@chromium.org,cthomp@chromium.org,mrsuyi@chromium.org Change-Id: I370fafb2a873946e396fac17344c163b44a763d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 956511, 942244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626491Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a0e9943ca69a..d9b4f3330fdb git log a0e9943ca69a..d9b4f3330fdb --date=short --no-merges --format='%ad %ae %s' 2019-05-24 srte@webrtc.org Cleanup of AudioAllocationSettings flags. 2019-05-24 sprang@webrtc.org Add test to cover bug in vp9 wrapper, triggered by field trial 2019-05-24 ossu@webrtc.org Avoid the render lock in AudioProcessingImpl::ProcessStream Created with: gclient setdep -r src/third_party/webrtc@d9b4f3330fdb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8bb6ab825945c050d25707960ca26e0373cb93a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627909Reviewed-by:
-
danakj authored
We will add an android_browsertests target instead that is for Android only. This is a minimal change because it touches a lot of lines for re-indentation which is likely to cause rebase conflicts until the end of time. The browser_tests, browser_tests_runner, and performance_browser_tests targets are all wrapped in if (!is_android) {} instead. R=jam@chromium.org Bug: 961849 Change-Id: Ie416fa0be7f40bfe0e27b234c17b0b4e725356f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626965Reviewed-by:John Abd-El-Malek <jam@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#663138}
-
Daniel Libby authored
There are effectively two copies of the WebScrollGranularity in cc/ and ui/events/ due to where it is currently defined in blink. Per https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/M7rjH6icU6I/nPDlZ0cXBAAJ move the enum to a ui/event/types location that can be included from all those places, and update DEPS. The two duplicate enums that were removed were in ui/events/gesture_event_details.h and cc/input/input_handler.h. Code to translate between the enums has also been removed. There's one more usage of ScrollGranularity that could use some cleanup: ScrollStateData, which stores it as a double. However, untangling that will be handled separately since the ScrollStateInit object (generated from a dictionary idl) has the granularity as a double. Bug: 965304 Change-Id: I67b5766e476d8d25ab24b37ad69427f38c8e7f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621269 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#663137}
-
Finnur Thorarinsson authored
Part 1: Show video thumbnails in the grid, but no preview (yet). Bug: 895776, 656015 Change-Id: I1f99224e33f98dd20e26543a0d05a2b7000ff871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615199 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#663136}
-
Peng Huang authored
Using rgb visual will regression some rendering performances, so always using argb visual. Bug: 965108,961358,960692 Change-Id: I80c8abf18d35b4fad899f1c74acf4f9fc99fcd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626342Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#663135}
-
Peng Huang authored
Bug: none Change-Id: I67056b210584112df09a779902d5bcd1b0d7144a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628235Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
-
Xing Liu authored
This CL moves code belongs to chrome for notification scheduler into its own subdirectory. Bug: 966535 Change-Id: Ic2af225bd6dd17e769f485718f49a49efde76fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627890Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#663133}
-
David Bienvenu authored
Unit tests shouldn't use system clipboard because clipboard is a global resource. Bug: 963112 Change-Id: I2c32042dac0aee6f91418b5f7b8099c018aef55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625942 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#663132}
-
Rohit Rao authored
BUG=922813 Change-Id: Ie9545589a8f99ff3ef7652ce06d3ab117fe2499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628049Reviewed-by:
-
Liquan(Max) Gu authored
We should dump a trace event when the UKM of Largest Contentful Paint is fired. This trace event can be used in several ways: * LCP benchmarks can be built on top of that * FCP++ viewer can report it * Loading metrics can report it Bug:964482 Change-Id: I1492a88f8316d38d64355c5c6d8f723096de35b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617687Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#663130}
-
Brian Salomon authored
Historically Skia's GL backend was always built and other backends were opt-in. Skia is making GL opt-in as well to support Vulkan-only and Metal-only builds of Skia. Also removes definition of GR_GL_IGNORE_ES3_MSAA which no longer has any meaning in Skia. Change-Id: I0dbcd3fc961258e927397b6b9e132d81b13c99df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628807Reviewed-by:
Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#663129}
-
Brian White authored
If the program is unable to allocate a memory (1MiB) for histogram recording, just disable persistent histograms. No metrics will ever be passed to Chrome for upload during this session but it's better that just crashing during program initialization. Bug: 946577 Change-Id: I45c5fe7de5de63e7b1395e301e496775fb65346f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622767 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#663128}
-
Mason Freed authored
These tests are always failing on Linux Tests (dbg) (1): external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/shared-worker/keep-origin-redirect/generic.http.html external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/shared-worker/no-redirect/generic.http.html external/wpt/referrer-policy/no-referrer/meta-referrer/same-origin/http-http/shared-worker/keep-origin-redirect/generic.http.html external/wpt/referrer-policy/no-referrer/meta-referrer/same-origin/http-http/shared-worker/no-redirect/generic.http.html https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29?limit=200 Example: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/80641 TBR=masonfreed@chromium.org NOTRY=true Bug: 966907 Change-Id: Ibcdb705284e6fa4667767a06b5357462c9d01e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628026Reviewed-by:
-
Xianzhu Wang authored
Bug: 966371 Change-Id: Idd768ff80000f16c4cc2e5ed754707baa7335188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627007 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#663126}
-
Michael Crouse authored
Stores the expiry time for fetched hints being placed in the HintCacheStore based on the GetHintsResponse max_cache_duration or a default value of 7 days (finch configurable). Bug: 932707 Change-Id: Iecd89f775ad25de59cbae37273f81650b8709deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605341 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#663125}
-
Alex Clarke authored
They are potentially dangerous especially for Then callbacks on a Promise<std::uniqe_ptr<T>>. Bug: 906125 Change-Id: Ic7b36433b0b71284ca3e7c4b885c79078e37cee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628717 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#663124}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/21e35ed8258b..3c59c438c0f7 Created with: gclient setdep -r src-internal@3c59c438c0f7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:966447 TBR=yukishiino@google.com,lgrey@google.com,masonfreed@google.com,rsorokin@google.com Change-Id: I91b8b8a09d67bf491342c2b577036fa08ec929c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628657Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663123}
-
Kevin Bailey authored
This is just a follow-up to 1625811, to also rename the flag used to enable the feature, to OmniboxGroupSuggestionsBySearchVsUrl. TBR=jdonnelly Bug: 966462 Change-Id: Id64c2751f105e9d57894a9f85f8307b1a687ff59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626341Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#663122}
-
Rohit Rao authored
This set of utilities is required to get ChromeTestCase compiling under EG2. BUG=922813 Change-Id: Ib1e6773f5ad8c58544ea2bda8464aad5cbd05970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628046Reviewed-by:
-
Etienne Pierre-doray authored
This Cl introduces RegisteredTaskSource to convey the "intent to queue" that originates from a call to TaskTracker::WillQueueTaskSource() until when it is run in TaskTracker::RunAndPopNextTask() or released with TaskTracker::UnregisterTaskSource(). Change-Id: I90f66dd04ee19fe84d819434261b3acd44b86aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611110 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#663120}
-
Peter K. Lee authored
Must check dominant flag first otherwise Finch would elect users into Identity Disc group unnecessarily. Bug: 965974 Change-Id: Ib2669a1c47940b504d3c4f0e02a448727502ce88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628653 Auto-Submit: Peter Lee <pkl@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#663119}
-
Dan Harrington authored
In Q, it is suggested that we use Context methods for accessing external paths. https://developer.android.com/preview/privacy/scoped-storage This change fixes a bug on Android Q where we don't have permission to store downloaded pages. Bug: 956679 Change-Id: If53b16c15204cdc396cf4ab1d84419b32c7384f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627667 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#663118}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5d3500a1..6bb4b9d8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3d9bbc18a6c546f3d893a13ceb1e8c002db3dea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628545Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663117}
-
David Bokan authored
These tests look like they've been passing consistently now so removing their expectations: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=custom-scrollbar-adjust-on-inactive-pseudo.html%2Ccustom-scrollbar-inactive-pseudo.html Bug: 789567 Change-Id: I21c27a4c04f923a4407d272f81c61adecd0ff046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626961 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#663116}
-
Roman Aleksandrov authored
Change the way the Recommended notification is updated on the ChromeOS to adjust to text changes. Text of the Recommended notification reflects whether the Recommended deadline was already passed or not. Bug: 963883 Change-Id: If4fa74f8ebb7b606b96fcc18af7030493665a1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622848Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/60c7eaa7fb0c..7d1300b89ab7 git log 60c7eaa7fb0c..7d1300b89ab7 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 raul@tambre.ee fake_repos: Fix use of NamedTemporaryFile on Windows 2019-05-24 raul@tambre.ee fake_repos: Log stderr when Git fails to start Created with: gclient setdep -r src/third_party/depot_tools@7d1300b89ab7 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:962263,chromium:962263 TBR=agable@chromium.org Change-Id: I21f4ce7ea3de9c523ece243894808d5c2051718e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628658Reviewed-by:
-
Aga Wronska authored
Create subclasses for Kiosk Next shelf control buttons, so they can draw their own backgrounds in the shape of rounded rectangle. Update size and position of the buttons to roughly match current design proposal. The exact details will be updated when UI spec is delivered. Move existing control button background (one background view shared between back and home buttons) to DefaultShelfView, because it is only used by default shelf. Bug: 948953 Test: KioskNextShelfViewTest + manually Change-Id: I69432668023865e06354dec46d41ec7ac50c3e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626051 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#663113}
-
