GitLab

This allows symbolization of Google Chrome Canary, Google Chrome Helper EH,
and Google Chrome Helper NP. The practical effect of this is that _main and
start will be properly symbolized by Breakpad.

BUG=94540
TEST=Look at the Breakpad crash reports for the canary browser process,
     plug-in process, and NaCl loader process. The bottom of each stack should
     show ChromeMain being called by main, which is in turn called by start.
Review URL: http://codereview.chromium.org/7799005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98682 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/7790007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:19010
TEST=Manual: open user image selection dialog, move to the last image and press the right arrow.


Review URL: http://codereview.chromium.org/7784003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98680 0039d316-1c4b-4281-b951-d872f2087c98

These changes enable save and restore of minimized window state on Windows.  (Mac and Linux came prior).  The window state is now saved whenever size-changed notifications fire (in addition to the original activation and close cases).

BUG=43274
TEST=Manual.  Launch Chrome on Windows, create two browser windows, minimize "a" window, quit.  Relaunch, expect "a" to be minimized.


Review URL: http://codereview.chromium.org/7748036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98679 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/7793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98678 0039d316-1c4b-4281-b951-d872f2087c98

Use the job object to prevent the GPU from spawning child processes on Windows.

BUG=None.
TEST=None.
Review URL: http://codereview.chromium.org/7768004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98677 0039d316-1c4b-4281-b951-d872f2087c98

 * Call OnTextInputTypeChanged from Mock class (which is used when ibus is not present)
 * Don't create InputMethod in desktop window.
 * Fix comment on RWHVV to be more accurate.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7761008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98676 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr@chromium.org
BUG=28439
TEST=none

Review URL: http://codereview.chromium.org/7790004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94308
TEST=Run unit tests - I don't have any way to reproduce the corrupted DB this CL works around.


Review URL: http://codereview.chromium.org/7747040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98673 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98672 0039d316-1c4b-4281-b951-d872f2087c98

TBR=apavlov@chromium.org

Review URL: http://codereview.chromium.org/7798001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98670 0039d316-1c4b-4281-b951-d872f2087c98

Also adding myself to chromeos watchlist.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7753026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98669 0039d316-1c4b-4281-b951-d872f2087c98

An upcoming libcros change adds a header dependency on glib, so we need an entry in system.gyp for cros_api.gyp to reference.

BUG=chromium-os:19576
TEST=none

Review URL: http://codereview.chromium.org/7799001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98668 0039d316-1c4b-4281-b951-d872f2087c98

I need to use this function in content/rendeder/p2p.

TEST=None
BUG=None

Review URL: http://codereview.chromium.org/7714027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98666 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98665 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7789001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98664 0039d316-1c4b-4281-b951-d872f2087c98

The language index in the dump referred by the crbug is left to -1, meaning that the language passed to TranslateInfoBarDelegate's constructor...

The call stack showed that the call came from an auto translate preference, so my only guess would be that a preference was saved for a language that is not available anymore, so I added code to protect against that.

BUG=93291
TEST=TranslateManagerTest.UnsupportedSavedLanguage

Review URL: http://codereview.chromium.org/7764003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98661 0039d316-1c4b-4281-b951-d872f2087c98

Revert 98656 - Make a new integer field in sql::MetaTable (a per-profile db) containing a counter for the next download id, so that this id is unique across sessions. This id will allow us to merge download id with db_handle and merge most/all of the maps in DownloadManager in future CLs.
Make DownloadManager read this field to initialize its next_id_ counter in Init().
Put a fine-grained mutex in DownloadManager::GetNextId() so that it can be called directly from any thread.
Define a thunk wrapping DM::GNI() to be passed around between threads to guard against other threads calling any other DM methods.
This thunk owns a scoped_refptr<DM> to manage life-time issues. This pattern is implemented for DM elsewhere.
Store this thunk in ResourceContext to be called by ResourceDispatchHost/DownloadThrottlingResourceHandler on the IO thread. Pass the returned DownloadId into DownloadResourceHandler.
The alternative way to obtain ids on the IO thread is to jump over to the UI thread and back. This way would add significant latency to a critical path. GetNextId() should be fast and easily accessible from any thread.
Now that ids are per-profile, define a class DownloadId containing a per-profile id and an indication of which profile, currently the DownloadManager*. DownloadIds are hashable, comparable, globally unique, not persistent, and are used by DownloadFileManager.
When the download is added to the history, MetaTable.next_download_id will be set to the new download's id +1 if that number is greater than MT.next_download_id. Increasing this counter at the same time as the download is added to the db prevents the counter from desyncing from the db, which was the primary concern re storing the counter in the BrowserPrefs.
See also http://codereview.chromium.org/7192016
LMK what to write a test for if anything.

Review URL: http://codereview.chromium.org/7237034

TBR=benjhayden@chromium.org
Review URL: http://codereview.chromium.org/7793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98660 0039d316-1c4b-4281-b951-d872f2087c98

* Disable underlining for links
* Add more padding between the button and the title.
* Discard the button gradient in favor of white.
* Move favicons two lower-left. 
* Display favicons at natural size (TODO: they need to be size constrained)
* Other bookmarks folder will be hidden if empty.

BUG=92921
Review URL: http://codereview.chromium.org/7749029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93144
Review URL: http://codereview.chromium.org/7713026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98657 0039d316-1c4b-4281-b951-d872f2087c98

Make a new integer field in sql::MetaTable (a per-profile db) containing a counter for the next download id, so that this id is unique across sessions. This id will allow us to merge download id with db_handle and merge most/all of the maps in DownloadManager in future CLs.
Make DownloadManager read this field to initialize its next_id_ counter in Init().
Put a fine-grained mutex in DownloadManager::GetNextId() so that it can be called directly from any thread.
Define a thunk wrapping DM::GNI() to be passed around between threads to guard against other threads calling any other DM methods.
This thunk owns a scoped_refptr<DM> to manage life-time issues. This pattern is implemented for DM elsewhere.
Store this thunk in ResourceContext to be called by ResourceDispatchHost/DownloadThrottlingResourceHandler on the IO thread. Pass the returned DownloadId into DownloadResourceHandler.
The alternative way to obtain ids on the IO thread is to jump over to the UI thread and back. This way would add significant latency to a critical path. GetNextId() should be fast and easily accessible from any thread.
Now that ids are per-profile, define a class DownloadId containing a per-profile id and an indication of which profile, currently the DownloadManager*. DownloadIds are hashable, comparable, globally unique, not persistent, and are used by DownloadFileManager.
When the download is added to the history, MetaTable.next_download_id will be set to the new download's id +1 if that number is greater than MT.next_download_id. Increasing this counter at the same time as the download is added to the db prevents the counter from desyncing from the db, which was the primary concern re storing the counter in the BrowserPrefs.
See also http://codereview.chromium.org/7192016
LMK what to write a test for if anything.

Review URL: http://codereview.chromium.org/7237034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=avayvod@chromium.org


Review URL: http://codereview.chromium.org/7784002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98655 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7736005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98654 0039d316-1c4b-4281-b951-d872f2087c98

use predefined messages, per Cira.
Review URL: http://codereview.chromium.org/7794001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98653 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98652 0039d316-1c4b-4281-b951-d872f2087c98

TBR=apavlov@chromium.org

Review URL: http://codereview.chromium.org/7795001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98651 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98649 0039d316-1c4b-4281-b951-d872f2087c98

TBR=asargent@chromium.org

Review URL: http://codereview.chromium.org/7792001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98647 0039d316-1c4b-4281-b951-d872f2087c98

Views IME keeps track of the focus changes, and notifies the keyboard manager if
the keyboard should be visible or not. So doing the same from
TouchBrowserFrameView isn't necessary anymore.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98646 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7753035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98645 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87336
TEST=net_unittests --gtest_filter=ProxyServiceTest.ProxyFallback:HttpStreamFactoryTest.JobNotifiesProxy


Review URL: http://codereview.chromium.org/7532011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=85408

Review URL: http://codereview.chromium.org/7787002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98642 0039d316-1c4b-4281-b951-d872f2087c98

This eliminates unnecessary dialog refreshes when input is lost and user has to enter it again.
Small JS change, properly disable OK controls in SIM dialogs.

BUG=chrome-os-partner:4661
TEST=Manual. Various operations with SIM dialog.

Review URL: http://codereview.chromium.org/7736014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98641 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94454
r=sreeram
Review URL: http://codereview.chromium.org/7772002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98640 0039d316-1c4b-4281-b951-d872f2087c98

Use TreeNode::empty() accessor function for checking if node has children or if
it isn't empty, instead of using child_count().

BUG=None
TEST=None

R=gbillock@chromium.org

Review URL: http://codereview.chromium.org/7775001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98639 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/7741032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98638 0039d316-1c4b-4281-b951-d872f2087c98

They are green locally on my Windows 7 x64 machine with DrM r482
TBR=bruening
BUG=http://code.google.com/p/drmemory/issues/detail?id=569
Review URL: http://codereview.chromium.org/7745056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98636 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/drmemory/issues/detail?id=12
TBR=bruening
Review URL: http://codereview.chromium.org/7736021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98635 0039d316-1c4b-4281-b951-d872f2087c98

after a WM_DESTROY. The current code in WM_DESTROY removes the
properties, which means if we get a WM_CLOSE after WM_DESTROY we can't
locate the profile and end up using local_state prefs, which haven't
had the pref registered and we crash. The fix is to remove the
properties in OnFinalMessage.

BUG=91396
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7741044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98633 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98632 0039d316-1c4b-4281-b951-d872f2087c98