GitLab

Since this file is associated with the Editing module, this should
be kept in core/editing instead of core/page.

BUG=402417

Review URL: https://codereview.chromium.org/467503002

git-svn-id: svn://svn.chromium.org/blink/trunk@180055 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes the functions:
- lastMatchedRulesPosition
- sortMatchedRulesFrom
- sortAndTransferMatchedRulesWithOnlySortBySpecificity
from ElementRuleCollector as they are unused (and the latter two don't
even have definitions).

Review URL: https://codereview.chromium.org/460263002

git-svn-id: svn://svn.chromium.org/blink/trunk@180054 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's not a good idea to use global variables in PrivateScriptRunner.js
because they are exposed to all window objects of the private scripts.
This CL reduces the number of global variables used in PrivateScriptRunner.js.

Also this CL removes a |global| parameter from installClass()
since the |global| is always equal to the window object of the JS file.

BUG=341031

Review URL: https://codereview.chromium.org/466623002

git-svn-id: svn://svn.chromium.org/blink/trunk@180053 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/GLl6aWs9-EM/uTqxEmM4iGcJ

The API is only enabled for testing, to allow the recent spec changes
to be implemented with tests for the new API: http://crbug.com/402376

This does not add support for the :fullscreen pseudo-class, which is
tracked by a dedicate issue: http://crbug.com/402378

BUG=383813

Review URL: https://codereview.chromium.org/395633011

git-svn-id: svn://svn.chromium.org/blink/trunk@180052 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds the flag 'inherited' to CSSProperties.in, replacing the
existing switch statement in CSSProperty.cpp. The primary use for
isInheritedProperty appears to be as part of the MatchedPropertiesCache
optimisation.

I've added the inherited flag to overflow-wrap and paint-order, which
are inherited in the code and specs[1][2] but were not returning true
in the switch. As far as I can tell, this has no difference aside from
making us still use the MatchedPropertiesCache if these are explicitly
set to inherit. I also added a fixme indicating that the property
resize shouldn't inherit by default.

[1] http://dev.w3.org/csswg/css-text/#overflow-wrap-property
[2] https://svgwg.org/svg2-draft/painting.html#PaintOrder

BUG=396992

Review URL: https://codereview.chromium.org/450103005

git-svn-id: svn://svn.chromium.org/blink/trunk@180051 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/463043003

git-svn-id: svn://svn.chromium.org/blink/trunk@180050 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are may well be several threads with same name, e.g. all worker threads will be called "WebCore: Worker". Such threads should be displayed as separate threads on tracing based timeline.

BUG=401895

Review URL: https://codereview.chromium.org/463033002

git-svn-id: svn://svn.chromium.org/blink/trunk@180049 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/460953002

git-svn-id: svn://svn.chromium.org/blink/trunk@180048 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402805
TBR=pfeldman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/464783002

git-svn-id: svn://svn.chromium.org/blink/trunk@180047 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Like [1] and [2]. We should do it in general.

[1] http://src.chromium.org/viewvc/blink?view=revision&revision=180023
[2] http://src.chromium.org/viewvc/blink?view=revision&revision=180029

BUG=398342

Review URL: https://codereview.chromium.org/459353002

git-svn-id: svn://svn.chromium.org/blink/trunk@180046 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/467523002

git-svn-id: svn://svn.chromium.org/blink/trunk@180045 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/453393002

git-svn-id: svn://svn.chromium.org/blink/trunk@180044 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the spec the ::first-line pseudo-element do not apply to
grid containers (neither to flexboxes).

Modified RenderBlock::findFirstLetterBlock() to use isRenderBlockFlow()
instead of isFlexibleBox(). This change has been already made before in
several parts of the code, but there was one missing case here.

Fix issue in RenderBlock::updateFirstLetter() that applies to both grids
and flexboxes. Basically if the grid's or flexbox's container was
defining the ::first-line pseudo-element and the grid or flexbox itself
too, the value from the grid or flexbox was being applied to the items.
Add the proper check to avoid this.

Added two new tests for grid and modified flexbox test to cover the
issue explained above.

TEST=css3/flexbox/flexbox-ignore-container-firstLetter.html
TEST=fast/css-grid-layout/grid-container-ignore-first-letter.html
TEST=fast/css-grid-layout/grid-item-first-letter-valid.html

BUG=395788

Review URL: https://codereview.chromium.org/440233002

git-svn-id: svn://svn.chromium.org/blink/trunk@180043 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402801
TBR=zerny@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/467553002

git-svn-id: svn://svn.chromium.org/blink/trunk@180042 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Merge multiple |namespace blink {}| blocks
- Remove unnecessary blink:: prefixes
- Make blank lines consistent

BUG=

Review URL: https://codereview.chromium.org/462843003

git-svn-id: svn://svn.chromium.org/blink/trunk@180041 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a WebCredentialManager interface that the credential
manager module will (eventually) use to call up into its embedder in
response to JavaScript API calls.

These methods don't currently do anything, and aren't actually called;
until the Chromium-side work is done, there's no reason to wire them up
to the JavaScript bindings.

BUG=400674

Review URL: https://codereview.chromium.org/456293002

git-svn-id: svn://svn.chromium.org/blink/trunk@180040 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds the flag 'animatable' to CSSProperties.in, replacing the
existing switch statement in CSSAnimations.cpp. Setting the flag
indicates that the property can be animated by CSS animations and
transitions.

The added code will generate a function in CSSPropertyMetadata, which
will eventually also support functions like isInheritedProperty and
isValidFirstLetterStyleProperty. This means that the individual lines in
CSSProperties.in may start getting a bit long, although a centralized
specification of our supported CSS properties arguably helps developers
add new CSS properties, by reducing the lines they need to add and
adding documentation on what changes need to be made.

BUG=396992

Review URL: https://codereview.chromium.org/454423003

git-svn-id: svn://svn.chromium.org/blink/trunk@180039 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This enables webkit_unit_tests and makes public/blink work in the
component build.

Review URL: https://codereview.chromium.org/466593002

git-svn-id: svn://svn.chromium.org/blink/trunk@180038 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Specifications:
http://www.whatwg.org/specs/web-apps/current-work/#the-menu-element
http://www.whatwg.org/specs/web-apps/current-work/#the-menuitem-element

Changes in /parser/HTMLStackItem.h are required as per this part of specification
http://www.whatwg.org/specs/web-apps/current-work/multipage/syntax.html#special
And isSpecial() is used here
http://www.whatwg.org/specs/web-apps/current-work/multipage/syntax.html#parsing-main-inbody
with section "Any other end tag"
During end tag processing, if it is a special element, it should report parseError.

Changes in /parser/HTMLTreeBuilder.cpp are required as per this part of specification
http://www.whatwg.org/specs/web-apps/current-work/multipage/syntax.html#tokenization
"When a start tag token is emitted with its self-closing flag set, if the
flag is not acknowledged when it is processed by the tree construction
stage, that is a parse error."
<menuitem> has no end tag, its a self closing tag, and it should not
contain any inner node, so adding token using insertSelfClosingHTMLElement().

Changes in /rendering/RenderTheme.cpp are as per this part of specification
http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#hidden-elements


BUG=87553

Review URL: https://codereview.chromium.org/443373002

git-svn-id: svn://svn.chromium.org/blink/trunk@180037 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This removes ~242 KB of *-expected.png and leaves only a few
platform-specific expectations left in
LayoutTests/platform/linux/virtual/android/fullscreen/

Some tests were simultaneously pixel tests and text tests, which is
not great for a reftest. To avoid having the (formated) log output in
*-expected.html, instead make those tests time out if any check fails.

Review URL: https://codereview.chromium.org/457663002

git-svn-id: svn://svn.chromium.org/blink/trunk@180036 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MediaSource.isTypeSupported() should not return true without making sure
that the HTMLMediaElement supports the content type as well.

BUG=402386
R=acolwell@chromium.org

Review URL: https://codereview.chromium.org/456313003

git-svn-id: svn://svn.chromium.org/blink/trunk@180035 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch is part 2 of merging the CSS .in files. Having a single .in
file for listing CSS properties makes it both easier to add new properties
and add new property flags.

BUG=396992
TBR=pfeldman

Review URL: https://codereview.chromium.org/415613002

git-svn-id: svn://svn.chromium.org/blink/trunk@180034 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In order to debug private scripts, JS errors thrown in the private scripts
(e.g., ReferenceError thrown when we make a typo in private scripts)
need to be reported to stderr. This CL makes the change.

The fprintf(stderr, ...) is enabled only in Debug builds.

This CL also renames throwDOMExceptionInPrivateScriptIfNeeded to rethrowExceptionInPrivateScript.

BUG=341031

Review URL: https://codereview.chromium.org/460573002

git-svn-id: svn://svn.chromium.org/blink/trunk@180033 bbb929c8-8fbe-4397-9dbb-9b2b20218538

AudioNode::isMarkedForDeletion is not needed any more in oilpan builds
for the following (non-trivial) reason:

0 isMarkedForDeletion is set to true in AudioNode::dispose().
In oilpan builds, AudioNode::dispose() is called after the AudioNode
becomes unreachable. In other words, isMarkedForDeletion is set to true
after the AudioNode becomes unreachable.

- The only user of isMarkedForDeletion is AudioNodeInput::canUpdateState().
AudioNodeInput::canUpdateState() returns false if isMarkedForDeletion is true.

- AudioNodeInput has a strong reference to the AudioNode.

These facts indicate that AudioNodeInput::canUpdateState() always returns true. Thus this CL removes the canUpdateState() checks from the code base. This also enables us to remove AudioNode::isMarkedForDeletion.

BUG=340522
NOTRY=true

Review URL: https://codereview.chromium.org/458923003

git-svn-id: svn://svn.chromium.org/blink/trunk@180032 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Fix leaks when the shared worker is requested to be terminated while loading the main script. (https://codereview.chromium.org/451603002/)

Reason for revert:
UAF bug in WebSharedWorkerImpl::stopWorkerThread().

Original issue's description:
> Fix leaks when the shared worker is requested to be terminated while loading the main script.
> 
> BUG=398742
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180013

TBR=jochen@chromium.org,sigbjornf@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=398742

Review URL: https://codereview.chromium.org/465863002

git-svn-id: svn://svn.chromium.org/blink/trunk@180031 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A reftest cannot be marked as NeedsRebaseline/NeedsManualRebaseline.
This caused lint errors on all bots.

> Mark test as needing rebaseline after Skia change improves it.
> 
> virtual/gpu/fast/canvas/canvas-createImageBitmap-colorClamping.html is less dirty after Skia change.
> 

TBR=bungeman@chromium.org,zerny@chromium.org

Review URL: https://codereview.chromium.org/463703004

git-svn-id: svn://svn.chromium.org/blink/trunk@180030 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL fixes flaky crashes in tables/mozilla/bugs/.

RenderImageResource::shutdown unregisters the owner RenderImage from an
ImageResource. We should call it in RenderImage::destroy because
RenderObject::willRenderImage, which is a callback of ImageResourceClient,
should not be called after RenderImage::destroy.

BUG=398342

Review URL: https://codereview.chromium.org/458383003

git-svn-id: svn://svn.chromium.org/blink/trunk@180029 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r179771 fixed the crash bug but it didn't fix the leak bug.

BUG=400012
TEST=n/a
NOTRY=true

Review URL: https://codereview.chromium.org/460213002

git-svn-id: svn://svn.chromium.org/blink/trunk@180028 bbb929c8-8fbe-4397-9dbb-9b2b20218538

virtual/gpu/fast/canvas/canvas-createImageBitmap-colorClamping.html is less dirty after Skia change.


git-svn-id: svn://svn.chromium.org/blink/trunk@180027 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=400387
R=ojan@chromium.org,esprehn@chromium.org,leviw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/459463003

git-svn-id: svn://svn.chromium.org/blink/trunk@180026 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow up CL to r178818, adding a comment why the order is important.

BUG=364377
NOTRY=true

Review URL: https://codereview.chromium.org/460053002

git-svn-id: svn://svn.chromium.org/blink/trunk@180024 bbb929c8-8fbe-4397-9dbb-9b2b20218538

PopupMenu::disconnectClient accesses some objects, and they might be destructed
when a RenderMenuList object is garbage collected. We should call
PopupMenu::disconnectClient earlier.

This fixes SelectPopupMenuStyleTest.PopupListBoxRTLRowWidth in Oilpan.

BUG=402439

Review URL: https://codereview.chromium.org/459313002

git-svn-id: svn://svn.chromium.org/blink/trunk@180023 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Have DocumentOrderedMap API deal with AtomicString type instead of StringImpl*
as it would be unsafe to use if the StringImpls were not atomized.

This basically moves the AtomicString::impl() calls from the DocumentOrderedMap
API call sites to the DocumentOrderedMap implementation. This simplifies the
call sites a bit and makes the DocumentOrderedMap code look safer.

R=morrita@chromium.org, adamk@chromium.org

Review URL: https://codereview.chromium.org/459203004

git-svn-id: svn://svn.chromium.org/blink/trunk@180022 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=kouhei@chromium.org,hajimehoshi@chromium.org
BUG=400588,402742,402743

Review URL: https://codereview.chromium.org/456863004

git-svn-id: svn://svn.chromium.org/blink/trunk@180021 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch is part 1 of merging the CSS .in files (part 2 is also up, at
https://codereview.chromium.org/415613002). Having a single .in file for
listing CSS properties makes it both easier to add new properties and
add new property flags.

I've renamed some of the StyleBuilder flags to make it more obvious what
these refer to and also re-ordered CSSProperties.in in some sort of
sensible fashion (see part 2 patch for what this will look like with the
remaining properties); the high/low priority split doesn't make too much
sense right now but will of course make sense once CSSPropertyNames.in
is merged into the same file.

BUG=396992
TBR=pfeldman

Review URL: https://codereview.chromium.org/410953002

git-svn-id: svn://svn.chromium.org/blink/trunk@180020 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r179509 incorrectly converted the master map. It didn't
include the @ToT Blink group.

TBR since this is causing the flakiness dashboard to be
down for the blink bots.

TBR=szager@chromium.org

Review URL: https://codereview.chromium.org/462963003

git-svn-id: svn://svn.chromium.org/blink/trunk@180019 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=180004

BUG=377445
TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/463763002

git-svn-id: svn://svn.chromium.org/blink/trunk@180018 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Including polymer.html in karma.conf.js makes platform.js throw
"Possible attempt to load Polymer twice" when a polymer component is imported.

I think this is because polymer.html is loaded twice: once by karma and again on
the first time that the browser encounters a <link href="polymer.html">. I believe
this might happen because of the way karma includes files by appending some kind
of hash to them.

If polymer.html is parsed twice, then the <script src="polymer.js"> also runs twice.

This CL adds karma-loader.html which imports polymer.html (so it should avoid
importing it a second time) and adds a listener for polymer-ready, which I didn't
think was necessary but seems to resolve some flakiness in karma.

BUG=400387
R=ojan@chromium.org,esprehn@chromium.org

Review URL: https://codereview.chromium.org/459223002

git-svn-id: svn://svn.chromium.org/blink/trunk@180017 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If the file doesn't exist in the repo, we should return a 400
instead of throwing an error and returning a 500.

TBR since this is causing 500s on the live server.

TBR=szager@chromium.org

Review URL: https://codereview.chromium.org/459243004

git-svn-id: svn://svn.chromium.org/blink/trunk@180016 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because <img> scale its contents on resize, incremental invalidation
doesn't apply to it. Force full invalidate if the image content is
resized during layout.

BUG=397939
TEST=fast/repaint/image-resize.html
TEST=fast/repaint/percent-size-image-resize-container.html

Review URL: https://codereview.chromium.org/458373003

git-svn-id: svn://svn.chromium.org/blink/trunk@180015 bbb929c8-8fbe-4397-9dbb-9b2b20218538