- 20 May, 2015 37 commits
-
-
newt authored
Includes this change: - Start proguarding google play services. BUG=484934 Review URL: https://codereview.chromium.org/1143003002 Cr-Commit-Position: refs/heads/master@{#330687}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#330686}
-
sammc authored
Review URL: https://codereview.chromium.org/1127993006 Cr-Commit-Position: refs/heads/master@{#330685}
-
Raymes Khoury authored
During destruction, pdfium may call back into the instance and access members. It would be better if this didn't happen but it isn't strictly wrong and may be necessary as it appears pdfium can run scripts at shutdown. BUG=485855 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1144923002 Cr-Commit-Position: refs/heads/master@{#330684}
-
tapted authored
When a navigation occurs and the omnibox is focused and fully selected, the replacement URL should also be fully selected. OmnboxViewMac currently does not do this. Use the same logic from void OmniboxViewViews::Update(). This makes Mac consistent with other platforms. Adds a cross-platform test to verify. BUG=471635 Review URL: https://codereview.chromium.org/1144853003 Cr-Commit-Position: refs/heads/master@{#330683}
-
rohitrao authored
Copies over the previous OWNER of this code, from before the code moved into net/extras/sqlite. BUG=None TEST=None Review URL: https://codereview.chromium.org/1143593007 Cr-Commit-Position: refs/heads/master@{#330682}
-
jrummell authored
blink was updated some time ago to use the new method, so this is simply a cleanup on unused code. TEST=compiles BUG= Review URL: https://codereview.chromium.org/1148523006 Cr-Commit-Position: refs/heads/master@{#330681}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/a65358c..8debd89 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1144933002 Cr-Commit-Position: refs/heads/master@{#330680}
-
jonross authored
Layer::GetTargetColor currently always checks the LayerAnimator for a target color. When the layer is not animating, the animator's defaults do not necessarily reflect the current state of the layer. This change updates Layer::GetTargetColor to return the current color if not animating. TEST=LayerOwnerTest, RecreateLayerSolidColorWithChangedCCLayerHonorsTargets, ran compositor_unittests, ash_unittests, views_unittests BUG=chrome-os-partner:40118 Review URL: https://codereview.chromium.org/1125283015 Cr-Commit-Position: refs/heads/master@{#330679}
-
mgiuca authored
BubbleFrameView: Replaced GetCloseButtonBounds with GetCloseButtonMirroredBounds. Now returns the RTL-mirrored bounds, which is necessary for the App Info dialog's FullSizeBubbleFrameView to correctly target events to the close button in RTL mode. BUG=474559 TEST=Change language to Arabic. Go to chrome://extensions; click "Details" on any extension. Click X button. Should close dialog. Review URL: https://codereview.chromium.org/1144853002 Cr-Commit-Position: refs/heads/master@{#330678}
-
oshima authored
BUG=chrome-os-partner:39397 R=marcheu@chromium.org Review URL: https://codereview.chromium.org/1146793002 Cr-Commit-Position: refs/heads/master@{#330677}
-
aurimas authored
BUG=406483 Review URL: https://codereview.chromium.org/1146453003 Cr-Commit-Position: refs/heads/master@{#330676}
-
thestig authored
Check for potential overflows in PDFResource::SearchString(). Review URL: https://codereview.chromium.org/1147883002 Cr-Commit-Position: refs/heads/master@{#330675}
-
yawano authored
This CL shows remaing space at the mount time in file manager. A CL to make file manager show latest remaing space will come as another CL. BUG=486396 Review URL: https://codereview.chromium.org/1140583005 Cr-Commit-Position: refs/heads/master@{#330674}
-
anthonyvd authored
BUG=462238 Review URL: https://codereview.chromium.org/1116353004 Cr-Commit-Position: refs/heads/master@{#330673}
-
ben authored
Move NativeViewport service into view_manager. This is a file move only. Further merging will happen subsequent to this CL. TBR=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/1131523007 Cr-Commit-Position: refs/heads/master@{#330672}
-
halliwell authored
WebGL render to texture is broken (random visual artifacts) on Chromecast. Disabling this extension appears to fix the problem. BUG= 489871 Review URL: https://codereview.chromium.org/1142273003 Cr-Commit-Position: refs/heads/master@{#330671}
-
amistry authored
BUG=467832 Review URL: https://codereview.chromium.org/972083002 Cr-Commit-Position: refs/heads/master@{#330670}
-
sunnyps authored
If we're not aggressive about expiring a retro frame (e.g. MISSED frames) then it's possible to enter a high latency mode often. PixelTestOutputSurface is used by the ui compositor in tests and we should not subtract the default estimated parent draw time from the deadline in that case. Doing so will cause MISSED frames to always expire in tests. BUG=469953 Review URL: https://codereview.chromium.org/1055113004 Cr-Commit-Position: refs/heads/master@{#330669}
-
yoshiki authored
BUG=480491 TEST=none TBR=xdai@chromium.org Review URL: https://codereview.chromium.org/1145873002 Cr-Commit-Position: refs/heads/master@{#330668}
-
hans authored
These broke in the last roll attempt, and weren't caught by ToT bots :( BUG=452726 Review URL: https://codereview.chromium.org/1125313007 Cr-Commit-Position: refs/heads/master@{#330667}
-
michaelpg authored
Always build Polymer 0.8 and 0.5. Polymer 0.5 should be removed in M45. BUG=483080 R=jlklein@chromium.org TEST=manual Review URL: https://codereview.chromium.org/1134753009 Cr-Commit-Position: refs/heads/master@{#330666}
-
xhwang authored
Also update MediaDrmBridge to use org.chromium.base.Log. See bug 472152. BUG=487435, 472152 TEST=Tested using a test certificate. We only get one key request instead of two, and playback works. Review URL: https://codereview.chromium.org/1145583003 Cr-Commit-Position: refs/heads/master@{#330665}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/90421e2..cda0078 TBR=hiroshige@chromium.org,szager@chromium.org,leviw@chromium.org Review URL: https://codereview.chromium.org/1134753010 Cr-Commit-Position: refs/heads/master@{#330664}
-
jdufault authored
BUG=489445 Review URL: https://codereview.chromium.org/1145833003 Cr-Commit-Position: refs/heads/master@{#330663}
-
enne authored
When LayerImpls scroll, their associated transform trees need to be updated so that they are correct. This fixes 17 of the 79 failing tests, when verification is turned on. R=ajuma@chromium.org,vollick@chromium.org BUG=481585 Review URL: https://codereview.chromium.org/1141353002 Cr-Commit-Position: refs/heads/master@{#330662}
-
miu authored
Adds a new FRAME_DURATION option to VideoFrameMetadata, which can be used by consumers of video frames to improve performance (e.g., encoding quality). This change also adds population of the new metadata by the desktop/tab capture pipeline, and consumption by Cast Streaming's software VP8 encoder. Having accurate frame duration information improves the encoder's ability to choose a compression quality level that better meets the target encode bitrate. Later changes will require this in order to compute resource utilization feedback signals (see bug for details). BUG=156767 Review URL: https://codereview.chromium.org/1146723002 Cr-Commit-Position: refs/heads/master@{#330661}
-
mbarbella authored
BUG=470777 Review URL: https://codereview.chromium.org/1143913003 Cr-Commit-Position: refs/heads/master@{#330660}
-
dtapuska authored
In release mode a DCHECK was compiled out and caused a crash; it was correctly asserting in the Debug builds. Change the DCHECK into a runtime check that throws an exception. This addresses the cluster fuzz crash. BUG=472058 TEST=out/Release/content_shell --dump-render-tree --use-gl=any --disable-gl-drawing-for-test file:///work/issues/472058/test.html Review URL: https://codereview.chromium.org/1140813007 Cr-Commit-Position: refs/heads/master@{#330659}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/9db912c..a65358c CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1146783002 Cr-Commit-Position: refs/heads/master@{#330658}
-
stanisc authored
This is an incremental fix for 438313 that addresses the two issues mentioned here: https://code.google.com/p/chromium/issues/detail?id=438313#c24 This issues are reproducible only with the alpha server with implicit permanent folders enabled. I added a test case for one of them - the out of order deletion which results in deleting the permanent folder for a datatype before some of the items of the same datatype. That occurs only in one particular corner case when a failed datatype need to be purged and re-downloaded. BUG=438313 Review URL: https://codereview.chromium.org/1139883007 Cr-Commit-Position: refs/heads/master@{#330657}
-
hans authored
Revert of do not hardcode -I/usr/include32 when cross-compiling (patchset #1 id:1 of https://codereview.chromium.org/1132853010/) Reason for revert: Looks like this broke some builds, where 'use_sysroot' isn't defined. See http://crbug.com/489783. Sounds like sbc has an alternative solution here: https://codereview.chromium.org/1142793003/ Original issue's description: > do not hardcode -I/usr/include32 when cross-compiling > > When we cross-compile, we do not want any /usr/include paths as that will > conflict with our own system headers. Disable the hardcoded path when we > have an active sysroot. > > BUG=chromium:488360 > > Committed: https://crrev.com/58b42a0c48127c60baad7ea79ea0e5576c6e1d0b > Cr-Commit-Position: refs/heads/master@{#330514} TBR=jochen@chromium.org,cjhopman@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org,scottmg@chromium.org,thakis@chromium.org,vapier@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488360,489783 Review URL: https://codereview.chromium.org/1147793003 Cr-Commit-Position: refs/heads/master@{#330656}
-
sievers authored
Make this work independent for MsgLoop vs. ChildThread destruction order and simplify the code a bit. BUG=465397 Review URL: https://codereview.chromium.org/1140633005 Cr-Commit-Position: refs/heads/master@{#330655}
-
pavely authored
Before this change InvalidationService CHECKs that object id is only registered with one handler. This causes browser crash when object id is received from network already registered. Solution is to let each component that uses InvalidationService decide how to react to duplicate registration. In this change: - InvalidationService::UpdateRegisteredInvalidationIds doesn't CHECK inside, but returns boolean that indicates if update was successful. - All places that call this function do CHECK to preserve existing behavior. - Internal implementations and tests are updated accordingly. BUG=475941 R=maniscalco@chromium.org Review URL: https://codereview.chromium.org/1146533005 Cr-Commit-Position: refs/heads/master@{#330654}
-
leviw authored
Revert of bluetooth: Move testing IPC from BluetoothDispatcher to BlinkTestRunner (patchset #2 id:250001 of https://codereview.chromium.org/1125133005/) Reason for revert: Broke a bunch of Layout Tests. Here's an example: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=virtual%2Fstable%2Fanimations-unprefixed%2Fanimation-events-prefixed-04.html STDERR: ==28151==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000050 (pc 0x000006a00bd0 bp 0x7fff171be890 sp 0x7fff171be880 T0) STDERR: #0 0x6a00bcf in content::BluetoothDispatcherHost::SetBluetoothAdapterForTesting(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/browser/bluetooth/bluetooth_dispatcher_host.cc:63:43 STDERR: #1 0x4e5d9d in OnSetBluetoothAdapter content/shell/browser/layout_test/layout_test_message_filter.cc:171:3 STDERR: #2 0x4e5d9d in DispatchToMethodImpl<content::LayoutTestMessageFilter, void (content::LayoutTestMessageFilter::*)(const std::__1::basic_string<char> &), std::__1::basic_string<char> , 0> base/tuple.h:252:0 Original issue's description: > bluetooth: Move testing IPC from BluetoothDispatcher to BlinkTestRunner > > This patch removes the testing IPC from BluetoothDispatcher and > BluetoothDispatcherHost. > > This patch also changes the way the mock BluetoothAdapter was set in > BluetoothDispatcherHost. Instead of receiving an IPC to set the adapter, > BluetoothDispatcherHost exposes a function to directly set the adapter. > This function is used by LayoutTestSupport to set the adapter. > > Mock adapter flow before: > BlinkTestRunner -> LayoutTestSupport -> BluetoothDispatcher --IPC--> > BluetoothDispatcherHost (Mock constructed here) > > After: > BlinkTestRunner --IPC--> LayoutTestMessages(Mock constructed here) -> > LayoutTestSupport -> BluetoothDispatcherHost > > This is the first of two patches to remove testing from BluetoothDispatcher > and BluetoothDispatcherHost: > > [1] This patch. > [2] http://crrev.com/1132943002 > > BUG=436284 > > Committed: https://crrev.com/3f7142d0acf5e930743cbe5d754084c464ac3c85 > Cr-Commit-Position: refs/heads/master@{#330647} TBR=jam@chromium.org,scheib@chromium.org,tsepez@chromium.org,ortuno@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=436284 Review URL: https://codereview.chromium.org/1142303002 Cr-Commit-Position: refs/heads/master@{#330653}
-
zmo authored
Revert of Temporarily disable a webgl conformance test on D3D9 only. (patchset #1 id:1 of https://codereview.chromium.org/1135333004/) Reason for revert: Bug fixed. Re-enabling the test. Original issue's description: > Temporarily disable a webgl conformance test on D3D9 only. > > BUG=488552 > TEST=webgl conformacne with D3D9 backend > R=kbr@chromium.org > NOTRY=true > > Committed: https://crrev.com/4fbdae9877d2b4775efa0dffdaa9c16ed6689c75 > Cr-Commit-Position: refs/heads/master@{#330138} TBR=kbr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488552 Review URL: https://codereview.chromium.org/1124083006 Cr-Commit-Position: refs/heads/master@{#330652}
-
erikchen authored
BUG=488146 Review URL: https://codereview.chromium.org/1130773004 Cr-Commit-Position: refs/heads/master@{#330651}
-
- 19 May, 2015 3 commits
-
-
brettw authored
Revert of Fix missing GN dependencies. (patchset #4 id:60001 of https://codereview.chromium.org/1128163007/) Reason for revert: Broke Windows: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/1568/steps/compile/logs/stdio Original issue's description: > Fix missing GN dependencies. > > Fixes some cases where a dependency between a target's inputs and outputs exists without an explicit dependency. > > json_schema_api.gni was generating wrong names, this was fixed. > > mojo_application_package.gni was fixed to generate unique names (just a bug I noticed in passing) and support the testonly flag, which is necessary when I added the correct dependency. > > The rest of the cases are just adding deps or making existing deps public so that the ability to depend on the target's outputs is passed to dependents. > > BUG=487897 > > Committed: https://crrev.com/eadea21096be21b0d74c93f5b1a0ae6a9cc057d7 > Cr-Commit-Position: refs/heads/master@{#330636} TBR=dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487897 Review URL: https://codereview.chromium.org/1137693006 Cr-Commit-Position: refs/heads/master@{#330650}
-
yusufo authored
Add a layout and constants for supporting a menu item with three icons in it. BUG=478984 Review URL: https://codereview.chromium.org/1138993011 Cr-Commit-Position: refs/heads/master@{#330649}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/b1dbd0d..90421e2 TBR=hiroshige@chromium.org,szager@chromium.org,leviw@chromium.org Review URL: https://codereview.chromium.org/1138823007 Cr-Commit-Position: refs/heads/master@{#330648}
-