GitLab

- The standalone headless_shell needs to invoke the Seatbelt server
  in its child processes.
- The --headless flag in Chrome needs to set up the CHILD_PROCESS_EXE
  override for finding the Helper.app. The --headless flag was incorrectly
  spawning the main app executable rather than the helper.

Bug: 866606, 689306
Change-Id: I0e4fec109fad5577263059fd0b62dea3bb966860
Reviewed-on: https://chromium-review.googlesource.com/1148478Reviewed-by: David Vallet <dvallet@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577949}

Fixes a few small format string bugs and makes the windows library
configuration #defines more friendly for chromium builds.

Based on original CL: https://codereview.chromium.org/2730473002

BUG=724399,b:70905156

Change-Id: If54c6cfc5c508744d2ee18f251677b2456acda72
Reviewed-on: https://chromium-review.googlesource.com/1145626
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577948}

The refresh token is updated to a new valid one in case of reauth. In this case
the old and the new refresh tokens have the same device ID.

When revoking a refresh token on the server, Gaia revokes all the refresh tokens
that have the same device ID.

This CL avoid revoking the old refresh token when to avoid Gaia revoking the new
token soon after a reauth.

Bug: 865189
Change-Id: I9c2a64f30e14a5376c530f3b511c212b70738f3a
Reviewed-on: https://chromium-review.googlesource.com/1145073
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577947}

On touch adjustment, we do a point-base hit test after the rect-base one
to make sure we find the correct target. This cl changes the point-base
hit test from the iframe to the root frame. Because when we have iframe
overlap by other elements, rect-base hit test might result an incorrect
target in the iframe. In-frame hit-test cannot find the correct target
that is outside the iframe. So, we should do the point-base hit-test on
root-frame to find the correct target.

Bug: 864849
Change-Id: Ib176a68e5c51eba40c504ad90190bec7fb66dccb
Reviewed-on: https://chromium-review.googlesource.com/1145477Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577946}

Bug: 806868
Change-Id: Id1204fad26029f7358d9628590d713b9c2af01f3
Reviewed-on: https://chromium-review.googlesource.com/1143895Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577945}

This is a preparation CL to remove animations when populating
the history TableView and when performing a search.

In order achieve that we need to reload all the content of the
TableView instead of inserting/removing specific entries. This
causes previously selected items to deselect when searching.
For this reason there's no purpose to searching while editing
is enabled, furthermore selecting the search bar will deselect
selected items, which can be frustrating for the user.

This CL disables the searchBar while the table is on Edit mode.
The user can still search something and edit the results of the
query, but it can't perform a new search query before exiting
edit mode. This is the behavior of the legacy implementation.

Screenshots:
Enabled
https://drive.google.com/open?id=1ZdplK968U4XgBE1cFSB9L4scblJwFeBN
https://drive.google.com/open?id=1dH47e9tPHmDd2eUuOUVIt-W3Nay4v_A1

Disabled
https://drive.google.com/open?id=1Gp4IXNawohaZnlwSnQTSJ0LLbvaFW6Iw
https://drive.google.com/open?id=1aDPPjOd3DqX99vncP2wNXNHx_XKRyGhM

Bug: 859736
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I705a936f8bb339ab29a1431d7d4d969d77337d71
Reviewed-on: https://chromium-review.googlesource.com/1148890Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577944}

Bug: webrtc:9532
Change-Id: Ia22b7976dc520ff968289d805de2ccc08635eb71
Reviewed-on: https://chromium-review.googlesource.com/1144149Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577943}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/58ea46ee..d729403c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I06b66ca92085d13d3fea0a10fa38da5161d5f601
Reviewed-on: https://chromium-review.googlesource.com/1149990Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577942}

All channels of Chrome should use the same preferences. This
updates two preference accesses that were not updated in the
original change.

BUG=866750, 831577

Change-Id: Ibd0f8d2895027eb85772b3f5308ffebaef3aff32
Reviewed-on: https://chromium-review.googlesource.com/1148473Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577941}

Remove Cocoa dependency from WebTextfieldTouchBar by moving
it from TabContentsController to BrowserWindowTouchBarController.

Hook up BrowserWindowTouchBarController to
AutofillPopupControllerImplMac on MacViews so that the
credit card touch bar can be updated.

Move the the logic that listens to WebContent changes to the
BrowserWindowTouchBarController. When the WebContents has
changed, BrowserWindowTouchBarController will update the
WebContents in BrowserWindowDefaultTouchBar and
WebTextfieldTouchBarController.

Modified SuggestedTextTouchBarController so that when its
WebContents has changed, it'll observe the new WebContents.

Bug: 856391
Change-Id: I9c29a371a0b38eb608bf8e32521abe22d5c664e0
Reviewed-on: https://chromium-review.googlesource.com/1135829Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577940}

Bug: 775415
Change-Id: I1184b1e058c80151cfb8226edfcb84558057bbb4
Reviewed-on: https://chromium-review.googlesource.com/1150150Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577939}

This CL eliminates NetworkingConfigDelegate by providing the
captive portal provider info in NetworkState directly.

This CL also:
* Adds NetworkState::ProviderInfo struct for both VPN and captive portal
* Renames NetworkingConfigDelegateChromeosTest ->
  NetworkingConfigChromeosTest since it wasn't testing the delegate
  per-se, but the functionality it was providing.

Bug: 651157

For trivial rename in arc_net_host_impl.cc:
TBR=hidehiko@chromium.org

Change-Id: Iab872220aaedbcf27b4228581931e39c43dbab97
Reviewed-on: https://chromium-review.googlesource.com/1141210Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577938}

https://skia.googlesource.com/skia.git/+log/42c1c03334c7..b284280be4cc


git log 42c1c03334c7..b284280be4cc --date=short --no-merges --format='%ad %ae %s'
2018-07-25 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 096c5296c3b0..2160821e16db (1 commits)
2018-07-25 mtklein@chromium.org temporarily disable t8888 config on *SAN bots
2018-07-25 benjaminwagner@google.com Revert "Blacklist hanging test."


Created with:
  gclient setdep -r src/third_party/skia@b284280be4cc

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I0b95381d5167f1c034b7c481cb00ac567652dabb
Reviewed-on: https://chromium-review.googlesource.com/1150049Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577937}

Currently calls to FindPolicyByGuidAndProfile produce an error when
called with an empty profile path. There are several places where this
can occur, but we recently added one to the system tray UI:

https://chromium-review.googlesource.com/c/chromium/src/+/1101204/12/ash/system/network/network_list.cc#813

Rather than ensure that we test for an empty profile path everywhere
(which just indicates a non favorite/saved network), just return nullptr
with no error when the path is empty.

Bug: None
Change-Id: I692babc10ae2472e8fa5dbfef1c8be170cc841b2
Reviewed-on: https://chromium-review.googlesource.com/1149096Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577936}

ChildProcessCrashObserver.java serves a similar purpose as
CrashDumpManager.java did (which it will replace), except without the
need (or ability) to check for a minidump on the filesystem. Instead of
a minidump path, the process ID of the crashed child is passed to the
callback which it can use to identify the correct crash dump.

Bug: crashpad:30
Change-Id: I718e653acfa35b14ebaa17d0e8c76804f9856dfb
Reviewed-on: https://chromium-review.googlesource.com/1150202Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577935}

https://webrtc.googlesource.com/src.git/+log/e095b819400f..e71d1bb7fc22


git log e095b819400f..e71d1bb7fc22 --date=short --no-merges --format='%ad %ae %s'
2018-07-25 nisse@webrtc.org Delete obsolete file api/videosourceinterface.h.
2018-07-25 titovartem@webrtc.org Move g722 to proper third_party directory


Created with:
  gclient setdep -r src/third_party/webrtc@e71d1bb7fc22

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I08c055b641e6c5040002b2ff1ff3c2e9730d59d9
Reviewed-on: https://chromium-review.googlesource.com/1150047Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577934}

NestedSubscription is a ref-counted object, and its first reference used to
be made by base::BindOnce in its constructor. The reference is passed to
another thread, and released when the callback instance is destroyed.

However, if the PostTask failed or the posted task ran soon before the
constructor finished to construct the NestedSubscription instance, the
ref count is decremented to 0, and `new NestedSubscription` may return
a stale pointer.

This CL adds a static constructor to avoid that by splitting the ref-count
related set up out of the constructor.

Bug: 866456
Change-Id: Idf03b31b95b4a7ddee81fdebff78a594e52a62f8
Reviewed-on: https://chromium-review.googlesource.com/1149762Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577933}

In some languages, the translation is too long for the bottom toolbar to fit it and the "edit" button without truncating. Since we have little control over BarButtonItems, we should cap the length at 16em to allow for both to be readable.

Bug: 841289
Change-Id: I19e76002baac55c2ed3099e54dfb504862662597
Reviewed-on: https://chromium-review.googlesource.com/1148996Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577932}

Some methods like HttpURLConnection.getHeader() hide IOExceptions,
but later calls to getResponseCode() would then throw unexpected
IllegalStateExceptions. Instead getResponseCode() should rethrow
the previously hidden IOException.

Bug: 866911
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Icc533d4a69875af5570a6f793463754d1bf477ab
Reviewed-on: https://chromium-review.googlesource.com/1148475Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577931}

CrashMetricsReporter::CrashDumpProcessed can be called multiple times
for the same process; see the comment in
ChildProcessCrashObserver::OnChildExit.

Previously we avoid duplicating collecting stats by checking that if
the dump is missing, meaning it has already been crashed before.

This mostly still works except for NotifyObserver call which is still
called under kMissingDump, so fix that.

Change-Id: I2145a0df8c604739f86fb9ab9cecf845168dcbfe
Reviewed-on: https://chromium-review.googlesource.com/1148558Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577930}

This patch manually snaps the omnibox dropdown popup widget window to
the physical pixel grid. On CrOS the popup is treated as a top level
window which is by default snapped to the root window.

This patch also lazily marks the root windows as snapped. The root
windows are snapped by default so marking them snapped makes sense.

Bug: 843250
Change-Id: I1dd20ea57522e4987d23ba7dcaa3ae891bbc7182
Component: Omnibox popup, desktop window tree host
Reviewed-on: https://chromium-review.googlesource.com/1139078Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577929}

Makes the method use TimeDelta instead of double to represent
duration.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id95aface04fa2b72bc919fd4ab52af062908f8df
Bug: 763980
Reviewed-on: https://chromium-review.googlesource.com/1140355Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577928}

This CL lands part of internal change 201519764.  The rest of that
change has been merged in https://crrev.com/c/1121700 (reviewed at
https://crrev.com/c/1121285).

Bug: 488484
Change-Id: I78b225c43af626eb7c6e3054b85e44018387b8cb
Reviewed-on: https://chromium-review.googlesource.com/1146664
Commit-Queue: Yang Song <yasong@chromium.org>
Reviewed-by: Yang Song <yasong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577927}

Currently the run_tests_rebaseline.sh script does not work as
intended due to the switch to AndroidJUnitRunner. This CL fixes
the script and makes it possible to rebaseline webview layout
tests as originally intended.

Change-Id: If055a4460925ea5e18d3996d927c8596b9027a7a
Reviewed-on: https://chromium-review.googlesource.com/1150160Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577926}

Bug: 847948,852341
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I77f63093d642a51193787641568a639f80d5c5e1
Reviewed-on: https://chromium-review.googlesource.com/1148796
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577925}

Previously I assumed -webView:didReceivedAuthenticationChallenge callback
is always called for the navigation associated with the current
WKWebView.URL value. In testing, it turns out in back/forward navigation,
this callback may be triggered for a subresource on the previous item
after WKWebView.URL has already been updated to the new item. As a result,
this DCHECK is incorrectly triggered when navigating back to NTP from a
web page before the web page finishes loading completely.

From code inspection, the implementation of this delegate call doesn't
depend on states associated with self.currentNavItem. This scenario
already exists between web pages. So the DCHECK is not protecting any
meaningful state corruption.

Bug: 864525
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I02a1678721e2db59ed1f288c9e4ec7139efc8632
Reviewed-on: https://chromium-review.googlesource.com/1147328Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577924}

Adds flags to the data.ndjson file, and exposed the information in the
UI using custom highlighting options. The UI will additionally list the
flags in the symbol infocard.

Bug: 847599
Change-Id: If2c7b7f5147296cf13e0c0ef9c36d6748820e42f
Reviewed-on: https://chromium-review.googlesource.com/1148795
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577923}

There are a few small issues with the code right now that prevent it
from linting cleanly. This change, while not affecting the
functionality, will make it much easier to catch linting errors in the
future.

Change-Id: Ib5284b025e7bc385810a2c171d36bef478fe83f5
Reviewed-on: https://chromium-review.googlesource.com/1150162Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577922}

Increase EVN to 70.0 for crostini. From now on, EVN major is reved after
each branch point to sync with the Chrome release milestone until we
migrate to DLC.

BUG=chromium:867062
TEST=None

Change-Id: Ie970bc285e7225167054caac8ab8f0ac60f7a64a
Reviewed-on: https://chromium-review.googlesource.com/1148943Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577921}

The accessibility code for Aura on Linux was using the ATK_ROLE_EMBEDDED
role for elements with the role ax::mojom::Role::kApplication so that
it would not apply to ARIA applications. To be consistent with other
applications, ATK_ROLE_APPLICATION is more appropriate. We only use this
when the element is the root of the accessibility tree.

TEST=accessibility_unittests --gtest_filter=AXPlatformNodeAuraLinuxTest.*

Bug: 867006
Change-Id: I6c64b142cf3307c906f73235ed8247e828cd2394
Reviewed-on: https://chromium-review.googlesource.com/1148397Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577920}

This CL adds a null check for the last committed NavigationEntry to fix
a crash in CaptivePortalTabReloader.

Bug: 857002
Change-Id: Ia26bd420cbee80958b3a74937ade9efb764ed03a
Reviewed-on: https://chromium-review.googlesource.com/1146657
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577919}

The function's main loop is supposed to halt after timeout, but contains
a branch that continues directly without checking timeout, which leads
to renderer hang in some edge/buggy cases.

This patch implements yoichio's idea (https://goo.gl/EQED8Y) to fix the
issue, by rewriting loop conditions and ensuring timeout checking in
all branches.

Note: no test in this patch, because the only repro case we have hits
a DCHECK earlier before entering the problematic branch.

Bug: 862648
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I050909bd625f122c0df7ed905184c32e133170ce
Reviewed-on: https://chromium-review.googlesource.com/1148645Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577918}

The level attributes specifies the hierarchical level of the element.
This is used for HTML heading elements.

TEST=accessibility_unittests --gtest_filter=AXPlatformNodeAuraLinuxTest.*

Bug: 866612
Change-Id: If3e1d5192dc6d0749bdaffda203d4539ea02bf63
Reviewed-on: https://chromium-review.googlesource.com/1150144Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577917}

This has several benefits:
1) No longer generating the authentication token for each benchmark results
too early. Before this CL, we generate authentication for every benchmark
results first, then process each perf results & upload them. With such logic,
the last benchmark to be uploaded may have token generated for a long period of
time.
2) Enables generating a new token for every retry attempt in
core/results_dashboard.py.

Bug:864565
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I8b2d681efdaa241a8af19a7ffbf126523caa12a9

NOTRY=true # CQ flakes

Change-Id: I8b2d681efdaa241a8af19a7ffbf126523caa12a9
Reviewed-on: https://chromium-review.googlesource.com/1150080
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577916}

This cl places the responsibility of determing the hit test component
on individual Views, which gets rid of some ash/ dependencies and
reduces code duplication.

The one behavioral change in classic Ash is that padding parts of
the hosted app button container (e.g. the medium sized space between
the menu button and the minimize button) are now HTCAPTION, i.e. can
be used to drag the frame rather than do nothing.

Bug: 854704
Change-Id: Ia290a42652a9acbf9b4b01c86941e8d2bdcadc48
Reviewed-on: https://chromium-review.googlesource.com/1145545Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577915}

Flatten DocumentThreadableLoader into the base class, ThreadableLoader.
Same for DocumentThreadbleLoaderClient and DocumentThreadableLoaderTest.

Bug: 706331
Change-Id: Ib15340f83bc38e6c0427d829cb0490f7b3ecd2c5
Reviewed-on: https://chromium-review.googlesource.com/1045522
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577914}

This is a reland of 6ec9b32f

Mac Retina bots were down when rebaselined last time, and
they started failing when back.

Original change's description:
> [LayoutNG] Remove spaces before <br> to avoid crbug.com/40634
>
> This patch removes spaces before <br> because the images do
> not match due to crbug.com/40634, which LayoutNG does not
> have the problem.
>
> TBR=eae@chromium.org
>
> Bug: 591099
> Change-Id: I8f0770f8911ce2d5c6f9e37ff90752011b84cb49
> Reviewed-on: https://chromium-review.googlesource.com/1142050
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576333}

TBR=eae@chromium.org

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I2243c930a20a1b2404854df09fbdeec4a33c9807
Reviewed-on: https://chromium-review.googlesource.com/1149640Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577913}

This CL adds a version number to the Local Site Characteristics DB and
reset its content if it already exists.

Bug: 773382, 866540, 867027
Change-Id: I0a68ad044456ab67c39a3f1537e9ff9534920d47
Reviewed-on: https://chromium-review.googlesource.com/1147113
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577912}

If the triggering element is no longer valid, update it, before
checking if a triggering a refill is necessary. While updating the
old element, check for nameless forms and unowned elements as well.
Also, if the triggering element is not filled, triggering a refill
is necessary.
Tests added.

Fixes (Desktop): etsy, staple and ysl.

Bug: 863575
Change-Id: Id9a775a31a345c5c722687df5958c55b662ebbfd
Reviewed-on: https://chromium-review.googlesource.com/1145486Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#577911}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/09f0990a2db0..cb29fbd231d6


git log 09f0990a2db0..cb29fbd231d6 --date=short --no-merges --format='%ad %ae %s'
2018-07-25 mikenichols@chromium.org cbuildbot_launch: Wrap duration with per instance timing metric.


Created with:
  gclient setdep -r src/third_party/chromite@cb29fbd231d6

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7e5fb32ce11a19647fa35aac7ca1c89814d7604b
Reviewed-on: https://chromium-review.googlesource.com/1150046Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577910}