GitLab

Add loading state UI to activation code, confirmation code, and profile
discovery pages.

Add default profile image to profile discovery page.

Screenshots:
https://screenshot.googleplex.com/B7TLNiG56hJbZEF.png
https://screenshot.googleplex.com/3EdZ4PYUNj2cbKu.png
https://screenshot.googleplex.com/9M9YhorePsHxQiX.png

Bug: 1093185
Change-Id: I5d69077dda0969b72c040b7f3e751402b88aa0ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628014Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Gordon Seto <gordonseto@google.com>
Cr-Commit-Position: refs/heads/master@{#843726}

https://android.googlesource.com/platform/external/perfetto.git/+log/704a1aa4c802..94ca9a9578a7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I75479174422f8a9707ca656f2a5dcd1eb32ca2ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628894Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843725}

Instead of HoldingSpaceTrayIconPreview owning the image layer directly,
delegate the layer ownership to a ui::LayerOwner. Unlike
HoldingSpaceTrayIconPreview, LayerOwner has logic to recreate the layer
when required. For example, when the layer tree was copied during
transition to tablet mode, the HoldingSpaceTrayIconPreview layers were
just moved to the new layer, causing the layer copy shown during the
tablet mode transition not to have item previews.

BUG=1166013

Change-Id: I17322043167e3275d6c9297617c90de834fb912e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629029
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#843724}

Moves AccountManagerAsh to chromeos/components/account_manager to
prepare the upcoming merge of AccountManagerFacade implementations.

This CL moves AccountManagerAsh's ownership from AshChromeServiceImpl to
chromeos::AccountManagerFactory. Subsequent CLs will change
account_manager_facade_factory_ash.cc to instantiate
AccountManagerFacadeImpl instead of AccountManagerFacadeAsh (which will
be removed).

Bug: 1161699
Change-Id: I1a0dfb3ed7034b2ee8fa3fae3741f4d1555f8a27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616353Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843723}

These histograms are still used for tracking regressions for heavy
ad intervention.

Bug: 1156208,1156210,1156211,1156212
Change-Id: I17067bfffa6b8bb143bae85ce475ef37a80fa7e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622318Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843722}

This CL ensures that the PersonalDataManager is fully loaded before
tests start executing. Hopefully, this reduces some of the flakiness.

Also it fixes some blocked IO access which was not noticed because the
tests were disabled.

Bug: 1162474,1078506,500491,935629,1090343,281541
Change-Id: Ib9595484bb790305a84c2a389db66ec86ff2e8e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627369
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#843721}

This CL changes the default profile name used for enterprise profiles
created through the new signed-in profile creation flow. The name
changes from "Work" to "<account-domain>.com".

The profiles created with SAML accounts are still named as "Work".

Bug: 1166712
Change-Id: I1edbe953c3c0857f6c0a4899f2f1120a313e9220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627404
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843720}

Bug: 1153766
Change-Id: I0a546ea960d7b344f408c3dc4a2a8ac42bb930e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626919Reviewed-by: Travis Skare <skare@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843719}

This CL adds logic in StandaloneTrustedVaultBackend to support device
registration before vault keys are available; it also allows to follow
very first key rotation, when there are no vault keys locally available,
but device was registered.

Bug: 1094326
Change-Id: If238944a15db550938fc48b9acf3e37bbd7f0e18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624650
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843718}

(CL series step 3/3)
Performance of initial load time is noticeably reduced with this
change. Unfortunately have not been able to get exact measurements,
because DevTools is not available on PDF Viewer's initial load, and
the Performance tab can't be leveraged.

The main PDF Viewer bundle can be split further to a main and lazy
part in a follow up, to reduce initial load time even more. As of
this writing pdf_viewer_wrapper.rollup.js amounts to 263K on Linux
and 291K on CrOS.

Bug: 1163956
Change-Id: Idef64e8c640d81469b643f4c4d231196cbd4d659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625607Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843717}

Example config in "document_policy_features.cc":
    {
      name: "DefaultValueFeatureForTest",
      document_policy_name: "_reserved",
      value_type: "Bool",
      default_value: "true",
      depends_on: [],
      default_value_behind_flag: [
        ["PaintHolding", "false"],
        ["ScriptStreaming", "true"],
      ]
    },

Generated output:
const DocumentPolicyFeatureInfoMap& GetDocumentPolicyFeatureInfoMap() {
  static const base::NoDestructor<DocumentPolicyFeatureInfoMap> feature_info_map([] {
    DocumentPolicyFeatureInfoMap map({        {
          mojom::DocumentPolicyFeature::kDefaultValueFeatureForTest,
          {
            "",
            PolicyValue::CreateBool(true)
          }
        }, ...});

        if (base::FeatureList::IsEnabled(features::kPaintHolding)) {
          map.insert_or_assign(
            mojom::DocumentPolicyFeature::kDefaultValueFeatureForTest,
            DocumentPolicyFeatureInfo {
              "",
              PolicyValue::CreateBool(false)
            }
          );
        } else if (base::FeatureList::IsEnabled(features::kScriptStreaming)) {
          map.insert_or_assign(
            mojom::DocumentPolicyFeature::kDefaultValueFeatureForTest,
            DocumentPolicyFeatureInfo {
              "",
              PolicyValue::CreateBool(true)
            }
          );
        }
    return map;
  }());
  return *feature_info_map;
}

Bug: 1166698
Change-Id: Ib0bf5905ddcccface2673486181616662c6e2b7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534612
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843716}

https://android.googlesource.com/platform/external/perfetto.git/+log/94ca9a9578a7..320b6dfbe5e4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ie9f6e5ec15a53dc954e57b37cf8f893de8533508
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628023Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843715}

Roll Chrome Linux PGO profile from chrome-linux-master-1610625483-0ee558e7111df5b3a3b368fd27939cbeb6a581b3.profdata to chrome-linux-master-1610647094-405a32bcf15e5a84949640f99f84a5b9f61e2f2e.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I1affa4edc3d915f3fcaeacdea71ab40f4105d91a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629888Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843714}

This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.

Bug: 1101837, 1164001
Change-Id: I398d7daba3b2c38884b1d28db8548ffd84677edd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627367
Owners-Override: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843713}

This allows embedders to define custom helper processes. They can define
the path to those by implementing ContentClient::GetChildPath(). For now
this is macOS only as the first place we need it is for macOS system
notifications.

Also updates the used message pump for services that do not run in a
sandboxed environment to use an NSApplication loop. This is necessary
to receive activation events from system notifications.

This CL is step 1 taken from rsesek@s prototype CL: crrev.com/c/2516122

Bug: 1127306
Change-Id: Iea2760b3daaa94bd797002be494c985abe8e78e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625882
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843712}

Chrome is about to switch to the TRACE_EVENT macro implementation
provided by Perfetto. The new implementation requires trace event
statements to be terminated by semicolons, so this patch modifies the
codebase to add semicolons where they were previously left out.

No functional changes.

Bug: 1006541
Change-Id: Ib3bc7a006ba42ff2d9065b80a61067cab82c1fda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628993
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843711}

In the PDF viewer, the viewport uses goToPageAndXY() to navigate inside
the document, which takes in-screen coordinates as x and y input. The
parameters we get from FPDFDest_GetVieware() are directly from the named
destination, which uses the in-page coordinates.

However, these in-page coordinates are sent to the viewport for
navigation without getting transformed into in-screen coordinates, which
results in PDF viewer zooming in at the wrong region of the page for
FitR type named destination.

Since coordinate transformation is missing for all view fit types, this
CL adds a helper ParamsTransformPageToScreen() to handle the
transformation according to the view's fit type. (See Table 151 about
Destination syntax from PDF 32000-1:2008.)

Bug: 1136733
Change-Id: I811844260f2ea9b1a5244a178174691e85f2f96d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628492Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843710}

Rewrite a trace event to use the TRACE_DISABLED_BY_DEFAULT macro instead
of manually spelling out the disabled category prefix string.

Bug: 1006541
Change-Id: I2759162549bcb4c562b0f86a62f8e4340092f68e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627861
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843709}

FrameHostMsg_DidDeleteInProcessInstance becomes a message on
the PepperIOHost.

BUG=1157519

Change-Id: I05cd8c0faf86ddb27a9b9ac77a09239ff1e7fae8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625999
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843708}

Roll Chrome Mac PGO profile from chrome-mac-master-1610625483-a0e2f95e7a919a4bc7e74f0638f605fdfadfc75f.profdata to chrome-mac-master-1610647094-3e6a9456ec2a4877d37636e99663c09557aba29f.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Id8cf6e1e000232d6b13f34f038fe8d062721813a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626530Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843707}

:)

Change-Id: I0839f1dae395b051d912e97e107a2d9fb8a89eed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629662
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Auto-Submit: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843706}

If there is an active sync setup when then PeopleHandler shuts down, it
will CloseSyncSetup() which drops the SyncSetupInProgressHandle. When
destroyed, the SyncSetupInProgressHandle ends up notifying the prefs
service which then calls back to the PeopleHandler mid-destruction
if it has a subscription to the syncer::SyncService.

This will then cause a crash because the PeopleHandler tries to talk
to the RenderFrameHost and RenderFrame, which are also being shutdown
and the RenderFrame has already been destroyed.

R=dpapad@chromium.org

Bug: 1158869
Change-Id: I24ed8fb8699cdcea30845df01a5996910fb71d25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627994
Auto-Submit: danakj <danakj@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843705}

Perform 1 drm commit consisting of all displays being modeset/disabled
together.
This guarantees that the kernel is aware of the states of all displays
at the same time, especially in case of inter-dependency.

ScreenManagerTest.{CheckForSecondValidController,CheckMultipleControllersAfterBeingDisabled}

BUG: b/172069469, b/168753412
TEST: modesetting kohaku with external display,
Change-Id: I4bb5b253eda793cc5807ab0000cc5e14854dc3d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551490Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Cr-Commit-Position: refs/heads/master@{#843704}

TBR: dominickn@chromium.org
Bug: 1166410
Change-Id: Ie498f6051ce491cce14e9f99977827a2646e9913
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629909Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843703}

This reverts commit 7452904e.

Reason for revert: AwAutofillTest failures, see https://ci.chromium.org/ui/p/chromium/builders/ci/android-pie-x86-rel/3610/overview

Original change's description:
> Autofill: Add fieldtrail testing for AndroidAutofillQueryServerFieldTypes
>
> Bug: 1151542
> Change-Id: I25545f36d588ca926ce1de9514ae919f3f441a64
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628040
> Commit-Queue: Weilun Shi <sweilun@chromium.org>
> Reviewed-by: Weilun Shi <sweilun@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#843427}

TBR=michaelbai@chromium.org,sweilun@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Id31bb7d9a0b420315d729b802c6634e5e9c59e71
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1151542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629971Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843702}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/65c824b5adc9..786a9e746bcb

2021-01-14 andoli@chromium.org [module.json extensions] Add support for ViewLocationResolver
2021-01-14 tvanderlippe@chromium.org Fix issues with localization presubmits
2021-01-14 jacktfranklin@chromium.org Create a helper for setting CSS props inside custom element

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1134103,chromium:1166108
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Iaf1e3cee5cf37d1857ce255c04007fbb87b1065f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627337Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843701}

The box-shadow property isn't shown in forced colors mode,
so give the realbox dropdown a real border instead.

In addition, the color used to highlight a dropdown item
when focused or hovered is ignored in forced-colors mode,
so set it to specific system colors that are respected
in that mode.

See bug for before/after screenshots.

Bug: 1166383
Change-Id: I537cd4dcf7be8b9539517cc9783295a29519f55a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627820Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843700}

Rename benchmark to desktop_ui in order to let more features use it.
Stories from different features can be added to DesktopUIStorySet now.

Bug: 1099917
Change-Id: I31ae8bbfd2f572c49e9a5057d686dcaf8ef3fda2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625273Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843699}

Stops setting the machine_name field in the DM API protos for iOS
browsers. The machine name will instead be set by the backend by using
the client ID, and fall back to the device model if needed.

Bug: 1150847
Change-Id: I00345b07bce3b5f99fce3e19cd753207da4e6113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617465Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#843698}

https://quiche.googlesource.com/quiche.git/+log/74ae09145aaf..e84d83393be4

$ git log 74ae09145..e84d83393 --date=short --no-merges --format='%ad %ae %s'
2021-01-13 wub Set SSL_OP_CIPHER_SERVER_PREFERENCE on QUIC TLS server's SSL_CTX.
2021-01-13 renjietang Handle stateless reset that's received from path validation.
2021-01-13 quiche-dev Internal QUICHE change
2021-01-13 danzh Send PATH_RESPONSE using the alternative socket if the PATH_CHALLENGE is received on that socket.
2021-01-13 fayang Internal QUICHE change
2021-01-13 haoyuewang Add methods that reads/writes connection ID in preferred_address transport parameter .
2021-01-13 haoyuewang Internal QUICHE change

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: Ica44198ce35862c4eb5c6469b20b6d8a239b78a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629427
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Auto-Submit: Bence Béky <bnc@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843697}

This CL fixes two minor coding style issues.

https://google.github.io/styleguide/cppguide.html#Rvalue_references

According to the coding style, rvalue refs can only be used in a
couple of scenarios, and they do not include the following:

1. base::OnceClosure&& done_cb
The idiomatic way is to declare base::OnceClosure function parameters
by value.

2. StateChangeTestEngine::StateChangeTestEngine(
      std::vector<StatePair>&& state_vec)
    : state_seq_(state_vec) {}
This ctor is not one of the cases where overloads on rvalue ref are
allowed.

Also, the code on trunk has a minor bug: because move semantics are not
passed through, std::move needs to be called even though `state_vec`
is a rvalue reference. Otherwise, the member initialization is still
going to be a copy instead of a move.


Bug: 1164718
Change-Id: I3d63cb6bb837121e640381ce1ff0ae96ce08d161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619964Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843696}

This is the last class in the flags package in chrome_java.

I considered moving it to a new metrics module, but the enums like
ActivityType are core and used in a lot of places, and have meaning
besides metrics, so I'm keeping these in flags and simply
modularizing to unblock any code that uses them.

Change-Id: I57c6accfaa2f1a18e230af2219b5e883919af49b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625890Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843695}

Diff:

1. Remove test BookmarkBridgeTest.testAddToReadingList from this CL as
@Batch is causing multiple times failure on official bots. The test will
be added in a separate CL.

2. Add a logging in EmptyReadingListManager.Add.

3. Add a logging when failed to parse UTF16 in
ReadingListManagerImpl::SyncToBookmark, this will help us to debug
crbug/1163876.

Bug: 1157808,1163225

Change-Id: I6b734ea67db192c1108f843699e7835c0e19a9da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626075Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843694}

This change adds support for version two QR codes, with “low” error
correction. This configuration matches how other platforms generate eSIM
QR codes. Additionally, since version two QR codes are smaller, their
blocks can be displayed with more pixels each, so a lower level of error
correction is reasonable.

Change-Id: I7f42239835f3d5c6c981b9c73680247858cc0f28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623842
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#843693}

For tote, users should be able to clear the selection by clicking or
tapping on the bubble background.

Bug: 1146145
Change-Id: Ibaabe09ae6f6b5dfb73581e1169d0a2d46651ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628075
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843692}

Chrome should not attempt to write a large blob that exceeds the
maxSerializedLargeBlobArray reported by the authenticator.

Fixed: 1143767
Change-Id: I2cc4f553c131655e75d7cd5380092d1747e09708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626412
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#843691}

BUG=None

Change-Id: I6941d9b5ecf5715297fe794717d6a649521e4b1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627402Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843690}

This CL adds two new base::Features, SafeBrowsingEnterpriseCsd and
SafeBrowsingDisableConsumerCsdForEnterprise to control
whether using the Enterprise CSD server is enabled. It also makes two
behavior changes depending on these flags. When enabled:
- The consumer download ping is skipped
- The |csd| field in the upload request is populated with the download
  metadata.

Bug: 1165815
Change-Id: I00e3cc17ed56eff93803ab50232bb00497667afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626031
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843689}

Bug: 1157278, 1164572
Change-Id: I463c7c6fd65690f26004331a3475700ee0677351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629869
Commit-Queue: Josh Nohle <nohle@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843688}

Though the entire downloads section header is focusable and behaves as
a single button, the focus ring is drawn as a circle around just the
chevron.

Screenshot: http://shortn/_yNqR9nC2Pk

Bug: 1160011
Change-Id: Ie58083966e5bf1d01b09472cc7271b978741b91f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628747
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843687}