- 09 Jul, 2020 40 commits
-
-
Wei Lee authored
Bug: none Test: ./build_ffmpeg.sh Change-Id: Ia5005852432b21a4f92f3bbc2a4cbf44bef7c8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288713 Auto-Submit: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#786622}
-
calamity authored
This reverts commit a51d306b. Reason for revert: Causing https://crbug.com/1095520 and the original bug isn't severe enough to warrant another fix. TBR=alancutter@chromium.org Change-Id: Ibfa7e073f713c3f0b1d29666bddf194553b04ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248386 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#786621}
-
Panos Astithas authored
I also took this opportunity to silence a clang-tidy warning in values.h. Given that there is already a long comment about why the linter is wrong in this case, it seems only natural to let the linter know about it, too. Bug: 646113 Change-Id: I59ae89f42731445789638c4c25840249263127fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285305 Commit-Queue: Panos Astithas <pastithas@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#786620}
-
Mustafa Emre Acer authored
Change-Id: Ib40248adae14cbdcdbf389f5689308110261b555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289373 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#786619}
-
Xiaohan Wang authored
Microsoft::WRL::ComPtr<T>::GetAddressOf() is banned due to the ease of causing memory leaks. Also replace CopyTo(foo.GetAddressOf()) with As(&foo) since CopyTo(&foo) does not work if we are copying to different interfaces. Also replace QueryInterface(foo.GetAddressOf()) with QueryInterface(IID_PPV_ARGS(&foo)). Bug: 914910 Change-Id: Iab2499f6c5348afab8e3b5b7a88be7553a035dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271074Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#786618}
-
Toshiki Kikuchi authored
This CL introduces a new shell type for ARC++ toasts in remote-shell. Since the purpose of toasts is a notification for users and the toast appears and disappears quickly without any user interaction, so toasts are supposed to be shown over Chrome OS's virtual keyboard. ARC++ side CL: ag/11272597 design overview: go/vk-overlays-toasts BUG=b:109717200 TEST=ToastSurfaceTest Change-Id: I3cec22a031a7046ff63770ff308b6d0695c313e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167792 Commit-Queue: Toshiki Kikuchi <toshikikikuchi@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#786617}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594238316-5a06a9d54d894d0a4b76afbfa24ee9bc79afbdb3.profdata to chrome-win32-master-1594241852-dbfc5354e90dfa07f5b39f6ede0ae89c2c21363d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia62d6239f813a275f1d7566e04e80bcd14809fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289126Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786616}
-
Mohsen Izadi authored
This reverts commit d64e736a. Reason for revert: Caused chrome_all_tast_tests / camera.CCAUISanity.fake failures; e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/7680 Original change's description: > Do not expose media devices before a successful getUserMedia() > > This is a spec-compliance change. > > This CL also adds some improvements to the blink MediaDevices unit test. > > Bug: 1101860 > Change-Id: If2e7824df3b3dbd3cdb80f4bcf6b5c417d6f0ef2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279808 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786253} TBR=hta@chromium.org,guidou@chromium.org Change-Id: I41b676c7d3e437c06d23f2b46270453f1cc81670 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288282Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786615}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ib08bcf3112a9da19685fc57c9c922465cc023815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289351Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786614}
-
James Vecore authored
Some of these prefs will be directly set in settings while other will be managed by Nearby's local device manager. The settings added to the allow list in settingsPrivate will be used directly in settings. Change-Id: If16722bb8441776a7ff057e01532d19ac2bc7c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289211 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#786613}
-
Samuel Huang authored
Previously, Supersize-diff of for multi-container .size data does not assign a container for symbols with name: "Overhead: aggregate padding of diff'ed symbols", which are added as "after" symbols of DeltaSymbols. As a result, when saving .sizediff files, these symbols cause key error since their container names of '' do not match an existing (diff) container. This CL fixes the problem by assigning a container to the above symbols. This CL also defines "segments" as (container, section) tuples. In .size files these appear as, e.g., "<0>.text", and serve as grouping keys for various data. Bug: 1040645 Change-Id: Ibbd7d96a9b4e413dd782ee8c0dc551e43c7d7f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288206Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#786612}
-
Owen Rodley authored
Bug: 1094768 Change-Id: Ib692acc66b8446cc2606551507caf01b6c7bc313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289271 Commit-Queue: Owen Rodley <orodley@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Owen Rodley <orodley@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#786611}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/563d497e009f..18523c34b464 2020-07-08 handellm@webrtc.org Migrate rtc_base to webrtc::Mutex. 2020-07-08 handellm@webrtc.org Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex. 2020-07-08 handellm@webrtc.org Clarify logging docs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4382c2f21c9c978372a8a7dfd7639045ae40676c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289153 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Jing Wang authored
onInputMethodOptionsChanged event will be fired by input method engine when any change to the input method settings in pref has been observed. Changes in third_party/ are auto-generated according to instructions at https://chromium.googlesource.com/chromium/src/+/master/docs/closure_compilation.md These two files were not update to date before, so there are some changes which are irrelevant to input method options changed event. Bug: 1042084 Change-Id: Iff7ccf76b11d5c196ac3aa2c012b2ef92720bde6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264089 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786609}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d60500e69944..8e4267f23771 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com,jam@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1102962 Tbr: keishi@google.com,jam@google.com Change-Id: I367c96fa4f83115f1322e37238b90a9fd6a7b86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289115Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786608}
-
David Tseng authored
R=akihiroota@chromium.org, katie@chromium.org Fixed: 817636 AX-Relnotes: ChromeVox correctly provides spoken feedback when performing a select all (ctrl+a) on a multiline editable text field that contains only a single line. Change-Id: I4b83cb044c496dab14ba6c43068cb4295ea1bcc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288089Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#786607}
-
David Tseng authored
R=akihiroota@chromium.org Fixed: 816631 AX-Relnotes: time and date (Search+a, d) feedback provided in braille as well as speech. Change-Id: Ic0447e493ef88cca3f494534e8397370abf2d972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288090Reviewed-by:
-
Yoshifumi Inoue authored
[LayoutNG] Make NGInlineCursor::PositionForPointInChild() to work with inline-block that has block children This patch changes |NGPaintFragment::PositionForPoint()| to work with block children inline-block to make |NGInlineCursor::PositionForPointInChild()| to work with it. Bug: 1096110 Change-Id: Ia7d070fe5287a20868cafd4eac370e83a4d81fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286092 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#786605}
-
Gavin Williams authored
cr-input is mainly used for receiving user keyboard input and comes with a lot of built-in features to support that. Since the print preview dropdown does not directly receive keyboard input it makes sense to replace cr-input with a standard div. This makes customization of the dropdown cleaner as well. "input" was removed from all of the element id's to reflect the removal of cr-input. Bug: 1059607 Change-Id: Icdbde1ac3e089fc76b35eef2ba67f76a4f649fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284866Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#786604}
-
Shawn Gallea authored
This allows rounded corners to be forced off when there is a sibling to a webview container window. Bug: b/155436903 Test: Locally on device Change-Id: Ida192575a1584192a248ceb1e98b1b54e467e857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245187 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#786603}
-
Victor Costan authored
QuotaClient will be converted to a mojo interface. Mojo doesn't have a built-in type for set, and sets can be transmitted cross-process as vectors. This CL replaces std::set use with std::vector, to facilitate the conversion. Bug: 1016065 Change-Id: I4c381b3082b0c4deb5dcea9a0af46cfe94a1e906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286475Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786602}
-
dpapad authored
Bug: 1102485 Change-Id: I43502e297fa36ea647e894addb09960057115275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284003 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#786601}
-
Yue Li authored
The cleanup will take 4 steps: 1. Add definitions to shared library in public repo and update usages 2. Update usages in internal repo 3. Update usages and remove obsolete code in public repo 4. Remove obsolete code in internal repo This change is step 3. Bug: b/160241802 Change-Id: Ia723886fa6832cc19eba2b54e5b10a5b8a6c3bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284359 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#786600}
-
Owen Rodley authored
The Gatekeeper config includes all builders under this master, except for mac-osxbeta-rel. But actually this builder is under chromium.fyi, so it wouldn't be included anyway. Bug: 1094768 Change-Id: Ide1321def6f5702c68645a28c14c8da91fe698d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287329Reviewed-by:
-
Jiajie Hu authored
ANGLE has provided angle_libjpeg_turbo_dir as a build override for a long period, but that probably never had any real effect until crrev.com/c/2282277. Bug: None Change-Id: I44228ed1403cc496beeb00410a337f4f7ce538dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285839Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Jiajie Hu <jiajie.hu@intel.com> Cr-Commit-Position: refs/heads/master@{#786598}
-
Victor Costan authored
ClientUsageTracker::GetGlobalLimitedUsage() has a bug, exposed by the tests in https://crrev.com/c/2288502/1. Fortunately, it is only used to implement UsageTracker::GetGlobalLimitedUsage(), which is only used in tests. This CL removes the unused code, and adds UsageTracker unit tests to prevent bugs similar to the one discovered in GetGlobalLimitedUsage(). Bug: 1103426 Change-Id: Ifb44dbce66579ea9afc420fce0ee2482cafa127d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288502 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Keishi Hattori authored
This reverts commit fdc228c7. Reason for revert: portal-activate-default.html test timeout failure https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/55803 Original change's description: > Abstract portal activation handling to avoid hack of making a fake promise. > > This is somewhat verbose, but allows us to avoid the unhandled rejection > being visible to script without having to make this hack even worse. > > Instead of actually calling activate(), this mirrors the spec structure > by simply calling to underlying logic, passing a resolver where it makes > sense and not (in this case, passing a substitute object) where it > doesn't. > > Bug: 1102081 > Change-Id: I0eecf253928bfce39afcddccf54e9bc6f6c0d549 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285340 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786480} TBR=jbroman@chromium.org,adithyas@chromium.org Change-Id: I00da9eee8625ca5da3a09efb7078e22a277dbfd8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288712Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#786596}
-
Karandeep Bhatia authored
Enforce isolated world CSP for fetches from isolated worlds instead of just bypassing the main world CSP. This also helps fix a bug where a redirected fetch from a content script doesn't correctly bypass the main world CSP. Add a regression test for the same. BUG=934819, 1099975 Change-Id: I3c471464274f1657ef3c08378f06a3963f95a0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278626 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#786595}
-
Ahmed Fakhry authored
When there are multiple running instances of the same app, left clicking its icon on the shelf will display an application menu showing an item for each instance from which users can select which instance to activate. When the kPerDeskShelf feature in enabled, this list should be filtered to show only running instances in the current active desk. This is done via giving the ShelfItemDelegate a filter_predicate to exclude the apps belonging to other desks. BUG=997102 TEST=Manually, browser_tests --gtest_filter=*PerDeskShelfAppBrowserTest.AppMenus* Change-Id: I8d70586a1ad638a42e6aa71378a55007c6b8dabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258902 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#786594}
-
Adam Langley authored
The |CtapMakeCredentialRequest| objects are already tweaked for each authenticator, but it was done just before dispatch. Thus lots of logic depended on the authenticator-independent |request_|, which wasn't what was actually sent. Since the tweaks are currently small, that didn't matter, but hmac_secret will make that more complex. Instead, perform the tweaks at the beginning of processing and carry that copy of the request through the functions. The logic becomes authenticator-specific after a while, so it would be possible to use |request_| for this. But, in order to avoid having to remember which functions are request specific and which can use |request_|, just thread the object everywhere. Since the |CtapMakeCredentialRequest| is quite a complex object, with a lot of members to move, the per-authenticator request is held in a |unique_ptr| so that the moving is trivial. Change-Id: I807aa44df237440c209d3062621b66e953515854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258855 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#786593}
-
Natalie Chouinard authored
TBR=donnd@chromium.org Bug: 1103496 Change-Id: Ibfdae5ef6eb7b3ed85b2cde6690529098ca0293c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288765Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#786592}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594231179-c7594468dab38d8e431c4fcba79f22d1baa4fc31.profdata to chrome-mac-master-1594252794-234742b7e174805efabe5bf943f9a0807ea87850.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I14248a0f4bed2e63d90e7acc48d1e06794273592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289156Reviewed-by:
-
Quang Minh Tuan Nguyen authored
Bug: 1007685 Change-Id: I0db5f8120bae94e8f71347de005284986a1b1827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282631 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Auto-Submit: Quang Minh Tuan Nguyen <nqmtuan@google.com> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786590}
-
Nate Chapin authored
It's unused, and a caller is null-derefing try to provide it. Bug: 1103072 Test: http/tests/css/stylesheet-load-complete-in-detached-iframe-crash.html Change-Id: I21e51697f8df31f08df93b3fa9ee09ef739d9f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287915 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#786589}
-
Shengfa Lin authored
Remove debugger tracker and its usage in webview impl and removed from build file so that DevTools Debugger can pause normally. Remove debugger tracker reference in documentation. Bug: 1099671 Change-Id: I8fca247f62f4a0651f190b165e98b132c3c1755f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288313 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786588}
-
Tomasz Wiszkowski authored
This change adds logic extracting and processing subtype information from search server response. The retrieved subtype information is not yet added to corresponding AutocompleteMatches / will be passed in subsequent CLs. Bug: 1103056 Change-Id: Ib7738ec9676b64a3ae4db63481f67eb18960595f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286031 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#786587}
-
Jing Wang authored
Also use std::find instead of for loop. Bug: 1103460 Change-Id: I33820ac380affe154ddce640093c7700c1e1c3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289172 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#786586}
-
Nate Chapin authored
Bug: 1103089 Test: html/semantics/embedded-content/the-iframe-element/sandbox-toggle-in-inactive-document-crash.html Change-Id: I7d5e7e9e53f7cfd4b94baf02ae58f1cda2d55009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288096 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
TBR=peconn@chromium.org, roagarwal@chromium.org Bug: 1103488 Change-Id: Ibe6c7d072d8e1b6791a97c00adb3bd8f49c0b10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288825Reviewed-by:
-
Min Qin authored
Windows file extension depdends on system registry. So if "text/html" is not in the registry, or if the registry uses ".html" instead of ".htm", the test will fail. BUG=1102538 Change-Id: I4c2e73f87eebd3cf2093ab0ef1e9f4b322815de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285285 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
