- 21 Jun, 2019 40 commits
-
-
Fabrice de Gans-Riberi authored
The feature name was renamed in Fuchsia. There is no permanent replacement for accessing "/hub" as of yet. Bug: 977730 Change-Id: Ice51e0d5a5464e596129f5b9aad075040d2a9510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671860 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#671441}
-
Khushal authored
Ensure that we never use shared images for low latency canvas until it can support single buffering. R=fserb@chromium.org Bug: 976774 Change-Id: I093b3627f05233ea4f7212eb3093c805498bf2ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669918 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#671440}
-
Xianzhu Wang authored
This reduces sizeof(LayoutObject) from 120 bytes to 104 bytes in release without DCHECK builds on 64-bit systems. - Move bitfields_ above pointers to fill the gap between DisplayItemClient and LayoutObject; - Move FragmentData::next_fragment_ into rare_data_ because we have already treated multi-fragment as rare (e.g. for pagination_offset, etc.). Change-Id: Ia0c695e3c3760a661035aa50213f1d9588c53661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669888 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#671439}
-
Eric Karl authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1614798 we added logic to set the background color to black for fullscreen webview in OnRenderFrameMetadataChangedBeforeActivation. It turns out that on pre-N Android, this is too late and misses the view being re-painted, leaving a white background up until the next invalidation is forced. This change in OnRenderFrameMetadataChangedBeforeActivation paralleled the EvictFrameIfNecessary from OnFrameMetadataUpdated, but missed other cases of EvictFrameIfNecessary. In order to more exactly match the pre-surface-sync behavior, this CL moves this workaround to a helper function and calls this from the appropriate places. Bug: 961223, 973365, 974692 Change-Id: I6067e4687fef918c97804634c32ad70be163182d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670359 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#671438}
-
Clark DuVall authored
This was a typed test to test both the network service and non-network service paths. Now that network service is launched on Clank, we can remove the non-network service code. Bug: 934009 Change-Id: Ia698854017cd6c1cbcecc8e3425e66ab58aa3eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660922 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#671437}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce6b75e9ac47..78e90396294f Created with: gclient setdep -r src-internal@78e90396294f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: Iec158df9464475425d8a515a82583fe2b85fbb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671911Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671436}
-
Frank Poole authored
This change removes the restriction that text fields with placeholder text cannot have children. Text fields with placeholder text need text children to enable UIA text navigation. Bug: 961787 Change-Id: Idcaef4f6f381f4e91bdea342c979de922f99db8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649466 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#671435}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11bc2d513286..7afb8a45a389 git log 11bc2d513286..7afb8a45a389 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 treehugger-gerrit@google.com Merge "perfetto-ui: Speed up slice summary query" Created with: gclient setdep -r src/third_party/perfetto@7afb8a45a389 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I6deddef0fe5da1b71c5386d85e9ddf3bb469f861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671434}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4c41a603c536..ec9252e6d134 git log 4c41a603c536..ec9252e6d134 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 djacobo@chromium.org Revert "arc: Add arm64 to the list of constants for PI" 2019-06-21 eashanbhatt@google.com Append VM Image bin file to image path directory. 2019-06-21 eashanbhatt@google.com device: Force private key assignment. 2019-06-21 vapier@chromium.org cros_bisect: update Ninja call 2019-06-21 saklein@chromium.org router.py: Filled in missing docblock. 2019-06-21 saklein@chromium.org Build API: Refactor Router functionality into an api module. 2019-06-21 chrome-bot@chromium.org Update config settings by config-updater. 2019-06-21 jclinton@chromium.org Mark mistral exterimental 2019-06-21 nednguyen@google.com chromite: fix commands.GenerateBuildConfigs to use FromChrootPath instead of ToChrootPath 2019-06-21 dburger@chromium.org Remove checking release importance determining postsubmit importance. Created with: gclient setdep -r src/third_party/chromite@ec9252e6d134 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I6a4ff167e37c413a3d452b5113119274960e2d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672059Reviewed-by:
-
Becca Hughes authored
Remove the aspect ratio option and replace it with width and height. If either of these are present then we should make sure they are BOTH present and valid. BUG=953957 Change-Id: Ide4a144e5c5ddde852d1aae5967d5b4b9c854879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658633 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#671432}
-
Kenneth Russell authored
The experimental hardware is now running Ubuntu 19.04 and NVIDIA's 418.56 driver. Bug: 953535 Change-Id: I5a5c5644d04938d850c75bf04613229794645917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666442 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#671431}
-
khachatryan authored
By a mistake comma was put inside the quotes. Moving comma out of quotes. Change-Id: Ib85852527cdc7c5e91e7fda2fba7561e6601a935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672405Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#671430}
-
Darin Fisher authored
Bug: 971859 Change-Id: I9213044a1555ddebffb7562ebd0a9448cfba9a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670318Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#671429}
-
Chris Blume authored
This CL adds flaky tests to the flaky list for the SkiaRenderer Vulkan Android bot & content_browsertests. Bug: 977669 Change-Id: Ibd51b99711479107ae204c2d664928ce56f596e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671929Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#671428}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/bb9511684f70..7d9288f5f86e $ git log bb9511684..7d9288f5f --date=short --no-merges --format='%ad %ae %s' 2019-06-20 johannkoenig vsx: disable on all builds 2019-05-22 ravi.chaudhary Start with q=active_best_quality for non-forced key frames 2019-06-19 jianj vp8: Allow higher resolution to get periodic keyframe. 2019-06-18 angiebird Change log2_fast to log2_approximation 2019-06-18 angiebird Implement log2_fast for vp9_nb_mvs_inconsistency 2019-04-12 yuec Fix timestamp overflow issues 2019-06-07 zxdan 3D reconstruction tool build by Processing Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I8c1e3ae2b34b1ae0b0dfd1db7a4d000ee4128edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670364Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#671427}
-
Brandon Wylie authored
Change-Id: I8eecc5d6aae55d4def5e19939ad7a0163ee33dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672008Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#671426}
-
Ryan Hamilton authored
to simplify callers and facilitate support for v99. Change-Id: I8eb5f2045b0cd9d1c847fb992378a30182a3619d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671013 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#671425}
-
Henrique Nakashima authored
This is needed to kickoff an Offline Prefetch test in reduced mode. Bug: 959957 Change-Id: I3ea78f1cc0011db5880e6c620706d3c57f9acf43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665869Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#671424}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5ae2e714. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I7d3e16d896bfcee360b5031feaff74368c85de2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671649Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671423}
-
Cathy Li authored
Bug: 977248 Change-Id: Ic1190f11013894dc51ae92588f48ee550880610b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670111Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#671422}
-
Peter Kotwicz authored
This reverts commit a8ab3bd5. Reason for revert: NoClassFoundError org.chromium.base.ApplicationStatus when running components_browsertests Original change's description: > Set up NativeBrowserTestApplications in the base class. > > We move the ApplicationStatus.initialize() call up to the base class > since they all need to do it. > > We also initialize the CommandLine there as it needs to be initialized > from the Application. The ChromeTabbedActivity would crash during > startup when it tries to use the CommandLine otherwise. > > Do the same in NativeTestApplication base class, instead of in > NativeTest, for consistency. This prevents the CommandLine from being > destroyed in NativeTest after the NativeBrowserTestApplication has > already set it up and is running. > > Bug: 961849 > Change-Id: I715d91fb1b251d4dbbb51e2b60760fb1cc95bc97 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670349 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671355} TBR=danakj@chromium.org,dtrainor@chromium.org,tedchoc@chromium.org Change-Id: I816f2813790c19ae0b42427644bd25c4f03e02c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 961849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672171Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#671421}
-
Manu Cornet authored
* Push down some logic from |ShelfButton| to |ShelfAppButton| when only app buttons are concerned (e.g. drag and drop behavior). * Move some logic from |ShelfView| to |ShelfButton| for better encapsulation, and having in mind wanting to make a |ShelfButton| be able to have its own life outside of a |ShelfView|. Bug: 973443 Change-Id: Ib0fa9374a35213ef6c80fee8a743eef27edfb039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667551Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#671420}
-
Tibor Goldschwendt authored
Play core sends the following status updates: Successful install: PENDING -> DOWNLOADING -> INSTALLING -> INSTALLED. SplitCompat not enabled, unsuccessful install: PENDING -> DOWNLOADING -> INSTALLING -> DOWNLOADED. Change-Id: I64300673dedda6c7b6d65d0c66642435bd3333e1 Bug: 977218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669847 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:Steven Holte <holte@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#671419}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2f24e880e71019989aea84e0a6e77e71b53b5011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671910Reviewed-by:
-
Nektarios Paisios authored
According to the principle of YAGNI, functionality that is not yet needed should be removed in order to reduce technical debt and improve code organization. R=aleventhal@chromium.org Change-Id: Iae2b93ea053b064a6c96fc717d45a1e62801af26 Bug: 956748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660973 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
Dan Beam authored
This reverts commit b71e82b8. Reason for revert: Broke gcp_unittests on Win ASAN: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/5921 Original change's description: > Fetch active directory upn via admin sdk and perform AD login on > the client device via GCPW. > > > Bug: 976543 > Change-Id: Iadfc198438c3dc13f0dcfb688b26c41fcd08dfa3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659512 > Commit-Queue: Rakesh Soma <rakeshsoma@google.com> > Reviewed-by: Tien Mai <tienmai@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671356} TBR=rogerta@chromium.org,tienmai@chromium.org,yusufsn@google.com,rakeshsoma@google.com Change-Id: If8ed792f99d8038e3ad9aea816975485db18f1b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671872Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#671416}
-
Lukasz Anforowicz authored
CORB launched to the stable channel in M67 and therefore we no longer need the metrics that were helping us assess the impact of CORB on existing websites. This CL marks the following histograms (logged only in the pre-NetworkService code path) as obsolete and stops logging them: - SiteIsolation.XSD.Browser.Blocked - SiteIsolation.XSD.Browser.Blocked.BlockedForParserBreaker - SiteIsolation.XSD.Browser.Blocked.HTML - SiteIsolation.XSD.Browser.Blocked.JSON - SiteIsolation.XSD.Browser.Blocked.Other - SiteIsolation.XSD.Browser.Blocked.Plain - SiteIsolation.XSD.Browser.Blocked.XML Note that this CL does *not* touch the SiteIsolation.XSD.Browser.Blocked.CanonicalMimeType histogram - we want to retain it for now (because covering PDF, ZIP and other types have been introduced recently - in M76): Bug: 940785 Change-Id: I005a3a2b8dfcd5948d0af189ad12becbfc8ea3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656018Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#671415}
-
Jeremy Roman authored
It was probably left behind during recent WPT refactoring. Change-Id: Ia993654248303c56559cb8cf755d11944213048a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671947 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#671414}
-
Becca Hughes authored
Do not create a PictureInPictureSession if there was an error from the embedder. This should reject the promise from Blink too. Also, moves the EmbedSurface and Show controls out of //chrome and into //content where we can setup the PictureInPictureWindowController in one place. BUG=953957 Change-Id: I75e3cc803896c805262fd82753d11face4199a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663009Reviewed-by:
-
James Hawkins authored
This change fixes a missing 'Remove' tooltip on the network proxy exclusion list items. R=maybelle@chromium.org Bug: 976663 Test: none Change-Id: I912b28da1301b6794516146402fde7a4a284deb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669183Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Auto-Submit: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#671412}
-
Kevin Ellis authored
The start and end gradient calculations handled one or two coincident control points, but not three. The test for coincidence of P2 and P3 was not quite correct. The case of 3 coincident control points is not addressed in the spec, and an issue has been filed. https://github.com/w3c/csswg-drafts/issues/4046 The algorithm as proposed in the spec is also missing a constraint for detection of coincident control points. Bug: 827560 Change-Id: I8b216c8ab32881d6e100d338f4601c30e658bfb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670150Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#671411}
-
Marcin Wiącek authored
Change-Id: I7517f892e54f45ef25052979d2ba1f150a4af7ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636050Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#671410}
-
Haines Sy authored
Bug: 135283879 type Test: Manually verified locally that uma metrics populate with product Change-Id: I4d2f9da60788ff656a1dc838139f10ce88442a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671648Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Haines Sy <hainesy@google.com> Cr-Commit-Position: refs/heads/master@{#671409}
-
John Budorick authored
This reverts commit d280a10b. Reason for revert: spec revert for https://bugs.chromium.org/p/chromium/issues/detail?id=977664 Original change's description: > [Android WebAPK] Rename resource dirs based on whether res are uploaded > > This CL renames the resource directories based on whether the resources > should be uploaded to the googlestorage build bucket. > > WebAPKs have 3 types of resources: > Type #1 Resources which are not processed by the client and uploaded > to the googlestorage build bucket. The server might further process > these resources. > Type #2: Resources which are processed by the client and then uploaded > to the googlestorage build bucket. > Type #3: Resources which are not uploaded to the googlestorage build > bucket. The server uses icons from the Web Manifest to populate these > resources. > > This CL moves resources of Type #1 to the to_upload/ directory > > R=hartmanng > TBR=wnwen > (For editing suppressions.xml due to rename) > > BUG=None > > Change-Id: I15b1633e772ec971b1ce2ae976ec060123abefdb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650270 > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Glenn Hartmann <hartmanng@chromium.org> > Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671375} TBR=hartmanng@chromium.org,wnwen@chromium.org,pkotwicz@chromium.org Change-Id: I923987e7b80802eb655851a5f00a0642ef4fe5d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671888Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#671408}
-
Etienne Bergeron authored
This CL is fixing an memory leak detected by memlog. The bug got introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/1526067 The loopup in the map is using the [] operator which is creating a default entry when the key is not present. Over the time, that map came really big and consumes too much memory. The fix is to not use the [] operator, but to validate the presence of the key. R=rockot@chromium.org,siggi@chromium.org CC=yuzus@chromium.org Bug: 973200 Change-Id: I701e682deddace850d094c68d75adea1cec391cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669101Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#671407}
-
Angel Alvarez authored
Deprecates the existing getEspCatalog method. Implement a new initiateCatalogFromFetch method in the java side ExploreSitesBridge. Updates references to getEspCatalog to use the new method (except for in ExploreSitesSection which will be removed). Moves ExploresSitesEnums.CatalogUpdateRequestSource to explore_sites_bridge.h and updated relevant build files. Removed unneccesary import statements and updated references to ExploreSitesEnums.CatalogUpdateRequestSource. These changes will have the effect of replacing the current methods in the ExploreSitesBridge by abstracting over the process of retrieving the catalog from network when the catalog is not available from disk. The initiateCatalogFromFetch method has some performance benefits over it's updateCatlogFromNetwork counterpart, since it does not have to deal with any java callbacks, or translating objects back into java. These methods also record relevant usage data, including if the network was used, and the page source of the update. Bug: 948872 Change-Id: Ieafba316742b84c0c16fb0f0075467583be41d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648666 Commit-Queue: Angel Alvarez <angelii@google.com> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#671406}
-
Geoff Lang authored
The passthrough command decoder implemented this feature but did not expose the capability. BUG=882580 Change-Id: I47310f7fbd1ebe53958a0098462abefd88df24f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670950Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#671405}
-
Michael Thiessen authored
No-Tree-Checks: true No-Try: true Change-Id: I510387270cf6140aab0fed2957413b4be068f9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671787Reviewed-by:
-
Mike Dougherty authored
Log metric to determine if a possible explanation for the previous session unclean termination exists. Bug: 965393 Change-Id: I053738a37461ae57b7d78053816e3471907ac997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669013 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#671403}
-
Jordy Greenblatt authored
The color contrast between text+icon and the background for the inactive state for the "Center" and "Center Cropped" buttons in the Wallpaper modal[1] is low enough to cause accessibility issues for vision impaired users at a ratio of 3.61 (compare to the minimal acceptable ratio of 4.5 to meet W3C guidelines). The contrast provided by the new color for both the text and icon, i.e. Google Grey 700 aka #5F6368 aka rgb(95, 99, 104), provides an acceptable ratio of 6.05. [1] http://screen/hKAXfVsRLVn ------ Result of this change: http://screen/dE3ipM3e1fA Note: newly colored text/icon in red rectangle Bug: 910362 Change-Id: Ica3b7b484f5ad64a83b259f9fa7c4d3e92c957df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670358 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
-
