- 24 Jul, 2018 40 commits
-
-
Hajime Hoshi authored
This reverts commit 47a44d77. Reason for revert: Test failures on some bots https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2064 ../../chrome/chrome_cleaner/os/disk_util_unittest.cc(892): error: Value of: HasZoneIdentifier(target_exe_path) Actual: false Expected: true Stack trace: Backtrace: StackTraceGetter::CurrentStackTrace [0x00007FF663FC6FE0+80] testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF663FE254A+90] testing::internal::AssertHelper::operator= [0x00007FF663FE204A+90] chrome_cleaner::DiskUtilTests_ZoneIdentifierWhenProcessIsRunning_Test::TestBody [0x00007FF663EECF4C+2924] ../../chrome/chrome_cleaner/os/disk_util_unittest.cc(897): error: Value of: base::ReadFileToString(stream_path, &content) Actual: false Expected: true Original change's description: > chrome_cleaner/os unit tests, part 1: a-f > > Also add test_util add extra setup that uses it to the test harness/ > > Bug: 830892 > Change-Id: Iae1bb4323f6a0b25339d13e702135c2a3625c99d > Reviewed-on: https://chromium-review.googlesource.com/1141146 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Chris Sharp <csharp@chromium.org> > Reviewed-by: Penny MacNeil <pennymac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577240} TBR=csharp@chromium.org,pennymac@chromium.org,joenotcharles@chromium.org Change-Id: Icf4ceab27056789e7aeb20f7c979aa9a3e52f3f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830892 Reviewed-on: https://chromium-review.googlesource.com/1147961Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577439}
-
Luciano Pacheco authored
Fix issues where Files app failed to mount .zip files, and also failed to zip files in M69 dev. Cause was on the Zip Archiver extension failing to load its own JS files due the manifest Content Security Policy (CSP) changes submitted in issue 836412. Bug: 864256, 865197, 836412 Change-Id: I8ffd382671deac0a23dfa5688830d9608a919bf5 Reviewed-on: https://chromium-review.googlesource.com/1147893Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#577438}
-
Kenichi Ishibashi authored
This CL adds three tests which basically correspond to ServiceWorkerContextRequestHandlerTest.ErrorCases. Bug: 860361 Change-Id: I57bca1d4ad53ffa53e45fd6b3e340d678133a856 Reviewed-on: https://chromium-review.googlesource.com/1146539Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577437}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4206a0a8498a..dcff0bd78e26 git log 4206a0a8498a..dcff0bd78e26 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 buildbot@webrtc.org Roll chromium_revision 0aff707f..bc855194 (577150:577382) 2018-07-23 steveanton@webrtc.org Add CreateIceCandidate overload which takes a cricket::Candidate Created with: gclient setdep -r src/third_party/webrtc@dcff0bd78e26 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2e5bc6c6e1e2915692ee15556b8c18a18b541e38 Reviewed-on: https://chromium-review.googlesource.com/1147901Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577436}
-
Matt Falkenhagen authored
Since issue 864731 was fixed in r576288, this workaround is no longer needed. Bug: 854993 Change-Id: I789dfb18cdb82ec51aa0ce5185586163c92269ec Reviewed-on: https://chromium-review.googlesource.com/1147889Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577435}
-
Hiroki Nakagawa authored
This is a follow-up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1146134 Bug: 825740 Change-Id: I401fb219d074546fcc13a49f50aab4a37e485010 Reviewed-on: https://chromium-review.googlesource.com/1147880Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#577434}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6a1002b4d937..2edae10bfbfe git log 6a1002b4d937..2edae10bfbfe --date=short --no-merges --format='%ad %ae %s' 2018-07-23 simonhatch@chromium.org Dashboard - Add new mojo linux name Created with: gclient setdep -r src/third_party/catapult@2edae10bfbfe The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863995 TBR=sullivan@chromium.org Change-Id: Id43b4f146c27fedc610a0feb59ba418aa708ec68 Reviewed-on: https://chromium-review.googlesource.com/1147722Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577433}
-
Kunihiko Sakamoto authored
Bug: 803774 Change-Id: Ic0d8445643d3a0639ce9b4527675be50d1f4b1af Reviewed-on: https://chromium-review.googlesource.com/1147886 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#577432}
-
Philip Rogers authored
This patch makes link highlights draw using foreign layers. To achieve this, link highlights have been more tightly integrated into the blink lifecycle. There are five big changes: 1) With BlinkGenPropertyTrees, link highlights paint above all other content and without inherited effects. This will be better UX, and it resolves an issue where link highlight painting could change painting in a subtle way. 2) Link highlight animations require an effect paint property node so a new effect node is now created/updated on LayoutObjects that have link highlights. When link highlights are added or removed, we now mark the associated layout object as needing a paint property update. 3) LinkHighlights::UpdateGeometry has been moved from WebViewImpl::UpdateLifecycle to LocalFrameView::PaintTree. This ensures link highlight layers are created/updated before the drawable layers are collected. 4) CollectLinkHighlightLayersForLayerListRecursively now collects link highlight layers, associates them with the link highlight effect node, and creates foreign layers for them. Because there can be multiple highlights, LinkHighlight has been made a DisplayItemClient to ensure the foreign layer ids are unique. 5) LinkHighlightImplTest has been parameterized to run with and without BlinkGenPropertyTrees which required some refactoring to ensure the test teardown occurred while the BlinkGenPropertyTrees setting was in scope. This change does not remove the GraphicsLayer dependency of the link highlight implementation, which will be required for SPV2, but it moves the implementation much closer to a SPV2-compatible design. BUG=857501 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8ed54a56b4cb23ae581e8a848db921baf09afcce Reviewed-on: https://chromium-review.googlesource.com/1125295Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577431}
-
Matt Falkenhagen authored
Remove the instrumentation from issue 854993 (and duped issue 838410) as it is now fixed. This is mostly a straight revert of the CLs, but it retains some checks as DCHECKs and other improvements like adding constness. Bug: 866769, 854993 Change-Id: Id617e06e85e2b947258ba5f80c1d7aa0396888af Reviewed-on: https://chromium-review.googlesource.com/1147888Reviewed-by:
-
Luis Hector Chavez authored
This change adds Interface.Manager.buildThreadSafeProxy(), which is roughly analogous to mojo::ThreadSafeInterfacePtr<T>. Given that Java does not have move-only semantics, the Proxy object that is passed is unbound and a new object is returned. Bug: 810084 Test: cheets_ContainerSmokeTest in Chrome OS Change-Id: I6565f9e526e3fa8f8cb222cb8cd11e95bb57f7d3 Reviewed-on: https://chromium-review.googlesource.com/1147320Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#577429}
-
Yutaka Hirano authored
OriginRestriction has three values: - kUseDefaultOriginRestrictionForType - kRestrictToSameOrigin - kNoOriginRestriction kRestrictToSameOrigin is equivalent to "same-origin" request mode. kUseDefaultOriginRestrictionForType works as kRestrictToSameOrigin for certain resource types. kNoOriginRestriction works completely differently, it bypasses a CanDisplay check in BaseFetchContext::CanRequest. This CL replaces kRestrictToSameOrigin with "same-origin" request mode, kUseDefaultOriginRestrictionForType with "same-origin" request mode for the corresponding resource types. This CL also replaces kNoOriginRestriction with SecurityOrigin::GrantUniversalAccess because the CL which introduced the value[1] seems to want to bypass checks for requests with has_universal_access_ in PepperURLLoaderHost. 1: https://codereview.chromium.org/344883006 Bug: 736308 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0fb39b9f59aa6fd3c25244516e735b72a7183593 Reviewed-on: https://chromium-review.googlesource.com/1143669Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f0bf9a40..0f6c4505 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I90a39b6b0f08ac4870cb3c58550a5459069d983c Reviewed-on: https://chromium-review.googlesource.com/1147864Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577427}
-
Maksim Sisov authored
Just creating an OWNERS file in the ozone/wayland and adding myself and Antonio as owners. Change-Id: I684e74b6ff2c8ec000a2b0f1fe98d6843d9cea46 Reviewed-on: https://chromium-review.googlesource.com/1146931Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#577426}
-
Sam McNally authored
Drive syncing can be paused when on a cellular connection. Monitor the pref backing this option and the network connectivity type, and use it to toggle DriveFS syncing. Bug: 854155 Change-Id: I0e6602b4055f5bf8926728933b84c78fa2fa19d2 Reviewed-on: https://chromium-review.googlesource.com/1147801Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#577425}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a76af0ca2e8c..4206a0a8498a git log a76af0ca2e8c..4206a0a8498a --date=short --no-merges --format='%ad %ae %s' 2018-07-23 ouj@fb.com Exposing video bitrate allocator into API 2018-07-23 steveanton@webrtc.org Change DtlsTransport to use a ThreadChecker 2018-07-23 steveanton@webrtc.org Cleanup networkroute.h 2018-07-23 steveanton@webrtc.org Step 1: Add RemoveTrackNew which returns an RTCError Created with: gclient setdep -r src/third_party/webrtc@4206a0a8498a The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3ccbf37df904212e5f20a6c30cbc6233738ed649 Reviewed-on: https://chromium-review.googlesource.com/1147900Reviewed-by:
-
Victor Costan authored
This CL includes the following inter-dependent changes. 1) Use SQLITE_DEFAULT_LOOKASIDE instead of a sqlite_db_config() call. 2) Use SQLITE_OMIT_COMPILEOPTION_DIAGS. This is needed to avoid a compilation error after the previous change. 3) Rework the way Chome-specific defines are injected into the SQLite amalgamation. This is needed to get the code linking after the previous change, and is explained in detail below. 4) Replace Chromium -> Chrome in SQLite's BUILD.gn file. While the project's name is Chromium, the codebase refers to the resulting product as Chrome. This is not strongly related to the above, but is bundled to avoid merge conflicts. Chrome's SQLite version is first generated using the standard amalgamation process [1]. Then we inject a set of macros [2] adding a prefix to every symbol exported by SQLite. This is currently done by taking advantage of the fact that a standard build of SQLite #includes a "config.h" header if the _HAVE_SQLITE_CONFIG_H macro is defined. Our current approach relies on the fact that the amalgamation generation script simply happens to list ctime.c as the first file in the amalgamation [3]. When the file's content is ignored by defining the SQLITE_OMIT_COMPILEOPTION_DIAGS macro, the assumption does not hold anymore. This CL replaces the _HAVE_SQLITE_CONFIG_H macro with an approach guaranteed to surive changes in SQLite's amalgamation process. Instead of building amalgamation/sqlite3.c directly, this CL introduces a sqlite3_shim.c which sets up the Chrome-specific compilation environment, including our rename macros, and then #includes amalgamation/sqlite3.c. [1] https://www.sqlite.org/amalgamation.html [2] https://cs.chromium.org/chromium/src/third_party/sqlite/amalgamation/rename_exports.h [3] https://cs.chromium.org/chromium/src/third_party/sqlite/src/tool/mksqlite3c.tcl?q=ctime.c Change-Id: Ib4ccea5f9c025114e7d2ebf0305687ed21bf68b7 Reviewed-on: https://chromium-review.googlesource.com/1146155 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#577423}
-
Yuichiro Hanada authored
Now aura::client::kAppType property is set for an ARC notification window. We can use it for check. Change-Id: Id27f5ab83492a4c1a517b1350ae1fc30bfbf8fae Reviewed-on: https://chromium-review.googlesource.com/1146626 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#577422}
-
Zhongyi Shi authored
Bug: 790547 Change-Id: Icb1fd8643db0b344b41fc5a31340d44be0d0be2a Reviewed-on: https://chromium-review.googlesource.com/1145786Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577421}
-
Ryan Hamilton authored
TBR=asvitkine@chromium.org Bug: 862555 Change-Id: I87b37b6c2ebfd27d86e3116693dd71f18e608aaa Reviewed-on: https://chromium-review.googlesource.com/1147513Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 8184 8185 8186 8193 8195 8196 8197 8203 8207 8211 8217 8222 8232 8240 8253 8258 2 lines were removed and 4 lines were deflaked by consecutive results since 8195. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I043a191621b414909e17b48d34c6e1815ef28ef9 Reviewed-on: https://chromium-review.googlesource.com/1146121 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577419}
-
Luciano Pacheco authored
Re-enables the call to |notifyEntriesChanged| and refresh all required metadata which includes "share", "modificationTime" and "size" among others. The method |notifyEntriesChanged| invalidates all metadata, so we should update all required metadata fields. This fixes the issue where file list (RHS) wouldn't display modification time column, because sometimes when it would try to display the metadata had been invalidated due to the call to |notifyEntriesChanged|. |notifyEntriesChanged|, so the fact that they're all passing now it's the the actual test. Test: Several tests were failing when re-enabling Bug: 857343 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5a1e243c22c4040530c55d3d41708740dd617d88 Reviewed-on: https://chromium-review.googlesource.com/1117966Reviewed-by:
Daichi Hirono <hirono@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#577418}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I896d5cd0bdc2f76cc139717c2d8d4b625e46039c Reviewed-on: https://chromium-review.googlesource.com/1147710Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#577417}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b8eeb808d84f..903fb041a2f8 git log b8eeb808d84f..903fb041a2f8 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 94c91a95358b..522095f7d7fe (6 commits) Created with: gclient setdep -r src/third_party/skia@903fb041a2f8 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I920b1d59d2b324868922865cd9edfc6140146468 Reviewed-on: https://chromium-review.googlesource.com/1147721Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577416}
-
Sergey Ulanov authored
VideoCaptureSystemImpl expects to have non-null VideoCaptureDeviceFactory, but it was getting nullptr value on Fuchsia. As result the browser was crashing Bug: 866669 Change-Id: I73ec5c850acdc392a7984f62d9f66edb0961809a Reviewed-on: https://chromium-review.googlesource.com/1147514 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#577415}
-
Erik Luo authored
Screenshot: https://imgur.com/a/8u2tq05 Bug: 845449 Change-Id: Ibe8ca7b40133891cfe2701f90d26a2850b7d7497 Reviewed-on: https://chromium-review.googlesource.com/1077101Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577414}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1116ef0b1c45..c62aa207e9ac git log 1116ef0b1c45..c62aa207e9ac --date=short --no-merges --format='%ad %ae %s' 2018-07-23 tsepez@chromium.org Tighten up ThisProxy casts. Created with: gclient setdep -r src/third_party/pdfium@c62aa207e9ac The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I70086cea92cab118a977e75a9ee23e97e49730a8 Reviewed-on: https://chromium-review.googlesource.com/1147723Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577413}
-
Koji Ishii authored
When layout is cached, this patch: 1. Skips marking full paint invalidation. 2. Ensures the DisplayClientItem ID (the pointer of the DisplayItemClient) is unchanged for paint system to track the identity and possible offset changes. We may be able to (or may need to) reduce paint invalidations in more generic SetPaintFragment function, but I'm starting from eliminating the simple case first. By reviewing the paint/invalidation test results, 73 tests have the same or less invalidations with this change. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2f6a06aeca4898ca2e5347be23596c811a389f2b Reviewed-on: https://chromium-review.googlesource.com/1146120Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577412}
-
Lei Zhang authored
Avoid confusion with another software project with a similar name. Change-Id: I1072b05c19c682a5a0b749ce6199db73a9dd68a6 Reviewed-on: https://chromium-review.googlesource.com/1147302Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577411}
-
Georges Khalil authored
This CL has 2 changes: - Change location to Google Policy/Enrollment - Derive filename from client ID (in case the home directory is mounted remotely) Change-Id: I5b3acafd20119f79deef24fb44e3e0514c693311 Reviewed-on: https://chromium-review.googlesource.com/1145627 Commit-Queue: Georges Khalil <georgesak@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577410}
-
Lei Zhang authored
Change-Id: Ic9aae2a702866818c2b06aaae5710813b6335bfa Reviewed-on: https://chromium-review.googlesource.com/1135942Reviewed-by:
Jianzhou Feng <jzfeng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577409}
-
Wei-Yin Chen (陳威尹) authored
Some tests are disabled for now. Bug: 853281, 865527, 865540, 865709, 865715 Change-Id: I4fda286ff877301704426820ee10d200cd54468b Reviewed-on: https://chromium-review.googlesource.com/1144305Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577408}
-
Kurt Horimoto authored
LegacyReadingListToolbarButton is actually a plain UIView superview of the UIButton handling touch events, so setting the a11y identifier on the superview was not passing touches to the underlying button in EG tests. This CL updates LegacyReadingListToolbarButton to take an a11y identifier that's applied to the underlying UIButton, allowing touches to be handled properly. Bug: 866012 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1e98ae482bd21e1e913d500d53f43526fadb62af Reviewed-on: https://chromium-review.googlesource.com/1147310 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#577407}
-
Erik Luo authored
CodeMirror text editors try to reduce indentation on 'Shift+Tab'. However, this consumes the key event, preventing focus from leaving, even if nothing changed. This CL allows focus to leave when we are sure that no indentation should change. Shift+Tab can now move focus from Console prompt to toolbar and from SourceFrame's editor to the Sources TabbedPane. Bug: none Change-Id: I3660a48fe1c30a0972e2908514ee44fba7a51132 Reviewed-on: https://chromium-review.googlesource.com/1142519 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#577406}
-
Erik Luo authored
Anchors can precede a console message's content, which makes filters with start/end of line ('$', '^') fail. This CL evaluates any filter regexes on the message content separately from the anchor. Bug: 819799 Change-Id: I0957fd8fb3dea26f690e859cfabbc432cdda069c Reviewed-on: https://chromium-review.googlesource.com/1081561Reviewed-by: -
Chris Harrelson authored
Previously, in such situations we failed to mark the layer as needing layer requirements update, which already has code to issue an invalidation on the new backing of the content now that it lost squashing. Bug: 865415 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I807bf1426e45ce71ed42024512e9c77481f018cc Reviewed-on: https://chromium-review.googlesource.com/1145896 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
sczs authored
Bug: 865044 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9099ae71217f68eb624332debb8260faa067991d Reviewed-on: https://chromium-review.googlesource.com/1145629Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#577403}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5ba1e9caeecb..6ec6d27f2d1b git log 5ba1e9caeecb..6ec6d27f2d1b --date=short --no-merges --format='%ad %ae %s' 2018-07-24 iannucci@chromium.org [led] Update to f8fd394bd671f4cf4da8064a1ee074018c275d15. Created with: gclient setdep -r src/third_party/depot_tools@6ec6d27f2d1b The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If9fb52596690d667bd5c410fabfd53de8dbcb71c Reviewed-on: https://chromium-review.googlesource.com/1147720Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577402}
-
sczs authored
Changes the vertical stackView distribution to UIStackViewDistributionFillProportionally,so the stackView doesn't cut the subtitle label for lack of space. Bug: 862744 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I524dacb378515088faae9e99c0db408ad3f9b4b0 Reviewed-on: https://chromium-review.googlesource.com/1147541Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#577401}
-
tzik authored
ViewEventTestBase has no-op AddRef and Release for a historical reason, but they are no longer needed for years. Bug: 866456 Change-Id: Iea74ee9c87667f033fc90d47f2d331a202ab61d8 Reviewed-on: https://chromium-review.googlesource.com/1146538Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#577400}
-
