GitLab

These messages allow requesting display updates and performing basic display
configuration.

BUG=377497
NOTRY=true

Review URL: https://codereview.chromium.org/378673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282022 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a build failure. I also did some refactoring.
This is a re-land that fixes a build error.

BUG=313751
TBR=glider@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281804

Review URL: https://codereview.chromium.org/376733006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282021 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282020 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
NOTREECHECKS=true

TBR=ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/376143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282019 0039d316-1c4b-4281-b951-d872f2087c98

Currently, it returns 'const PasswordFormMap'. While returning a value, marking it const does not make much sense (it's a copy anyway). So it should be either 'const PasswordFormMap&' or just 'PasswordFormMap'. The only place this call is used at makes a copy of the result anyway, so I chose the former. That also seems to be a more versatile choice -- if somebody needs just a read-only copy in the future, returning by value would result in an unnecessary copy.

BUG=261628
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/382493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282018 0039d316-1c4b-4281-b951-d872f2087c98

This patch is mainly for merging into M37. In trunk, we should fix
base:: conversion routines instead.

Blink UTF conversion routines are considerably faster than the ones
from base::, especially on strings that only contain Latin-1 characters,
so use them instead. This gives a 9% speed gain on Cordova's "exec"
benchmark.

BUG=391492

Review URL: https://codereview.chromium.org/377173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282017 0039d316-1c4b-4281-b951-d872f2087c98

onc_validator had some deviations from the onc_spec.
This updates the onc_spec.

BUG=386182
R=davidroche@chromium.org, pastarmovj@chromium.org

Review URL: https://codereview.chromium.org/366273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282016 0039d316-1c4b-4281-b951-d872f2087c98

This CL does the 3 following things to allow the mojo shell to run:

- Updates java_apk.gypi to allow bundling additional libs.
- Bundle the network service with the mojo shell.
- Updates the shell to look for .so and .cr.so file in the local file
  system for android component build.

Review URL: https://codereview.chromium.org/334783006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282015 0039d316-1c4b-4281-b951-d872f2087c98

The only reason this flag is still around is because the buildbots still pass it to Telemetry.

BUG=None

Review URL: https://codereview.chromium.org/348223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344769

Review URL: https://codereview.chromium.org/378223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282013 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389016

Review URL: https://codereview.chromium.org/363853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282012 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282010 0039d316-1c4b-4281-b951-d872f2087c98

> Revert of NaCl: Update revision in DEPS, r13441 -> r13452 (https://codereview.chromium.org/371413003/)
> 
> Reason for revert:
> Suspect this is causing PPAPINaClNewlibTest.FileIO to crash on Mac:
> 
> http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%283%29/builds/3112
> 
> Original issue's description:
> > NaCl: Update revision in DEPS, r13441 -> r13452
> > 
> > This pulls in the following Native Client changes:
> > 
> > r13442: (dyen) Added support for log uploading for commands in toolchain_build.
> > r13443: (noelallen) Rolls DEPS file to get deps aware toolchains.
> > r13445: (dyen) Added a log_url field to package archs and recalculated revision hashes.
> > r13446: (ncbray) Factor arg parsing in sel_ldr into its own function.
> > r13447: (ncbray) Add my chromium account to OWNERS with my google account.
> > r13448: (dyen) Fixed repo_tools invalid reference to pynacl.
> > r13449: (thakis) Undo cros-specific hack now that r13435 seems to have stuck.
> > r13450: (ncbray) Consolidate sel_ldr's configuration logic.
> > r13451: (dyen) Package Version script now supports downloading build logs.
> > r13452: (hamaji) Non-SFI Mode: Add isatty interface
> > 
> > BUG=none
> > TEST=browser_tests and nacl_integration
> > CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281849
> 
> TBR=bradnelson@google.com,ncbray@chromium.org,mseaborn@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
> 
> Review URL: https://codereview.chromium.org/379663002

Reverting this causes new failure. Hence reverting the revert.

TBR=samuong@chromium.org

Review URL: https://codereview.chromium.org/379153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282009 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 281831 "Fix nacl_integration to run 32bit tests with 32bi..."
> 
> > Fix nacl_integration to run 32bit tests with 32bit userland and 64bit kernel.
> > 
> > detect_host_arch.py already knows how to figure this out, so reuse it.
> > (It could probably be used in the darwin and maybe even in the windows
> > branch too.)
> > 
> > BUG=368384
> > TEST=nacl_integration on http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/ goes green
> > TBR=mseaborn@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/373253002
> 
> Suspect this is causing the failure http://build.chromium.org/p/chromium.win/builders/NaCl%20Tests%20%28x86-64%29/builds/13394
> 
> TBR=thakis@chromium.org
> 
> Review URL: https://codereview.chromium.org/374383002

Reverting the revert since it doesn't seem to cause the problem

TBR=kaliamoorthi@chromium.org

Review URL: https://codereview.chromium.org/378283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282008 0039d316-1c4b-4281-b951-d872f2087c98

This test relies on data extracted from the Chrome DevTools (Blink-side)
frontend JavaScript code in a controversial manner

BUG=392430
TBR=stgao@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/379833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282007 0039d316-1c4b-4281-b951-d872f2087c98

This change plumbs '.active' and you will be able to access
an active worker via 'navigator.serviceWorker.active'.


BUG=379012
TEST=content_unittest --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py http/tests/serviceworker/waiting.html
TEST=run_webkit_tests.py  http/tests/serviceworker/active.html (http://crrev.com/373013002)

Review URL: https://codereview.chromium.org/354643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282006 0039d316-1c4b-4281-b951-d872f2087c98

The TableList specifies the overflow property depending on its height. If it
specifies 'hidden', the list cannot be scrolled even if the Files.app specific
scroll bar is visible.

BUG=391698
TEST=manually

Review URL: https://codereview.chromium.org/376123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282005 0039d316-1c4b-4281-b951-d872f2087c98

What this patch does:

 -- plumbs in GinJavaBridge... instead of JavaBridge... classes on
    browser and renderer sides;

 -- fixes the issue with adding JavaScript interfaces to popup windows
    created via WebChromeClient.onCreatePopup;

 -- updates JavaBridge tests to match the behaviour of the new
    implementation.

BUG=355644

Review URL: https://codereview.chromium.org/353163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282004 0039d316-1c4b-4281-b951-d872f2087c98

- move all the generic permission settings from gcm to content_settings
- delete the midi implementation in favour of this one.

Some important changes in midi.

Clicking Yes/No on Bubbles did not save the permission for future uses,
while when using infobars it was saved. Now it is saved in both cases

The existing midi implementation had some renderer crashes that have now
been fixed. It also had a browser race when tring to run the result
callback. Both issues are fixed in this implementation.

The midi cancel closure is not implemented, it does not seem to be used
anywhere and the paradigm was a bit convoluted
(passing it as an out pointer in RequestMidiSysExPermission)

The old midi infobar used to say Allow/Deny but the bubble said Allow/Block,
now it says Allow/Block in both cases.

BUG=392145

Review URL: https://codereview.chromium.org/365123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282003 0039d316-1c4b-4281-b951-d872f2087c98

Expose SyncProcessRunner's constants to use it in the test code.

BUG=344769

Review URL: https://codereview.chromium.org/375123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282002 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rogerta@chromium.org

Review URL: https://codereview.chromium.org/372843006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282001 0039d316-1c4b-4281-b951-d872f2087c98

Previously, DevToolsWindow relied on DevToolsClientHost life time,
which is error prone and introduced quite a few bugs.

BUG=392180

Review URL: https://codereview.chromium.org/371363005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282000 0039d316-1c4b-4281-b951-d872f2087c98

> Fix nacl_integration to run 32bit tests with 32bit userland and 64bit kernel.
> 
> detect_host_arch.py already knows how to figure this out, so reuse it.
> (It could probably be used in the darwin and maybe even in the windows
> branch too.)
> 
> BUG=368384
> TEST=nacl_integration on http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/ goes green
> TBR=mseaborn@chromium.org
> 
> Review URL: https://codereview.chromium.org/373253002

Suspect this is causing the failure http://build.chromium.org/p/chromium.win/builders/NaCl%20Tests%20%28x86-64%29/builds/13394

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/374383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281999 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=marja@chromium.org

Review URL: https://codereview.chromium.org/375273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281998 0039d316-1c4b-4281-b951-d872f2087c98

BUG=279351

Review URL: https://codereview.chromium.org/364883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281997 0039d316-1c4b-4281-b951-d872f2087c98

By the way, we should do this more often than once in 2000 revisions :)

BUG=345874
TBR=rnk@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/374373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281996 0039d316-1c4b-4281-b951-d872f2087c98

This is the same as
https://codereview.chromium.org/284743002

Which was reverted because a mojo refactoring won the checking race
and I did not notice the revert.

Original message:

Adding more guts to the mojo spy.

This CL fleshes out the basic architecture of the spy. Introducing SpyServerImpl and enough code to operate the "start" and "stop" commands of the front-end.

Still a quite a few loose ends, specially on teardown.

I updated the design doc to reflect this CL:
https://docs.google.com/a/chromium.org/document/d/11FKYXf9mSohlsgl4JmGlyWE1ScX3DKdssdjub63tkwA/edit?usp=sharing

TBR=darin
BUG=360188
TEST=manual via test/spy_repl_test.html

Review URL: https://codereview.chromium.org/379753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281995 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281994 0039d316-1c4b-4281-b951-d872f2087c98

cb46ea1 Fix BUILD.gn for commit 3522876d.
ab99c38 Revert 95c018e.
95c018e Fixes for re-enabling more MSVC level 4 warnings.
3522876 Remove custom memory manager.
e7ee98e Fix for UMR in CXML_Parser::GetCharRef.
30f2ff1 Fix integer overflow in fx_basic_[bw]string.cpp.
d7db790 Fix a crasher issue due to invalid 'bits per component' in PDF.
a26b328 fix a crash issue in _CMapLookupCallback.
f3227ae Fix uninitialized nresults and RGB.
e644f7f Fix uninitialized offset.
5a5c042 Fix uninitialized RGB in GetRGB.
17dd07a Fix uninitialized RGB in translating scanline.
ab4221c Integer overflow in fx_basic.h and fx_memory.h.
c7d8739 Fix uninitialized RGB in LoadPalette.
cceb554 Fix uninitialized font_offset.

Review URL: https://codereview.chromium.org/374233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281993 0039d316-1c4b-4281-b951-d872f2087c98

This will give us some insight into how often this happens.

BUG=353047

Review URL: https://codereview.chromium.org/356893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281992 0039d316-1c4b-4281-b951-d872f2087c98

The existing safe_browsing=2 only exercises the code path using
flywheel protection. safe_browsing=1 uses new code path that
combines full safe browsing and flywheel.

However, the full safe browsing feature is controlled by Finch
experiment. Without Finch experiment setup, the behavior is the
same as before, i.e., only Flywheel safe browsing is enabled.

BUG=381896

Review URL: https://codereview.chromium.org/343183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281991 0039d316-1c4b-4281-b951-d872f2087c98

Revert of DevTools: enable Screencast in DEBUG_DEVTOOLS mode (https://codereview.chromium.org/375873002/)

Reason for revert:
Breaks docked DevTools

Original issue's description:
> DevTools: enable Screencast in DEBUG_DEVTOOLS mode
> 
> This is useful for debugging Screencast without an Android device.
> 
> BUG=None
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281755

TBR=pfeldman@chromium.org,kaznacheev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/379123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281990 0039d316-1c4b-4281-b951-d872f2087c98

1) Early restart is disabled in "Chrome for ChromeOS" desktop build.
2) Ignore signin profile.

The first change simplifies development.
The second fixes the problem "user session cannot be ended if both
owner and current user both have (different) flags set."

BUG=391357
TEST=none

Review URL: https://codereview.chromium.org/378893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281989 0039d316-1c4b-4281-b951-d872f2087c98

- file_system extensions API.
- various extensions API code.
- some print preview code.

BUG=305852

Review URL: https://codereview.chromium.org/376813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281988 0039d316-1c4b-4281-b951-d872f2087c98

No need to manually manipulate the ref count when scoped_refptr can be used.

BUG=None

Review URL: https://codereview.chromium.org/376863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281987 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a unit test for the app list search result mixer. This
involves making Publish a static method on Mixer and moving the SortData
struct into the header file.

This is a precursor CL for https://codereview.chromium.org/369693004/.

BUG=349727

Review URL: https://codereview.chromium.org/372843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281986 0039d316-1c4b-4281-b951-d872f2087c98

This CL includes:
- Simple replacement by following rules.
    s/display: -webkit-box/display: flex/
    s/-webkit-box-orient: vertical/flex-direction: column/
    s/-webkit-box-orient: horizontal/flex-direction: row/
    s/-webkit-box-flex: 1/flex: auto/
    s/-webkit-box-flex: 0/flex: none/
    s/-webkit-box-pack: start/justify-content: flex-start/
    s/-webkit-box-pack: end/justify-content: flex-end/
    s/-webkit-box-pack: center/justify-content: center/
    s/-webkit-box-align: center/align-items: center/
    s/-webkit-box-align: baseline/align-items: baseline/
    s/-webkit-box-align: stretch/align-items: stretch/
- Flex items in "-webkit-box" don't shrink by default, but ones in "flex" shrink by default. So some flex items are specified "flex: none;" additionally. 
- "vertical-align: middle;" doesn't work for flex items, so specify "align-items: center;" for their parents.
- Some position adjustment taking care of difference between "-webkit-box" and "flex". (commented inline)

BUG=387568

Review URL: https://codereview.chromium.org/376783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281985 0039d316-1c4b-4281-b951-d872f2087c98

autocomplete_match_type is in chrome/common, but it is not used
by common and renderer actually. This CL removes the unused
includes and unused class referring AutocompleteMatchType.

BUG=388510
R=pkasting@chromium.org, brettw@chromium.org
TBR=jered@chromium.org, jschuh@chromium.org
TEST=build all

Review URL: https://codereview.chromium.org/377783005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281984 0039d316-1c4b-4281-b951-d872f2087c98

Use filename mentioned in download attribute of anchor element while saving file using "Save Link As" from context menu.

BUG=366370

Review URL: https://codereview.chromium.org/339153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281983 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281982 0039d316-1c4b-4281-b951-d872f2087c98