- 17 Sep, 2013 10 commits
-
-
jsbell@chromium.org authored
When porting the transaction back-end from Blink we brought along an AVLTree implementation for the in-memory key/value store for transactions. Replace this with a std::map since it provides similar performance guarantees (red-black tree) and we like to delete code. TBR=jam@chromium.org R=alecflett@chromium.org Review URL: https://chromiumcodereview.appspot.com/17462005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223493 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
Currently the Tooltip widget is created in the tooltip timer which also handles setting the tooltip text on the Tooltip object. There is a timing window between this and the mouse event coming in, which ends up causing the tooltips to not show up if the underlying root changes in between. Fixes bug https://code.google.com/p/chromium/issues/detail?id=292530 BUG=292530 R=sky@chromium.org, sky Review URL: https://codereview.chromium.org/23958012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223492 0039d316-1c4b-4281-b951-d872f2087c98
-
dpolukhin@chromium.org authored
BUG=292963 TEST=manual TBR=dskelton@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/23591056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223490 0039d316-1c4b-4281-b951-d872f2087c98
-
wonsik@chromium.org authored
BUG=NONE R=qinmin@chromium.org Review URL: https://chromiumcodereview.appspot.com/24065004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223487 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
Soon PerfTimer will move into base/timer/ directory as it is already used by production code. This splits the logging stuff into their owns files and also moves PerfTimeLogger into its own files. BUG=None TEST=base_unittests, ipc_perftests, etc... R=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/23985006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223486 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=293024,293033,293043,293049,293058 NOTRY=true TBR=thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/23470010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223485 0039d316-1c4b-4281-b951-d872f2087c98
-
ikarienator@chromium.org authored
> Simplify PPB_NetworkMonitor proxy. > > The new proxy is based on ppapi::proxy::PluginResource and > ppapi::host::ResourceHost which simplifies code significantly. Also > the permission check is consistent with socket APIs now. > > BUG=281781 > > Review URL: https://chromiumcodereview.appspot.com/23819033 TBR=sergeyu@chromium.org Review URL: https://codereview.chromium.org/23463037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223484 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
This also fixes a number of issues I saw when testing Netflix: -fix http status header not reaching plugin -send a Content-Type header if one isn't specified by the plugin for POSTs -null check info->headers, needed for data: URLs This doesn't support responding to 200s after a byte-range request. I'm gathering stats now to see how often this happens. BUG=286074 R=ananta@chromium.org, jschuh@chromium.org Review URL: https://codereview.chromium.org/23830007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223483 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
The new proxy is based on ppapi::proxy::PluginResource and ppapi::host::ResourceHost which simplifies code significantly. Also the permission check is consistent with socket APIs now. BUG=281781 Review URL: https://chromiumcodereview.appspot.com/23819033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223482 0039d316-1c4b-4281-b951-d872f2087c98
-
ccameron@chromium.org authored
This was previously disabled when running unit tests, but it looks like there are additional problems with WebViews, and potentially with switching in and out of compositing mode. TBR=zmo BUG=292655 Review URL: https://codereview.chromium.org/23757059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223480 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Sep, 2013 30 commits
-
-
girard@chromium.org authored
At scale factors above 125%, we are over-scaling up the dpi calculation. BUG=292607 Review URL: https://chromiumcodereview.appspot.com/23851034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223478 0039d316-1c4b-4281-b951-d872f2087c98
-
ernstm@chromium.org authored
We still need the 'webkit' category in the trace until the reference build is updated to a revision that uses 'webkit.console' for the timeline markers. R=tonyg@chromium.org BUG=282712 Review URL: https://chromiumcodereview.appspot.com/23757054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223477 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=292999 NOTRY=true TBR=glider@chromium.org Review URL: https://chromiumcodereview.appspot.com/23868033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223476 0039d316-1c4b-4281-b951-d872f2087c98
-
frankf@chromium.org authored
PageLoadingTest.testShouldBeAbleToNavigateForwardsInTheBrowserHistory TBR=craigdh@chromium.org BUG= Review URL: https://codereview.chromium.org/23619060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223475 0039d316-1c4b-4281-b951-d872f2087c98
-
noamsml@chromium.org authored
In debug builds, LogInterfaces cannot run in the IO or the UI threads due to an AssertIOAllowed() call (seems the IO thread cannot run actual IO either, see https://code.google.com/p/chromium/codesearch#chromium/src/base/threading/thread_restrictions.h ) NOTRY=true Review URL: https://chromiumcodereview.appspot.com/24181004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223473 0039d316-1c4b-4281-b951-d872f2087c98
-
armansito@chromium.org authored
Added a utility function to NetworkState to query if a network requires activation. All UI code should use this instead of comparing the Cellular.ActivationState property themselves, as this utility function handles the "unknown" case as well. BUG=289470 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/23532065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223472 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
Found by the Mac OS X 'leaks' tool; fixed on a plane. BUG=292905 Review URL: https://chromiumcodereview.appspot.com/23606034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223471 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
BUG=288991 R=koz@chromium.org Review URL: https://codereview.chromium.org/23970005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223470 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
I was working on the Windows build and having problems finding why a file was loaded that shouldn't have been. This adds the source of the invocation to the verbose logging so you can find this information. I removed an assert which caused a debug assertion for random punctuation and isn't harmful (a real error will be reported). I moved the location-to-string conversion code into the location class so I can share it for my new logging command, and moved a bunch of other logging functions to the new .cc file. BUG=288991 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/23532076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223469 0039d316-1c4b-4281-b951-d872f2087c98
-
tbarzic@chromium.org authored
Also, remove some uneeded dependencies from LoginState tests. BUG=NONE Review URL: https://chromiumcodereview.appspot.com/23444061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223468 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223466 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157831:157846&mode=html TBR= BUG= Review URL: https://chromiumcodereview.appspot.com/24184002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223465 0039d316-1c4b-4281-b951-d872f2087c98
-
scheib@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/23757050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223464 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=267983 TEST=compiles R=estade@chromium.org Review URL: https://chromiumcodereview.appspot.com/23629046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223463 0039d316-1c4b-4281-b951-d872f2087c98
-
rsadam@chromium.org authored
BUG=292727 Review URL: https://chromiumcodereview.appspot.com/23621045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223462 0039d316-1c4b-4281-b951-d872f2087c98
-
karenlees@chromium.org authored
Enables most of the test cases on windows. Adds TODOs and bug numbers for those still disabled. BUG=245594 Review URL: https://chromiumcodereview.appspot.com/23614016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223460 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none R=ben@chromium.org, jamesr@chromium.org TBR=jamesr@chromium.org Review URL: https://chromiumcodereview.appspot.com/23533057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223459 0039d316-1c4b-4281-b951-d872f2087c98
-
sukolsak@chromium.org authored
Clean the machine by uninstalling Chrome (if it's installed) for now. This allows the test slave to work properly. Eventually, we should read the clean state from the config file and clean the machine according to it. NOTRY=True BUG=264859 TEST= 1) Install Chrome at user level (if it's not installed already.) 2) Build Chrome with Release mode and make sure that mini_installer.exe is created. 3) Go to src\chrome\test\mini_installer 4) Run "python test_installer.py config\config.config --build-dir=<build-dir> --target=Release" where <build-dir> is the path to main build directory (the parent of the Release directory). The test should pass. 5) Repeat steps 1-4, but install Chrome at system level instead. The test should still pass. Review URL: https://chromiumcodereview.appspot.com/23523045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223458 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
NOTRY=true Review URL: https://chromiumcodereview.appspot.com/23464075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223457 0039d316-1c4b-4281-b951-d872f2087c98
-
nasko@chromium.org authored
> Enable GPU blacklist in tests. > > Partial re-land of https://codereview.chromium.org/22198004/) -- Always enable FCM on Windows -- Part 1/3. > > On top of fixing some of the issues there; only lands the part that enables the GPU blacklist in tests as the former CL is too hard to land all at once. > > Also keeping --skip-gpu-data-loading around for now to be able to deal with failures caused in layout_tests by this on their own later (this needs to land ASAP and layout_tests don't need this ASAP). > > Another CL will follow to always enable FCM on non-blacklisted Windows machines. > > This part re-enables loading the blacklist in tests (and adds a content_browsertest to make sure that the configuration we expect to be testing is indeed the one we are testing -- this uncertainty is basically the only reason the blacklist was explicitly disabled before). > > This CL also cleans up compositor_util.cc which was enforcing the blacklist twice. > > The original plan was to do this only for Windows as Mac/Linux was causing trouble, but it turns out to be harder to do it only on Windows; so taking care of http://crbug.com/277242 in this CL too after all... > > BUG=233830, 267038, 190942, 277242 > TBR=jcivelli, piman > > Originally Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219132 > Then Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=219159 > > Then re-committed (part 1/3): https://src.chromium.org/viewvc/chrome?view=rev&revision=221114 > Reverted in: https://src.chromium.org/viewvc/chrome?view=rev&revision=221145 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222105 > > Review URL: https://chromiumcodereview.appspot.com/23534006 TBR=gab@chromium.org Review URL: https://codereview.chromium.org/24074005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223456 0039d316-1c4b-4281-b951-d872f2087c98
-
ckocagil@chromium.org authored
BUG=248597 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223452 0039d316-1c4b-4281-b951-d872f2087c98
-
nyquist@chromium.org authored
This CL removes the last usage of clientlogin tokens for 'chromiumsync' on Android. BUG=264503 Review URL: https://chromiumcodereview.appspot.com/23686014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223450 0039d316-1c4b-4281-b951-d872f2087c98
-
michaelpg@chromium.org authored
ProfileInfoCache. Otherwise if the usernames are only being hashed by appending "-hash", extra dictionaries are created and written out to the LocalState file. In particular, the ProfileInfoCache stores some extraneous information. This change should have no impact when running on real machines. BUG=289772 Review URL: https://chromiumcodereview.appspot.com/23528008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223448 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=292960 NOTRY=true TBR=zhaoqin@chromium.org Review URL: https://chromiumcodereview.appspot.com/23480079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223444 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
This will allow us to keep images in drawable-mdpi in the source tree. BUG=289843 Review URL: https://chromiumcodereview.appspot.com/23944009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223443 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
NOTRY=true TBR=yangguo@chromium.org Review URL: https://chromiumcodereview.appspot.com/23950008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223441 0039d316-1c4b-4281-b951-d872f2087c98
-
tedchoc@chromium.org authored
Use the ability to track activity changes by registering a listener on the application. Also, this will manage the state of various activities on the java side. BUG=286071 Review URL: https://chromiumcodereview.appspot.com/23522032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223437 0039d316-1c4b-4281-b951-d872f2087c98
-
gbillock@chromium.org authored
R=asargent@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/23452031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223436 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
This also makes a minor change to WifiConfigView to update the 'Connect' button enabled state after receiving wifi properties by calling UpdateDialogButtons(). BUG=289642 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/23872021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223435 0039d316-1c4b-4281-b951-d872f2087c98
-
sheu@chromium.org authored
This CL removes a redundant class in the form of media::VideoCapture::VideoFrameBuffer, and replaces it with media::VideoFrame. Also: as media::VideoFrame has an embedded destruction callback, use this to handle buffer returns on the video capture stack, and remove the explicit VideoCapture::FeedBuffer entry point. BUG=None TEST=local build, content_unittests, run on desktop Linux with screen capture and webcam Review URL: https://chromiumcodereview.appspot.com/23587018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223434 0039d316-1c4b-4281-b951-d872f2087c98
-