- 17 Oct, 2017 40 commits
-
-
Eugene But authored
New NavigationManager::LoadIfNecessary triggers the load, which replaces WebState::View() hacky call. Bug: 705819 Change-Id: Ie8c13bd9eb07a982f88372ee17d2c2dd5f6a6018 Reviewed-on: https://chromium-review.googlesource.com/722223Reviewed-by:
Mike Baxley <baxley@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#509389}
-
Eric Noyau authored
Bug: 768876 Change-Id: Ibeeda79779df12348472e50fd9b58f012fd06184 Reviewed-on: https://chromium-review.googlesource.com/721741 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#509388}
-
Eugene But authored
LoadURLWithParams should load the URL without any additional calls, but the load does not happen because of crbug.com/705819. WebState::GetView() will be changed so it does not trigger pending, load hence LoadIfNecessary is used intead. Bug: 705819 Change-Id: I1356e37c6d3d7a0d9e0739e4605bf76928d455a8 Reviewed-on: https://chromium-review.googlesource.com/721078Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#509387}
-
Fredrik Söderquist authored
Compute the union of the children of a flow box using FloatRect too, then convert to a LayoutRect for setting the InlineBox's logical rect. Also restructure the physical->logical conversion a bit. Bug: 757436 Change-Id: I6c8f3a781c3c02dfb28d87eafa3df6cd5fb864f3 Reviewed-on: https://chromium-review.googlesource.com/721320Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#509386}
-
Jean-François Geyelin authored
Error found because XCode 9 now runs apps with a "Main Thread Checker" that detects invalid use of UIKit from a background thread. Bug: None Change-Id: I16b159b9dcb0710a37faa66c773063e5b97ae84f Reviewed-on: https://chromium-review.googlesource.com/723462Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#509385}
-
Mounir Lamouri authored
This is using the UKM service to record the autoplay attempts and the unmute results. Bug: 744659 Change-Id: Ice9a259a4006beff1044e5ed62981619841895e5 Reviewed-on: https://chromium-review.googlesource.com/525692 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#509384}
-
Gauthier Ambard authored
RecentTabsHandsetCoordinator should retain its block property. Bug: 775508 Change-Id: Ifd9bd829786592adde9057bec68bf3a73b6c9fc2 Reviewed-on: https://chromium-review.googlesource.com/723304Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#509383}
-
Dave Tapuska authored
Instantiate MockWidgetInputHandler in MockWidgetImpl. No behavioural side effects of this change are occurring in this CL that will come in a followup CL once the class is in the correct location. BUG=722928 Change-Id: Ia1096e8c5ca7cdc6b745fe289961b48e910f1fb0 Reviewed-on: https://chromium-review.googlesource.com/719236Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#509382}
-
Eric Lawrence authored
Change the default configuration of the MarkNonSecureAs to show warnings when the user loads a non-secure page in Incognito mode or edits a form field on a non-secure page. Bug: 721898 Change-Id: I2803f56dbe256d1c56981663f1694efff4c52f1c Reviewed-on: https://chromium-review.googlesource.com/721683Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#509381}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/de105717..06d8821c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ib916384979a16492152799cbc011946a42f8dae1 Reviewed-on: https://chromium-review.googlesource.com/723259Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#509380}
-
Jérôme Lebel authored
I forgot to add my egtests file into BUILD.gn in crrev.com/c/647530 Bug: Change-Id: I36fb246d2d612603c80e02658755f072b54e7a28 Reviewed-on: https://chromium-review.googlesource.com/721546Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#509379}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/ae7dc1f62d82..94f6d57a4c42 $ git log ae7dc1f62..94f6d57a4 --date=short --no-merges --format='%ad %ae %s' 2017-10-16 ewaldhew [cff] Fix segfault on missing `psaux' (#52218) 2017-10-15 apodtele [base, cff] Fix MSVC warnings. 2017-10-14 apodtele [base] Netpbm image tracing. 2017-10-14 apodtele * builds/windows/ftdebug.c (FT_Message): Print to stderr. 2017-10-14 behdad [afshaper] Delay creating `hb_set' objects until needed. 2017-10-12 ewaldhew * devel/ftoption.h: Enable T1_CONFIG_OPTION_OLD_ENGINE by default. 2017-10-12 ewaldhew [type1, cid] Add hinting engine switch. 2017-10-12 ewaldhew Add T1_CONFIG_OPTION_OLD_ENGINE configuration option. 2017-10-12 ewaldhew Extract width parsing from Type 1 parser. 2017-10-12 wl [autofit] Better visualize table tracing in source code. 2017-10-09 wl * src/base/ftoutln.c (FT_Outline_Translate): Fix integer overflow. 2017-10-08 wl * src/base/ftobjs.c (ft_glyphslot_preset_bitmap): Integer overflows. 2017-10-08 wl Document global size metrics needed for native bytecode hinting (#52165). 2017-10-08 wl Prevent creation of an incorrect documentation entry. 2017-10-07 wl [sfnt] Adjust behaviour of PS font names for variation fonts. 2017-10-07 wl [cff, truetype] Adjust behaviour of named instances. 2017-10-07 wl Make `FT_Set_Named_Instance' work. 2017-10-07 wl Make `FT_FACE_FLAG_VARIATION' work. 2017-10-07 wl New function `FT_Set_Named_Instance'. 2017-10-07 wl Add macros for checking whether a font variation is active. 2017-10-07 wl Add framework for setting named instance in MM service. 2017-10-07 wl [type1] Minor code shuffling. 2017-10-05 wl * src/base/ftobjs.c (ft_glyphslot_preset_bitmap): Fix integer overflow. 2017-10-05 wl Fix compiler warnings. 2017-10-04 John.Tytgat [cff] Add support for `FSType'. 2017-10-02 wl CHANGES: Formatting. 2017-10-01 wl [smooth,type1] Formatting, whitespace. 2017-10-01 wl [psaux] Formatting, minor fixes, whitespace, copyright notices. 2017-09-30 wl [base,cff,cid] Whitespace, formatting. 2017-09-30 wl [include] Whitespace. 2017-09-30 apodtele Signedness fixes in bitmap presetting. 2017-09-29 apodtele Bitmap metrics presetting [2/2]. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org Change-Id: Ie327d67350aeaec40df6d1a6d4379c8c20c8b58a PDFium-bug: https://bugs.chromium.org/p/pdfium/issues/detail?id=918 Reviewed-on: https://chromium-review.googlesource.com/721779Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509378}
-
Marc-Antoine Courteau authored
This was requested by sdefresne in https://chromium-review.googlesource.com/c/chromium/src/+/719477/6/ios/chrome/browser/ui/payments/cells/payments_text_item_unittest.mm#44 R=mahmadi Bug: Change-Id: Ic59eda9202d21d9c36ad194d5b41b120e70ad461 Reviewed-on: https://chromium-review.googlesource.com/721870Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#509377}
-
Lutz Justen authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/72120182b44d..106eeed3635e $ git log 72120182b..106eeed36 --date=short --no-merges --format='%ad %ae %s' 2017-09-29 matthewmwang wifi: system_api: adding constant for OpenVPN.ExtraHosts support 2017-09-18 ljusten Add proto for policy storage and retrieval 2017-10-05 benchan shill: remove kProposeScanFunction constant 2017-10-02 dgreid Add constant for the Termina VM component 2017-09-29 ejcaruso modemmanager: add ModemManager1.Modem interface name Created with: roll-dep src/third_party/cros_system_api Bug: Change-Id: Iae949703a863be9f495974f5ad665a1902436d26 Reviewed-on: https://chromium-review.googlesource.com/723099Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#509376}
-
Niels Möller authored
The earlier problems with linking fuzzer tests should be fixed with webrtc cl https://webrtc-review.googlesource.com/c/src/+/6840 This is a reland of fd5966b5 Original change's description: > Set rtc_link_task_queue_impl = false and link in task_queue.cc explicitly. > > Bug: webrtc:8166 > Change-Id: I83f4adb45f66a90db179f229e165419a6d3307c1 > Reviewed-on: https://chromium-review.googlesource.com/681814 > Reviewed-by: Per Kjellander <perkj@chromium.org> > Reviewed-by: Henrik Kjellander <kjellander@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Niels Möller <nisse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505570} Bug: webrtc:8166 Change-Id: Ie68448b7ab7d6bc8daa413a1f17b85118953d26f Reviewed-on: https://chromium-review.googlesource.com/702294Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#509375}
-
mariannet authored
Bug: 762159 Test: manually Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c8c8dfe6f81a121e5b0c08ee6c28f5074d9ca35 Reviewed-on: https://chromium-review.googlesource.com/722461Reviewed-by:
Keigo Oka <oka@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Marianne Thieffry <mariannet@google.com> Cr-Commit-Position: refs/heads/master@{#509374}
-
Vladislav Kuzkokov authored
Bug: Change-Id: I348f2aec1158c5b9db6ba42182cb635d6574ec5c Reviewed-on: https://chromium-review.googlesource.com/721740Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#509373}
-
Ke He authored
This is a preparation CL for mojofication on InputServiceLinux. Before this CL, the HidDetectionScreen always query the InputServiceProxy for connected devices. As a part of InputServiceLinux mojofication, the InputServiceProxy will be removed. All clients will be converted to use the InputDeviceManager mojo Interfaces. In HidDetectionScreen, to avoid calling mojo interface frequently and to make the logic of creating/deleting the InterfacePtr<InputDeviceManager> more simple, it should get and maintain the list of devices instead of always doing query. To test, go through the following cases: 1. If a Chrome OS device has sufficient input devices (mouse, keyboard), the HID detection screen should be skipped. 2. If a Chrome OS device doesn't have sufficient input devices (mouse, keyboard), the HID detection screen should show up. 3. Put a few Bluetooth devices in pairing mode, and when HID detection screen shows up, make sure the detection screen can detect them and pair with them. 4. Show HID detection screen first, and then put a few Bluetooth devices in pairing mode, make sure the detection screen can detect the new Bluetooth devices and pair with them. 5. On HID detection screen, test Chrome OS device can pair with several Bluetooth devices and then go forward to the Network screen and login the user session, test the Bluetooth is still power on and the Bluetooth devices can still be used. 6. On HID detection screen, connect a wire keyboard and mouse (not Bluetooth one), and go forward to the Network screen, test that the Bluetooth should be powered off. BUG=767309 Change-Id: I518b9a322ca162a861a241261f780d065e3e946e Reviewed-on: https://chromium-review.googlesource.com/680500Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#509372}
-
Bhagirathi Satpathy authored
Same exception message is coded separately for addEventListener and removeEventListener. Made this as common code. Bug: Change-Id: I6f0b131cee7e524b17340963273e685e456da3a2 Reviewed-on: https://chromium-review.googlesource.com/721481Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#509371}
-
Vasilii Sukhanov authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/718858. The combobox should be center-aligned with the label like it used to be. Only the static password label is top-aligned. Bug: 774393,774962 Change-Id: Id4fe1bf3a93d30f2d9748978afb91df08929726c Reviewed-on: https://chromium-review.googlesource.com/723139 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#509370}
-
Klemen Kozjek authored
This CL adds an operation for compression part of Zip Archiver to release resources allocated by a compressor. As a result, there will be no stale compressor left in Zip Archiver's PNaCl module. Bug: 359837 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8da6232a3e1c3cc3d1f38015fd43d26d45769376 Reviewed-on: https://chromium-review.googlesource.com/712675 Commit-Queue: Klemen Kozjek <klemenko@google.com> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#509369}
-
Vadym Doroshenko authored
GAIA change password form is on myaccount.google.com domain not on accounts.google.com. As result credentials saved on change password form and on sign-in forms are treated separately. This CL fixes: 1.Stop proposing saving sync password. 2.Update sync password hash. TBR=vabr@chromium.org Bug: 767621 Change-Id: I90c5deda2a765e15e1165dc391f18fe803364405 Reviewed-on: https://chromium-review.googlesource.com/715760Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#509368}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f4579b90..de105717 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ic860f7b2c7e1379f59f53f155427b993799c3190 Reviewed-on: https://chromium-review.googlesource.com/721349Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#509367}
-
Vasilii Sukhanov authored
Bug: 774516 Change-Id: I17344d16d835a9db9daf1c87824ea9e40ec38baa Reviewed-on: https://chromium-review.googlesource.com/721544 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#509366}
-
Eric Noyau authored
Bug: 768876 Change-Id: I12f81073a5749978cbdd2e18d139fb38f4142e62 Reviewed-on: https://chromium-review.googlesource.com/722939Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#509365}
-
Hector Dearman authored
ProcessMemoryDump's can now be passed (via mojo) to other processes. At the moment they use TraceLog::GetInstance()->process_id() to get the process id when adding MADs. This incorrect after they have been passed to another process (this isn't a big deal: adding MADs in the wrong process ought to be undefined) but more importantly this makes it hard to test code which uses PMDs from multiple processes. This CL switches the code to derive the GUIDs from UnguessableTokens and happily removes another tracing dependency. Change-Id: I683b57be1a29f0c9f42fd71fa7f065a089ca747e Reviewed-on: https://chromium-review.googlesource.com/707094 Commit-Queue: Hector Dearman <hjd@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#509364}
-
Yutaka Hirano authored
This change introduces (yet another) Dictionary::Get function which implements part of https://heycam.github.io/webidl/#es-dictionary. Fetch API will use the function in subsequent CLs. Bug: 775318 Change-Id: I009ac158f05fbb9767b873a7a1d0123b04e3bc4b Reviewed-on: https://chromium-review.googlesource.com/722539 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509363}
-
Sami Kyostila authored
BUG=752914 Change-Id: I1adde656a84d01cc2149df71051d7042308dbf5a Reviewed-on: https://chromium-review.googlesource.com/721122 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#509362}
-
Erik Språng authored
Bug: chromium:763949 Change-Id: If2220274063c0053390ea5588fcce11a973bb071 Reviewed-on: https://chromium-review.googlesource.com/720926Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Erik Språng <sprang@chromium.org> Cr-Commit-Position: refs/heads/master@{#509361}
-
Renjie Liu authored
The cl first generate s2CellId to language code mapping from the adminregionsdata.csv, and provide a lookup function for any lat/lng pair to convert to a list of S2CellIds which will be used for query corresponding language codes. Design doc: https://docs.google.com/document/d/1JPuaAsQqSqYELabGla1qn_JKGeB8vNTK8Sa2DgrWQkU/edit?ts=59d2c47b#heading=h.z2uacpmfvnuk 1) Read s2 cellid with lang code data from adminregionsdata.csv; 2) Generate cpp code to look up language code. 3) Lookup logic impl. 4) Add unit test as well. The generated code will live under <OUT_DIR>/gen/components/language/util Bug: 769160 Change-Id: I198488adce31def9741663adf57d59df45a45159 Reviewed-on: https://chromium-review.googlesource.com/559184 Commit-Queue: Renjie Liu <renjieliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#509360}
-
Takashi Toyoshima authored
test_support of platform/loader and platform/network should depends on //storage/public/interfaces:interfaces_blink__generator because it indirectly includes generated mojo interface headers. This is the root cause of the original issue, and it seems BUILD file splitting makes it happens more easily. This is a reland of 997ce7ad Original change's description: > Reland "Split WebKit platform build file" > > platform/network/BUILD.gn lacked mojo_bindings_blink dependency. > This caused a race on compiling. > > This is a reland of 080c70a7 > Original change's description: > > Split WebKit platform build file > > > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader. > > To resolve it necessary to extract targets //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed. > > All of these done in this CL. > > > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it > > to submit since it needs quick rebase works to catch up HEAD. > > > > Bug: 754600 > > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e > > Test: gn check out/Release && ninja -C out/Release > > Reviewed-on: https://chromium-review.googlesource.com/612284 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Daniel Bratell <bratell@opera.com> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#508661} > > TBR=engedy@chromium.org > > Bug: 754600 > Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc > Reviewed-on: https://chromium-review.googlesource.com/718243 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#508993} TBR=engedy@chromium.org Bug: 754600 Change-Id: Ia1231a3ee2213bb44474bd8ffeacf67b86002bfd Reviewed-on: https://chromium-review.googlesource.com/720542 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#509359}
-
Marc Treib authored
These were all converted to Mojo a while back, but some things were not moved to instant_struct_traits.h (probably an oversight). Bug: none Change-Id: Iad96765a80557e634eb56ca7309533f22ef5c273 Reviewed-on: https://chromium-review.googlesource.com/712736Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#509358}
-
Makoto Shimazu authored
Bug: 754139 Change-Id: I3a81eed8d8dbf406bb0188ae01b03630ba3199b3 Reviewed-on: https://chromium-review.googlesource.com/704421 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#509357}
-
Klemen Kozjek authored
This CL adds Cancel operation to Zip Archiver's packer. Cancel operation can be invoked through 'Cancel' button on the progress notification. As a result, long zip operations can now be canceled from UI. Bug: 359837 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6c334201c6eb1db05276628056b1747d88f9398e Reviewed-on: https://chromium-review.googlesource.com/712136Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Klemen Kozjek <klemenko@google.com> Cr-Commit-Position: refs/heads/master@{#509356}
-
Eric Willigers authored
We interpolate between paths when they have the same number and type of path segments. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/_DPl-JG6bV8/y2_GUwFVDwAJ BUG=696395 Change-Id: Ib5de282169cbb6ab4d5a4972d5e894dc000cf1d3 Reviewed-on: https://chromium-review.googlesource.com/706747 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#509355}
-
Keishi Hattori authored
In an effort to consolidate heap related code to ThreadHeap, this CL moves arenas_(and related fields) from ThreadState to ThreadHeap. Also moves the following related methods from ThreadState to ThreadHeap. - MakeConsistentForGC() - MakeConsistentForMutator() - Compact() - Arena() - FindPageFromAddress() - ShouldFlushHeapDoesNotContainCache() - IsAddressInHeapDoesNotContainCache() - VectorBackingArena() - ExpandedVectorBackingArena() - AllocationPointAdjusted() - PromptlyFreed() - PoisonEagerArena() - PoisonAllHeaps() - RemoveAllPages() - TakeSnapshot() - ClearArenaAges() - ArenaIndexOfVectorArenaLeastRecentlyExpanded() Bug: 757440 Change-Id: Ib734628157daf7fbe9f6386f22d473532ee32483 Reviewed-on: https://chromium-review.googlesource.com/718161Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509354}
-
Rune Lillesveen authored
Leaving Opera. TBR=jochen@chromium.org,mstensho@opera.com NOTRY=true Change-Id: Ia6acfa96bc8a899b970cb4edd213cfb43a2abe2b Reviewed-on: https://chromium-review.googlesource.com/721181Reviewed-by:
Rune Lillesveen <rune@opera.com> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#509353}
-
Naina Raisinghani authored
Currently when we copy over a StyleRule we parse all proeprties greedily. This should only be the already parsed properties. The greedy method may result in a dangerous state. This is a speculative fix for the ClusterFuzz issue. Bug: 774061 Change-Id: I0b7f09018c7cf2d8ca75ea5d705016fbcce6f0ae Reviewed-on: https://chromium-review.googlesource.com/722579Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#509352}
-
Darren Shen authored
Currently we over/underflow if a counter value goes beyond the limits of a 32 bit integer. The spec [1] says we can ignore the increment if it would cause an over/underflow. This patch implements this behaviour. Firefox follows the spec in this. [1] https://drafts.csswg.org/css-lists-3/#valdef-counter-reset-custom-ident-integer Bug: 655473 Change-Id: I6e10b6e4f5f672d723a0ccb69fd309d52d1d1204 Reviewed-on: https://chromium-review.googlesource.com/708105Reviewed-by:
Justin Schuh <jschuh@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#509351}
-
Becca Hughes authored
This fixes a regression where touch/click events are not correctly being picked up by the slider. This adds padding around the timeline and volume slider which will pick up gestures in these areas. There is no visual effect of this change. BUG=773475 Change-Id: Idff48c259438bb776f6794d921625f5340744d1b Reviewed-on: https://chromium-review.googlesource.com/721319Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#509350}
-