GitLab

The code will continue to load the 200P pak file and fall back to those
resources, but the supported scale factor on @3x devices will now be 300P.

This CL adds a unittest to ensure that image conversion works properly when the
scale factor of the source image does not match the current supported scale
factor of the system.

BUG=413300
TEST=None

Review URL: https://codereview.chromium.org/574663003

Cr-Commit-Position: refs/heads/master@{#295160}

The previous fix for positive start times http://crrev.com/93c37f1b is
incomplete. It fixed seeking, but did not fix rendering. As such, the
media timeline will start playback from 0 and advance in real time to
any positive start time... even if the actual start is hours away.

When testing I used a test clip with a short positive start time so
did not notice the issue.  In attempting to write a layout test, I
retested with a larger start time which revealed the deficiency in my
first solution.

This change reverts the removal of Demuxer::StartTime() with the added
restriction that it must always be positive.  Pipeline uses this time
like it did before, during initialization and as a minimum bound for
seeking.

BUG=413292
TEST=four new tests! layout test forthcoming.

Review URL: https://codereview.chromium.org/575643002

Cr-Commit-Position: refs/heads/master@{#295159}

specified.

BUG=409724
TEST=SplitViewcontrollerTest.SplitModeActivation

Review URL: https://codereview.chromium.org/573803003

Cr-Commit-Position: refs/heads/master@{#295158}

BUG=none
TEST=cq
TBR=brettw

Review URL: https://codereview.chromium.org/576653003

Cr-Commit-Position: refs/heads/master@{#295157}

BUG=414467

Review URL: https://codereview.chromium.org/567643003

Cr-Commit-Position: refs/heads/master@{#295156}

Previously the local NTP thumbnails were stretched. We now make preserve
ratio preserved by setting height to "auto", but keep min-height to 100%
so if thumbnail is too short we won't see blank space.
To accommotate Material Design thumbnails, we make stored thumbnails
taller. In the thumbnail <iframe>, the extra height is hidden from view.

BUG=414878

Review URL: https://codereview.chromium.org/564973003

Cr-Commit-Position: refs/heads/master@{#295155}

This should increase the quantity of perf profiles collected for
chromiumos-wide-profiling by a factor of 8. Based on the current amount of
data received, this should increase the number of profiles collected to a
quantity less than it was before the collection scheduling was changed in
https://codereview.chromium.org/282093011/

TEST=Not really... This is just turning a knob. I did compile it.
BUG=chromium:413951

Review URL: https://codereview.chromium.org/559843007

Cr-Commit-Position: refs/heads/master@{#295154}

CreateTrailsFromString function accepts values for trails_string argument without last separator symbol

BUG=401298

Review URL: https://codereview.chromium.org/452923003

Cr-Commit-Position: refs/heads/master@{#295153}

Revert of mojo: Create a basic clipboard. (patchset #29 id:540001 of https://codereview.chromium.org/562483002/)

Reason for revert:
Breaking GN builders.

http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20GN&number=10604

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/12120/steps/gn/logs/stdio

Original issue's description:
> mojo: Create a basic clipboard.
>
> This creates a basic clipboard interface and uses it from
> html_viewer. This is a minimal implementation and does not actually
> interact with the system clipboard.
>
> BUG=411039
>
> Committed: https://crrev.com/757286d8a2c778fe4622890140c9b9d2afd21063
> Cr-Commit-Position: refs/heads/master@{#295143}

TBR=dcheng@chromium.org,darin@chromium.org,sky@chromium.org,erg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411039

Review URL: https://codereview.chromium.org/579503003

Cr-Commit-Position: refs/heads/master@{#295152}

Relanding  https://codereview.chromium.org/564553002/ with fixes for the unit test failures which required addition of some more plumbing in the form of dummy IO and file blocking threads. The IO thread is needed to ensure that the RenderWidgetHelper instances get freed corectly.

When we switch tabs in chrome, the tab being switched away from gets hidden/shown/hidden.

This occurs in the NativeViewHostAura::NativeViewDetaching code path where we first remove the
clipping window which is the intermediate parent of the web contents view. The clipping window
is hidden which causes the RWHVA::Hide function to get called which initiates the hiding sequence.
Then the web contents view is reparented to the main view which is still visible. Now the RWHVA::Show
function is called which initiates the show sequence. Eventually the main view is hidden, which then
initiates the hide sequence.

Addressed this with the following changes.
1. WebView::AttachWebContents and WebView::DetachWebContents
   now show and hide the webcontents native view. The
   WebContents is shown and hidden as before in
   WebContentsNativeViewAura::OnWindowVisibilityChanged.

2. Removed the WebContentsNativeViewAura::OnWindowParentChanged function.
   This function was present to show and hide the webcontents if the window was visible.
   This should not be needed with the change in #1 above.

3. Added a new file webview_unittest.cc. This contains the unittest WebViewUnitTest.TestWebViewAttachDetachWebContents
   This is run as part of unit_tests.exe.

BUG=412989
R=sky

Review URL: https://codereview.chromium.org/569153005

Cr-Commit-Position: refs/heads/master@{#295151}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1e78fc4..170f90b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/577553004

Cr-Commit-Position: refs/heads/master@{#295150}

./run_benchmark --output-format=json --output-format=html foo

BUG=

Review URL: https://codereview.chromium.org/574593002

Cr-Commit-Position: refs/heads/master@{#295149}

The SDK has a dependency on an inner interface on the nacl side.
We use a fake to share code.
Updating the fake to actually provide what the nacl side expects.

BUG=None
TEST=trybots
R=sbc@chromium.org,binji@chromium.org

Review URL: https://codereview.chromium.org/575743006

Cr-Commit-Position: refs/heads/master@{#295148}

BUG=366145

Review URL: https://codereview.chromium.org/577673004

Cr-Commit-Position: refs/heads/master@{#295147}

This allows for specifying more than one urls for update checks and pings.
The urls are then tried in the order they are specified.

BUG=413879

Review URL: https://codereview.chromium.org/565363002

Cr-Commit-Position: refs/heads/master@{#295146}

We haven't been using the Safe Browsing timing histograms. Remove the
timing code and mark the histograms obsolete.

BUG=

Review URL: https://codereview.chromium.org/572163002

Cr-Commit-Position: refs/heads/master@{#295145}

A new version of Issue 565583005: Clean up GestureEventDetails
constructors
https://codereview.chromium.org/565583005/

BUG=350942

TBR=tdresser@chromium.org, jdduke@chromium.org, sadrul@chromium.org

Review URL: https://codereview.chromium.org/573963005

Cr-Commit-Position: refs/heads/master@{#295144}

This creates a basic clipboard interface and uses it from
html_viewer. This is a minimal implementation and does not actually
interact with the system clipboard.

BUG=411039

Review URL: https://codereview.chromium.org/562483002

Cr-Commit-Position: refs/heads/master@{#295143}

Relanding of https://codereview.chromium.org/465543004
with a fix for official builds.

This establishes a ManifestFetchDataDelegate for use
by ExtensionDownloader and ManifestFetchData, and moves
ManifestFetchData into //extensions/browser/updater.

The delegate provides implementation details for
update manifest fetching, including brand code,
boilerplate query parameters, and ping data.

Chrome's implementation has knowledge of the
Google brand, the metrics service, and Omaha-specific
query parameters necessary for CRX item queries.

BUG=398671
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/475423002

Cr-Commit-Position: refs/heads/master@{#295142}

While TapDown gestures are a typical part of the touch-gesture pipeline,
they are not required and probably even undesirable in the case of
synthetic Tap gestures (e.g., with tap disambiguation). Allow such
synthetic taps through the gesture stream validator.

BUG=414372

Review URL: https://codereview.chromium.org/572853005

Cr-Commit-Position: refs/heads/master@{#295141}

BUG=414766

Review URL: https://codereview.chromium.org/574033003

Cr-Commit-Position: refs/heads/master@{#295140}

This picks up:
Update NDK to r10c-rc4
https://gerrit.chromium.org/gerrit/71574

Review URL: https://codereview.chromium.org/570263002

Cr-Commit-Position: refs/heads/master@{#295139}

r294653 added two DCHECKs in JingleSession in CancelChannelCreation()
and destructor. These checks were failing in the client sometimes. This
CL fixes the code that was causing them to fail:
 1. The ChannelMultiplexer needs to be destroyed explicitly in the
    destructor.
 2. ChannelDispatcherBase was calling CancelChannelCreation() even
    after the channel is created.

Review URL: https://codereview.chromium.org/571273003

Cr-Commit-Position: refs/heads/master@{#295138}

Many targets in mojo need to depend on different targets depending on if
they are building in the static or component build. In gyp, this is done
with variables (since that's the only thing you have) and the GN build
initially copied these variables into //mojo/system.gni. This worked, but
is not very idomatic in GN. This replaces the variables with groups that
forward to the correct depenedency depending on the build type and
target type (encoded in the target name).

R=brettw@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/554363005

Cr-Commit-Position: refs/heads/master@{#295137}

Revert of Introduce GetBackendFromContextId to avoid using list index. (patchset #1 id:1 of https://codereview.chromium.org/556003005/)

Reason for revert:
It looks like the moto E perf bots are broken due to this change.

BUG=414267

Original issue's description:
> Introduce GetBackendFromContextId to avoid using list index.
>
> BUG=398467
> TEST=ExtensionTest
>
> Committed: https://crrev.com/a1a83005087fdac70e7809f9dc1d89f6c4f88dfc
> Cr-Commit-Position: refs/heads/master@{#294455}

TBR=tbarzic@chromium.org,achuith@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=398467

Review URL: https://codereview.chromium.org/573573003

Cr-Commit-Position: refs/heads/master@{#295136}

Random fixups that the automated rewriting tool opted to skip.

BUG=110610

Review URL: https://codereview.chromium.org/578533002

Cr-Commit-Position: refs/heads/master@{#295135}

This is in preparation for using the networkingPrivate API directly
for the code that has been re-factored so far.

BUG=279351

Review URL: https://codereview.chromium.org/544173013

Cr-Commit-Position: refs/heads/master@{#295134}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a32f175..1e78fc4

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/569313005

Cr-Commit-Position: refs/heads/master@{#295133}

This reverts commit 3853ffa8.

The change broke the Mac10.6 Tests bot on the chromium.webkit waterfall.

TBR=hwennborg@chromium.org, thakis@chromium.org
BUG=400849

Review URL: https://codereview.chromium.org/572413002

Cr-Commit-Position: refs/heads/master@{#295132}

Going to add it as a build step:
https://codereview.chromium.org/575733003/
but for now, don't want to error out.

TBR=brettw@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/577723002

Cr-Commit-Position: refs/heads/master@{#295131}

This field is not used at all.

BUG=408755
R=dewittj@chromium.org
TEST=build all succeeds

Review URL: https://codereview.chromium.org/566093002

Cr-Commit-Position: refs/heads/master@{#295130}

BUG=411015

Review URL: https://codereview.chromium.org/539343002

Cr-Commit-Position: refs/heads/master@{#295129}

This is like https://codereview.chromium.org/443483002/ , but that check wasn't
as convincing as it could have been since clang accepts override and final as
an extension in c++98 mode. No intended behavior change.

If your bot can't deal with this, please let me know!

BUG=none
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/555383004

Cr-Commit-Position: refs/heads/master@{#295128}

This prevents racy teardowns that might cause BrowserPlugin to try to delete an invalid
pointer

BUG=none
Test=Open browser sample, and close browser sample. It should not crash.
TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/574623004

Cr-Commit-Position: refs/heads/master@{#295127}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l

Review URL: https://codereview.chromium.org/552883002

Cr-Commit-Position: refs/heads/master@{#295126}

This is refactoring some code and also allows add to homescreen to use
<meta name='application-name'>.

BUG=366145

Review URL: https://codereview.chromium.org/568823003

Cr-Commit-Position: refs/heads/master@{#295125}

to be within metrics code

MetricsReportingEnabled checkbox changed code refactored for not-chromeos:
-prefs removed from HTML
-Handler and callback functions added to core_options_handler
-Major refactoring in metrics_reporting_state
-Simple histogram added in metrics_reporting_state without distinguishing the source of the change
-browser_options_handler changed to handle new way of forcing company policies of disabling the checkbox

BUG=401233

NOPRESUBMIT=true
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/506663003

Patch from Gayane Petrosyan <gayane@chromium.org>.

Cr-Commit-Position: refs/heads/master@{#295124}

Avoid using ToInternalValue in computing timings, so that the timings are consistent accross platforms and with javascript performance timings API.

BUG=413672

Review URL: https://codereview.chromium.org/557953006

Cr-Commit-Position: refs/heads/master@{#295123}

My previous checking mistakenly used tabs. replacing
them with spaces as required by the style guide.
https://codereview.chromium.org/545103003/

Review URL: https://codereview.chromium.org/570933004

Cr-Commit-Position: refs/heads/master@{#295122}

This CL makes a few changes in the direction of removing dependencies
on ErrorCode by pushing them up a layer:

- Trap now simply uses TrapKeys directly to store trap function and
metadata instead of needlessly encoding them as ErrorCode.

- MakeTrap returns a bare trap ID and it's instead the caller's
responsibility to encode in an ErrorCode if needed, which is now
handled by ErrorCode's trap constructor.

- Also, ErrorCodeFromTrapId() is replaced by IsSafeTrapId() to answer
the one question that SandboxBPF was interested in knowing about
existing traps.

- Change a few SandboxBPF trap-constructing functions into static
functions since they don't depend on any SandboxBPF instance member
variables.

BUG=414363

Review URL: https://codereview.chromium.org/572753002

Cr-Commit-Position: refs/heads/master@{#295121}