- 09 Jul, 2018 40 commits
-
-
Ran Ji authored
We need to use the pref in components, so move the pref to ui/base so it can be accessed. TBR=jam@chromium.org Bug: 729596 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iffc7c5c2f459340c14a74787defeab00c6c5589c Reviewed-on: https://chromium-review.googlesource.com/1125143 Commit-Queue: Ran Ji <ranj@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#573536}
-
David Bertoni authored
The FileSystemProvider API tests load up platform apps that rely on an external extension's web accessible script to be injected. This script would normally be blocked by the platform app's CSP. Update the tests to use an explicit CSP allowing the extension's resource. Bug: 861815 Change-Id: Ifd2ce1ce01cb6578663b10ac11940cd9a066769f Reviewed-on: https://chromium-review.googlesource.com/1129473 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573535}
-
Wang Hui authored
CreateSimpleURLLoaderWithVariationHeaders. Tons of people call AppendVariationHeaders() with variations::SignedIn::kNo with the following comment: // Note: It's OK to pass SignedIn::kNo if it's unknown, as it does not affect // transmission of experiments coming from the variations server. This CL simply make a version without the sign-in parameter of AppendVariationHeaders and CreateSimpleULRLoaderWithVariationHeader and remove those many comments in the code. BUG=857127 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id0af5394ce31b117e109033f44a43720d4407197 Reviewed-on: https://chromium-review.googlesource.com/1121669 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#573534}
-
Yutaka Hirano authored
BodyStreamBuffer has a ReadableStream instance, but because it's implemented in V8Extra we cannot holds it as a member (i.e., as a ScriptValue). Instead, we attach the value to the JS wrapper of the C++ object. This required us to maintain chains of wrappers, FetchEvent -> Request -> BodyStreamBuffer for example, manually. This CL replaces that mechanism with wrapper tracing. Bug: None Change-Id: I889ef0d0442d62ad50826a4b487ec234f041a982 Reviewed-on: https://chromium-review.googlesource.com/1124270Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#573533}
-
Tommy Martino authored
This change solves two problems related to font colors: * Changes passed down from UX have requested the use of the subtext/hint color for all text in footer rows. * A bug causes text colors to change (permanently) to incorrect values when hover styles are applied. This was observed on Linux under GTK+ theme only. We don't need to modify text colors during RefreshStyle anyway, so the simplest fix is to define these at initialization and not touch them again. Change-Id: I80d2de91bb7067b3dc8fea6f369c83658e15c22a Bug: 861883, 859887 Reviewed-on: https://chromium-review.googlesource.com/1130015 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#573532}
-
dpapad authored
The code stopped working when paper-icon-button-light was updated to its latest version, which changed the structure of the DOM. Bug: 860854 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0c7189752a5ae47eab0024e3e81775a5f93ee7b6 Reviewed-on: https://chromium-review.googlesource.com/1128463Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#573531}
-
Miguel Casas authored
This CL connects |enable_canvas_2d_image_chromium| on CrOs, enabling use of GpuMemoryBuffers for blitting the Skia produced textures onto. GMBs on CrOs are GL_TEXTURE_EXTERNAL_OES, which can't be used to CopyTextureCHROMIUM() onto, so CanvasResourceGpuMemoryBuffer gets a new member (a 2D texture ID), connected to the same GMB, to be used for that purpose. Also as pointed during the review, there's no need to hold on to a Image2DChromium as long as it's bound to a texture (to which we hold on to), so removing the current |image_id_|. Bug: 839970 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I375451cca8f4e29e8fd40a4e6aaadc1a49bcd398 Reviewed-on: https://chromium-review.googlesource.com/1056168 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#573530}
-
Florin Malita authored
Outlines should always be rectangular, and the outline paint code forces the outer/inner radii to zero. But the shared paint code in BoxBorderPainter::DrawDoubleBorder does not enforce zero-radii when computing the intermediate double edges. Update DrawDoubleBorder() to avoid rounded intermediate edges when the exterior edges are not rounded. Bug: 861816 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I81cfccfbb3f14568a0aeacb065fc447f583f28c8 Reviewed-on: https://chromium-review.googlesource.com/1129334Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#573529}
-
Manu Cornet authored
Bug: 805612 Change-Id: I86af86a62fe2e46691db6bfb2b24da404c93ec1d Reviewed-on: https://chromium-review.googlesource.com/1130059 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#573528}
-
Emircan Uysaler authored
Proposing to add myself as the owner since I have been maintaining and reviewing these files and looking forward to cleanups and adding more profiles support soon. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I73e637c376e91df209f759fb55d5f6ba8d86a219 Reviewed-on: https://chromium-review.googlesource.com/1130230Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#573527}
-
Steven Holte authored
This both helps organize the members of UkmRecorderImpl a bit, and also simplifies the code for Purge(), so that it doesn't need to know about all of the different fields. This should help make it harder to accidently add a new field and not delete it during a Purge(). Change-Id: I49558468cfb491c34ef76d2c2801aae72ddc8364 Reviewed-on: https://chromium-review.googlesource.com/1054142 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#573526}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d7890bca9b35..c56adf60d141 git log d7890bca9b35..c56adf60d141 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 tobine@google.com Roll Vulkan repos fwd as of 7/3 2018-07-09 jmadill@chromium.org Vulkan: Add driver uniforms set. 2018-07-09 jmadill@chromium.org Vulkan: Roll SPIRV-Tools and SPIRV-Headers. 2018-07-09 jmadill@chromium.org Vulkan: Make DynamicDescriptorPool single pool. 2018-07-09 geofflang@chromium.org Vulkan: Support EGL_ANGLE_surface_orientation for vertical surface flipping. 2018-07-09 jmadill@chromium.org Return an Error from ContextImpl::syncState. Created with: gclient setdep -r src/third_party/angle@c56adf60d141 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I0a67fff7f7d0db7042c340605d9ae848407a64e6 Reviewed-on: https://chromium-review.googlesource.com/1130180Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573525}
-
tzik authored
This CL replaces base::Timer with its subclasses. As base::Timer changes its behavior subject to its construction time flags, that makes hard to see the actual timer behavior, especially it's unclear when a timer is injected from other components. Also, that OnceCallback support of base::Timer is hard to implement on the dynamically determined invocation pattern. Bug: 850247 Change-Id: I2a7a85a39ba25da01cec2b151d2911f7dba8029a Reviewed-on: https://chromium-review.googlesource.com/1128691Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#573524}
-
Esmael El-Moslimany authored
Bug: 860699 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3845e42fb4bde966077406d8553a9b74c9a46c22 Reviewed-on: https://chromium-review.googlesource.com/1128177Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#573523}
-
tzik authored
This CL replaces base::Timer with its subclasses. As base::Timer changes its behavior subject to its construction time flags, that makes hard to see the actual timer behavior, especially it's unclear when a timer is injected from other components. Also, that OnceCallback support of base::Timer is hard to implement on the dynamically determined invocation pattern. Bug: 850247 Change-Id: I38b7d932304466a9d86bbd577f9918149914f8ea Reviewed-on: https://chromium-review.googlesource.com/1128694Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#573522}
-
Xiaoqian Dai authored
When the drag ends, TabDragController::ClearTabDraggingInfo() might trigger a bounds change of the dragged window, which then trigger TabDragController::OnWidgetBoundsChanged() to be called again to continue dragging. We should remove TabDragController as an observer of the dragged widget when the drag is ending as we do not care about any subsequent moves to the widget. Bug: 854835 Change-Id: Ia940e7f0a33609bfc19ff9d96861948579fb5dd7 Reviewed-on: https://chromium-review.googlesource.com/1109266Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#573521}
-
David Black authored
We need to disable it: - when Assistant UI is dismissed. - when an Assistant interaction is started (e.g. via hotword). Bug: b:110961300 Change-Id: I97024e9f2681d171c40f54ac5b47c5ed549085b6 Reviewed-on: https://chromium-review.googlesource.com/1119530 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#573520}
-
chrome://reset-passwordJialiu Lin authored
When chrome://reset-password interstitial is triggered by password reuse, sets password type in content::OpenURLParams::post_data to pass this info to reset-password interstitial page. Such that we can have more accurate uma tracking. If user directly navigates to chrome://reset-password page, post_data won't be available. In this case, we log UMA separately for unknown reused password type. Bug: 859412 Change-Id: I736180c5325d3680c27a03e1c22992814ced3b9b Reviewed-on: https://chromium-review.googlesource.com/1123310 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573519}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7219d053d56a..478313fa8ea2 git log 7219d053d56a..478313fa8ea2 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 buildbot@webrtc.org Roll chromium_revision a9fbefaa..a4679480 (573255:573356) Created with: gclient setdep -r src/third_party/webrtc@478313fa8ea2 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I96a97b1bca2793b8b2992f5bc1afa648d6d19a7b Reviewed-on: https://chromium-review.googlesource.com/1130080Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573518}
-
Philip Rogers authored
This reverts commit 292ad04d. Reason for revert: I think this caused an active window test failure, see https://crbug.com/861963 Original change's description: > Remove makeKeyAndOrderFront: from WebContentsViewMac::Focus(). > > WebContentsView::Focus() is supposed to update the first responder of the > Window, not make the window focused. The latter should go through > WebContentsDelegate::ActivateContents(). > > This logic is usually a no-op because the window receiving the call is the > active window. But in the case where the user quickly switches windows, this can > cause the old window to re-take focus. > > This logic was added in 2009 not because it had the right semantics, but to > match the behavior of Windows: http://codereview.chromium.org/165492. > > Bug: 859614 > Change-Id: I2bc44a825d93159d774c632da17cc2f2d151fc3a > Reviewed-on: https://chromium-review.googlesource.com/1124772 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573344} TBR=avi@chromium.org,erikchen@chromium.org Change-Id: I6ae990055c9a9cf0bd84f7599939e25490178304 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859614 Reviewed-on: https://chromium-review.googlesource.com/1130141Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573517}
-
Justin DeWitt authored
Previously we disabled POST requests from being snapshotted by OPC. However, this inadvertently prevented SnapshotController from marking a WebContents as snapshottable, so any POST requests would be unable to complete - they would hang in downloading state until Chrome exited. After that, the background loader would take over and error out because it does not support non-GET requests and would use a GET HTTP request for a POST resource which typically fails or redirects to a login page of some kind. Additionally, extends NavigationSimulator to use the method from SetMethod when committing navigations, rather than the currently-hardcoded "GET" method. Bug: 859403 Change-Id: Ic10dd0b088da9e3ebf2a42e3cca6096eea449d16 Reviewed-on: https://chromium-review.googlesource.com/1125031Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#573516}
-
Sunil Kumar authored
Depends-On: eureka-internal/182625 Depends-On: eureka-internal/183487 Bug: 79116492 Test: manual / CQ Change-Id: I9dab6b83145078b3b896a2490a8432500ccdabbe Reviewed-on: https://chromium-review.googlesource.com/1121594 Commit-Queue: Sunil Kumar <skx@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#573515}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I517af72120c9748a1e2a09756e832bea20000928 Reviewed-on: https://chromium-review.googlesource.com/1126167 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#573514}
-
Martijn Croonen authored
This fixes a compiler error. ../../base/sampling_heap_profiler/lock_free_address_hash_set_unittest.cc(148,22): error: no member named 'make_unique' in namespace 'std' auto thread = std::make_unique<WriterThread>(&set, &cancel); ~~~~~^ ../../base/sampling_heap_profiler/lock_free_address_hash_set_unittest.cc(148,34): error: 'WriterThread' does not refer to a value auto thread = std::make_unique<WriterThread>(&set, &cancel); ^ ../../base/sampling_heap_profiler/lock_free_address_hash_set_unittest.cc(116,7): note: declared here class WriterThread : public SimpleThread { ^ ../../base/sampling_heap_profiler/lock_free_address_hash_set_unittest.cc(148,48): error: expression result unused [-Werror,-Wunused-value] auto thread = std::make_unique<WriterThread>(&set, &cancel); ^~~~ 3 errors generated. ninja: build stopped: subcommand failed. Change-Id: I72d5bddf448c091417f9497b6cb751df5a75dff1 Reviewed-on: https://chromium-review.googlesource.com/1129759Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#573513}
-
Xiaochu Liu authored
Component updater does not force an update if an compatible component is installed. We provide an option in the Load API to support forced update check. BUG=chromium:850798,chromium:859573 TEST=platform_AddPrinter.epson Change-Id: I1649e0ce641089cd57d4910155fc93e660967df1 Reviewed-on: https://chromium-review.googlesource.com/1119199Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#573512}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I5bb941b74e051648a8863bcc6922f3c43b6eb51f Reviewed-on: https://chromium-review.googlesource.com/1126337Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573511}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I84a9b876102f223e46da4314a5b616d245a46358 Reviewed-on: https://chromium-review.googlesource.com/1126319 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#573510}
-
Majid Valipour authored
Match the recent CSSWG resolutions: https://github.com/w3c/csswg-drafts/issues/2737#issuecomment-402574750 https://github.com/w3c/csswg-drafts/issues/2751#issuecomment-402604609 Make following properties none animatable: * contain * direction * display * text-orientation * unicode-bidi * will-change * writing-mode Note that wpt tests have already been updated for direction and writing-mode here [1] [1] https://github.com/web-platform-tests/wpt/commit/41f4ab65b239a5a9e9eeedadc2cae3d1fe0234c0 Bug: 860359 Change-Id: I3e7296e3c28ff494eddbc6f011621dd29ba7d2aa Reviewed-on: https://chromium-review.googlesource.com/1127062 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#573509}
-
Jeremy Roman authored
webaudio: Avoid recursive acquisition of graph mutex due to overriding AudioNode::connect and disconnect. Instead of overriding these members, have them call new virtual functions which handle only the logic delegated to the derived class. This is executed with the graph lock already held, and thus it is not necessary to recursively acquire it. Bug: 856641 Change-Id: I26847e6719b03ecfe203fa4077367672c7656d7f Reviewed-on: https://chromium-review.googlesource.com/1118922 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#573508}
-
Aga Wronska authored
This flag guards entry point to setup device in offline demo mode. It needs to be used in combination with kEnableDemoMode flag to take effect. It allows to enable/disable offline demo mode when demo mode feature is enabled. Bug: 855672 Test: Run browser tests DemoSetpTest, DemoSetupOfflineDisabledTest + manually Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1383d664a56cb41e2aabe8e57fbe2d684048f463 Reviewed-on: https://chromium-review.googlesource.com/1112901 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#573507}
-
Eugene But authored
This handler allows to control the size of the download response, and test larger downloads. The handler was adopted in inttests and egtests. Bug: 854232 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6569cc43081d03ffb065e64c5f9d80da833f6541 Reviewed-on: https://chromium-review.googlesource.com/1110599 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#573506}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I04beeb4ecf69ca8b8bab1b53114c11d40dfb2ed4 Reviewed-on: https://chromium-review.googlesource.com/1111572Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573505}
-
Yi Gu authored
Currently in cc a keyframe effect is allowed to have the following keyframe model sequence: opacity, transform, opacity; but this is never true in reality if they are in the same group, i.e., start together. This patch is to forbid such behavior and update tests accordingly. Bug: 860341 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I39e7765faf910ff4e9385b18b796baa394d0e660 Reviewed-on: https://chromium-review.googlesource.com/1129200Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#573504}
-
Becca Hughes authored
Add a kCoverForcedByUserAgent ViewportFit value which is used when the media controls are forcing kCover. The value will behave exactly the same as kCover but being seperate will allow us to track it seperately in metrics. BUG=855739 Change-Id: I7cf8418f190b47cf1e04d5dc461448a4df5234ed Reviewed-on: https://chromium-review.googlesource.com/1117766Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#573503}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1354048c8fa8..c3833b4c152a git log 1354048c8fa8..c3833b4c152a --date=short --no-merges --format='%ad %ae %s' 2018-07-09 bsalomon@google.com Revert "Add genIDs from all contributing elements to GrReducedClip's mask key." 2018-07-09 herb@google.com Update SkSpan to match the standard more closely 2018-07-09 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 8fbd9d96e68b..c2136b67f69d (1 commits) 2018-07-09 brianosman@google.com Update mandrill PNGs to be sRGB (rather than gamma 2.2) 2018-07-09 meisterdevhwan@gmail.com More workarounds on Windows Debug DLL crash. 2018-07-09 bungeman@google.com Remove SK_IGNORE_WIN_EMOJI_FIX 2018-07-09 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6a990f8b1a93..6a6692214c26 (1 commits) 2018-07-09 brianosman@google.com Remove some linear-blending sRGB logic from sk_app 2018-07-09 brianosman@google.com Always unpremul nonlinearly before writing PNGs in DM Created with: gclient setdep -r src/third_party/skia@c3833b4c152a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: If8084c869fe666d9b93f5f2e1c8b974617e3e611 Reviewed-on: https://chromium-review.googlesource.com/1129640Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573502}
-
Maggie Chen authored
The comman line switch --disable-gpu-process-for-dx12-vulkan-info-collection is added to layout tests and browser test so the non-sandboxed gpu process, which is used for DX12 and Vulkan info collection and histograms, can be disabled to avoid interference. The info collection process is not needed for these tests. BUG=852796,856398 Change-Id: I7fac317987996aeb4a5ea37e473468f69ef3d89a Reviewed-on: https://chromium-review.googlesource.com/1123167Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#573501}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I538205f53ba84bf5b2aaf4104a09c080e9aab375 Reviewed-on: https://chromium-review.googlesource.com/1126162Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573500}
-
Helen Li authored
These two histograms are unused. The related histograms have already been deprecated. This essentially reverts crrev.com/466197. Bug: 859569 Change-Id: Idfbe20823425576aff4eaed54fdc67339c24e007 Reviewed-on: https://chromium-review.googlesource.com/1129827Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#573499}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/27f6e148..cae2929d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5c5f15dfad2e8721e1c6ce61a214c7a024d289e6 Reviewed-on: https://chromium-review.googlesource.com/1130018Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573498}
-
Karan Bhatia authored
This CL performs the following changes: - extension_with_rulesets_ holds ExtensionsIds instead of Extension pointers. - file_task_runner_ uses the central Extension file task runner now instead of creating its own. - RulesMonitorService declares explicit dependencies on ExtensionRegistry, ExtensionPrefs and ExtensionSystem. This refactoring is in preparation for a subsequent CL which will handle indexed ruleset corruption. This CL does not introduce any behavior change. BUG=852058 Change-Id: Ia3a6a234836ac23f1571bb7b062ebf7bf6fc98ba Reviewed-on: https://chromium-review.googlesource.com/1128387 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#573497}
-