GitLab

This was causing build failures on the Win2008 dbg builder.
http://chromesshgw.corp.google.com/i/chromium/builders/Win%20Builder%202008%20%28dbg%29/builds/4501


r1464: Use flock-style lock on Windows to limit number of concurrent links
r1465: Fix usage of shlex in unit tests on windows.
r1466: Fixes an issue where OutputDirectory and IntermediateDirectory were
       being incorrectly generated without a trailing slash on MSVS 2008.
r1467: This makes it easier to test combinations of msvs version without having
       to muck with environment variables
r1468: Fix the Android Eclipse CDT generator.
r1469: Prepend 'call' to all non-cygwin commands to prevent incredibuild from
       aborting the scripts early.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10836254

TBR=newt@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824318

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151730 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os-partner:12316


Review URL: https://chromiumcodereview.appspot.com/10854146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151728 0039d316-1c4b-4281-b951-d872f2087c98

The flag was there to make checking of inner classes optional
until all inner classes could be fixed.

We must still parse the flag until this has been rolled in and
plugin_flags.sh has been updated not to pass in the flag anymore.

BUG=136863


Review URL: https://chromiumcodereview.appspot.com/10837254

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151727 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dhollowa
BUG=137223
TEST=unit_tests pass.

Review URL: https://chromiumcodereview.appspot.com/10825367

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151726 0039d316-1c4b-4281-b951-d872f2087c98

The new test fails on some bots:
http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20ASAN%20Tests%20%281%29/builds/992/steps/browser_tests/logs/stdio
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%281%29/builds/1195/steps/browser_tests/logs/stdio

The smoke test is simple - it checks that Chrome can load nexes.  The more
interesting part of this CL is that it lays the groundwork for adding more NaCl
tests to browser_tests.  This will allow many nacl_integration tests to be
rewritten as browser_tests.  This CL adds an extensible jig for decoding
messages from Javascript, which makes it easier to add test logic in the web
page.  This CL also establishes locations in the build directory for nexes and
other test data.

There are two followup CLs planned: 1) simplify how nexes are built in GYP
and 2) share the code for running tests in Javascript with the PPAPI test
suite.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2959
TEST= browser_tests --gtest_filter=NaClBrowserTest*


Review URL: https://chromiumcodereview.appspot.com/10837207

TBR=ncbray@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827356

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151724 0039d316-1c4b-4281-b951-d872f2087c98

Don't use NSDistributedLock, which uses a lock that isn't cleaned up on
unexpected program termination, and which strongly recommends to not
call -breakLock (which makes this class fairly pointless).

Instead, use a flock(), which is cleaned up by the OS on process exit.
Suggested by shess@.

BUG=141108

Review URL: https://chromiumcodereview.appspot.com/10823329

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151723 0039d316-1c4b-4281-b951-d872f2087c98

- Modified chromoting.py to enable me2me automation
- Added chromoting_helper.py to handle install, uninstall, enable, disable, changepin which requires admin privilege
- Added chromoting.base.py as the base for all chromoting test cases
- Modified chromoting_basic, renamed it it2me_basic and moved it under chromoting dir
- Added auth, me2me_enable, me2me_connect test
- Added a cert and a private key for signing host on mac
- Added mock_pref_pane.* files to mock the pref pane for different scenarios


NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10821015

TBR=yihongg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10837266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151722 0039d316-1c4b-4281-b951-d872f2087c98

Unlike Seek(), calling Start() while running is a clear programmer error. If the pipeline did stop running and you called Start() again, make sure to no-op inside StartTask().

Review URL: https://chromiumcodereview.appspot.com/10857018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151721 0039d316-1c4b-4281-b951-d872f2087c98

(This is a reland of r151502, which was reverted in r151517 because it
broke the Linux Official build.)

This may break the Official build for a brief window while a two-sided
patch lands.

BUG=139744

Review URL: https://chromiumcodereview.appspot.com/10837057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151720 0039d316-1c4b-4281-b951-d872f2087c98

- Modified chromoting.py to enable me2me automation
- Added chromoting_helper.py to handle install, uninstall, enable, disable, changepin which requires admin privilege
- Added chromoting.base.py as the base for all chromoting test cases
- Modified chromoting_basic, renamed it it2me_basic and moved it under chromoting dir
- Added auth, me2me_enable, me2me_connect test
- Added a cert and a private key for signing host on mac
- Added mock_pref_pane.* files to mock the pref pane for different scenarios


NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10821015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151717 0039d316-1c4b-4281-b951-d872f2087c98

The smoke test is simple - it checks that Chrome can load nexes.  The more
interesting part of this CL is that it lays the groundwork for adding more NaCl
tests to browser_tests.  This will allow many nacl_integration tests to be
rewritten as browser_tests.  This CL adds an extensible jig for decoding
messages from Javascript, which makes it easier to add test logic in the web
page.  This CL also establishes locations in the build directory for nexes and
other test data.

There are two followup CLs planned: 1) simplify how nexes are built in GYP
and 2) share the code for running tests in Javascript with the PPAPI test
suite.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2959
TEST= browser_tests --gtest_filter=NaClBrowserTest*


Review URL: https://chromiumcodereview.appspot.com/10837207

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151716 0039d316-1c4b-4281-b951-d872f2087c98

Removing temporary code put in place to allow WK92278 to land.


Review URL: https://chromiumcodereview.appspot.com/10854081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110111

Review URL: https://chromiumcodereview.appspot.com/10829306

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151714 0039d316-1c4b-4281-b951-d872f2087c98

This is due to multiple callback calls in GDataFileSystem::AddUploadedFileToCache.
It should be called exactly once on every code path.

BUG=none
TEST=Manual: open Drive folder, select a file, ctrl-C and then ctrl-V.

Review URL: https://chromiumcodereview.appspot.com/10834328

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151713 0039d316-1c4b-4281-b951-d872f2087c98

If an OmniboxViewWin is created then destroyed without being used in the interim, the destructor would dereference a null pointer.

Discovered while writing https://chromiumcodereview.appspot.com/10854017

BUG=NONE
TEST=NONE

Review URL: https://chromiumcodereview.appspot.com/10826271

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151712 0039d316-1c4b-4281-b951-d872f2087c98

measure when we could be combining jobs.

BUG=139811


Review URL: https://chromiumcodereview.appspot.com/10824297

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151710 0039d316-1c4b-4281-b951-d872f2087c98

It has been superseded by --sdk-build, which has already been set for all
other Chromium and WebKit users.

BUG=


Review URL: https://chromiumcodereview.appspot.com/10855147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151709 0039d316-1c4b-4281-b951-d872f2087c98

BUG=78497
TEST=unit_tests
Review URL: https://chromiumcodereview.appspot.com/10829300

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151708 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141493
TEST=unit test


Review URL: https://chromiumcodereview.appspot.com/10825343

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151707 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True
BUG=None


Review URL: https://chromiumcodereview.appspot.com/10836264

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151706 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136057
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10829180

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151705 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142355
TEST=visual


Review URL: https://chromiumcodereview.appspot.com/10829323

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151704 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140931
Test=Manual
Run Chrome using --force-device-scale-factor=2
Change theme.
Close chrome and restart.
Ensure that the app icons use hidpi images.

TBR=sky, erg

Review URL: https://chromiumcodereview.appspot.com/10832313

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151703 0039d316-1c4b-4281-b951-d872f2087c98

Horizontal clipping is still needed for slide animations.

Other minor fixes:
*) Centered network step contents.
*) Step logo is hidden initially to prevent flicker during boot/sign out into Login screen.

BUG=142770

Review URL: https://chromiumcodereview.appspot.com/10830332

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151701 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142869,140441
TEST=content_unittests

Review URL: https://chromiumcodereview.appspot.com/10830335

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151700 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=compiles
TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10831331

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139834


Review URL: https://chromiumcodereview.appspot.com/10837190

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151698 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10832270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151697 0039d316-1c4b-4281-b951-d872f2087c98

Historically, all the entry-points into the OutputConfigurator needed to refresh
their view of the cached output data.  This newly-added entry-point doesn't do
this which can lead to the cached data becoming stale (since it technically only
applies within the context where the corresponding XRRScreenResources are
valid).
Ideally, no such information would be cached and every attempt to evaluate or
change the state of the video outputs would start by requesting this structure.
That change is of larger scope and risk, though, so this is the tactical
solution to the immediate problem suitable for porting to stable branches.

BUG=chromium:140807
TEST=Manually tested that ctrl-F4 and "manage displays" (in chrome://settings)
work on a Lumpy the same way with and without this change


Review URL: https://chromiumcodereview.appspot.com/10825306

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151696 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=compiles
TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829338

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151695 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138281
TEST=No touch optimized ui in about flags, nor does it get set when a touch screen is plugged in.


Review URL: https://chromiumcodereview.appspot.com/10832252

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151694 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes our custom GYP flag and modifies the build so both the SRPC and IPC proxies are built side by side. In addition, NaClBrowser now checks the '--enable-nacl-ipc-proxy' flag to determine which IRT to load. The IPC proxy's name is of the form 'nacl_ipc_irt_*'. 

BUG=116317
TEST=builds and runs NaCl apps with --enable-nacl-ipc-proxy
TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10831316

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151693 0039d316-1c4b-4281-b951-d872f2087c98

usage_file_path can be empty when a FileSystem is accessed after DeleteFileSystem call.

BUG=


Review URL: https://chromiumcodereview.appspot.com/10832316

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151692 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151691 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10829337

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151690 0039d316-1c4b-4281-b951-d872f2087c98

DeviceMonitorMac detects device changing and forwards the notifications to the system monitor.



BUG=137799


Review URL: https://chromiumcodereview.appspot.com/10824162

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151689 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151688 0039d316-1c4b-4281-b951-d872f2087c98

TBR=enne@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10837256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151687 0039d316-1c4b-4281-b951-d872f2087c98

SequencedWorkerPool task that are pushed with the shutdown blocking enum must
block shutdown, which means that the task execution is important enough that
it has to be executed before going into background. Those tasks are
transformed into CriticalTasks.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10829318

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151685 0039d316-1c4b-4281-b951-d872f2087c98

Code in content/ should be in the content namespace.

TBR=jam
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10823318

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151684 0039d316-1c4b-4281-b951-d872f2087c98