- 02 Nov, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da627bb2e1dc..e057780671f2 Created with: gclient setdep -r src-internal@e057780671f2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id8130828a365fb90b1d9c10d4d49759b78fac6a8 Reviewed-on: https://chromium-review.googlesource.com/c/1314094Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604866}
-
weigua authored
Bug: 900873 Change-Id: I684ac77608c8274cc8e221300b310f37bc41e9cf Reviewed-on: https://chromium-review.googlesource.com/c/1312149 Commit-Queue: Wei Guan <weigua@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#604865}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ib3dfa6423735abcbcf4dae62c70702231732c5fb Reviewed-on: https://chromium-review.googlesource.com/c/1314095Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604864}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c0b6c639b109..caeb1e895d7b git log c0b6c639b109..caeb1e895d7b --date=short --no-merges --format='%ad %ae %s' 2018-11-02 jmadill@chromium.org Vulkan: Allow unlimited simultaneous descriptor sets. Created with: gclient setdep -r src/third_party/angle@caeb1e895d7b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I488a54ffafca65ba16fa9917c3c6d1b971c45e94 Reviewed-on: https://chromium-review.googlesource.com/c/1314092Reviewed-by:
-
Dominic Farolino authored
This CL changes the default classic script fetch options credentials mode from "omit" to "same-origin", as per the recent spec change [1], and adds descendant worker credentials tests as a follow-up to said spec change and [2]. [1]: https://github.com/whatwg/html/pull/3656 [2]: https://github.com/web-platform-tests/wpt/issues/13426 R=domenic@chromium.org, kouhei@chromium.org, nhiroki@chromium.org Bug: 849101 Change-Id: I958f552f0ee91beb8aab98269f79a1eb219fb40a Reviewed-on: https://chromium-review.googlesource.com/c/1301964 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#604862}
-
Yoshifumi Inoue authored
This patch introduces |LayoutNGTextFragment| to make layout text objects in NG layout tree to have |NGInlineItem| for utilizing it in Element#innerText to handle |Text| nodes with ::first-letter. Before this patch |Text| node applied ::first-letter is represented with two |LayoutTextFragment| objects for first-letter part and remaining part. After this patch, they are represented to |LayoutNGTextFragment| with |NGInlineItem|. [1] http://crrev.com/c/1309562 Make Element#innterText to utilize NGInlineItem instead of NGPaintFragment Bug: 873957 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4cd6b43fdc4caf0d92b1030cfbb75f37d4fe67b8 Reviewed-on: https://chromium-review.googlesource.com/c/1309391Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604861}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 86a99a1c. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 24c885e6 "[css-properties-values-api] Invalidate paint worklet on registration." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I8029188a5087781c419c842d8c04590279294abd Reviewed-on: https://chromium-review.googlesource.com/c/1314138 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604860}
-
Hirokazu Honda authored
VaapiDmabufVideoFrameMapper does format conversion to I420. This is not good from design perspective as VFMapper should map a buffer as it is. This eliminates the format conversion from VaapiDmabufVFMapper. BUG=chromium:856562 TEST=VDA unittest --test_import --frame_validator Change-Id: Ic5e12e7875a9bb91ca2e21fc50c2de3a1d913199 Reviewed-on: https://chromium-review.googlesource.com/c/1312440Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604859}
-
Yuke Liao authored
This CL hooks the Clang code coverage wrapper into the build toolchains, and specifically, a new build flag: coverage_instrumentation_input_file is added to allow turning on/off the wrapper and pass the list-files-to-instrument around. Bug: 898695 Change-Id: I405ccbfc1796afa44534794d711f2953fac78f6d Reviewed-on: https://chromium-review.googlesource.com/c/1309999 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604858}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. event_target_names.json5 contains items like: { name: "core/frame/Window", ImplementedAs: "DOMWindow", }, This CL updates _symbol() in make_names.py so that it produces 'kWindow' for it. _legacy_symbol() produces 'DOMWindow', however we don't need to use C++ implementation class name here. This CL has no behavior changes. Bug: 889726 Change-Id: I02a796015ba7ca63d9331f16f4f715445c44ed55 Reviewed-on: https://chromium-review.googlesource.com/c/1314008Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#604857}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/26fcd7166c74..e1abea653b28 git log 26fcd7166c74..e1abea653b28 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@e1abea653b28 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ife30f0d9e318088f12dfa684648654406207c217 Reviewed-on: https://chromium-review.googlesource.com/c/1314091Reviewed-by:
-
Erik Luo authored
Introduces a common interface between ElementsTreeOutlines and ObjectPropertiesSections. This allows both to be keyboard navigable in Console. Bug: 865674 Change-Id: I405d161692147374827918cce2369d129620a9fd Reviewed-on: https://chromium-review.googlesource.com/c/1275225 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#604855}
-
Giovanni Ortuño Urquidi authored
Patch to remove the no longer used TrayBluetooth code. Bug: 898419 Change-Id: I3f2393dc562a91b42345d107f6faf3292124d232 Reviewed-on: https://chromium-review.googlesource.com/c/1312137Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#604854}
-
Ken Rockot authored
Adds a new test support library with a single helper class, FakeNavigableContentsFactory. This allows unit test code to fake out a basic Content Service implementation to help drive Content Service client code under test. Bug: 854367 Change-Id: I3e81aa7b6540aa35347e6c3311c0f816cb945a01 Reviewed-on: https://chromium-review.googlesource.com/c/1277960 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#604853}
-
Anand K. Mistry authored
Metadata requests in the chrome.fileSystemProvider API declare what metadata fields they are requesting (i.e. size, modifiction time, etc). Fields that are provided but not requested will be logged as warnings. BUG=721790 Change-Id: Ia2c1c1b39f72048be654069557cfc951c5cfc325 Reviewed-on: https://chromium-review.googlesource.com/c/1313989Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#604852}
-
Kouhei Ueno authored
Bug: 711706 Change-Id: I46271b96329d45d4b2ad6ad0988490dcad98943e Reviewed-on: https://chromium-review.googlesource.com/c/1314013 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
BUG=762641 TBR=oshima@chromium.org Change-Id: I512f29e5f8d9bba022890b401ef8e938683baa1a Reviewed-on: https://chromium-review.googlesource.com/c/1314132 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604850}
-
Asami Doi authored
changed. Some tests in update-registration-with-type.https.html fail because a new worker is not created when a script type is changed and a script content is identical. This CL makes |skip_script_comparison_| true when a script type is same. Also, I replaced has_installed_version() newest_installed_version(). Bug: 824647 Change-Id: I755e3d031b97d6659a7a35a1f93f9acfc654368c Reviewed-on: https://chromium-review.googlesource.com/c/1312828 Commit-Queue: Asami Doi <asamidoi@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/502d2e215556..c0b6c639b109 git log 502d2e215556..c0b6c639b109 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 yizhou.jiang@intel.com Implement GetTexLevelParameter api of texture multisample extension Created with: gclient setdep -r src/third_party/angle@c0b6c639b109 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I04fd25db433714cd0b7e788585ef1d5b8857ed3f Reviewed-on: https://chromium-review.googlesource.com/c/1314090Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 39b7746e. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 24c885e6 "[css-properties-values-api] Invalidate paint worklet on registration." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler jsbell@chromium.org: external/wpt/resources kojii@chromium.org: external/wpt/css/CSS2/text rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-basic-card yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I0f7d7e40a7a6c5bfade6a3f585521c25f09299f6 Reviewed-on: https://chromium-review.googlesource.com/c/1314128 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Stuart Langley authored
We're still waiting on the correct artwork, so for now just re-use existing icons so we get the feature working. Still needs to support "USB and External Devices" after confirming with drive folks that this name will not be localized. Tested manually as there are no automated tests for style right now. Bug: 884020 Change-Id: I209f6e1a76c75655475e4c62ee6e97f79c9215df Reviewed-on: https://chromium-review.googlesource.com/c/1313988Reviewed-by:
-
Shu Chen authored
Bug: 859432 Change-Id: I61f8540a9027d43a29dcde5892f4547bad09c026 Reviewed-on: https://chromium-review.googlesource.com/c/1312143 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#604845}
-
Mitsuru Oshima authored
This is 2nd attempt to land: crrev.com/c/1304973 [2] are the difference from above CL. *[2] Added null check in OnStartingAnimationComplete. * Pause occusion tracker during overview animation [2] wait 5000ms when exiting overview before resume because a user may re-enter overview [2] wait 50ms when entering overview before resume because it can take 2 frame to finish draing the frame after animation observer is called. * Activate the text filter after animation * [2]Animate shelf after overview animation. * [2] Improve blur animation: Use Compositor's AnimationObesrver to drive animation Progress only by 2 to reduce the frequency. * Don't animate backdrop window during overview animation. * Fix the bounds change issue in WindowGrid. It shouldn't change the parent window's bounds. Bug: 898077, 897387, b/118675936 Test: no functional change. Manually tested visual change by entering/exiting overview mode in both clamshell and tabletmode. The web contents should load after animations without backdrop animation. No gap at the bottom of the screen after exiting overview mode. Change-Id: I5e5dc17afd62d4dc477d87becdeee91c55bd81ca Reviewed-on: https://chromium-review.googlesource.com/c/1304973 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:Sammie Quon <sammiequon@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604206} Reviewed-on: https://chromium-review.googlesource.com/c/1312614Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#604844}
-
Sam McNally authored
If a file is not openable while preparing the launch data for a file handler, the file handling app is launched without any file entries and without the handler ID. With DriveFS, hosted docs will fail in this fashion; when attempting to zip files including a hosted doc, this causes the zip archiver to fail silently since it's launched without any information. Pass the handler ID to the app when launching without any entries so it can identify what the user was attempting to do. In the zip archiver, display the same notification that would be displayed if the zip pack operation later failed when such launch events are received. Bug: 892595 Change-Id: I3d2e145a8c6e955b03891063813c0624b692d943 Reviewed-on: https://chromium-review.googlesource.com/c/1303320Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604843}
-
Kouhei Ueno authored
This should serve as a better proxy for measuring ES6 modules usage in the wild. Before this CL, we relied on kPrepareModuleScript, which only counts ES6 module usage via <script type=module>, and no other invocation paths. kInstantiateModuleScript will also cover module usage via dynamic import, via workers, and others. Bug: 594639 Change-Id: I5d1690fcfb7ea6ee9eac3beb22a4659a1410c561 Reviewed-on: https://chromium-review.googlesource.com/c/1314011Reviewed-by:
-
Shakti Sahu authored
Fixed an issue where the filter change callback was not getting propagated correctly to the mutator, due to which the back button press was unable to update the contents of the tab. Bug: 899936 Change-Id: I46f83fd651a453aba875c62ef47da9d8ee8b2067 Reviewed-on: https://chromium-review.googlesource.com/c/1309427Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#604841}
-
Koji Ishii authored
Following bot results are included. 11268 11270 11273 11280 11287 11296 11304 11316 11319 11324 11330 11336 11341 11351 11357 11362 11368 1 lines were removed and 1 lines were deflaked by consecutive results since 11296. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I9876bcba7cfbf94a3500e9b9a4ae41f45eaa0b3e Reviewed-on: https://chromium-review.googlesource.com/c/1308956 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/94d7af7bcc96..26fcd7166c74 git log 94d7af7bcc96..26fcd7166c74 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 reed@google.com remove scale parameter from getFontMetrics 2018-11-02 caryclark@skia.org match getFontMetrics change in docs 2018-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a23184454e9c..42e8e54e3049 (1 commits) 2018-11-02 reed@google.com remove (unused and weird) zoom parameter on getFontMetrics 2018-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2197dc529052..502d2e215556 (1 commits) Created with: gclient setdep -r src/third_party/skia@26fcd7166c74 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ic17491a3ec84e6000b1fd9a33c02b75f1a842d19 Reviewed-on: https://chromium-review.googlesource.com/c/1314088Reviewed-by:
-
Shakti Sahu authored
Fixed several bugs : 1 - On orientation change, toolbar needs to readjust its contents. 2 - Search menu item visibility needs to be correctly initialized based on the contents. 3 - The downloads area (recycler view and toolbar) will be limited to 600dp on wide screen. Bug: 899139 Change-Id: I5eaad5c68d6ff4d268ac0c7da4489a591f8bf29f Reviewed-on: https://chromium-review.googlesource.com/c/1303401Reviewed-by: -
Keishi Hattori authored
Converts all HeapHashSet, HeapLinkedHashSet, HeapListHashSet allocations from new to MakeGarbageCollected. Allocations using new will be banned from now on. Bug: 757708 Change-Id: I065d7e2f86bc11ce6e46dda378583f8cc630947c Reviewed-on: https://chromium-review.googlesource.com/c/1309894 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#604837}
-
Luciano Pacheco authored
This is a reland of 2903236d Original change's description: > Change NavigationListModel to support MyFiles as Volume. > > Add MYFILES_VOLUME_ENABLED in private strings to be able to have the > feature flag in the JS/UI code. > > Change VolumeManager to use MyFiles folder for Downloads volume, the > method |GetMyFilesFolderForProfile| takes care of returning the right > value based on the feature flag MyFilesVolume. > > Change NavigationListModel to support MyFiles as Volume when > MyFilesVolume feature flag is enabled: > 1. MyFiles volume is the Downloads volume (after the feature flag is > removed we can rename it accordingly). Setup Downloads volume as > VolumeEntry, > 2. Create a NavigationModelFakeItem with "My files" label, based on the > VolumeEntry (step #1). > 3. Skip adding "Downloads" to Myfiles, since now MyFiles is in fact > Downloads volume. > 4. Continue to add Linux and Play files to Myfiles. > > Test: unit_tests --gtest_filter='VolumeManagerTest.GetVolumeListMyFilesVolume' and browser_test --gtest_filter='FileManagerJsTest.DirectoryTreeTest:FileManagerJsTest.NavigationList*' > Bug: 873539 > Change-Id: Ia242d52a1e4d7b4fb3c7ca219d9cfdc4fce72543 > Reviewed-on: https://chromium-review.googlesource.com/c/1308235 > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604143} Bug: 873539 Change-Id: I396cda87781c21856a736c6f5eae8f76efb4e62c Reviewed-on: https://chromium-review.googlesource.com/c/1314012Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604836}
-
Koji Ishii authored
This patch fixes two excessive marking of line box dirtiness in NGInlineNode::MarkLineBoxesDirty(). 1. LayoutObject::InsertedIntoTree() marks dirty, even if it will be dirtied again later in NGInlineNode:: MarkLineBoxesDirty(). Fixed LayoutNGMixin<Base>:: DirtyLinesFromChangedChild() to do only if it was in NG inline formatting context. 2. It may dirty the first line box because it clears LayoutObject::FirstInlineFragment as it traverses in pre- order, but NGPaintFragment::DirtyLinesFromChangedChild() needs FirstInlineFragment of its previous siblings. Changed to keep previous fragment in this loop. blink_perf.layout does not show observable improvements, but loading.desktop shows ~3% improvements. Bug: 636993 Change-Id: Ia0706bb2407427b3e4ed093290646eb21bc5c0f3 Reviewed-on: https://chromium-review.googlesource.com/c/1309388 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604835}
-
Xiaocheng Hu authored
This patch changes HotModeSpellCheckRequester to use uncanonical versions of PreviousWordPosition and EndOfWord to reduce usage of VisiblePosition. Bug: 657237 Change-Id: I26428ede826bc63ee76af02ace14a8bf43d69e25 Reviewed-on: https://chromium-review.googlesource.com/c/1313839Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604834}
-
Tarun Bansal authored
Currently, optimization hints are fetched only when data saver pref is set. This can be done by going to data saver setting or by installing the extension on the desktop. This CL additionally checks if data saver is enabled via command line switch. This makes it simpler to test hints on Linux without having to install the extension. This is not really a user-facing change since users are not expected to turn data saver via that switch. Bug: 878131 Change-Id: I4f728a3e9bbfe30119257ff43c8eeb52b211732d TBR: dougarnett@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1313274 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#604833}
-
Xiaocheng Hu authored
This patch exposes noncanonical versions of Previous/NextWordPosition to reduce usage of VisiblePosition. Bug: 657237 Change-Id: I0815b0c0bf4de34427432ca8f6aa769c356c6385 Reviewed-on: https://chromium-review.googlesource.com/c/1313876Reviewed-by:
-
Sungguk Lim authored
Implementation for chrome.tabs.goBack and chrome.tabs.goForward Above APIs provide a reliable way to trigger a navigate-back/forward action like back/forward button on toolbar. Bug: 830622 Change-Id: I1f5e8d5e4768161f43b2df1621a03a6cc3383b4f Reviewed-on: https://chromium-review.googlesource.com/c/1274225Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604831}
-
Zhuoyu Qian authored
This patch stops passing VisiblePosition to the functions, and hoists creation of VisiblePosition to the callers, to decrease the usage of VisiblePosition. Bug: 657237 Change-Id: I52a6a34e240aa0180d2459c262b2db919fab4674 Reviewed-on: https://chromium-review.googlesource.com/c/1309568Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#604830}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: Id8d03ff031991eeea8a2d4069332adb17b6ae869 Reviewed-on: https://chromium-review.googlesource.com/c/1314148Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#604829}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I8724b84354fda40bcaa90a7d90a82c563fb11698 Reviewed-on: https://chromium-review.googlesource.com/c/1312151Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#604828}
-
Reilly Grant authored
This change fixes a number of issues with sending bulk and interrupt transfers to a USB device using the new Windows backend. * Posting completion callbacks to the proper thread (a requirement for DevTools) has been fixed. * Overlapped I/O results are now read using the correct method (WinUsb_GetOverlappedResult) and from the correct handle. * Aborting transfers on handle close no longer results in a double-free. Bug: 637404 Change-Id: I4fdb254e4ea6e9cbf7d764f588c94d698d61cb02 Reviewed-on: https://chromium-review.googlesource.com/c/1313828 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#604827}
-
