GitLab

Refactor FakeAttachmentStore into AttachmentStoreProxy and
InMemoryAttachmentStore backend. Break AttachmentStore interface into
AttachmentStoreBase (common interface for backends) and AttachmentStore
(referenced by datatype and AttachmentService).

BUG=
R=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/601553004

Cr-Commit-Position: refs/heads/master@{#297339}

Currently Blink is shut down before all the pending tasks in the message loop are deleted. This is problematic in Oilpan because a destructor of the pending tasks can touch Oilpan objects. Because Oilpan is already detached from the renderer thread at that point, touching Oilpan objects in the destructor leads to a crash. (See the bug report for a concrete scenario.)

To prevent Blink objects from getting accessed after Blink is shut down, this CL deletes all pending tasks in a message loop before shutting down Blink.

BUG=411026
TEST=None. I cannot reproduce the crash.

Committed: https://crrev.com/fdd5612c20f777e1279efd7c1e99d82ed04afaaf
Cr-Commit-Position: refs/heads/master@{#296697}

Review URL: https://codereview.chromium.org/583043005

Cr-Commit-Position: refs/heads/master@{#297338}

Followup to https://codereview.chromium.org/602013002/, which fixes a bug with empty window shapes not being handled properly on CrOS.

BUG=417014

Review URL: https://codereview.chromium.org/607623002

Cr-Commit-Position: refs/heads/master@{#297337}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/613053002

Cr-Commit-Position: refs/heads/master@{#297336}

There are a number of static downcasts in ShelfView that are *probably*
correct, but there is no clear proof that they are casting to the
correct type. This patch adds explicit CHECKs before every static_cast
to ensure that we are not casting from an incompatible dynamic type.

drag_view_ now has type ShelfButton*, so it is downcast on assignment,
rather than on many of its uses.

BUG=418460

Review URL: https://codereview.chromium.org/614653002

Cr-Commit-Position: refs/heads/master@{#297335}

BUG=417835

Review URL: https://codereview.chromium.org/610673002

Cr-Commit-Position: refs/heads/master@{#297334}

R=tbreisacher@chromium.org, vitalyp@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/613763005

Cr-Commit-Position: refs/heads/master@{#297333}

Increase device orientation event frequency to 60 Hz to match requestAnimationFrame rate on most hardware. Change constants to microseconds for increased precision.

BUG=413327

Review URL: https://codereview.chromium.org/604483003

Cr-Commit-Position: refs/heads/master@{#297332}

BUG=401365

Review URL: https://codereview.chromium.org/508823009

Cr-Commit-Position: refs/heads/master@{#297331}

This copies the logic from tools/build/scripts/slave/runtest.py in swarming.

I changed test_env.py so that it sets CHROME_DEVEL_SANDBOX to be an empty string, instead of unsetting it. The latter doesn't work as Chrome triggers checks in content/browser/browser_main_loop.cc. This is what runtest.py does.

BUG=414808,336218

Review URL: https://codereview.chromium.org/605063004

Cr-Commit-Position: refs/heads/master@{#297330}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/612243002

Cr-Commit-Position: refs/heads/master@{#297329}

Define ViewMsg_ColorProfile IPC message and plumb it into renderer
RenderWidget::SetDeviceColorProfile(). The browser uses the IPC to
set the renderers screen color profile.

Note SetDeviceColorProfile is overridden by RenderViewImpl, so the
IPC message data is handled there - it calls the base RenderWidget
SetDeviceColorProfile, which detects if the color profile changed,
and stores it in the RenderWidget if so.

If there was a change, the RenderViewImpl informs its webview() so
the Page contained therein can update / repaint all color profiled
elements on the Page.

For a diagram of the IPC and procedure call proceedings, including
layout test support (added in issue 369787), see:

  https://crbug.com/368663#c14

Not used as yet: the IPC from the browser-side will be added later
(need to resolve issue 338130, issue 357443 first), so this change
is again just plumbing.

CQ_EXTRA_TRYBOTS=tryserver.blink:mac_blink_rel,mac_blink_dbg
BUG=368663

Review URL: https://codereview.chromium.org/601273002

Cr-Commit-Position: refs/heads/master@{#297328}

This is a simpler fix than https://codereview.chromium.org/595213005/.
I would like to make a more robust fix (and added a TODO), but this
should address the crash bug for 38 and 39 while allowing us to
investigate a better solution for 40.

BUG=417633

Review URL: https://codereview.chromium.org/614793003

Cr-Commit-Position: refs/heads/master@{#297327}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ed24ca8..b4e21e6

TBR=zmo@chromium.org,eustas@chromium.org

Review URL: https://codereview.chromium.org/607673003

Cr-Commit-Position: refs/heads/master@{#297326}

BrowserActionView::~BrowserActionView deletes ExtensionActionViewController,
which calls CleanupPopup, which resets a MenuButton::PressedLock, which was
already deleted. Fix the order of destruction.

BUG=418737

Review URL: https://codereview.chromium.org/615543006

Cr-Commit-Position: refs/heads/master@{#297325}

Restore Pepper printing support even without full printing.
If was guarded to work in full printing for Android, because Android
did not implemented that functionality. Proper guard should allow
even non-full printing, because code is usefull to print PDF.

Removed printing to DC code, related code already deleted from Chrome.

BUG=170859, 417967

Review URL: https://codereview.chromium.org/599633007

Cr-Commit-Position: refs/heads/master@{#297324}

BUG=416691

Review URL: https://codereview.chromium.org/612983004

Cr-Commit-Position: refs/heads/master@{#297323}

Missed from https://codereview.chromium.org/454623002

Review URL: https://codereview.chromium.org/618453003

Cr-Commit-Position: refs/heads/master@{#297322}

ShelfViewTest.AppListButtonTouchFeedback and ShelfViewTest.AppListButtonTouchFeedbackCancellation are both failing on Valgrind after the refactor of the feedback switch. The tests does not have a memory failure, the test cases are failing now.

Disabling the tests until they can be fixed.

This is a follow up to: https://codereview.chromium.org/580903003/

TBR=skuhne@chromium.org
BUG=398398

Review URL: https://codereview.chromium.org/616703002

Cr-Commit-Position: refs/heads/master@{#297321}

These values should be filled in as specified by the MSDN documentation for the function: http://msdn.microsoft.com/en-us/library/windows/desktop/dd162611(v=vs.85).aspx

BUG=418684
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/613033002

Cr-Commit-Position: refs/heads/master@{#297320}

To be merged on 2171.

BUG=418816
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/616713002

Cr-Commit-Position: refs/heads/master@{#297319}

We might have a native ContentViewCore but not a java side.  Don't
attempt to show the context menu if this is the case.

BUG=410599

Review URL: https://codereview.chromium.org/610913004

Cr-Commit-Position: refs/heads/master@{#297318}

In Java the filename and classname must match.

BUG=None
TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/606343003

Cr-Commit-Position: refs/heads/master@{#297317}

Added Do... methods for each state in DoHandshakeLoop (similar to the
conventions that we typically use in our state machines).

DoVerifyProof and DoGetChannelID which could do async operation
return  QuicAsyncStatus.

In DoHandshakeLoop changed "for (;;) {" to be similar to other
do { ...} while loops of other state machines in chromium.

R=rch@chromium.org,agl@chromium.org

Review URL: https://codereview.chromium.org/588443002

Cr-Commit-Position: refs/heads/master@{#297316}

Bypass ServiceWorkers for synchronous resource loads to avoid deadlocks when the worker and page are running in the same process.

[1] this cl
[2] layout test https://codereview.chromium.org/573293005/

BUG=413103

Review URL: https://codereview.chromium.org/553333005

Cr-Commit-Position: refs/heads/master@{#297315}

BUG=78368
R=dbeam@chromium.org
TEST=GYP_GENERATORS=ninja gyp --depth . third_party/closure_compiler/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/599203003

Cr-Commit-Position: refs/heads/master@{#297314}

particular, wmii indicates that it supports EWMH via _NET_SUPPORTING_WM_CHECK
and _NET_ACTIVE_WINDOW via _NET_SUPPORTED but does not ever set the
_NET_ACTIVE_WINDOW property. This is a known bug with wmii
(https://code.google.com/p/wmii/issues/detail?id=266)

BUG=417767
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/602183003

Cr-Commit-Position: refs/heads/master@{#297313}

BUG=416722
R=jochen@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/596153003

Cr-Commit-Position: refs/heads/master@{#297312}

Review URL: https://codereview.chromium.org/602293003

Cr-Commit-Position: refs/heads/master@{#297311}

The mean_input_event_latency result of groupcloned.com_test_list-images
is not correct and is adding too much noise to the metric over the page set.
We want to exclude its mean_input_event_latency from the test result
which is pending the telemetry feature of page result filter. So for now,
lets disable the this page.

BUG=409086

Review URL: https://codereview.chromium.org/616513003

Cr-Commit-Position: refs/heads/master@{#297310}

Add an ExtensionWantsToAct() method on ExtensionActionAPI.
Even though we're not quite sure what we want the UI to look
like for an extension desiring to act, we can start a little
bit of the plumbing now. For instance, exposing a method that
allows a caller to check if an extension wants to act on a
given page.

BUG=417441

Review URL: https://codereview.chromium.org/597413003

Cr-Commit-Position: refs/heads/master@{#297309}

Blocking renderer->plugin messages can be interrupted by any message
from the plugin->renderer (even async ones). So while handline a blocking
message, such as HandleInputEvent or HandleBlockingMessage, it's currently
possible to re-enter JavaScript. This patch makes that impossible by
queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage
while any renderer->plugin sync message is on the stack.

BUG=384528

Committed: https://crrev.com/f73075c99b5ba30e8d62dc5f13fdfb210d0fc506
Cr-Commit-Position: refs/heads/master@{#296311}

Committed: https://crrev.com/3fe4ceee750b2cd130bd402de3d371d8518c3eba
Cr-Commit-Position: refs/heads/master@{#296807}

Review URL: https://codereview.chromium.org/589213003

Cr-Commit-Position: refs/heads/master@{#297308}

BUG=401365

Review URL: https://codereview.chromium.org/509273002

Cr-Commit-Position: refs/heads/master@{#297307}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0c6b223..ed24ca8

TBR=eustas@chromium.org
BUG=

Review URL: https://codereview.chromium.org/611993003

Cr-Commit-Position: refs/heads/master@{#297306}

After we show and activate a popup window from a user gesture, we should
always focus the web contents.

BUG=411322

Review URL: https://codereview.chromium.org/599763003

Cr-Commit-Position: refs/heads/master@{#297305}

For example "cr_cronet.py test -f *Quic*" will run just Quic tests.

BUG=

Review URL: https://codereview.chromium.org/601863002

Cr-Commit-Position: refs/heads/master@{#297304}

This patch ensures that we always activate when we become invisible.
The reason being is that when we come back to being visible again,
we don't need to rasterize both active and pending trees. We can
just rasterize what used to be the pending tree.

Since we set RequiresHighResToDraw on becoming visible, this also
ensures that we don't checkerboard on becoming visible.

BUG=410000, 417598
R=danakj, enne, brianderson

Review URL: https://codereview.chromium.org/605823002

Cr-Commit-Position: refs/heads/master@{#297303}

Also refactors some common code into a method in MetricsService.

BUG=400357

Review URL: https://codereview.chromium.org/612883003

Cr-Commit-Position: refs/heads/master@{#297302}

I moved all tests to Win Tests x64 (1) in preparation for removing 2 & 3.

BUG=414808
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/608363004

Cr-Commit-Position: refs/heads/master@{#297301}

When the download shelf is closed, it's still in the view hierarchy with height
of 0. To make it not appear in the AX hierarchy, we hide the view after the
close animation is finished.

BUG=417698

Review URL: https://codereview.chromium.org/615663002

Cr-Commit-Position: refs/heads/master@{#297300}