- 07 Oct, 2019 40 commits
-
-
Sergey Poromov authored
SCHEMA_ALLOW_INVALID_TOPLEVEL and SCHEMA_ALLOW_INVALID_TOPLEVEL_AND_ALLOW_UNKNOWN are not used. SCHEMA_ALLOW_UNKNOWN_TOPLEVEL is only used in Chromoting where it's a no-op to change it to SCHEMA_ALLOW_UNKNOWN as all Chromoting policies RemoteAccess* are either boolean or string policies. So, it's safe to delete these 3 strategies. The next step is to remove SCHEMA_STRICT. Bug: 969706 Change-Id: I9cc2f4e80840724afcd150d3cc0940a7160a6587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836194Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#703420}
-
Ce Chen authored
AsOmniboxEventProviderType. This is to fix crash in http://crbug/1011730. Bug: 1011730 Bug: 925072 Change-Id: I1cd11156505ce501fac45527b5c59af74e8b96cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844056 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#703419}
-
Peter Kasting authored
Bug: 82078 Change-Id: I43764c6f3b0682b16dc3822ff3ef7b0daa473579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844053 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#703418}
-
Lorne Mitchell authored
DevTools: Modified Security.securityStateChanged to use types and data instead of pre-processed English strings This change modifies the shape of the Security.securityStateChanged (https://chromedevtools.github.io/devtools-protocol/tot/Security#event-securityStateChanged) CDP event to include the type of state that has changed along with the data needed to generate the details that are shown in the Security tool. The strings that are currently present in security_state_strings.grdp will be moved to the DevTools frontend. security_state_strings.grdp will remain in place, so that we don't break backwards compat with Security.securityStateChanged. This will come in a separate CL. Bug: 946860 Change-Id: I18a2ff879bf201d36cf02af88963dcb996c4811f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646792 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#703417}
-
Elly Fong-Jones authored
As far as I can tell this class has never had a user in chromium. This change also removes the ImageViewBase abstraction layer, which was added to support AnimatedImageView. Bug: None Change-Id: I9af55bfb0ef1b7a07a2d5a1db234b5e998a66c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842037Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#703416}
-
Andrew Grieve authored
Bug: 982762 Change-Id: Ia67f95207bc5c9f107ee1f42a4d151e25792178e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837198 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#703415}
-
Mostyn Bramley-Moore authored
https://chromium-review.googlesource.com/c/1423625 removed the third_party/closure_compiler/build directory, but left a reference to it in DEPS. Let's remove that too. Change-Id: I6a41677b8930025add9167c6c897060dbc14b1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844957Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#703414}
-
Patrick Monette authored
ServiceWorkerContextWrapper's observer methods are supposed to always be dispatched on the UI thread. This CL ensures this is true with additional DCHECKs and adds the DeleteOnUIThread custom deleter because observers are also notified in the destructor. Bug: 993029 Change-Id: I10c7baa6a908e61ea50a00486d0e3bae81e7e32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841765Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#703413}
-
Lukasz Anforowicz authored
user_gesture ============ NavigateParams::user_gesture field was manually copied from OpenURLParams::user_gesture field right after calling FillNavigateParamsFromOpenURLParams in 3 places: //chrome/browser/android/tab_web_contents_delegate_android.cc: TabWebContentsDelegateAndroid::OpenURLFromTab //chrome/browser/chrome_content_browser_client.cc: ChromeContentBrowserClient::OpenURL //chrome/browser/ui/browser.cc: Browser::OpenURLFromTab This CL moves the nav_params.user_gesture = params.user_gesture assignment into NavigateParams::FillNavigateParamsFromOpenURLParams This part has no intended behavior change and should be non-controversial. blob_url_loader_factory and href_translate ========================================== blob_url_loader_factory and href_translate were propagated from OpenURLParams into NavigateParams in //chrome/browser/ui/browser.cc (Browser::OpenURLFromTab), but not in the other 2 places. This CL moves the nav_params.blob_url_loader_factory = params.blob_url_loader_factory; nav_params.href_translate = params.href_translate; assignments into NavigateParams::FillNavigateParamsFromOpenURLParams This part changes the behavior of - //chrome/browser/android/tab_web_contents_delegate_android.cc: TabWebContentsDelegateAndroid::OpenURLFromTab - //chrome/browser/chrome_content_browser_client.cc: ChromeContentBrowserClient::OpenURL so that they propagate as much information from OpenURLParams as necessary (consistently with other callers of FillNavigateParamsFromOpenURLParams). Bug: 1007041 Change-Id: I042afe0b71e825a44c015c792514c820823258f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838976Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#703412}
-
Chandani Shrestha authored
This change makes Copy color in colorPicker keyboard accessible. Earlier, this was working only with mouseclick. This was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1686452 which has been broken down as below Make copy color in color picker keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817416 Make copy color in color picker screen-reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1818297 Gif showing color picker with this change https://imgur.com/9YxCQpc Bug: 963183 Change-Id: I03e1e1481ba74e816d86c100783d732329dc4e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817416Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
John Emau <John.Emau@microsoft.com> Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703411}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f4389a6ddae5..603e7a0e5a97 git log f4389a6ddae5..603e7a0e5a97 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 nuskos@google.com Ensure that we generate a ChromeConfig that sets record_mode. Created with: gclient setdep -r src/third_party/perfetto@603e7a0e5a97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I500723777937607f055b64d1ce98e61f539f8d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845772Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703410}
-
Chandani Shrestha authored
This change adds h1 because page must contain level one heading to make it accessible. More info https://dequeuniversity.com/rules/axe/3.0/page-has-heading-one This change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1648916 which has been split into small changes. Bug: 963183 Change-Id: I107b87ed3bc4e182daba7c85f8af12bf68b84311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817415Reviewed-by:
-
Yves Arrouye authored
Bug: N/A Test: N/A Change-Id: Icf7a53ecf5e22a356478fb5cb754e38b0bfd5ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845851Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#703408}
-
Wei Li authored
There are cases that HaTS javascript library may not be loaded successfully, for example, when the browser is offline. In this case, we monitor the resource load complete call to make sure HaTS library is loaded. Otherwise, we don't proceed with showing the survey. BUG=1006674 Change-Id: Ibcd725728978ce96fbbe263fb0c5d5c894d1ced9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826291Reviewed-by:
-
Brian Cui authored
This PR fixes an issue with placeholder text in input fields showing as black against black when the dark theme is enabled, making them impossible to read. The fix simply assigns the ::placeholder CSS pseudo-element to all input fields so the placeholder text is always a shade of gray, compatible with both themes. The color value `rgba(0, 0, 0, 0.54)` was copied from the stylesSidebarPane rule that specified ::placeholder color (and hence, the sidebar was not affected by this bug). Before: https://i.imgur.com/iwiKvrU.png After: https://i.imgur.com/labeZzz.png The light theme appearance is unchanged. Before (Light): https://i.imgur.com/x8sXkWU.png After (Light): https://i.imgur.com/qp3zzzc.png Bug: 1011477 Change-Id: Ia418ce346defb134a7a4db57b83bc666f7f49056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841665 Auto-Submit: Brian Cui <brcui@microsoft.com> Reviewed-by:
-
Peter Kasting authored
Bug: 82078 Change-Id: Ibf7270ca6aa083864de74ddd8ca0e89731b006d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842957 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#703405}
-
David Maunder authored
The orchestrator is the entry point into acquiring Tab suggestions. Bug: 1009105 Change-Id: I1a4fb35efaefd6d08a7105bea196ef907abea555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830397 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
-
Sanket Joshi authored
When the tab keydown event occurs while a keyboard focusable element has focus, the tab keypress event should be suppressed. Inside a popup window though, keypress does still get fired today. This CL fixes that. Bug: 1011168 Change-Id: I45f0853a00fc9ea45777fc0d7cdafbdb6e55eeda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842951 Commit-Queue: Sanket Joshi <sajos@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#703403}
-
Hiroshige Hayashizaki authored
This CL implements scoping of import maps: - Parsing in ImportMap::Parse(), and - Resolving in ImportMap::Resolve(). To use ResolveImportsMatch() and MatchPrefix() for resolving using scopes, this CL makes them take |SpecifierMap| arguments instead of using |imports_|. Sorting order of scope keys is fixed by https://github.com/WICG/import-maps/pull/182 and new tests (which will pass after this CL) are added by https://github.com/WICG/import-maps/pull/183 Bug: 927181 Change-Id: I778a74424ad0eded8af8bfcf8443764b52abfbd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838233Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#703402}
-
Erik Chen authored
GpuBenchmarking already has as pointer to a RenderFrame. This CL updates the helper class GpuBenchmarkingContext to use that pointer to fetch the relevant objects. This CL is mostly a refactor with no intended behavior change. The big difference is that it used to use a main frame RenderWidget [which may be undead and nullptr in the future]. Now it fetches the local root render widget. Bug: 912193 Change-Id: I6c5bde608c955dc0c8f9383ae40e5fcbc884a08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838477 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703401}
-
Piotr Bialecki authored
Bug: 997369 Change-Id: Ib094d6c30d58a87ee193741081c0a9f96fbf500d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841659Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#703400}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/37a1d28c0058..40324d671c25 git log 37a1d28c0058..40324d671c25 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 jrosenth@chromium.org chromeos_config: mark veyron_jerry experimental Created with: gclient setdep -r src/third_party/chromite@40324d671c25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I16e87e3bf559182b6d3c77b21ace2f218362ba57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845651Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703399}
-
Tommy Li authored
This reverts commit 483903ea. Reason for revert: Fix for at least one of the leaks is here: https://chromium-review.googlesource.com/c/chromium/src/+/1845991 Reverting to re-enable these tests. I'll fix more this week if there are further ASAN omnibox failures. Original change's description: > Disabling flaky Omnibox and KeyProvider tests. > > They sometimes leak on ASAN. > > TBR: tommycli@chromium.org > Bug: 1010691 > Change-Id: I663cb4fa70974b35832edacf77e0fdb094631135 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844958 > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703338} TBR=phoglund@chromium.org,tommycli@chromium.org Change-Id: Ib7ff3431c0b0aabe01f5372ecbc03c9b707131da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846033Reviewed-by:
-
Tim van der Lippe authored
I saw the following stacktrace while running Chromium locally: [205430:205430:1007/182130.681774:ERROR:CONSOLE(61)] "TypeError: Cannot read property 'originStackTrace' of null TypeError: Cannot read property 'originStackTrace' of null at Function._script (devtools://devtools/bundled/sources/sources_module.js:1469:197) at Sources.ScriptOriginPlugin.rightToolbarItems (devtools://devtools/bundled/sources/sources_module.js:1467:41) at Sources.UISourceCodeFrame.syncToolbarItems (devtools://devtools/bundled/sources/sources_module.js:335:215) at Sources.SourcesView._updateScriptViewToolbarItems (devtools://devtools/bundled/sources/sources_module.js:1215:168) at Sources.SourcesView._editorClosed (devtools://devtools/bundled/sources/sources_module.js:1226:43) at Sources.TabbedEditorContainer.dispatchEventToListeners (devtools://devtools/bundled/common/Object.js:12:173) at Sources.TabbedEditorContainer._tabClosed (devtools://devtools/bundled/sources/sources_module.js:1012:114) at TabbedPane.dispatchEventToListeners (devtools://devtools/bundled/common/Object.js:12:173) at TabbedPane._innerCloseTab (devtools://devtools/bundled/ui/TabbedPane.js:30:73) at TabbedPane.closeTabs (devtools://devtools/bundled/ui/TabbedPane.js:23:93)", source: devtools://devtools/bundled/host/InspectorFrontendHost.js (61) It appears that the code in this file already assumes that script can be undefined, but forgot this particular case. Change-Id: I7b0c0d34b4d16a1d29656cd8d86e3f290f8bb227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845751 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e94f473753be..6acfca3ad3e3 git log e94f473753be..6acfca3ad3e3 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 cnorthrop@google.com Vulkan: Handle texStorage when base level is set Created with: gclient setdep -r src/third_party/angle@6acfca3ad3e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I1f979e1c8221a26be767c33a251d175420feb7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845333 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Andrew Grieve authored
Two motivations: 1. Allows comparing trichrome (where dex is uncompressed) with Monochrome (where it is compressed). 2. Aligns with SuperSize breakdowns. Change-Id: I86905c52d89a66b52adb05fe8b74df6666c7e485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839432Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#703395}
-
Pavel Yatsuk authored
This CL adjusts logic in TemplateUrlServiceAndroid::SetPlayAPISearchEngine to merge search engine data when search engine with matchiung keyword already exists. Additionally this CL adjusts merging logic during prepopulated list update to preserve Play API search engine data. This is important since search url might contain attribution parameters. We might decide to take different approach with providing attribution info, but before that happens preserving Play API data is the safest approach. BUG=1002271 R=pkasting@chromium.org,wylieb@chromium.org Change-Id: I596a6df724cfc73801663ca7d97074ba69e856c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838534 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Ryan Daum authored
Upstreams a utility which draws roundy corners on aura windows. (Re-land of chromium/1841573 with fucshia build fix) Bug: internal b/141369549 Test: manual Change-Id: I366f9020632eeae9f3f1f5dad908f8aeb6a910ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845995Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#703393}
-
Fernando Serboncini authored
Otherwise we may lose back information Bug: 1011309 Change-Id: Idabededd27383bca54db237a23fbd245b8c83eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845231 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#703392}
-
Francois Doray authored
This CL reduces the memory associated by a ScopeLock: - Remove ScopeLock::is_locked_: We can check if the release callback is nullptr to know if the lock is held. - Remove level and ScopedLockRange bound to the release callback: The values are already stored in the ScopeLock and can passed when invoking the callback. The goal is to offset the memory that will be used in a subsequent CL to track the frame holding each ScopeLock. Bug: 980533 Change-Id: I9b6852db43c2000ae1b68c31996921bc52a63916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838374 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#703391}
-
Pavel Yatsuk authored
BUG=1002271 R=wylieb@chromium.org Change-Id: I91b95a2cdb8db323248bb9341c85e2a83ec9a15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842673Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#703390}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af16026220a0..d16fbbb2686c Created with: gclient setdep -r src-internal@d16fbbb2686c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I725c0d10fd151fadc4c9774bdad4d195b7d653a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844122Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703389}
-
Maksim Sisov authored
At the moment, we have zwp_linux_dmabuf support that we use to create wl_buffers in the browser process based on passed dmabuf prime fds from the GPU process. However, there are plenty of systems that also support EGL_EXT_image_dma_buf_import, but do not provide zwp_linux_dmabuf protocol extension. Instead, instead they use the wl_drm protocol. Thus, import it to third_party protocols and utilize it in the Ozone/Wayland implementation. There are no functionality changes brought with this CL, but rather it adds support for that protocol and uses it if zwp_linux_dmabuf is not available. If non is available, Chromium uses software compositing (Chromium hosts gpu service in a separate process) or Wayland Egl (in-process-gpu is passed and the gpu service is hosted in the browser process). Bug: 1008348 Change-Id: I06eddc68ef0ad0a897aeefa1f31677986e563eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827001Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#703388}
-
Peter Kasting authored
Bug: 82078 Change-Id: Ic2152a5bc8464df9354dcd158a72d6f5168d6030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844338 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#703387}
-
Mathieu Binette authored
Moved in https://crrev.com/c/1841581 and https://crrev.com/c/1841889. Bug: 1011508 Change-Id: I9a582bf09f3c3198e1438e8d41774cee1f5ffabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842560Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#703386}
-
Brandon Wylie authored
When an Android app is killed, C++ destructors aren't guaranteed to be called. When an app is killed within the 5 second delay for CommitQueuedOperations, the operation is skipped completely. The end result is non-Google search engines missing from the settings screen. Bug: 1007070 Change-Id: Icd178a067a2b440ce538b03c4da82e0449306b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837074Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#703385}
-
Vitaly Buka authored
C/C++ for "XEvent = {}" promise to zero initialize only the first member of the union. The tails of larger member can be uninitialized. Detected with -ftrivial-auto-var-init=pattern. XEvent member sizes on x86_64 40 xany 96 xkey 96 xbutton 96 xmotion 104 xcrossing 48 xfocus 64 xexpose 72 xgraphicsexpose 48 xnoexpose 48 xvisibility 72 xcreatewindow 48 xdestroywindow 56 xunmap 56 xmap 48 xmaprequest 72 xreparent 88 xconfigure 56 xgravity 48 xresizerequest 96 xconfigurerequest 56 xcirculate 56 xcirculaterequest 64 xproperty 56 xselectionclear 80 xselectionrequest 72 xselection 56 xcolormap 96 xclient 56 xmapping 40 xerror 72 xkeymap 40 xgeneric 56 xcookie 192 pad Bug: 977230 Change-Id: I7838e5f68b6320e067f9c446222a38fdcd35bdd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842505Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#703384}
-
Xiaohui Chen authored
Bug: b:142244324 Test: locally build and able to start voice query Change-Id: I5b3ce11a8b1944b1f6f013e4b39151887bfaf878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845432 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/647c7a97d32d..25f416465e8d git log 647c7a97d32d..25f416465e8d --date=short --no-merges --format='%ad %ae %s' 2019-10-07 brianosman@google.com Add particles gallery to skia.org site 2019-10-07 jlavrova@google.com Adding line/style metrics 2019-10-07 fmalita@chromium.org [skottie] Horizontal-constraint for Shaper *ToFit alignment modes 2019-10-07 borenet@google.com Update go deps Created with: gclient setdep -r src/third_party/skia@25f416465e8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Ieb57f56e11f3e7970df0f4855579aad707df1ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844120Reviewed-by:
-
Tim van der Lippe authored
Bug: 1006759 Change-Id: I3f5917ab3f5b3fb823ca460c395301ba19eed2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841792 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
