GitLab

Only modify the out parameters when there's actual state to be returned.

Also, when PKP lookup fails due to pinset out of bounds (that should not
happen, I guess) the method only returns false if there is no STS state
either.

Bug: 749059
Change-Id: Ida1fe3e60d2eb5c9bbc1625cd4b8b6550f9b716d
Reviewed-on: https://chromium-review.googlesource.com/973610Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550583}

TBR=ortuno@chromium.org

Bug: 832544
Change-Id: Ifd414f8e86d4a791723c925f647c524436d4f807
Reviewed-on: https://chromium-review.googlesource.com/1012032
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550582}

Before this CL, only when passwords are synced then sign-in password
is saved, this CL removes condition on synced passwords.

Also IsSyncAccountCredential is returned to the state before CL
https://chromium-review.googlesource.com/c/chromium/src/+/932743.

Bug: 816988
Change-Id: Ib1bfad08a8a85ed9107e3df042c450ec93629526
Reviewed-on: https://chromium-review.googlesource.com/999713
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550581}

This resolves the onIceConnectionStateComplete probmise when
iceConnectionState reaches either 'connected' or 'completed' and fixes
the race if it had already reached these states before the function was
called.

This fix is speculative. I am no longer able to repro the TIMEOUT
locally with or without the fix.

Bug: 829401
Change-Id: I1dec90250d640d93498c59a932ab5e84a3b96f15
Reviewed-on: https://chromium-review.googlesource.com/1012029Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550580}

Removes unnecessary getting of the interface each processing pass.

Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5097dee52d62f5f29bac9a2d760595ccfe54046f
Reviewed-on: https://chromium-review.googlesource.com/1011615Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550579}

Bug:831745
Change-Id: Ic68c7a02a81ba288a050a6405e3ffc77149adbc0

TBR=eyaich@chromium.org
NOTRY=true  # tests in PRESUBMIT

Change-Id: Ic68c7a02a81ba288a050a6405e3ffc77149adbc0
Reviewed-on: https://chromium-review.googlesource.com/1011255
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#550578}

Instead, base::BindOnce and base::OnceClosure are used.

This is driven-by CL that allows the presubmit hook to let other
changes to this file to be uploaded.

BUG=714018

Change-Id: I0adbfe6bc5a2195e52310bebcd5a1c00e85ef244
Reviewed-on: https://chromium-review.googlesource.com/1011304Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#550577}

Token revocation is only best effort and has no guarantee to go through.
However existing code was just giving up if the network was down.
This CL improves the behavior, by waiting until the network is available
before sending the revocation request.

Bug: 824791
Change-Id: I1bed2b1d28e5e827a07be0797fe6a56a38778a29
Reviewed-on: https://chromium-review.googlesource.com/1004616
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550576}

It's useful to know how long successful queries take, without failed queries potentially skewing
the histogram towards lower values. Some failures may even occur before a DNS query is sent, so
the existing DnsQueryDuration histogram really measures how quickly LogDnsClient handles a
request to obtain an inclusion proof (successful or otherwise). This is useful, as a measure of
its throughput, but unhelpful for determining how fast an inclusion proof is obtained in the
case of success.

BUG=506227

Change-Id: I133f2f30abd104281d51906079cf859e62556ffc
Reviewed-on: https://chromium-review.googlesource.com/1010303
Commit-Queue: Rob Percival <robpercival@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550575}

Adds a new flag, kFormatUrlOmitPath, that formats URL by omitting
everything after the hostname, like path and query.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3f98fd52a6e5fbb404fb87d72cdb4bbebe2d15b5
Reviewed-on: https://chromium-review.googlesource.com/971481
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550574}

This is a preparation CL for migrating CustomizationWallpaperDownloader
from URLFetcher to SimpleURLLoader.

It brings in no functionality change, but it prepares the ground for
the use of EmbeddedTestServer rather than FakeURLFetcherFactory.
Basically, the manifest URL can not be static/constant because of
the way EmbeddedTestServer::GetURL works.

BUG=None

Change-Id: I30dfc24ed9083d952bfa9c0c72be1ea9350f5b5e
Reviewed-on: https://chromium-review.googlesource.com/1011302Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#550573}

This CL makes sure that calling video.requestPictureInPicture() shows a
Picture-in-Picture window and that setting disablePictureInPicture to
true or calling document.exitPictureInPicture() hides the
Picture-in-Picture window.

Bug: 806249
Change-Id: Ifa9e6df55c913d6eb68fd0fbb59450d3d516ee1c
Reviewed-on: https://chromium-review.googlesource.com/1006956Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#550572}

This does not appear to be used by anything. When it was added in 2011,
there was some musing about using it but it seems it never was
(https://codereview.chromium.org/7518028/diff/12006/net/dns/dns_config_service_posix.cc#newcode52).

Bug: 831665
Change-Id: I1181594cb9f84ba406228075834c4fbfed42a21a
Reviewed-on: https://chromium-review.googlesource.com/1007664Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Rob Percival <robpercival@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550571}

Our win bot is broken by extensions/common/extension_unittest.cc,
but I can't even find that file in the chromium source tree! Let's try
to get off of 'all' once and for all. Chromium isn't building all for
the most part, so we are sensitive to breakages in obscure targets.

It's not clear if building the remote webapp is enough to prevent
the breakages in http://crbug.com/820041; we failed to repro that one
on our workstations because of nacl build magic, but we didn't
conclude that the bot couldn't have caught the issue since it was
fixed while we were working on it. Well, IIRC.

Let's try this, and if we get more breakages in pnacl_newlib
because of webrtc_overrides problems, let's revisit the problem
and see if we can build some kind of integration test with pnacl
so we detect these errors earlier without building magical targets
(or all for that matter).

Bug: None
Change-Id: Ibc0441ffa17c046f18b5a9b8a82c111f1b03d0f9
Reviewed-on: https://chromium-review.googlesource.com/1011609Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550570}

DICE is Desktop Identity Consistency.

* Dice uses a different Gaia signin page. It is similar to the "new flow",
except that the password input field is not reachable by ID. Instead,
it can be retrieved by searching for input fields under the element with
ID "password".

* The Dice signin flow happens directly in a tab, and is not embedded in
a WebUI. With Dice, the WebUI specific code has to be removed.

* Dice requires Gaia country redirects to succeed. The host resolver is
updated for this.

* Some dead code is removed.

Bug: 828729
TBR: ellyjones
Change-Id: I861126e1136f2f6e27b2814593f0cd8b50eb4b22
Reviewed-on: https://chromium-review.googlesource.com/998165Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550569}

Bug: 831778
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I74a6f95430be7a4651c0bedf13d0f58b38d089a5
Reviewed-on: https://chromium-review.googlesource.com/1011144Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550568}

This CL also updates //third_party/abseil-cpp:absl_exceptions_cflags_cc
which was wrongly changed in a previous CL ("-fexceptions" is OK except
when Abseil is built for Windows).

Bug: webrtc:8821
Change-Id: I1fe54167919ab9e972b90b4c0723f113e6f06eab
Reviewed-on: https://chromium-review.googlesource.com/1011621Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550567}

A selector matching for "::slotted" uses a "node -> slot" lookup,
but it doesn't use a slot's assigned nodes.

Given that, we don't need to update distribution for ::slotted because the status of
slot's assigned nodes doesn't matter here.

It looks that was introduced at:
https://chromium.googlesource.com/chromium/src/+/38a8b698b864db5dadba51bbda82cc07d3cc2b93

Change-Id: I38e7e8ea0dd104a059a671a5d314b5df89000417
Reviewed-on: https://chromium-review.googlesource.com/1011528Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550566}

This is a reland of f6c12979

Original change's description:
> [base] Implement std::size(), std::empty() and std::data()
>
> This change provides C++14 implementations of C++17's std::size(),
> std::empty() and std::data().
>
> Bug: 828324
> Change-Id: If1b83826a23b26fd557f7854962bcbc771a7ffe0
> Reviewed-on: https://chromium-review.googlesource.com/992236
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550137}

TBR=dcheng@chromium.org,kylechar@chromium.org

Bug: 828324
Change-Id: I4c3e637129aaaf277d83ca07b4705dc3b815183b
Reviewed-on: https://chromium-review.googlesource.com/1011962Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550565}

Getting rid of yet another mutable style access.

Bug: 813068
Change-Id: I227ccf577d0c0c90bc871c5eee3b768a6f140656
Reviewed-on: https://chromium-review.googlesource.com/1000732
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550564}

This patch fixes the crash bug on Android.

Bug: 831057
Change-Id: I94c6a893aad63894609eb34a78bba095596555d6
Reviewed-on: https://chromium-review.googlesource.com/1005636Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550563}

Disable flaky test: org.chromium.chrome.browser.contextualsearch
.ContextualSearchManagerTest#
testContextualSearchDismissedOnForegroundTabCrash

Bug: 832539
Change-Id: I8d7022888e45b1e867db2edcd9fba772f78b77f3
TBR: donnd@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1011616Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550562}

Using wpt-import in Chromium 6908d45e.
With Chromium commits locally applied on WPT:
47f17dae "[css-typed-om] Support offset-rotate."
2c0351ed "Allow feature policy to be used in opaque origins."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15501

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=danyao

No-Export: true
Change-Id: Ie97f441bb6a44d467b7f282f0e7ce08de63030c9
Reviewed-on: https://chromium-review.googlesource.com/1011982
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550561}

Bug: 813068
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2f6ac184988b6040b2a5bd82c562201c06c1581e
Reviewed-on: https://chromium-review.googlesource.com/1000372Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550560}

Bug: 813068
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I420609e50155f7ef313a5a8ac25e067911d2c9a0
Reviewed-on: https://chromium-review.googlesource.com/1000452
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550559}

https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5170

TBR=ortuno@chromium.org

Bug: 832544
Change-Id: I0252cf8bcf5c0c16028830fa92ac69b644a7397f
Reviewed-on: https://chromium-review.googlesource.com/1011529Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550558}

When the user selects a different password value in the password bubble,
that is a signal that we detected the password field wrong. We now update the |password_element| of
the pending |PasswordForm| which produces a vote uploaded to the autofill server with the password
element which contains the selected password value.

Since password_element is part of the password store key, updating it is
possible by removing the old entry first.

The new element name is stored in the |password_element| field. This
conflicts with an obsolete feature, where we would use the element name to
autofill. I changed the obsolete code where it conflicted with
crowdsourcing.

Change-Id: If14831da442eab3120d497c0643acf2e580b8b44
Reviewed-on: https://chromium-review.googlesource.com/941522
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550557}

ShouldBypassCacheDueToUpdateViaCache() is moved to ServiceWorkerUtils
so that we can use the function in S13nSW code path.

This fixes test failures in
- http/tests/serviceworker/chromium.update-served-from-cache.html
- external/wpt/service-workers/service-worker/registration-updateviacache.https.html

Bug: 831998
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iff73827268f37b4fa2aa5826ff153bd92b3a3c92
Reviewed-on: https://chromium-review.googlesource.com/1011527
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550556}

This CL changes to package-private the access level of getters for view
elements in SigninView. Constructor has to stay public, as this class is
instantiated by LayoutInflater.

Bug: 814728
Change-Id: I91cbaa1c46917573ec0ead17d4ed50f161f544bb
Reviewed-on: https://chromium-review.googlesource.com/1010289Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550555}

Move four methods: GetSSLCertRequestInfo(), GetChannelIDService(),
GetTokenBindingSignature(), and GetChannelIDKey() from SSLClientSocket
to its base class's base class, StreamSocket.  Also make
GetSSLCertRequestInfo() const.  Provide dummy implementations, with
NOTREACHED(), in base class, to make it less painful to implement a new
derived class.

Remove 11 accounts of static_cast<SSLClientSocket*>(StreamSocket).  The
only remaining invocations are within SSLClientSocketImpl.

Bug: 826713
Change-Id: I1f87d31204b95687e6552b7d6f02578de4321eaf
Reviewed-on: https://chromium-review.googlesource.com/1010106
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550554}

TBR=phoglund@chromium.org

Bug: webrtc:8821
Change-Id: Iab26c960b3d5d796943deaf09edd2c5bd36a67ba
Reviewed-on: https://chromium-review.googlesource.com/1011610Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550553}

Bug: webrtc:8821
Change-Id: I491118ef06695897f001a27ccd296501cf6b72d7
Reviewed-on: https://chromium-review.googlesource.com/1011608Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550552}

WebRTC trybots are detecting more ODR violations in dynamic_annotations:
https://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg/builds/27341

Bug: webrtc:8821
Change-Id: I2cfa4770b6dbfdb3419431d72de914f5a538fd82
Reviewed-on: https://chromium-review.googlesource.com/1009912
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550551}

This CL decouples the keyboard accessory from the suggestions.
There is no visible change yet as suggestions will remain part of the
accessory for now. They are not part of the MVP and might become
optional/feature-guarded later.
The main purpose of this CL is, that the existing accessory can exist
without having to have suggestions to fill.

Side-effects:
 - Deflaked the tests (mainly for emulators) a little bit.
 - Maybe improved the RTL difficulties (I intend a second pass when
   taking care of crbug.com/729916).

Bug: 828832
Change-Id: I5baca03e93a04b174f3a36156b604b0c80f302b1
Reviewed-on: https://chromium-review.googlesource.com/998101
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550550}

unprefixed versions of the "grab" and "grabbing" CSS cursors
were not supported at blink.
so we should check how many use prefixed values before retire
that values. and i will make another patch to support
unprefixed values parallelly.

Bug: 708197
Change-Id: Ic882d9d6d5bc18724f3802c8ab2336668074f17d
Reviewed-on: https://chromium-review.googlesource.com/1011883
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550549}

The class now supports NonMainThreadScheduler, so its name should also
be changed. File names are also updated.

Bug: 826203
Change-Id: I49c08a359db10d28db5db434b8db5e5b0c985e6f
Reviewed-on: https://chromium-review.googlesource.com/1011862Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550548}

Bug: 831566
Change-Id: I020d3829eeeb4fff098efaf751465fdc21e9edb4
TBR: chcunningham@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1011612Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550547}

This CL adds GCC compiler flags to the main absl BUILD.gn file. Before
this CL, clang flags were used also on GCC.

TBR=phoglund@chromium.org

Bug: webrtc:8821
Change-Id: I9d84f03e5e6986d0b5fce836bd90057437029d8c
Reviewed-on: https://chromium-review.googlesource.com/1011603Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550546}

Whenever the TextInputManager::TextSelection or the
TextInputManager::CompositionRangeInfo properties of the RWHVMac change,
forward them to the RWHVCocoa. This is in contrast to the previous
behavior where we would do a synchronous IPC back to the RWHVMac to
query their value.

This is motivated by the attributedSubstringForProposedRange method
in RWHVMac, which would be complicated to implement by a synchronous
IPC.

Remove RWHVCocoa's selectedRange_ member because it is now fully
redundant to the cached copy of the selected range. Leave RWHVCocoa's
markedRange_ member because it is not always equal to the cached
copy of the composition range.

While converting attributedSubstringForProposedRange, fix an overflow
bug, and remove some roll-your-own NSString<->base::string16
conversions.

Rename ClearMarkedText to CancelComposition.

Bug: 821651
Change-Id: Ieace82d061f15c510762d37e110c70b10eeb2bde
Reviewed-on: https://chromium-review.googlesource.com/1007981
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550545}

The stability issues in 10.13's earlier releases appear to have been
fixed in 10.13.4.

Bug: 773705
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib483847c6b8b8779448b6d47d5ab3cd6a72d2c34
Reviewed-on: https://chromium-review.googlesource.com/1011252Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550544}