GitLab

On the local NTP we allow background customization even if
a theme is installed. Remove the logging for unavailablity
due to having a theme installed as it's no longer true.

Bug: None
Change-Id: Ib181fd959f5e321343789f692f18c1491b53ebbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575637Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652901}

Change-Id: Ica0e38196c37e00e2503b8674323b64ce6490554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576022
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652900}

Add viz::MetalContextProvider, and add Metal to the Skia build by
default. Do not wire up any of this yet.

Bug: 952063
Change-Id: I897d052bdbf046114c1ddc0527c1d3cafc8777c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577296Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652899}

Orca expects that this API also scroll to the target node onto the
screen. Eventually Orca will be able to use the AtkComponent scrolling
API, but that isn't widely available yet, so we implement this fallback
behavior.

Bug: 950530
Change-Id: Id769d32849221591dfdb9ab6e96c07c8fb0e6b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576561
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
Cr-Commit-Position: refs/heads/master@{#652898}

CreateNativePixmap() will need to get VkDevice to be able to allocate
buffers compatible with the target device.

Bug: 852011
Change-Id: I7294fbd48d93c0614f78440b023f63a84b01bae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570534
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652897}

Change the button from wrap_content to a width relative to the width
of parent element.

Bug: 936052
Change-Id: I63ff28b1329a221255f14113f9ae65dba2cee514
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575361
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652896}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/fe8eb40a01ae..8c506a537d15


git log fe8eb40a01ae..8c506a537d15 --date=short --no-merges --format='%ad %ae %s'
2019-04-22 norvez@chromium.org chromeos_config: mark cyan as important again


Created with:
  gclient setdep -r src/third_party/chromite@8c506a537d15

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: Ie57851f6209b058e393ebb622a0ab654bf1b7f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576297Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652895}

Previously, we were constructing and returning a unique_ptr solely for
the purpose of being able to return a nullptr if a printer was not found.
Instead, let's just return an optional which makes more sense for this.

Change-Id: I14db20b6f7ffc8855ee48de2eda622fb78ec6b57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572263
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652894}

Current AV1 content doesn't use many tiles, so we see much better
performance by increasing the number of frame threads on systems that
can handle the increase versus increasing tile threads.

This patch sets the number of tile threads based on current encoding
practices and the frame threads based on recommendations from dav1d:
https://bugzilla.mozilla.org/show_bug.cgi?id=1536783

It distributes tiles threads and frame threads based on the number of
available processors and other //media limits -- preferring to fulfill
tile thread recommendations first since the dav1d folk indicate they
are more efficient.

If a system has the cores for it, we'll now use the following:
<300p: 2 tile threads, 2 frame threads.
<700p: 3 tile threads, 2 frame threads.
<1000p: 5 tile threads, 4 frame threads
>1000p: 8 tile threads, 8 frame threads.

If we don't have the cores for it; i.e., on systems with <= 3 cores
we'll now use less threads. Previously even if a system had <= 3 cores,
we would still allocate >= 3 threads (up to 3 tile, and 2 frame). Now,
for such systems, we will set frame_threads=1 (which generates no more
threads, since the calling thread counts as a thread) and at most 1
more tile thread over the core count.

E.g. a 3 core system will use a maximum of 3 tile threads and 1 frame
thread. Single and dual core systems will use 2 tile threads and 1 frame
thread.

BUG=954659
TEST=https://www.youtube.com/watch?v=Fmdb-KmlzD8 plays smoothly; see
1m30s+ for most intense areas.

R=chcunningham

Change-Id: I82e5725a32a987a98567af9aeba495d248000105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576158
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652893}

Before tracing was not activated for client tasks due to problem of
activating tracing in their processes. Now it is solved and we have
extra events to analyze. queueBuffer and dequeueBuffer may have the same
hierarchy as surface flinger events that cause false error reporting.
This CL adds detection of surface flinger process id and consume events
from it.

TEST=Locally
BUG=b:122555793

Change-Id: I048275c56d21de0c6bf19f07ab472972af8f0e82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574648Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652892}

Bug: 909915
Change-Id: Ic64749cede88ed4ccfa0a28163fddde9f7f33e82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577489Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652891}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65dffa4595e2..109321d1bdd1


Created with:
  gclient setdep -r src-internal@109321d1bdd1

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org

Change-Id: Ic3aa61e57d7ffe3002ed959621b9c9a926d7b640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577560Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652890}

This change introduces a new metric Tabs.TimeSinceLastView.onTabClobber.

This is emitted when a user focuses the omnibox and then subsequently navigates within a certain amount
of time after returning to a tab.

This and Tabs.TimeSinceLastView.onTabView are mutually exclusive
(per-engagement).

Bug: 947572
Change-Id: I61a6fff00197134ca806adf6f94bb8bcfef7416b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551942Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Matt Simmons <mattsimmons@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652889}

Use three-words "Native File System" everywhere. Also change
RuntimeEnabledFeature status from "experimental" to no status,
since it should currently only be changed by the base::Feature
being enabled.

Bug: 853326, 929490
Change-Id: Ifaead92ed2e236dda9661e3f58d02fff017e51f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572251
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652888}

NOTRY=true

Bug: 954319
Change-Id: Id8eeeb53df0dc8747b9f4f96ae9a6f5891eef8d1
TBR: alph@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576173Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652887}

This also rewrites the test for style reasons while I'm touching it.

Bug: 953836
Change-Id: I2cf956f9fae60a9fc9ef83748e977279a459a2ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572110
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652886}

This is a reland of 4dd1f3ce.

Disabled test in msan as well.

Original change's description:
> Reland "Move loading of data URLs out of the network process."
>
> This is a reland of f45ff75d
>
> Original change's description:
> > Move loading of data URLs out of the network process.
> >
> > For subresources the renderer was already loading it in-process. Now for navigations and downloads, we keep them in the browser process. This avoids:
> > 1) sending GURLs bigger than 2MB to a different process, which strips them as they're bigger than url::kMaxURLChars
> > 2) having the network process deal with a scheme that's not going over the network, which we avoid
> >
> > Bug: 937146, 939871
> > Change-Id: I8ca8225308b2a5f1f90594ab06943f0641a5c551
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570805
> > Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> > Reviewed-by: Ken Rockot <rockot@google.com>
> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > Reviewed-by: David Trainor <dtrainor@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#652196}
>
> Bug: 937146, 939871
> Change-Id: I480da494a987c9b223c1a571821b35e3bdbc7447
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574881
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#652335}

TBR=bsep@chromium.org

Bug: 937146, 939871
Change-Id: I7088f802cb5fef81021c488aa6426d1a87604e99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577483
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652885}

A bunch of tests need to be updated for a behavior change in
https://chromium-review.googlesource.com/c/chromium/src/+/1526426
These are the ones where the updated test passes before and after the
behavior change.

Bug: 914587
Change-Id: Ic8b34c4c205ea2f9bf59b620ca6baac47cd7b1ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576025Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652884}

I was unable to repro the bug consistently with an unaltered build.
I was able to repro the bug, however, with some local changes in which
I posted the UpdateLabel calls to simulate a timing issue. With this
change, I was able to reproduce the bug consistently.

Bug: b:130758812
Change-Id: I063527e9c52f5584104ce556d3558fc4ed62e228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577494Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#652883}

Bug: 932708
Change-Id: Ib793df737907234c4ffe7f7d7f591086711d9f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574721
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652882}

The animation is already ongoing when the closing is scheduled,
Chrome is going to crash without SetTargetState() regardless of
the side-shelf state.

Bug: 954907, 951853
Test: manually
Change-Id: Ic5e67e152341cb96829fd2d1e9e768485f8b2eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577482Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652881}

This fixes an issue where a context menu opened from the app menu would
trigger UMA logging events for the bookmarks bar.

Bug: 951907
Change-Id: I4521b6b7101e2c662f347f479130201482617d6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574682Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652880}

Status bubble text was drawn with certain transparency. When it was
changed to be drawn on a label, the color would be automatically
computed based on foreground and background colors, which makes the text
color even lighter with some themes. We fix that by disable auto color
readability on that label.

BUG=952061

Change-Id: I25ec54aa82c4d62e7fa67f146f0e7c9e39511eac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565504
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652879}

Record when the infobar is shown, opened and dismissed.

Bug: 942747
Change-Id: I76b8dbfc3538d7095eb2a9f0d4e96706954c0493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574833
Auto-Submit: sebsg <sebsg@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652878}

https://chromium.googlesource.com/catapult.git/+log/76c5c490d194..4b68d1e3e421


git log 76c5c490d194..4b68d1e3e421 --date=short --no-merges --format='%ad %ae %s'
2019-04-22 crouleau@chromium.org Speculatively reduce parallelism in metrics calculations to prevent d8 error.


Created with:
  gclient setdep -r src/third_party/catapult@4b68d1e3e421

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:953365
TBR=charliea@chromium.org

Change-Id: Id0e080bd242a0b35657db6b10230642d5d13218d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576292Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652877}

Recent refactoring (r649193) added the NavigationRequest as parameter
to ValidateDidCommitParams, but instrumentation landed in r652724 is
using the member variable of RenderFrameHostImpl. This CL changes
the debug instrumentation to use the passed in parameter, which should
be available for most navigations.

Bug: 931895
Change-Id: Ic8339dd81948af83fac822d6ab6d95cea01e1838
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577581Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652876}

Defer computation of ink bounds until needed instead of pre-computing it
during shaping. This does not yet change how the bounds are accumulated.

In legacy layout the bounds are computed and cached by CachingWordShaper
immediately after shaping, minimizing changes to the API or performance.

In LayoutNG bounds are no longer computed during the PrepareLayout step,
where initial paragraph shaping occurs, nor during the subsequent layout
step, where line breaking and fragment construction takes place. Instead
bounds are only computed when NGPhysicalTextFragment::SelfInkOverflow is
called, typically during painting.

This avoids unnecessary and repetitive bounds computation, lowers memory
consumption, and simplifies the implementation. Resulting in significant
performance improvements. Specifically for forced and off-screen layout.

This improves performance significantly for LayoutNG, most of the layout
benchmarks in the blink_perf.layout suite improve by between 5% and 20%.

  chapter-reflow-once                      20%
  long-line-nowrap                         18%
  fit-content-change-available-size-text   11%
  hindi-line-layout                        10%
  change-text-css-contain                  10%
  latin-ebook-resize                       10%

Furthermore it significantly improves the more realistic loading.desktop
numbers which measure time to fully render a number of real world sites.

  timeToFirstContentfulPaint:layout        10%
  timeToInteractive                         7%
  timeToFirstMeaningfulPaint                3%
  cpuTimeToFirstMeaningfulPaint             3%

Bug: 636993
Change-Id: Ib1dbdf4483137039ddba37e4a48c816369425788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572875
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652875}

NOTRY=true

Bug: 954994
Change-Id: I5a91e3fd45cb886990ab103911117285a7f6a813
TBR: mbarowsky@chromium.org, wangxianzhu@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577496Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652874}

This change aims to demonstrate how we can re-implement the following
methods in a sane way.

 * TSFTextStore::CancelComposition()
 * TSFTextStore::ConfirmComposition()

In our initial implementation [1], those two methods were implemented
in a really hacky way. It was implemented by simulating a text change
event during a composition with an assumption that the current IME will
terminate the composition when it receives |OnTextChange|.
|ITfContextOwnerCompositionServices::TerminateComposition| should have
been used instead in this scenario.

[1]: e7888801

Bug: 948783
Change-Id: Ibfb270d9f8dc2459ca73824c7405f10111e12ad1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572240
Commit-Queue: Siye Liu <siliu@microsoft.com>
Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652873}

Change-Id: I35cddbfae13842633ff611e2f85966ac12e8b6cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572208Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652872}

Qualcomm needs a usage bit to be set on AHardwareBuffers used with HWC
for direct scanout. Currently its set internally in the framework but
since Chrome allocates its own buffers with SurfaceControl, it needs to
be added by Chrome.

R=piman@chromium.org

Bug: 889328
Change-Id: Ie5596a1bfcd9916d9676ac29c1f6c0ae2555cef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576000
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652871}

This CL surfaces the "Why this suggestion" text in the bubble for
removing suggestions.

Suggestions that can be removed now have a "More Info / Remove..."
context menu entry. Suggestions that cannot be removed have a
"More info..." context menu entry.

Both bring up a bubble.

This won't be the final UX treatment, but gets the capability in there
for further refinement.

Bug: 929477
Change-Id: I2dc9a5fea920653ead8ff9efea41fb77f91ff919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575872
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652870}

This change formats the site_settings_handler.cc and
site_settings_handler_unittest.cc files.

Change-Id: Ia678d766341022b3f5fd3e06b8f2b3788d4f733b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575825Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652869}

Found by the newly-added fuzzer. Fortunately this is not a problem for
any existing callers, which only ever passed a StringPiece derived from
a full std::string (which promises to be NUL-terminated).

Bug: 954703, 954760
Change-Id: I274de66b785d9f272a25264980e21878c5a77872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577580Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652868}

Bug: none
Change-Id: If821edbfc5ea2f222c0a885cbe14d8a48c789d0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575868
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652867}

This is a follow-up to https://crrev.com/c/1570914.

Bug: 912727
Change-Id: I284dbb580bb396da787c7d2f5755428458f88aeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577479Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652866}

This extends AutocompleteMatch with explanatory text as to where this
suggestion came from. This is currently purely based on the
AutocompleteMatchType.

These are placeholder strings meant for development only.

Bug: 929477
Change-Id: Ia8bb271b6f7ad4b2848011bec98d16d4f64f64de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574886
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652865}

Currently, we are sending text query for the timer notification actions.
Improve it by adding timer deeplinks that trigger AlarmTimerManager APIs.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

Bug: b:119116816
Test: Manual
Change-Id: Ife633a5978f9d0af1a5bef8a70782a7f7d364fa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531606
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652864}

This flag will enable net::features::kSameSiteByDefaultCookies, which
will make cookies set without a valid SameSite attribute default to
being treated as SameSite=Lax. When the feature is enabled,
SameSite=None is required to get the previous default behavior of not
having any same-site restrictions.

Bug: 953306
Change-Id: Iaa7983e6568cdadf18752e89539c3e411325694e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574835Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652863}

The class docs mention a number of methods that I have since removed.

Bug: 912727
Change-Id: Ic3ac8c28167b09c8d9acf3b336b58385e17a9ff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575725
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652862}