- 19 Nov, 2020 40 commits
-
-
Leonid Baraz authored
The purpose is to make max_total_files_size, max_total_memory_size, single_file_size and max_record common parameters for all queues, and have them available in StorageQueue. The next step would be to manage queues based on them. Also, parameterize StorageTest (like StorageQueueTest was). Bug:b:157943192 Bug:b:159361496 Change-Id: I073ba6f3a4d3dd4e9c92ef263a3f569a9343c3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548101Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#829266}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fa9411e0a242..f577788041b6 2020-11-19 mmortensen@google.com Port FindSymbolFiles from scripts/upload_symbols.py, refactor for BuildAPI. 2020-11-19 vapier@chromium.org simplify gitiles links 2020-11-19 engeg@google.com api.payload: Add dlc support to api 2020-11-18 kimjae@chromium.org dlc_lib: Sort global variable names 2020-11-18 navil@google.com dependency: Only return changed packages. 2020-11-18 saklein@chromium.org scripts/OWNERS: Add autotest_quickmerge OWNERS. 2020-11-18 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I7c8533dcb563beedcdb1cbe2208ad941ebbca111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550166Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829265}
-
Amr Aboelkher authored
policy namespace Accessing the PSM UMA constants will be useful to be used in its corresponding testing file, instead of using a literal strings. As PrivateSetMembershipStatus is being used twice, once as the expected status of the request in AutoEnrollmentClientImpl, and another usage to indicate whether PSM is enabled or not in the test file. Thus, the one inside the test file has been renamed. BUG=chromium:1150248 Change-Id: I31944094c63e505592197400d3a8d63a3db3e852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545387 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Auto-Submit: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#829264}
-
Adam Langley authored
I tightened up a lot of visibility in f50ddd34 but, while this class isn't used directly from outside of the package, the Android system uses reflection in ways that require it to be public. BUG=1002262 Change-Id: Ie2c921e465e89de4f6ff650a240c0bebe799737c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548384 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#829263}
-
Xianzhu Wang authored
Change-Id: I6fdca5b9b5ebde0af04fb8dbdc6aa524ac8e5255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548140Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829262}
-
Toni Barzic authored
The pref toggle change handler was referencing the toggle using this.$.<control-id>. This seems to be broken - possibly because the toggle is inside a template element. This changes the code to use this.$$('$<control-id>'). BUG=1150682 TEST=Toggle the setting to show shelf navigation buttons in tablet mode, and verify the shelf state (while in tablet mode) changes. Change-Id: I522a296320e886693dfd64688c51ab6a5030f9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548189 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#829261}
-
Jack Franklin authored
Change-Id: Id80b71dbd68ed0cd390bdb804ed9378cc6ac3f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550029Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829260}
-
Avi Drissman authored
On platforms where accelerators are not shown in menus, and in circumstances where the underline is not drawn, fully strip the CJK style of accelerators "(&x)". Note that this was already done for Mac native menus and associated Mac native code in FixUpWindowsStyleLabel(). Fixed: 974843 Change-Id: Ifc89fc574213cd350da8e992ac02683afec3718c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546471 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829259}
-
Nate Fischer authored
No change to logic, this only changes OWNERS. This swaps out my LDAP for file:// URIs pointing to what I think are reasonable subfolders (of which I'm already an OWNER). I also added some new per-file rules for tests which fit in the same logical grouping (networking and metrics). Test: N/A Change-Id: Id55c72e29821255a2ab2375f64596ceef6c6f19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548388 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#829258}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=pkasting@chromium.org, tluk@chromium.org Bug: 1145565 Change-Id: Ifb06297c295ec0b76e7380bc3d3787bc72a4b411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547776 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#829257}
-
Anton Bikineev authored
If maybe_ptr is within super-page payload, but refers to not allocated memory, null is returned from GetSlotStartInSuperPage. The check for returned null was missing. Bug: 11297512 Change-Id: I4284b1c79f353c32c96e9cbc75d0200aa452bf30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549921 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#829256}
-
David Grogan authored
These used some full-width characters that wpt doesn't have a font for. As a result, the sizes of the containing blocks that had been calculated to align with the text is misaligned on wpt. I replaced the characters with inline-blocks with fixed width and height. I tried using an mplus web font available in wpt but couldn't find a way to determine the size of the characters that I could use to derive the size of the blocks. Using fixed width/height blocks is more robust anyway. https://wpt.fyi/results/css/css-flexbox?label=experimental&label=master&aligned&q=css-flexbox-row Change-Id: I3e9484029c9e275c4dcc23dda967d2a166e44da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548681Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#829255}
-
David Tseng authored
- in SpeakOrEnqueue, for tts platforms that were not yet ready, we were enqueueing the utterance then immediately clearing it if the utterance was !CanBeEnqueued. We should clear the queue, then add the utterance to be spoken later. - cleanup for style/readability R=dmazzoni@chromium.org Change-Id: Ifb2311792c6dca042181871797de8aa0c67ba261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543374 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#829254}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=estade@chromium.org Bug: 1145565 Change-Id: Icbd9700d976f131d4507a9601d7664894806da2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547961 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#829253}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202011190600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/zwjjfdu5X9OPcMNJ2vD6-qpbr5JfXymOFoQz-LOYG6cC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540 Tbr: help-app@grotations.appspotmail.com Change-Id: Ia9fff990bc4d8ccc7f02a1a8834a5474d3e3d3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550164Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829252}
-
Peter Wen authored
Most of these suppressions no longer matter after switching to linting monochrome bundle only. Bug: 1116130 Change-Id: I0e675603ccb2ecdd056c6a3b8f9e995e1c0108d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546994Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#829251}
-
Artem Sumaneev authored
The test was disabled with https://codereview.chromium.org/608153002 as flaky on Mac. It does not seem to be a case anymore. BUG=339240 TEST=unit_tests --gtest_filter="PolicyTest.FileURLBlacklist" Change-Id: I4f67e001ee73b75152895960e37af5e6c98ce65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550028Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Artem Sumaneev <asumaneev@google.com> Cr-Commit-Position: refs/heads/master@{#829250}
-
Vasiliy Telezhnikov authored
Before this CL we would look just for substring in GL_EXTENSIONS string which is incorrect. In this particular case there is extension GL_ARM_shader_framebuffer_fetch_depth_stencil which extends base GL_ARM_shader_framebuffer_fetch to use for depth and stencil. Some devices (e.g Pixel 2) support it and don't support the base one. This CL switches over to gfx::ExtensionSet to avoid problems. Bug: 1150171 Change-Id: I4a2708bfeaf3ef54818ffe171fbeb7cfb2ff7452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550223Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829249}
-
Ben Pastene authored
Got the buildergroup wrong. Whoops. Bug: 1146481 Change-Id: If00c61c494d9adc1970af948fb8b6433b241a65f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548124 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#829248}
-
Guido Trotter authored
Currently when the info dialog doesn't have the remove button, its text is not read on opening, and it is not accessible via ChromeVox controls. This patch fixes it, by reading it out by default, on opening. Signed-off-by:
Guido Trotter <ultrotter@chromium.org> Fixed: 901427 Change-Id: I091e9ff9c2e32a9fc1dc40ada25b2bccea8fe569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544969Reviewed-by:
Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#829247}
-
Willie Koomson authored
This change refactors GpuArcVideoServiceHost to split it into 2 services: GpuArcVideoServiceHost implements mojom::VideoHost, while GpuArcVideoKeyedService is an ARC KeyedService that registers GpuArcVideoServiceHost with the ARC bridge. This means that GpuArcVideoServiceHost can run before login. BUG=b:165826281 TEST=tast run <DUT> arc.VideoDecodeAccel.* Change-Id: I2cec09518f3a25d0c44420c058a36517e1f747b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538162Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#829246}
-
Tanmoy Mollik authored
These test failures was caused by https://crrev.com/c/2432413 cl and was reverted. Enabling the tests again. Bug: 1145573 Change-Id: I8abe2e9b9bf999494719fa8136825695fb40cb27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549942Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#829245}
-
Lily Chen authored
This CL removes the code added in https://crrev.com/c/2243255. Bug: 1095192 Change-Id: I906b7c50e1e60184155ebabcd81dbef0798e9eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547398Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#829244}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I7dca04f8b947bc88977691c5a6fb353a5484fb36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547702Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#829243}
-
Alex Turner authored
Currently, only typeface digests (i.e. the output) are included. We now include two likely lookup values: where the family name or the PostScript name were looked up with default FontSelectionRequests. While there will be many input digests that map to the same typeface, this should handle a good chunk. We also remove the duplicate signed integer copy of the typeface digest, leaving only the unsigned version. Bug: 1150480 Change-Id: I7f36061b5da4022984a908ba9988258094e9c5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548311Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829242}
-
Wolfgang Beyer authored
This is a reland of 2c942cf7 Revert is at https://crrev.com/c/2545724 Original change's description: > [DevTools] Introduce `Page.DocumentOpened` CDP event > > Send a `Page.DocumentOpened` event via CDP when an iframe's content is > edited via JS. Writing to an iframe's document via JS is not considered > a navigation, therefore no `Page.Navigated` CDP event is emitted. But > since writing to an iframe's document can change attributes which > DevTools needs to be informed about, the `Page.DocumentOpened` event is > emitted instead. Previously only a refresh of DevTools would let > DevTools know about changes to an iframe caused by JS manipulation of > said iframe. > > Example (see http://doc/1gczarAME7AATGHwqm_IDqcGFlOM6DLAoX9rqetv4Rx0): > There is a 'frameNavigated' event for the initial load of an iframe. > If there is a 'document.write' for this iframe right away, there is no > 'frameNavigated' event for this iframe at all. > > Frontend CL: https://crrev.com/c/2507793 > (needs to be merged first, this will fix the failing tests, which fail > because the frontend cannot handle unknown CDP events) > > Bug: chromium:1140540, chromium:1140481 > > > Change-Id: I92a659b7ab8b1cb7ae50e28df40b8ca9b0bf8c86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498482 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Wolfgang Beyer <wolfi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828122} Bug: chromium:1140540 Bug: chromium:1140481 Change-Id: I4fce7b9511e61e15a52c11971ea9be7560da2e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545011Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829241}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=romanarora@chromium.org Bug: 1145565 Change-Id: Ic27dc466d5f152cb73a2f767720032eb6bf02597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548021 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#829240}
-
Hwanseung Lee authored
Use enum class instead of enum for Widget::MoveLoopEscapeBehavior. enum class is more type safety. Bug: 940736 Change-Id: I93a798be271d83179a86cb778a772b2ed70a4872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547229 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#829239}
-
Abigail Klein authored
widgets. Bug: 1068752 AX-Relnotes: Expose posinset and setsize to VoiceOver for native Change-Id: Ic4d0d598a537eeb9a6917cc867986b0b27574e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544962 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#829238}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011190600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/diLwXTxdRV6cbd18SoCniJNniVTvHD4wv7-x_eVBHkkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/150642729,b/167996979,b/171674574 Tbr: media-app@grotations.appspotmail.com Change-Id: Id2500f8da17055220fa4f0df4b4d144c27cfcb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549155Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829237}
-
Sorin Jianu authored
This is a follow up for https://chromium-review.googlesource.com/c/chromium/src/+/2495332 The idea is that passing input parameters by const references, when possible is still the C++ style. I don't recall what the specific issue was when the code did not build in the original CL. At any rate, this change does not affect the lifetime of any of the parameters, since the binding of the references in callbacks is always by value, unless the caller specifies std::ref of std::cref. Bug: 1147094 Change-Id: I47c9aef89ddbeea386e6efb9f8ae42d3385c3601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547430Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829236}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605765502-afac6c1491dbda42eb7f9fa994b3ce280c680afd.profdata to chrome-linux-master-1605786790-1f9152a71727d792e23874dce2b7f267f3ebd366.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I41055d04ab92d30f2dd7e6f9a02853a42f69ebe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549152 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829235}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c151f873e4ab..6abd28db911a 2020-11-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 169d0c7f8a7b to ec5cd38a0ca6 (2 revisions) 2020-11-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bb96f79d0e15 to 282aa417236a (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I16dc9b9cb05809c7739310ddb1a245caf858d088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549149Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829234}
-
Chris Sharp authored
value of * The default policies for ContentSettings are implemented with the * wildcard, so if the allow or block list also defines *, the behavior becomes undefined as there are two rules with the same value. Change-Id: If279c8a4ad74c36d63cd2860be2949dfe6fedd03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547309 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#829233}
-
Harry Cutts authored
As requested on https://crrev.com/c/2487253, this CL adds a note to summaries of the input-related Chrome OS-only histograms. This isn't necessarily an exhaustive set. Bug: none Change-Id: Ie73176bd2eecb669ca6eeb0c2eb6e6e7140668ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548389 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#829232}
-
Olga Sharonova authored
There are some concerns about increased audio rendering glitches in Beta finch experiment (go/mac-rt-thread-finch). They may be caused either by the renderer side RT audio thread being descheduled since it's made "preemptible", or by multiple RT audio threads competing for CPU since we relaxed their deadlines. This CL is exposing the controls to allow for further experimentation around that as needed. The plan is to backmerge this to M88 and to run an 3-leg M88 experiment with "preemptible" set to false and true in experiment groups.. Meanwhile, there is 1% M87 stable experiment to confirm positive effects on Meet we've observed in M87 Beta. Bug: 1132225 Change-Id: I7a79f5a0317814ff16252e0d88db8d61d5af599c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546712 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#829231}
-
Mingjing Zhang authored
Revert "Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`."" This reverts commit b8a64dcd. Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_OutOfView is failing consistently on "Android FYI SkiaRenderer Vulkan (Pixel 2)" https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20SkiaRenderer%20Vulkan%20%28Pixel%202%29/b8863213321775995088 Original change's description: > Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`." > > This reverts commit 85d844e3. > > Reason for revert: reland initial commit with disabled flaky test. > > Original change's description: > > Revert "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`." > > > > This reverts commit 114bc6ab. > > > > Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown is failing consistently on linux-chromeos-rel: > > > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42849 > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42850 > > > > Original change's description: > > > Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > > > > > > 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > > > 2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered. > > > 3. Set `hide_scrollbars` to avoid artificial scrollbars. > > > 4. Set `record_whole_document` to force the whole page to be rendered. > > > 5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight". > > > > > > Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37 > > > > > > Screenshots: > > > > > > - Before: https://i.imgur.com/yt6WZRx.png > > > - Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars. > > > - Patchset #3: > > > * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view. > > > * https://imgur.com/MXpgHOl > > > * https://imgur.com/haxemcr - not aligned with the node. > > > * https://imgur.com/RbdlYVT > > > - Patchset #18: > > > * https://imgur.com/EWUmn0O > > > * https://imgur.com/DUrQ1yF > > > * https://imgur.com/cT5oBSi - perfectly aligned. > > > * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended). > > > > > > Bug: 1003629 > > > Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876 > > > Commit-Queue: Maksim Sadym <sadym@chromium.org> > > > Auto-Submit: Maksim Sadym <sadym@chromium.org> > > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#827440} > > > > TBR=dgozman@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,caseq@chromium.org,sigurds@chromium.org,sadym@chromium.org > > > > Change-Id: Iaa9b6ee9f5584adbb4a521808e2d201834a6a6dc > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1003629 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538543 > > Reviewed-by: Scott Little <sclittle@chromium.org> > > Commit-Queue: Scott Little <sclittle@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827505} > > TBR=dgozman@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,caseq@chromium.org,sclittle@chromium.org,sigurds@chromium.org,sadym@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1003629 > Change-Id: I2d394d77d0235762c61449ff8e90573de4c0c5d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545524 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Maksim Sadym <sadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829147} TBR=wangxianzhu@chromium.org,caseq@chromium.org,sadym@chromium.org Change-Id: I2422b2560d10910cd90290c5647eb068743ac682 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1003629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550242Reviewed-by:
Mingjing Zhang <mjzhang@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829230}
-
Mike West authored
This reverts commit 39053ccc. Reason for revert: `PermissionBubbleBrowserTest.HasLocationBarByDefault` started failing in https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/57303 (and other Mac bots at the same time). Failures look like https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863201444294046496/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/Deterministic_failure:_PermissionBubbleBrowserTest.HasLocationBarByDefault__status_CRASH_/0. Original change's description: > Add PermissionChip feature to fieldtrial_testing_config.json. > > As a prerequisite to landing cr/339683181. > > Bug: 1134294 > Change-Id: I95a0774957c5ba1cae28faad5916865f50e5a8d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510054 > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829185} TBR=bcwhite@chromium.org,bsep@chromium.org,olesiamarukhno@google.com Change-Id: I6e8f9f26c972e5681e69a909653d2d88a6184a40 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550184Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#829229}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/745ab6e3c09a..a3db6c585a2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mkwst@google.com Change-Id: Iad1527932ff1f1cf7a0650bd7f7d41bdfcc60432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549148Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829228}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1a5d5109644a..4d79f96b5ec9 2020-11-19 yangguo@chromium.org [ts] Typecheck ProfileLauncherView.js 2020-11-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-19 jacktfranklin@chromium.org TypeScriptify ui/ContextMenu.js 2020-11-19 wolfi@chromium.org Update DevTools protocol 2020-11-19 aerotwist@chromium.org TypeScriptify LiveHeapProfileView.js 2020-11-19 alcastano@google.com Breakpoint on Trusted Type violation (Devtools) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1139949,chromium:1142804 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic9165e61488df5403e8681ba4fa95f2e74f1ffdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549147Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829227}
-