- 24 Mar, 2020 40 commits
-
-
Sergey Ulanov authored
AudioRendererAlgorithm may use resampler depending on playback rate. When using the resampler audio samples may be buffered in AudioRendererAlgorithm itself as well as in the resampler. frames_buffered() was returning only number of frames buffered internally, without accounting for the buffers in the resampler. Replaced it with BufferedFrames() that adds the buffers in the resampler. Bug: b/150247610 Change-Id: Iacc5e8914f086f5298ecc7120ab369bd32ea5a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113808 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#752720}
-
Noel Gordon authored
waitForElementsCount helper was private to directory tree tests but is more generally useful. Make it available to all tests (remoteCall). Bug: 992819 Change-Id: I8bdf21e60d34cc822656ad76a4c6b8d990832e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115860 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#752719}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I099de2febbbd2a57c22f6f6f2fd2d32d87880c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117248Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752718}
-
Peter Kasting authored
The test terminated its loop in the correct condition, but logged as if it hadn't. Adjust the code so it logs when the loop doesn't terminate. Bug: none Change-Id: I6587eccf76538a6170df84c7dfb58a179cf3f498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116540 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#752717}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c17b5128..a4725a13 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iee1f6146222867dcb2cfd10987b5531898f0b9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115749Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752716}
-
Hirokazu Honda authored
This CL make libgav1 library built on ChromeOS ARM. VideoDecoder using libgav1, Gav1VideoDecoder, is also available on ChromeOS ARM. The VideoDecoder is enabled by the chrome option, --enable-features=Gav1VideoDecoder. The chrome binary size (bytes) increases as follows for kevin (CrOS ARM 32bit); No dav1d/libgav1: 120,898,388 dav1d (ToT) : 121,397,308 (+ 498,920 bytes) libgav1 : 121,760,372 (+ 861,984 bytes) libgav1 + dav1d : 122,255,484 (+1,357,096 bytes) Bug: 1047051 Test: Build chrome Test: Gav1VideoDecoder is used on kevin with --enable-features=Gav1VideoDecoder Change-Id: I0fae28bf390e2f3f421411ad2617f153df8f191d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028875Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#752715}
-
Timothy Loh authored
Miscellaneous improvements to PluginVmInstaller: - Split up State enum into InstallingState (stage in installation) and State (idle/installing/cancelling). This removes duplication in states, and allows InstallingState to be re-used by PluginVmInstallerView later on. - Add an explicit state for checking for existing VMs to make cancelling work (I think currently calling Cancel() at this point will do nothing) - Unify cancelled observer callbacks and fix drive download cancels to correctly reset the state. Bug: 1063748 Change-Id: Ib5675e30f96509d3dae814335dfd9ea216009f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114604 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#752714}
-
Avery Musbach authored
Bug: None Change-Id: I5b4cbabdc3821049dcbbc6d2ac50413b25c23a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111394Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#752713}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Iacfe3484a804e485ad290c493a194b60cd84faff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116949Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752712}
-
Stephen McGruer authored
NOTRY=true TBR=robertma@chromium.org Bug: 1062984 Change-Id: I58c79a207768e6e7f0aa73fef771c817e5ca7c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117165Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#752711}
-
Noel Gordon authored
The caret icon between the breadcrumb <button> is never interactive so always show a CSS default cursor for the caret icon. Bug: 1062902, 1035691 Change-Id: I022752f55e8c3c527d1c7ced2aa488b13a8b789a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114473 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ae3586b5380f..2b2aec6506a8 git log ae3586b5380f..2b2aec6506a8 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 pkasting@chromium.org Revert "depot_tools: Run using Python 3 by default." Created with: gclient setdep -r src/third_party/depot_tools@2b2aec6506a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I44be14eb491467c1e809f6075bcb8d05cbe0732c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117080Reviewed-by:
-
Noel Gordon authored
Add keyboard-specific CSS rules for the drop-down menu <button>s focus and hover so they render the same effects as mouse interaction. Hence, there is no visible difference in keyboard || mouse interaction and this to match all other files app menus and context menus. Bug: 1062902, 1035691 Change-Id: I9bf24464c28036fc82a3a07ce88d1fd76cac3778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112372 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/35bcc9f6d5e8..ffed96d1528d git log 35bcc9f6d5e8..ffed96d1528d --date=short --first-parent --format='%ad %ae %s' 2020-03-24 dschuff@chromium.org Revert "Update revision for PNaCl" 2020-03-24 thakis@chromium.org Suppress a -Wunreachable-code warning in cros/arm builds. 2020-03-07 dschuff@chromium.org Disable cond_timedwait_test and debug_stub_test on Windows 2020-03-06 dschuff@chromium.org On Windows, always do a GN build so we can use tls_edit.exe with SCons 2020-03-06 dschuff@chromium.org Don't support clang/non-clang GN builds 2020-03-05 dschuff@chromium.org Ensure that MSVC is not required to be installed not building trusted code 2020-02-28 dschuff@chromium.org Update revision for PNaCl Created with: gclient setdep -r src/native_client@ffed96d1528d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:346399 Tbr: mseaborn@chromium.org Change-Id: I8ffcb099a646064f57ad89a2bbddaab34d5d0509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117241Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I796e4af3c4821fa3167250866edf781cb4cdb014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117243Reviewed-by:
-
Sergey Ulanov authored
CastRunner redirects AudioCapturer to the parent agent. The AudioCapturer implementation in the agent uses 16kHz sample rate internally. Update default sample rate to 16kHz, so the agent won't need to resample the stream. Bug: 1059836 Change-Id: I7519485f8dfc7c56c527730cc3c90bbf689146c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117161 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752705}
-
Noel Gordon authored
Make make <button> and drop-down menu <button> :active color the same, ie., don't bother trying to match :active color with other menus. Bug: 1062902, 1035691 Change-Id: Icf6dc9d0ae5f68d48f1301ff8c7f44c949c8e404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114311 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
calamity authored
Bug: 1062668 TBR=ayui@chromium.org Change-Id: I51e4514af63bd318c2a933b10f4d4b3595168e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117410Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#752703}
-
Ben Joyce authored
Updates design, annotations, and lifecycle_commons Bug: 1052460 Change-Id: I521d955abfe883868473d3b293854f2105ee8852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116594Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#752702}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/06a4dd62094e..ea6ae4a32307 git log 06a4dd62094e..ea6ae4a32307 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 titovartem@google.com Add calculation of actual encode bitrate into DefaultVideoQualityAnalyzer Created with: gclient setdep -r src/third_party/webrtc@ea6ae4a32307 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I55871ad7488c6950887a6541917031965669d886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117079Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/85201b613e63..032c78376792 git log 85201b613e63..032c78376792 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 dberris@google.com Pinpoint: Update io equal to execution timeout Created with: gclient setdep -r src/third_party/catapult@032c78376792 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1023451 Tbr: sadrul@google.com Change-Id: Icb6ac3d617c79d70b978a8232f8052832d1b54ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117075Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/12e857a3bca2..4b8b07825641 git log 12e857a3bca2..4b8b07825641 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 amaiorano@google.com CMake: make SWIFTSHADER_DCHECK_ALWAYS_ON work on Windows Created with: gclient setdep -r src/third_party/swiftshader@4b8b07825641 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib852f6fd731927fc826e7f62c86de52e26b005cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117076Reviewed-by:
-
Noel Gordon authored
Breadcrumb <button>s show focus rings when the keyboard or the pointer device (mouse/pointer/touch) is used for <button> interaction. Change that: only show focus rings for keyboard interaction, using the global focus-outline-visible class provided by the cr.ui.focus_outline visibility manager. Note the main breadcrumb <button> are direct children of the :host, so a child selector is enough to control their :focus behaviors. The last breadcrumb <button> never gets :focus (it's always [disabled]) and any hidden <button> are display:none (can not have :focus). Drop-down menu <button> do not have focus rings (no change in behavior). Bug: 1062902, 1035691 Change-Id: Ic244310f2126a30e3896f5a1da45ffacbc35dd78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111516 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
spdonghao authored
Bug: 1058829 Change-Id: I775623b50f5de2ca4851198deaac6b133f424e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115883Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#752697}
-
Meredith Lane authored
Previously, the close button was the first thing to receive focus. WAI-ARIA dictates that for a modal dialog, focus should move to the first focusable control in the dialog, in this case the font selector. The user can still close at any time by using the Esc key. Note that this causes no visual changes; it only changes focus order. Bug: 1015200 Change-Id: Ieee530095dc90a7befc30761ddcb45e8935a8121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114771 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
-
Meredith Lane authored
This change changes the *-left properties to *-inline-start to comply with RTL CSS style guides, as well as a minor change to alphabetize properties. Bug: 1024894 Change-Id: I73e0d3144af9a956f026da6ebf8b681341de8032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113602Reviewed-by:
-
Bettina Dea authored
This CL was generated by running the export script after updating the internal repos. Change-Id: I81992e0615dc6d18789d7be4d0d55c9b2aee64dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117054Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#752694}
-
rajendrant authored
Adds a histogram that is recorded once at startup when save-data estimates are available in field trial. Bug: 923551 Change-Id: Ie0d57ab0d45a8261a1c612360754f50988d3f967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112193Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#752693}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1063639 Change-Id: I57eda35f46e0adc508548182cd721de918ecc25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114398 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#752692}
-
Maggie Cai authored
Currently the replaced app map uses the wrong app id. Fix this issue and also add unit test for this. BUG=853604 Change-Id: Iabc05d87faa2bc08b2c0e2922bfd875207f577d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113603 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#752691}
-
Noel Gordon authored
When the pointer is down, anywhere in the app, a hover over breadcrumb <button> shows its :hover effect, even though the user cannot interact with the <button>, since the user has mousedown-ed on some other files app element or <button>. We should not show a :hover effect in this case, since it suggests the <button> is interactive even though it is not. Use the global pointer- active detector added in CL:2111810 to block the :hover effects on any :not(:active) breadcrumb <button>. Bug: 1062902, 1035691 Change-Id: I96d399d22f92d93ae2249027ad4ce9b70e97f802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112173Reviewed-by:
-
Jinsuk Kim authored
Removes all the occurrences of TabImpl.getActivity() in gesturenav/. Now the dependencies are passed through HistoryNavigationCoordinator.create() in the form of supplier, runnable, etc. Bug: 952703 Change-Id: I722acf5cbaa866556f2b953d7760ac7aa9630604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106045 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#752689}
-
Gyuyoung Kim authored
align-baseline.html can be migrated to WPT because it doesn't use Blink internal APIs as well as doesn't have an image baseline. Besides, the spec exists. Bug: 1063749 Change-Id: I99706d7929bc572d6fbc4b9ec0d217d7feca920d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114477Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#752688}
-
Stephen McGruer authored
Replaced with promise_rejects_js and promise_rejects_dom. Bug: 1051932 Change-Id: I9018db17d0a64e72b5234b631da5c1937364ffdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116552 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#752687}
-
Andrew Xu authored
My previous CL (https://crrev.com/c/2106958) does not cover all of scenarios. For example, show the home launcher by back gesture in tablet mode or by toggling applist button in clamshell mode. In this CL, moving the code which hides the virtual keyboard to the function [1] which handles the visibility change of applist. [1] is called before the search box view within the applist is focused (which shows the virtual keyboard through transient-blur feature). In addition, in [2], this CL ensures that the last blur time recorded in virtual keyboard controller is reset by [3]. A ash unit test case is added to verify this scenario. [1] AppListControllerImpl::OnVisibilityChanged [2] KeyboardUIController::HideKeyboard [3] KeyboardUIController::HideKeyboardExplicitlyBySystem Change-Id: I9464e21854c9dfc90e974c2ea98c183419581ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111877 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#752686}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c41827fa748d..0769db92d478 git log c41827fa748d..0769db92d478 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 leese@chromium.org Revert "Deduplicate tabs with same URL" 2020-03-23 michael.liao@microsoft.com [Elements - Accessibility Pane]: Adding more intuitive keyboard navigation to Accessibility tree 2020-03-23 michael.liao@microsoft.com [Elements - Event Listeners]: Add context menu item to reveal nodes in DOM 2020-03-23 michael.liao@microsoft.com [Pie Chart]: Implementing Keyboard Nav and SR functionality to pie charts 2020-03-23 sigurds@chromium.org [issues] Start counting at 0 2020-03-23 pfaffe@chromium.org Asyncify the CXX DWARF language plugin 2020-03-23 szuend@chromium.org Emit real TypeScript enums for inline declared protocol enum types 2020-03-23 sigurds@chromium.org [issues] Improve UX for issue resources collapse/expansion 2020-03-23 szuend@chromium.org Emit TypeScript enums in protocol.d.ts for Protocol enums 2020-03-23 tvanderlippe@chromium.org Typecheck test/{perf,screenshots} with TypeScript 2020-03-23 tvanderlippe@chromium.org Typecheck all e2e tests with TypeScript 2020-03-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-23 tvanderlippe@chromium.org Add ts_library for test/e2e/application 2020-03-23 tvanderlippe@chromium.org Fix presubmit check to always run when generated files change 2020-03-23 leese@chromium.org Deduplicate tabs with same URL Created with: gclient setdep -r src/third_party/devtools-frontend/src@0769db92d478 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1032016,chromium:1057979,chromium:670180,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib3080adace5b59cea4934c3105c43391ea6aae78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117074Reviewed-by:
-
Peter Kasting authored
Change function signatures. This is mostly using Optional to better convey "function returns a value or failure", but also uses a struct in one spot to change outparams to multiple return values. This change exposed what I think was previously a bug, where EnumMonitorForDisplayInfoCallback() would use GetDefaultMonitorPhysicalPixelsPerInch() if it could not get an appropriate pointer device, but would use an empty vector if GetPixelsPerInchForPointerDevice() failed. Using Optional for its helpers makes it easy to use the former in both cases, which seems more correct. Bug: none Change-Id: Ie9df3da798e1c5b448b57963929955193a2a255e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109262 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#752684}
-
Xing Liu authored
Image fetcher service is an existing backend to support image download, decode, and provides a disk cache for faster image data access. This CL implements the image cache layer using image fetcher service. TBR=msramek@chromium.org Bug: 1058534 Change-Id: I4fc47fad176e13b0ac6545e7e79c8389204161bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113819 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
-
Peter Kasting authored
More simplifications, this time sometimes touching helper functions. Bug: none Change-Id: Idaaf4be6c4ec0e70a311333b9bfb8ccf817d99d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108987Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f1df04b094fe..06a4dd62094e git log f1df04b094fe..06a4dd62094e --date=short --first-parent --format='%ad %ae %s' 2020-03-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2a41e24b..8bddf9e4 (751948:752565) Created with: gclient setdep -r src/third_party/webrtc@06a4dd62094e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I397bdcfa05b8e24589e177fed02bbbdefd91c217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117072Reviewed-by:
-
