- 23 May, 2018 40 commits
-
-
Rayan Kanso authored
I was writing a unittest where OpenCache is called with a MemoryLoader. It kept crashing, and it seems to me that this was due to WriteIndex running without callbacks. The CacheStorageCacheHandle was going out of scope, and when a new one was being created by NotifyCacheCreated, there was a crash due to some WeakPtr ref count internals. This fix makes sure that the ref count is non-zero until all callbacks consume the CacheStorageCacheHandle. Bug: 838908 Change-Id: I610b2cad26d5608bacd18a4daa60edc976093fb4 Reviewed-on: https://chromium-review.googlesource.com/1069350Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#561028}
-
Gauthier Ambard authored
This CL adds an effect to make the "New Incognito Tab" row of the tools menu blink a selected state when the in product help requires it. TBR=edchin@chromium.org Bug: 829344 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia677ddb92ab3ae3a3ea9fc0622cc140b1dce4367 Reviewed-on: https://chromium-review.googlesource.com/1068182Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#561027}
-
Philip Jägenstedt authored
Upstream dir went away in https://github.com/w3c/web-platform-tests/pull/10870. No-Try: true Change-Id: I5e37b453e96feaa4c491283e331ea36c00bba922 Reviewed-on: https://chromium-review.googlesource.com/1068677Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#561026}
-
Joel Hockey authored
Bug: 845075 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I58042d110a399d6c4d6879132292f9d75a99ad9a Reviewed-on: https://chromium-review.googlesource.com/1070087Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#561025}
-
Colin Blundell authored
IdentityProvider is deprecated as a general-purpose means of interacting with the user's Google accounts. This CL ports ExtensionDownloader away from it, having it instead take in the OAuth2TokenService directly as well as a callback that returns the account to use with the webstore. It also clarifies the lifetime relationship between ExtensionDownloader and the ProfileOAuth2TokenService/SigninManager instances on which it depends for authentication. In the long term ExtensionDownloader will be ported to interact with the Identity Service for its use case. This CL is an incremental step on the path that also fills the more near-term goal of eliminating usages of IdentityProvider. Bug: 809966, 809927 Change-Id: I6b82cc318bd807d559e1701391ed3e02fcb489aa Reviewed-on: https://chromium-review.googlesource.com/1051810 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561024}
-
Morten Stenshorne authored
NGConstraintSpaceBuilder is shortlived and we only have at most one of them at any given time. Using bitfields just made the code bigger and harder to maintain, and probably didn't save any memory at all. Also make it STACK_ALLOCATED. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia30cd77f3babbffec182443060e12940d4e8e2af Reviewed-on: https://chromium-review.googlesource.com/1069347Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#561023}
-
Matt Falkenhagen authored
This allows SharedWorkerScriptLoaderFactory to use non-NetworkService factories like for chrome-extension://. It allows loading such URLs for the main shared worker script. Remaining work is to add plumbing to Blink so that importScripts() also works. Bug: 839982 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I332ca96c8eef46771ca0ea7f290208642b2f82d0 Reviewed-on: https://chromium-review.googlesource.com/1068900Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561022}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Disable ProtocolParserTest.Reading on Android until it's fixed, see the third bug. (The CrOS failure was fixed a few months ago, see crbug.com/795645) Bug: 842698, 795645, 845816 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 R=thakis@chromium.org Change-Id: I4c683170508d431864880774543f942cf7446b88 Reviewed-on: https://chromium-review.googlesource.com/1068873 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#561021}
-
Max Morin authored
Bug: 845105 Change-Id: Id7dfb50a2e4b1539dfd92c62a127b29c31e65c16 Reviewed-on: https://chromium-review.googlesource.com/1065778 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#561020}
-
Nicholas Verne authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/40aa75e44dda..f6223168d99e $ git log 40aa75e44..f6223168d --date=short --no-merges --format='%ad %ae %s' 2018-05-22 nverne Add owner_id to message StartVmRequest 2018-05-21 brunokim Notify ARC on boot that supervision state changed. 2018-05-21 yusukes arc: Remove StartArcInstanceRequest message Created with: roll-dep src/third_party/cros_system_api Bug: 842561 Change-Id: Id86b391b25cfc46feb2af21e8fa84a75a660c976 Reviewed-on: https://chromium-review.googlesource.com/1070010Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#561019}
-
chromite-chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fdd7e08cde5d..8a1ffe0c9756 $ git log fdd7e08cd..8a1ffe0c9 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 bpastene chrome-sdk: Add board and sdk version as gn args. Created with: roll-dep src/third_party/chromite BUG=chromium:732531 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If7a8fea914f24d0f4719d2f44cba84d7a6896c96 Reviewed-on: https://chromium-review.googlesource.com/1069918 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561018}
-
Gauthier Ambard authored
This reverts commit f1d5c4b5. Reason for revert: Still breaking the unittest, not sure to know why it passed the CQ... Original change's description: > Re-reland "Add blink effect to the PopupMenu" > > This CL adds an effect to make the "New Incognito Tab" row of the tools > menu blink a selected state when the in product help requires it. > > TBR=edchin@chromium.org > > Bug: 829344 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Ic2e6fe63f5e2233f70ffaa0747c332778370132c > Reviewed-on: https://chromium-review.googlesource.com/1068044 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561006} TBR=edchin@chromium.org,gambard@chromium.org Change-Id: Ie70a8341a896ad0270e1f5249cf0154eb0ba607f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829344 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1070030Reviewed-by:
-
Colin Blundell authored
This method is not used, and removing it is a nice clarification of the use case of this interface. TBR=jochen@chromium.org Bug: 809927 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2ff8915f93612f029172f4b6478b7ea9eb04b9e6 Reviewed-on: https://chromium-review.googlesource.com/1046847 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#561016}
-
Yutaka Hirano authored
We're considering removing some WebRequest API functionalities from WebSocket to support Network Service. This CL adds histograms to measure whether such features are actually used. Bug: 721400 Change-Id: Ia975966291e80233b0c46d9c462c06d4766f8da9 Reviewed-on: https://chromium-review.googlesource.com/1059092 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#561015}
-
Hayato Ito authored
We need to increment (and decrement) a counter on a per-document basis because call stack can span across different documents. BUG 776656, 845770 Change-Id: Ib9e89448217e7e335ba3c32c9775c9aa9c8f28cf Reviewed-on: https://chromium-review.googlesource.com/1069959Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#561014}
-
Colin Blundell authored
This CL restricts the AccountTracker public API to what's actually used by GCMAccountTracker, its only client. This helps to clarify what the purpose of AccountTracker is. The CL also removes an AccountTracker unittest that was calling into a now-private API. That test checks that a token revocation doesn't cause any AccountTracker event to fire if the token was never made available in the first place. That sequence of events (token revocation being fired by OAuth2TokenService without the token first being made available) doesn't reflect reality, so there is no purpose in testing for it. Change-Id: Ic3085897b87895faa6cf0c3d5d5d9f6520d0c808 Reviewed-on: https://chromium-review.googlesource.com/1046832 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#561013}
-
Mugdha Lakhani authored
now that it has been rolled out to 100% on Stable. Bug: 814376 Change-Id: Ib643fcb4cea179ece647b75d07dfd3a92f935e47 Reviewed-on: https://chromium-review.googlesource.com/1069091Reviewed-by:
-
stkhapugin@chromium.org authored
Since the edit view is not of LocationBarEditView class anymore, it makes more sense to use the shorter "editView". Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2ab065846d88da69333a74c8cdc9001ccd61adf0 Reviewed-on: https://chromium-review.googlesource.com/1064511 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#561011}
-
Christian Dullweber authored
Remove dead code from components/browsing_data. Add test for output of HistoryCounter. Bug: 843995 Change-Id: I44361907de445728f4783c2206857684414f8954 Reviewed-on: https://chromium-review.googlesource.com/1064117Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#561010}
-
Gauthier Ambard authored
This CL adds some polish to the popup menu, increasing its max height and swaping the BrowserActions and CollectionsActions items. Bug: 845477 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia7f05c29f0110bedb6f0ede7847ca3e39e420360 Reviewed-on: https://chromium-review.googlesource.com/1069148Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#561009}
-
Yoichi Osato authored
This patch adds contenteditable attribute to each test in editing/selection/modify_move/move_* so that failure doesn't show up in NG. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I98d54f2a48d23b4186b0a779a97020021e7e972b Reviewed-on: https://chromium-review.googlesource.com/1070016Reviewed-by:
-
Oskar Sundbom authored
So they can be referenced between processes. This is needed to that we can, in the next CL, ask the browser / audio process to associate an input stream with an output device for echo cancellation purposes. CL 2 of 5 to plumb echo canceller output device information from into native AEC implementations. For a full outline of the changes, see: https://docs.google.com/document/d/1ZH3lk4MdoEtmOleFD3ip6X0JF2-6_24_NTUjxshvM3U/edit?usp=sharing Bug: 837661 Change-Id: I1f2b9eb7d991e54793f11063f6ee06cb3e59b106 Reviewed-on: https://chromium-review.googlesource.com/1062305Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL adds an effect to make the "New Incognito Tab" row of the tools menu blink a selected state when the in product help requires it. TBR=edchin@chromium.org Bug: 829344 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic2e6fe63f5e2233f70ffaa0747c332778370132c Reviewed-on: https://chromium-review.googlesource.com/1068044 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
now that the feature has been rolled out everywhere. Bug: 814376 Change-Id: I14e8463cfc0a948f6e41b50990a6f1f759aa2646 Reviewed-on: https://chromium-review.googlesource.com/1069014Reviewed-by:
-
Koji Ishii authored
StyleVariant was added to NGPhysicalFragment but was enabled only for NGPhysiclaTextFragment. This patch enables it for all fragments. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I892da56449f80ce4e072a9d78bfc51cafa1a535e Bug: 636993 Reviewed-on: https://chromium-review.googlesource.com/1068781 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Yoichi Osato authored
At the discussion on the painting line gap patch, we decided not to paint selection gap: https://chromium-review.googlesource.com/c/chromium/src/+/989519/7/third_party/blink/renderer/core/paint/ng/ng_text_fragment_painter.cc#120 This patch rebaselines image failures not painting such selection following the decision. Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Idb2452d50da896081265a6b9628912c92c60d6f4 Reviewed-on: https://chromium-review.googlesource.com/1068577Reviewed-by:
-
Jérôme Lebel authored
IdentityChooserViewController lets the user select a different account. "Add Account" button will be implemented with crrev.com/c/1065456. Mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQNtxfU4ytJv/files/MCHtA7U1iMGr62Mmhjs3q0iDhQHgIuNdWV0 Screenshot: https://drive.google.com/open?id=1h8As3jY03OTehX8KaR83MD8O0QkGUpX_ Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I426b92beea148dacdd675e9e1eccc1e895e4d76e Reviewed-on: https://chromium-review.googlesource.com/1058698 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Mikel Astiz authored
Pages can use Javascript to update the title, which is an event that, from history's perspective, we added support for quite recently in https://chromium-review.googlesource.com/847697 We're mostly interested during page load, and the first few seconds after loading has completed (just in case). However, some pages stay for very long (even indefinitely) in loading state, so we should guard against too many updates hammering history, which as side effect can trigger sync. We cap the max number of title updates per navigation, i.e. with a shared counter for the full timespan during which title updates are propagated to history (loading state and the few seconds after loaded). Bug: 843057 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3eb8c4157b951ea2aae941510719256bd26491d7 Reviewed-on: https://chromium-review.googlesource.com/1060055 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#561001}
-
Roman Sorokin authored
This CL wires DeviceLoginScreenDomainAutoComplete policy with the Active Directory login screen BUG=chromium:841294 TEST=ActiveDirectoryLoginAutocompleteTest.TestAutocomplete Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I29b264b251cc21b909a526bfb35c73110e6a93ea Reviewed-on: https://chromium-review.googlesource.com/1069147Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561000}
-
Alexandr Ilin authored
This CL changes use of base::SharedMemory and base::SharedMemoryHandle classes in favor of base::UnsafeSharedMemoryRegion in media::AudioSyncReader and all dependent classes. Since mojo::SharedBufferHandle can be converted to/from the both APIs classes, media.mojo.AudioDataPipe interface can stay unchanged until both sides of a data pipe are converted. Later handle<shared_buffer> should be replaced by more specific mojo_base.mojom.UnsafeSharedMemoryRegion. Bug: 844508 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icaf7f873799192433b6413f5b24f260e278929d3 Reviewed-on: https://chromium-review.googlesource.com/1068928Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560999}
-
Max Rebuschatis authored
Remove tools:replace from AndroidManifest.xml This appears unnecessary and may be causing issues. Bug: 845517 Change-Id: I913b80edba632b1afcc3836eb357ea9ab7905a27 Reviewed-on: https://chromium-review.googlesource.com/1069264Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#560998}
-
Yuta Kitamura authored
This patch removes CanExceedIdleDeadlineIfRequired() and ShouldYieldForHighPriorityWork() from WebMainThreadScheduler. Those functions are not meant to be exposed to Chromium via Web interfaces, and ThreadScheduler is the proper home for them. ThreadScheduler already has the declarations of the same functions, so at this point the declarations in WebThreadScheduler are just redundant -- we just need to remove them and we are good. Bug: 826203 Change-Id: Iaef204c07d51088a21be9f34e03074c3eb8454d9 Reviewed-on: https://chromium-review.googlesource.com/1067278Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#560997}
-
Peter K. Lee authored
- Removed background color on left-icon and added tint - Changed font-style - New dismiss icon at top-right - Changed button corner radius Screenshot of what the AFTER looks like for iPhone X and iPhone 8: https://screenshot.googleplex.com/vZw7f4UomSt Bug: 843571 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9a0446897298a3d5e51def78de61022e81115c77 Reviewed-on: https://chromium-review.googlesource.com/1068136Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#560996}
-
Darren Shen authored
|SetDraggableArea| returns checks if the container behavior is null, but KeyboardController always has a container behavior (initialised in the constructor). This patch removes the container behavior null check. Bug: 845780 Change-Id: Iaa21bd8179a7fb88a0dd277f4888ae778c624d99 Reviewed-on: https://chromium-review.googlesource.com/1069950 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#560995}
-
Daniel Cheng authored
This reverts commit 96ed9b3f. Reason for revert: Theory verified. Reverting. Original change's description: > [OOPIF] Add debugging checks for IPC races between view and frame close. > > It's unclear how this is happening: one possibility is there's a race > between WebWidget::Close() actually being invoked in the renderer (it is > currently triggered via a non-nestable posted task) and the browser > state being torn down (which sends FrameMsg_Delete from the destructor > of RenderFrameHostImpl). > > Bug: 838348 > Change-Id: If98c4f104a27f39e083f45f6cd335b326a3976e0 > Reviewed-on: https://chromium-review.googlesource.com/1067577 > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560383} TBR=dcheng@chromium.org,creis@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 838348 Change-Id: I624189fca8b6eae76be26fc1e487ec440b2217e2 Reviewed-on: https://chromium-review.googlesource.com/1069917Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#560994}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ic7ab0978b450ddf7d102c60fd7c2dc93d54e5d57 Reviewed-on: https://chromium-review.googlesource.com/1070002 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560993}
-
Jérôme Lebel authored
Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie88b2fbf10d49b6158d23c37ce593f90c81531b4 Reviewed-on: https://chromium-review.googlesource.com/1069270Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |FocusControllerTest| to use |AttachShadowRootInternal()| and CreateV0ShadowRootForTesting() instead of |Element::attachShadow()| and |Element::createShadowRoot()|to avoid using script only functions for improving code health. Change-Id: Id362106ff3f1b1f577da7ec3bce97e60b0b490f4 Reviewed-on: https://chromium-review.googlesource.com/1070011Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560991}
-
Yoshifumi Inoue authored
This patch changes |WhitespaceAttacherTest| to use |AttachShadowRootInternal()| instead of |Element::attachShadow()| to avoid using script only functions for improving code health. Change-Id: I8b646df53a1316c2c987f7599a16573c75f82896 Reviewed-on: https://chromium-review.googlesource.com/1067566Reviewed-by:
-
Abhishek Bhardwaj authored
Clang format message logic files. BUG=None TEST=Compile. Change-Id: Ia13728381fd16705fba8091236622a42e7e59f0e Reviewed-on: https://chromium-review.googlesource.com/1069685Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#560989}
-
