- 15 Jun, 2020 40 commits
-
-
Mason Freed authored
In the [1] review, three comments were missed - this CL addresses those comments. One test is deleted, as it is no longer needed once WCv0 is removed. One is a rename. And one is updated to replace ::content with ::slotted(). [1] https://chromium-review.googlesource.com/c/chromium/src/+/2243692 Bug: 937746 Change-Id: I2160ba32632b7ba1cd900158ad7b222a4e1bd941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246786 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#778533}
-
Abhijeet Singh authored
The widget for QuickAnswersView is parented to the owner of the MenuController of an active menu to allow keyboard accessibility starting chromium/2222119. The bounds the widget is set to will need to be converted from screen coordinates to that of its parent for it to keep being positioned correctly within the screen. This CL does the required coordinate conversion. Bug: b:158883518 Test: Tested on Chrome OS VM and Atlas test device. Change-Id: I52f34069df5ddb0fedff2fb5be9161bd10c31454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245172Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#778532}
-
Ben Joyce authored
Bug: 1005891 Change-Id: I8648cb582a6009653d3fd717ee8f3af8a1617dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246837Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#778531}
-
Ben Joyce authored
Converts test filters in chrome/android/webapk, chrome/browser, and chrome/test. Bug: 1005891 Change-Id: I0d14e2243cacbae5338cce3d73ec4eb610f7d135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245685Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#778530}
-
Andrew Davies authored
dev_finder and device-finder are both available in the SDK. device-finder is preferred. dev_finder is deprecated and will be removed from the SDK very soon. Bug: fxbug.dev/54129 Change-Id: I73dbbe4115fff7d2f69c7a415219c47f4fa78d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246876 Commit-Queue: Andrew Davies <awdavies@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#778529}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I194e3a501b2f54d01301541aa1cb7621bafc23d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246872Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778528}
-
Sammie Quon authored
Reland crrev.com/c/2224990, including a fix for failing builders and a fix with tablet screenshot related. It seems the problem was Minimize animation also recreates layers so when we do destroy the window, calling stop animation on the current window layer would not stop the layer we originally observed. This patch also caches the correct layer and stops the animation if the window is recreated. Test: none Bug: 1088169, 1088039 Change-Id: I502e83ac22470c892b2c4a06f8feb86af1fff59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242742 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima (slow:gardening) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#778527}
-
Linkun Chen authored
No need to add XXXToString helper function in each file. Bug: None Change-Id: Ie717defac4f4444aeab207de472ae190f935ac1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220359 Commit-Queue: Linkun Chen <lkchen@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#778526}
-
Etienne Bergeron authored
In some unittests, the ThreadPool is not created and tasks can't be posted. Typically, unittests should instantiate a TaskEnvironment to allows posting tasks to the pool. The GPU tests are wrapped and doesn't provide an easy place to instantiate that environment. As an example, this is how the angle platform methods 'gles2_conform_test': angle::InitializePlatform [0x00007FF924B66670+112] (C:\src\chromium\src\ui\gl\angle_platform_impl.cc:150) gl::GLSurfaceEGL::InitializeDisplay [0x00007FF924B79497+4943] (C:\src\chromium\src\ui\gl\gl_surface_egl.cc:1206) gl::GLSurfaceEGL::InitializeOneOff [0x00007FF924B78110+64] (C:\src\chromium\src\ui\gl\gl_surface_egl.cc:856) gl::init::InitializeGLOneOffPlatform [0x00007FF9540E764A+102] (C:\src\chromium\src\ui\gl\init\gl_initializer_win.cc:195) gl::init::InitializeGLOneOffPlatformImplementation [0x00007FF9540E607E+60] (C:\src\chromium\src\ui\gl\init\gl_factory.cc:178) gl::init::`anonymous namespace'::InitializeGLOneOffPlatformHelper [0x00007FF9540E5CE7+276] (C:\src\chromium\src\ui\gl\init\gl_factory.cc:107) gl::init::InitializeGLNoExtensionsOneOff [0x00007FF9540E5E4B+104] (C:\src\chromium\src\ui\gl\init\gl_factory.cc:134) egl::ThreadState::Get [0x00007FF6C17C68D7+623] (C:\src\chromium\src\gpu\gles2_conform_support\egl\thread_state.cc:82) eglGetDisplay [0x00007FF6C17C6036+21] (C:\src\chromium\src\gpu\gles2_conform_support\egl\egl.cc:23) GTFInitEGL [0x00007FF6C17A731D+218] (C:\src\chromium\src\third_party\gles2_conform\GTF_ES\glsl\GTF\Source\GTFInitEGL.c:310) GTFMain [0x00007FF6C17A9E1C+2073] (C:\src\chromium\src\third_party\gles2_conform\GTF_ES\glsl\GTF\Source\GTFMain.c:406) main [0x00007FF6C17C78BE+422] (C:\src\chromium\src\gpu\gles2_conform_support\native\main.cc:56) __scrt_common_main_seh [0x00007FF6C17E01E4+268] (d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288) BaseThreadInitThunk [0x00007FF962404034+20] RtlUserThreadStart [0x00007FF964443691+33] R=sunnyps@chromium.org Bug: 1091259 Change-Id: I037a4bdcaf525c6c8b3bce7dd6e76252c231a792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246869Reviewed-by:Jamie Madill <jmadill@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#778525}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/774f09ba9004..e364dd820b29 2020-06-15 nodir@chromium.org Roll rdb binary If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ib481f629f2560954b09ef15e2833e077601639c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246752Reviewed-by:
-
Emily Stark authored
The main goal of this CL is to add a regression test for https://crbug.com/1093748. To do that, it adds an OmniboxViewViews::SetPathColor() method that is overridden by TestingOmniboxView to check that the path is not set to transparent when it shouldn't be. The same method is used to test that the path is set to transparent when the path-hiding field trials are enabled. This approach waas complicated by the fact that the unit tests don't actually call the real EmphasizeURLComponents(), which is where the bug was located. TestingOmniboxView had an EmphasizeURLComponents() override that did a subset of what the real version does. The real EmphasizeURLComponents() was not immediately usable from unit tests because it had an early-return when there was a null location_bar_view_, which is the case in tests. However, I couldn't find any reason why a non-null location_bar_view_ was needed, so I simply removed that check and made the unit tests use the real EmphasizeURLComponents(). The last wrinkle in this plan is that using the real EmphasizeURLComponents() caused OmniboxViewViewsTest.OnBlur to start failing. AFAICT this is due to either a real bug related to how RTL URLs are scrolled in focus mode, or an incorrect assertion. I commented out the assertion for now and filed https://bugs.chromium.org/p/chromium/issues/detail?id=1094386. Bug: 1092651,1093748 Change-Id: I8b4690251d5d82fc28f4141bb37087ca730726fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243491 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#778523}
-
Lei Zhang authored
One variant of base::IsAligned() takes a void*, but that does not work for const float*. Change the parameter type to const void*, add a unit test for it, and convert some code in media/ that can use IsAligned(). Change-Id: Iae7f8d5057dc947ebb85839a0b10e33f21ac207a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246838Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#778522}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ebf55a0711b8..00965b9fa9a8 2020-06-15 dj2@everburning.com Remove unused variable. (#2273) 2020-06-15 rharrison@google.com Remove unused function, BaseTypeName (#2272) 2020-06-15 cepheus@frii.com HLSL: Remove support for having GLSL versions of HLSL intrinsics. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Iea7977262c60e3a570477ab55242e84690685870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246749Reviewed-by:
-
Alex Ilin authored
chrome://signin-reauth is displayed within a native dialog. The content should occupy all available space in the dialog. It used to be done by setting body.height css property to the expected height of the dialog. This logic has a flaw because the actual size might be different from the expected one. This CL defines the body.height parameter as 100% of viewport height, which we actually want. Bug: 1045515 Change-Id: I4b1200cb44882a5d9b22869a947a7bfeb6e554a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246171Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#778520}
-
John Delaney authored
These navigation start offset maps have unbounded growth in the number of frames on the page. This CL adds notifications for render frame deletion to the PLMUpdateDisaptcher and LCPHandler to prevent any potential memory leaks. Change-Id: I06689fdd00c284f4fd9986384e2d7ff7614d9415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238493 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#778519}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I67006b7fcb07d3328c0f0a5a33b594ca70ff60c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246753Reviewed-by:
-
Saurabh Nijhara authored
This CL refactors update required screen browsertest to use test::UIPath as constants for better readability. Bug: 1048607 Change-Id: Ia8f6c201409abb2074492982dbbe7484b00548d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245700Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#778517}
-
Sergey Ulanov authored
This reverts commit 28bafce9. Reason for revert: Flake due to the tests timing out. Original change's description: > Reland "Reland "Group tests of Trusted Types for WebUI"" > > This change groups tests of Trusted Types for WebUI into 10 WebUI pages > per test to minimize the size of the file. This change also fixes a bug > where `CallJavascriptFunction` might be called before allowing JS. > See: crrev.com/c/2242372 > > Bug: 41905 > Change-Id: I5f28e056ca3bcb3f39678e2b6009e66316848322 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242656 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#777969} TBR=dpapad@chromium.org,Jun.Kokatsu@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 41905 Change-Id: Ica2a1b8b76e2cb2d6690514e336b6e5e42183f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246984Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778516}
-
Wan-Teh Chang authored
Add the boolean parameter premultiply_alpha to ConvertVideoFrameToRGBPixels((), default to true. This will be used by blink::AVIFImageDecoder. Change-Id: I2a9f2ab55c0dbfa4a9e44bd749cdee187088f33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243866Reviewed-by:
-
Brian Sheedy authored
Refactors the Skia Gold-related code in //content/test/gpu/gpu_tests to be the same as //build/android/pylib. All the code that interacts with Gold is encapsulated in its own class, and users simply run one method and check its output to perform an image comparison. Also adds a bunch of unittests (also taken from //build/android/pylib) since the split makes the code unittest-able. Drive-by fixes a related TODO in //build/android since the same TODO was fixed in the GPU code in this CL. Bug: 1093994 Change-Id: Id2fe1506796695f258069334149550cfaea49f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243718Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#778514}
-
Adam Langley authored
Currently, creation requests that specify public-key algorithms that an authenticator doesn't support can still be routed to that authenticator. When that happens, it fails immediately and we ignore it, so it never blinks. Instead, don't route such requests to the authenticators in the first place and replace them with dummy touches. BUG=1094066 Change-Id: Ie89c387887339f4dfc970a9f2205c6c354d141f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214100 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#778513}
-
Kyle Horimoto authored
Prevents the need for an extra OWNERS review for search tag screenshots. Change-Id: I5959ee4b10555025ad71f18c9dcb501604496104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246821 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#778512}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7b7cf9d6efd4..359f70a9b525 2020-06-15 ddrone@google.com Merge "Initial Protozero extension support" 2020-06-15 treehugger-gerrit@google.com Merge "Add a trace-argument for per-frame state." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib5e434ad7a5406f5c5db3b305e49f079ba826feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246750Reviewed-by:
-
Chris Lu authored
This change overrides bannerInfobarButtonWasPressed: to add a modal request if upload is on. This keeps consistency with existing implementations of save card. Bug: 1071914 Change-Id: Ia82426b15cd6d2aeb733934d085faead88bfb24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241866 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#778510}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/add1180e0488..2c91b8d5a4b1 2020-06-15 awdavies@google.com [telemetry][fuchsia] dev_finder -> device-finder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I185c1c2a8a2c84a099303dc542a9a71011ba5100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246748Reviewed-by:
-
Xing Liu authored
This CL adds a date time picker dialog for download later feature. The logic is not wired to DownloadDialogBridge yet. Bug: 1078454 Change-Id: I543f389a5c357db49e2f478533f2a367a46a06cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245932 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#778508}
-
Lei Zhang authored
Fix policy and metrics files, where various owners entries use chromium.com instead of chromium.org. Change-Id: I92007a632f1f410d7e3a662f2fee3f5df9ec48a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245680Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#778507}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ie8b3002cbf7ba01a539c391d40fd31d73a56a7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245682Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#778506}
-
Rakib M. Hasan authored
Doing a git diff may be expensive. The deleted test files from the diff will already be in the set of deleted test files that are still referenced in test expectations. Bug: 1050760, 1050754 Change-Id: I7793af519df5e27596a7423acd44c25679ef8a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246944 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#778505}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/99e196c0..85169498 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9d6d0b984610e9784cd4fb02b82690e643db476d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246799Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778504}
-
Kevin Ellis authored
Previously, the transition generation was updated when an ontransition event was generated; however, this timing is too late since a transition created after a style flush should be in a new transition generation even if in the same animation frame. Bug: 1095105 Change-Id: Ibf90a68b8f57357f3e26a98af7e10ee0d63b4bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246924Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#778503}
-
Vasiliy Telezhnikov authored
This CL replaces usages of CodecBufferWaitCoordinator in CodecImage with |is_texture_owner_backed| flag as the real usage of coordinator was moved to CodecOutputBufferRenderer and here we just need to distinguish between overlay/texture owner cases Bug: 1076564 Change-Id: Iaa55fdfe3ba1830eec3ec75fba21061918926ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246547 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#778502}
-
Leonid Baraz authored
Fix for moveable objects handing by ASSIGN_OR_RETURN macro. Without this change, some of the added unittests do not compile. Bug:b:153361703 Change-Id: I0a511d2dc3256d110db63d75d96221203ab40b61 Change-Id: I0a511d2dc3256d110db63d75d96221203ab40b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242690 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#778501}
-
Justin Donnelly authored
This new header version will be used to run a second round of on-device experiments but with pre-period analysis this time. Bug: 1079341 Change-Id: I3bd554b014c21c270e4bd7b9873334c74ab94b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246624Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#778500}
-
Vasiliy Telezhnikov authored
This is first CL for cleanup after we started to use proper VideoFrame::visible_rect for Android. This code isn't used anymore. Bug: 1076564 Change-Id: Ibb29512f57346ab2c785031a909e839562949fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246180Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#778499}
-
David Bertoni authored
This CL removes using HTML pages to load scripts and converts tests to event page-based extensions. Bug: 1093066 Change-Id: I98ba6d2545bac20f1109cffa66cabece4207200b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240055Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#778498}
-
Ben Joyce authored
Bug: 1005891 Change-Id: I68e4f08bd48d84d122f5920a3216ae7e3bc06ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246938Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#778497}
-
Elly Fong-Jones authored
Bug: None Change-Id: Iaa77ee61ba63e9b2ec1412f844a1e4834c8cf4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246637Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#778496}
-
Anqing Zhao authored
Change-Id: Iba122adad93174ea75504d15c53cc9c9795ab52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246512Reviewed-by:
-
Andy Paicu authored
CL was reverted because tests failed on Android L, the problem being that the EME API call fails automatically on Android L. Disabled these tests before M. Original CL text: https://testtracker.googleplex.com/testplans/details/33023?revision=10 The link above describes the currently existing manual tests related to the permission prompts. As part of the review process, I've implemented the tests from section 1.2 all of which could be automated and are related to the "protected content" settings page. TBR=yfriedman@chromium.org Bug: 1063164 Change-Id: Ib5e76f5257e57abf6e96a33ac6257af0435ea0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246570Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778494}
-
