- 29 Jul, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic5bb69ff130d6e6e05080eb2b64e609c7bfe39b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792575}
-
Mario Bianucci authored
std::vector<> is used, but not included, resulting in a presubmit warning. This CL adds the include to fix the warning. Change-Id: I40e7bcd24c15ddb885fd4d52dbab7122105b1531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324107Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792574}
-
Dominic Mazzoni authored
Bug: 1109787 AX-Relnotes: exported PDFs are correctly tagged with language codes Change-Id: Ife54fe6a2782ffa24ccf76f222371d630fe5d210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320074Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#792573}
-
Maksim Sisov authored
Don't use X11 calls when OzonePlatform is used. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I68b4d3b6a324c759b68ebfc876b8663b19803067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315345Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#792572}
-
Ryo Hashimoto authored
ArcSessionManager is a huge class which depends on many other classes. This means sometimes it's impossible to include arc_session_manager.h because of a dependency issue. To mitigate this, put ArcSessionManager::Observer in a separate header: - ArcSessionManager::Observer -> ArcSessionManagerObserver - Replace arc_session_manager.h include with arc_session_manager_observer.h if possible. BUG=None TEST=build TBR=sky@chromium.org for type rename and #include fix Change-Id: Id90606d2ad449779c6c9ccc329bfadac7ec7136f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322426 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#792571}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I36e73a09340904d74bed6e301c2dfb20e9ad6cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324243Reviewed-by:
-
David Tseng authored
R=akihiroota@chromium.org, oshima@chromium.org Fixed: 1042907 AX-Relnotes: ChromeVox detects slight differences in Chromebook keyboard (some of which have shifted brightness up keys). Change-Id: If12a9fe12c1e12e40a32a460378057fec17b2260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311029Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792569}
-
Zhenyao Mo authored
BUG=711140 TEST=manual R=khushalsagar@chromium.org Change-Id: I93d4986998fefc1bf162c511345b34152d60a542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320928 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#792568}
-
Anders Hartvoll Ruud authored
Change-Id: I12ae422ab55376b6e796f9e38fd5fda077c0f752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324581Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#792567}
-
Ahmed Fakhry authored
R=chromium-metrics-reviews@google.com Fixed: 1109810 Change-Id: I2deab56f121c5e0847096fe5d70135f41931fc0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321521 Auto-Submit: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#792566}
-
Trent Begin authored
These calls should be BindReceiver since they accept a pending receiver and not a remote. Bug: chromium:1057739 Change-Id: I5e59a12ab696103af026912ac9ff67d1b2c7b019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323725Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792565}
-
Abigail Klein authored
changes. Fire a IA2_EVENT_OBJECT_ATTRIBUTE_CHANGED event when the text-align attribute changes. AX-Relnotes: Make it possible for Windows screen reader to announce changes to the alignment of content, such as left, right, or center. Useful for code editors. Bug: 1090995 Change-Id: I4b2d3dc70521bb61219eafd75306f8fa2e16b9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276214Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#792564}
-
Maxim Kolosovskiy authored
Bug: 1095627 Change-Id: I7daaf558ac35d2badefdc3fe774c5639ac3cacfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317210 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#792563}
-
Alex Danilo authored
RTL layout for the icons in some of the action bar buttons requires an end margin for correct positioning. Add margin-inline-end to the affected action bar buttons. Bug: 1110570 Change-Id: If08c70ec4aa66c820058cfd77a38181cb81872f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325296Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792562}
-
Timothy Loh authored
'Title' is a better description than 'BigMessage' Change-Id: I8d6b4fbab59e1c42116c43d42fe76fa53edd8f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324686 Auto-Submit: Timothy Loh <timloh@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#792561}
-
My Nguyen authored
Bug: 1108251 Change-Id: I3631d479757bde410104b128a0fcc6f63442ad11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322267Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792560}
-
Yuheng Huang authored
When there are tabs changed, TabSearchPageHandler will start a timer to schedule an upcoming call to TabsChanged(). This will reduce the number of calls to the webui frontend yet keep the data flow simple to manage. Bug: 1099917 Change-Id: I67772107d06938983fadcedc159d287bebdcc7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290996 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#792559}
-
Regan Hsu authored
Prior to this change, enabling Reverse scrolling would meant that swiping up would cause the page to move up, and vice versa. This CL corrects that so that: * Turn off Reverse (swipe up to move the page up). * Turn on Reverse (swipe up to move the page down). This is fixed by setting the "natural_scroll" pref to true if "Reverse Scrolling" is enabled, and the "natural_scroll" pref to false if "Reverse Scrolling" is disabled, instead of the opposite as it was previously. Fixed: 1109966 Change-Id: Id60df73f421992dce893339b6efaac0941ef9110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321235 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#792558}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/07cdf4214314..c20449a879c6 2020-07-28 jmadill@chromium.org DEPS: Remove use_relative_hooks. 2020-07-28 cnorthrop@google.com Capture/Replay: Break up SetupContext 2020-07-28 jonahr@google.com Add mac_xcode_version gclient arg to DEPS 2020-07-28 jmadill@chromium.org Perf Tests: Use timestamp queries for GPU time. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1107325 Tbr: tobine@google.com Test: Test: NBA2K20 MEC Change-Id: Iab63718bd8be1adeecb11be3d2356000b564258b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325201Reviewed-by:
-
Mark Pearson authored
Revive: History.InMemoryURLIndexingTime Retire: History.InMemoryURLIndexRestoreCacheTime History.InMemoryURLIndexSaveCacheTime Bug: 986511 Change-Id: I22f289ebdc696b2f2e91a02101d760ca7c2086ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324551 Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#792556}
-
Jing Wang authored
Test: tested on Chrome on Linux to verify the crash is gone. Bug: 1109386 Change-Id: I57761a67b0765d5c0c39e7bafa88a711c5478cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318890 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#792555}
-
Ankit Kumar 🌪️ authored
Currently note is added to highlights as: Highlight ++ Note While the correct format is: Highlight ++ Note ++++ Note text The CL fixes the structure for addition of notes in PDF highlights for accessibility. Tests have been updated to reflect the new structure. CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_chromium_dbg_ng Bug: 1008775 Change-Id: I83e1f4e09c901b4c2d5969528e1aeef7aebc6196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315373 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
-
Sophie Chang authored
This should provide parity with google CL 323652109 Bug: 1110487 Change-Id: I3be1c9d94aca74ec97be502dbef586cf4e101489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324889 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#792553}
-
zhaoyangli authored
Added the flag to build XCTest based unit test targets to some iOS fyi builders. Will sent follow up CLs to build the targets in all iOS builders. Ignore-CQ-Freeze: true Bug: 1001667 Change-Id: I8521ddafaafcc4424294a27da54e070a2ec4ba94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315638Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#792552}
-
shrekshao authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/803227b..c1d5cef Tbr: kbr@chromium.org Bug: 1108588, 1110449 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: Ifb676b5aec5d658754040f41dac09d6153897e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323722Reviewed-by:
Shrek Shao <shrekshao@google.com> Auto-Submit: Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#792551}
-
Jared Saul authored
Fixed: 1109857 Change-Id: Ic2d5fe9f43877c488a34c3da06fb405cc38319a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324565Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#792550}
-
Steven Bennetts authored
This includes a small amount of cleanup in the defails page and network-config-toggle. BUG=1093135 Change-Id: I4cfab202ff03cfa544ce13a6152f7fc108882f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324804 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Lei Zhang authored
Bug: 477699, 1021350 Change-Id: Iaac4c933d2da01d566c06b3c06b4fa34b306c053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324865Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#792548}
-
Dale Curtis authored
Mostly just worked already, the way that MIPS scaling was implemented was unnecessarily over-complicated though. Simply always using the Y plane size when scaling yields the same results. This also fixes some typos in the AVIF test file names as well as adds a README.md file for the ones I've updated. Some of which actually needed to be recreated since they were incorrectly labeled. Fixed: 915972 Test: Updated unittests. Change-Id: I7582a41f8dce6af21aaa1b1d2dda182f640297d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318056Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#792547}
-
Weilun Shi authored
We should set CrOS in os.name for ChromeOS to better identify ChromeOS machines. Bug: 1109204 Change-Id: I7808ff53ef0743aa35eff888a145f2d53206b100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315433 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Claude van der Merwe authored
BSSID was displayed as lower case because of missing localization in chromeos_strings.grdp Bug: 1041699 Change-Id: Ic16c307d639559a645f84d49dba5d3360b700b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324171 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#792545}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b394db45e6e6..39d1c1ebb607 2020-07-28 reed@google.com Revert "Never share pixels when we make a subset image" 2020-07-28 reed@google.com Never share pixels when we make a subset image 2020-07-28 johnstiles@google.com Use SkScalar type where appropriate. 2020-07-28 johnstiles@google.com Add missing #includes. 2020-07-28 robertphillips@google.com Skip the compressed_texture* GMs on the Pixel3 2020-07-28 mtklein@google.com JIT functions taking six pointers 2020-07-28 mtklein@google.com fix r12 2020-07-28 robertphillips@google.com Fix up image-cacherator-from-* GMs for direct context If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I690f2e10ae66160e23b756d7a43712cb873df491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324308Reviewed-by:
-
Junji Watanabe authored
This reverts commit 93873650. Reason for revert: The mixin isn't necessary anymore. Ignore-CQ-Freeze: true Original change's description: > [mac-rel-swarming] add arm-64 Mac to the target bots > > ARM Mac bots have 'arm64' cpu dimension. > https://chromium-swarm-dev.appspot.com/bot?id=build201-a9 > > Adding Ignore-CQ-Freeze because this isn't for production. > > Ignore-CQ-Freeze: true > Bug: 1103470 > Change-Id: I3d3713909994a88224aec6c9eaf48e9d0890d2ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320714 > Commit-Queue: Junji Watanabe <jwata@google.com> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Auto-Submit: Junji Watanabe <jwata@google.com> > Cr-Commit-Position: refs/heads/master@{#792461} TBR=estaab@chromium.org,martiniss@chromium.org,tikuta@chromium.org,bpastene@chromium.org,jwata@google.com,yekuang@google.com Change-Id: Ic96fb6dbb7934065cffeb637c132d23ff3202c0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325452 Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#792543}
-
Mehran Mahmoudi authored
This records the remaining required histogram and user actins for the startup experiment. Bug: 1109991 Change-Id: Id1875ba20e61f667d4de15d7448222099a287d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320888 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#792542}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/8c11e26c0dfd..d6a5a2271e6e 2020-07-29 mfoltz@chromium.org [Open Screen] Adds a unit test for logging macros. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ie3c22038cf315a34bfc5eca926fca9d4bd683a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325241Reviewed-by:
-
Yury Semikhatsky authored
After calling Browser.setWindowBounds values of the window.outerWidth/outerHeight are now updated to reflect new bounds. In headless browser WebContentsViewMac is created with null WebContentsViewDelegate hence there is no top level native window. In this change we pretend that there is such window and propagate its using newly introduced SetWindowFrameInScreen method. Bug: none Change-Id: I3bb4338ed28c2d477736bc1cc5976b873a3061d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321409 Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Auto-Submit: Yury Semikhatsky <yurys@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792540}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie205fb21acb4c9047996ee73f73155d4e17bbb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324970Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 1110458 Change-Id: I3d3d6b42fec5c872c84c0e72c07da1d634b53769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324885 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#792538}
-
David Maunder authored
UserData is a pattern to enable fields to be moved out of Tab to classes which implement the UserData interface to avoid Tab becoming too large. Bug: 1105236 Change-Id: Ia3a2bf65a4860d5eeee9d01b01c9274c03ea85c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306214 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#792537}
-
rbpotter authored
In an attempt to not match the setting too easily and restore a size the printer didn't support (see https://crbug.com/924488), Print Preview required two media sizes from different printers to match exactly, or the size would be reset to the printer default when the destination was changed. This CL allows any media sizes reporting the exact same dimensions to match, which will allow the user's selected paper size to be persisted across different destinations more often. Note that in certain cases, different destinations have similarly named paper sizes that may correspond to the same standardized size, but report slightly different dimensions for these sizes to Print Preview. This CL does not change the behavior for those cases, as it may be infeasible to distinguish such cases from printers with very similar reported sizes that correspond to different physical paper sizes, particularly given that custom user paper sizes are supported by a large number of printers. Bug: 1108661 Change-Id: I42794fd1b80f34bcd277c111a66aeeb49239e71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321965 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
