- 06 Jan, 2021 40 commits
-
-
Jérémie Boulic authored
Convert JS files for directory_model.js and dependencies. In //ui/file_manager/file_manager/foreground/js/: - constants.js - directory_contents.js - directory_contents_unittest.m.js - directory_model.js - file_list_model.js - file_list_model_unittest.m.js - file_watcher.js In //ui/file_manager/file_manager/foreground/js/ui/: - file_list_selection_model.js - file_list_selection_model_unittest.m.js In //ui/file_manager/externs/: - entries_changed_event.js To avoid the circular dependency where directory_contents.js depends on directoryModel and directory_model.js depends on DirectoryContents, the constant `DirectoryModel.CROSTINI_CONNECT_ERR` in //u/f/f/f/j/directory_model.js has been moved to `constants.CROSTINI_CONNECT_ERR` in //u/f/f/f/j/constants.js. Remove `DriveMetadataSearchContentScanner.SearchType`, which is a copy of chrome.fileManagerPrivate.SearchType. This makes mocking easier in directory_contents_unittest.m.js. Bug: 1133186 Change-Id: I819da19a9f9c0ab380e4c35c7d6ca3672b2b3556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610413 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#840482}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c8d1d1cb..8bf25fa0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I702bbd4d37adf1ab549a882e01ed4ed32fe5e769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612564Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840481}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f257fc7a7055..af799e0c26ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1161472 Tbr: patricialor@google.com Change-Id: I904f4869cc078a3b453416a98a59f732f4a1f485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612035Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840480}
-
David Bienvenu authored
Also, ignore poup windows when computing occlusion. Both these should reduce the cost of computing occlusion on Windows, especially since it will reduce the number of calls to IsWindowOnCurrentVirtualDesktop, which profiling has shown to be expensive. Bug: 1162132 Change-Id: I665ad477a26d88a1b71174893b6f9ad046a9355f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611840Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840479}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4342.0-1607345364-benchmark-89.0.4357.3-r1 to 89-4367.0-1609757097-benchmark-89.0.4379.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iaed4760b6a041af5ed379e9dbe6539269c49474f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612451Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840478}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609880376-433e631db9acaf4e4400335821e1ac4c51c26057.profdata to chrome-win64-master-1609890206-499d6ba28146a6731502f2a224934145a8e0db92.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifba43f0e3227b9fdf10ec484a2b0e87230791d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612408Reviewed-by:
-
Gang Wu authored
This is regression from https://chromium-review.googlesource.com/c/chromium/src/+/2521782 DataSaverDetail is not use footerResourceId, so we should not check it. Bug: 1163024 Change-Id: I710d20de086381cf0d0590a3c62e4971d6d614e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611869Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840476}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4342.0-1607944823-benchmark-89.0.4357.3-r1 to 89-4367.0-1609764762-benchmark-89.0.4379.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2f5ed9ac27402e7da9d86655e12ec7ab1ed74de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612450Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I213c3c025d4159fa234506eaf8f2b95ec78c968e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611951Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840474}
-
John Palmer authored
chrome-eng-reviews approval:http://g/chrome-eng-review/Jg_kfpi26ac BUG:b/175254005 Change-Id: I1ca4a8cd4927d1b211ed6d33ed255293c2053ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608100Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#840473}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ac96016abc40..6128ceacf001 2021-01-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib4c80a9d1ecd05071f4060f084faf16fa1fbb7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612410Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609869437-72e3039165a5f03888cbec3c10f727c8e1a8e480.profdata to chrome-win32-master-1609880376-51963dc93137cbb2d9fa681b7bce54c93abd3038.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I34bffc1f1a1ce2ef968c94f394a0a83563b06add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611398Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/325d666beb8f..f9a1b53d2809 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1b330a446f6a76468ff7bef047d26d972c38e757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611902Reviewed-by:
-
Melissa Zhang authored
This CL adds a SharesheetParentWidgetObserver which observes changes in the parent widget and updates the position of the bubble to remain anchored to it. Bug: 1159674 Change-Id: I9bc7d180b249fda54bc387b83501063be72ab37f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596899Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840469}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ic2d216be2e02eb61c912cda4be68e813501f22e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612406Reviewed-by:
-
Daniel Rubery authored
This CL adds a new boolean field is_dom_match to CSD pings. This makes it easier to separate out the pings due to the DOM model from the ones due to the visual model. In principle, this can be computed by comparing the score in the ping to the model threshold, but this process is fairly complex due to the potential for models to change on the server-side. Change-Id: I8685f5795eec41dddb433fe8f6dec5a4f30bee0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610951Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#840467}
-
David Tseng authored
This change implements the infrastructure for assignment and capture of Switch Access keys tied to a specific type of input device (internal, usb, bluetooth). Along the way, it also cleans up unused code, obsoleted preferences. It does not hook up the final UI for the device type which will be handled separately once UX is finalized. R=josiahk@chromium.org Bug: 1163226 Test: preexisting ash_unittests Change-Id: I381bbfb32e1de25ab6228cac7b52707170e136ab AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599923 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Josiah Krutz <josiahk@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#840466}
-
kouhei authored
Bug: 1064763 Change-Id: I47ca3b7e4287c7125bfc8daa82db2476247b3771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592852Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#840465}
-
WangHui authored
Use is_mobile_optimized from RenderFrameMetadata. Bug:1090459 Change-Id: I8ad737a6aa33abfa9c67bb5f7371421240b10d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606875Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: HuiWang <wanghui210@huawei.com> Cr-Commit-Position: refs/heads/master@{#840464}
-
Mario Bianucci authored
Part 2 of ensuring that a delegated ink trail stops as quickly as possible when a user lifts the left mouse button or pen tip, part 1 here[1]. This CL checks the new flag on the RenderFrameMetadata in the browser process to determine if the left button is expected to be down or not. It compares that information to if the button is down on the current point or not, and if they don't match, it informs viz to reset prediction. Resetting prediction when we know the trail is ending will help the trail better match the user's expectation of where the ink should show up. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2579704 Bug: 1052145 Change-Id: If2ffcba7dbddf326263bb982fc8b002d5b162221 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581001Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#840463}
-
Clark DuVall authored
This avoids users having a potentially slow startup after an update due to invalid dex. See bugs for more details. Bug: 1152970, 1159608 Change-Id: I897587b1b19ae6b9f4ba3dff23a598f9d3f58abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612088Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840462}
-
Min Qin authored
The test is failing due to threading issues. When completed_requests reaches 3, we need to wait on UI thread for the download to complete before we can verify the file content. Also added a check for received slices during the download. BUG=1105429, 1106059 Change-Id: I44f63cc898fe9f9d4390fa48fe7d56e79fe69b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606665Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840461}
-
Mario Bianucci authored
In a scenario where delegated ink trails are being used while inking via drawing with the left mouse button down, if the left mouse button is raised and inking stops, the delegated ink trail will continue briefly. This is due to the fact that the browser process isn't aware of anything about the ink trail, aside from the fact that it is being used. So it will take a moment for the renderer to process the event and send an updated RenderFrameMetadata to the browser, telling it to stop forwarding points. In this time, it can send multiple points to viz that end up being drawn as part of a trail, then erased in the next frame without the app rendering a stroke in its place, resulting in a bit of unexpected inking "whiplash" for the user. This same thing can happen when the user is using a stylus that supports hovering. After pen tip lift, hovering points may be sent from the browser to viz before the browser is aware that inking has stopped. This CL is the first step in fixing this issue by tracking the state of the left mouse button on the DelegatedInkMetadata and plumbing that information to the browser process. The follow up[1] will use that bool as part of the decision to send points to viz or not. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2581001/7 Bug: 1052145 Change-Id: I82092ce7821a4a99bac854dd792b643618c4ac28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579704 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
-
Kenton Lam authored
This is a reland of e3dd922b This was reverted in https://crrev.com/c/2600318 Original change's description: > Implement skeleton of emoji_picker using Polymer. > > Very basic skeleton of the interface with search box and list of > emoji. Currently draws emoji into groups from the emoji_ordering.json > file. There is also a row of icons (currently not rendering). > > Some changes to BUILD.gn have been made to build the components > using Polymer. This allows us to write template in html and have them > imported into the js component code (see `__html_template__` placeholders) > > Bug: 1152237 > Change-Id: Ie7f803ba8c2f45d136e81ae2f6b0dd95d616fd27 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591988 > Commit-Queue: Kenton Lam <kentonlam@google.com> > Reviewed-by: Keith Lee <keithlee@chromium.org> > Reviewed-by: John Palmer <jopalmer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837808} Bug: 1161061,1152237 Change-Id: Ifd12ba0cc53f14a3363451dd80abcb6571ce5e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607982Reviewed-by:
John Palmer <jopalmer@chromium.org> Commit-Queue: Kenton Lam <kentonlam@google.com> Cr-Commit-Position: refs/heads/master@{#840459}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.141. R=rmhasan@google.com, ynovikov@chromium.org Bug: 1041619 Change-Id: Ic3cd4f2a81627de4d7d098ca14a694d8fe4dc3e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611970 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#840458}
-
Bartek Nowierski authored
All partitions on 32-bit systems are marked non-scannable, effectively disabling PCScan and preventing address space waste for quarantine bitmaps that would never materialize. Bug: 1159694 Change-Id: I6fea110633ea0a72146beb917810b8b04d603f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601894Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#840457}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/57ea1fcb74d6..854ee85736e3 2021-01-05 csmartdalton@google.com Delete GrTriangulator::Mode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I39461014ba3a9ef9c27f60d3b712945c2b78df93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611402Reviewed-by:
-
Wenbin Zhang authored
tab_search is added and we need to update the shard map for desktops. Updating the other as well after the holiday season. Bug: chromium:1152598 Change-Id: I9183271ca56babaf79d84ed88eeaf2138276d143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611653 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#840455}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609869437-1a950cb4179e276745ee2e9da68ac232cb554183.profdata to chrome-mac-master-1609890206-97a23ce40eede0995d03d53b562706106b3aa301.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9d5fc3429eef7286b2f92759bb4f976b59fa54a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611400Reviewed-by:
-
Sammie Quon authored
Also updated some DIR_METADATA files. Bug: none Test: builds Change-Id: Ife905c4926ef4d38577fc550ef60f6ca7f7c4f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612031Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#840453}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7e7351226820..ac96016abc40 2021-01-05 vadimsh@chromium.org [cipd] Update CIPD client to 2.5.1. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1163308 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I55bb2628e18a7d75b3aee1068b5131087d6b861d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612156Reviewed-by:
-
Mei Liang authored
Fails to reproduce it locally, even with the swarming bots. This CL re-enable the test. Bug: 1127280 Change-Id: Ibf53ad0a5a0b0d8fda671f45ec7c6b4a2a2f5244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611898Reviewed-by:
-
Joey Arhar authored
Focus rings are rendered differently in dark mode, so we need additional pixel tests for dark mode. Original change: crrev.com/839189 Revert: crrev.com/839445 The original change failed because the trybots didn't have dark mode selected in the system preferences like my machine. I fixed this by removing the "light" option in the meta tag of the test, which makes it ignore the system preferences setting. Fixed: 1067517 Change-Id: I426f70fd376097e75d795470f973ede1a5a43684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600335Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#840450}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609869437-8f3fde660eac6867df6a9ca50d8e63b86cfec419.profdata to chrome-linux-master-1609890206-88ace00cc385e4ef682397c3629935c4bd822382.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1f3b6331ed61ec5daadef77d57f99d1f8aa394be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611397Reviewed-by:
-
David Maunder authored
Protocol buffers do not allow fields to be null so openerAppId is converted to an empty string if it is null on serialize() and then converted back again on deserialize(). Bug: 1161980 Change-Id: Id0cedad8b47b1f40938c934536c18769d874ca71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611899Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#840448}
-
Thomas Guilbert authored
This CL converts sync_file_system::SyncFileCallback to a base::OnceCallback. Bug: 1152272 Change-Id: Ie6d76be751d014664d90e523f899f806e1b97781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606664 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840447}
-
Kehuang Li authored
Audio packet can be sent after handshake packet, and thus handshake packet must also has a multiple of 4 bytes to ensure alignment of audio data. Merge-With: eureka-internal/509721 Bug: internal: 176167293 Test: Add alignment check on receiver side and audio works fine. Change-Id: I57343bf0238df64de47ec69ed5b64ed4eecd0a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607812 Commit-Queue: Kehuang Li <kehuangli@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840446}
-
Victor Costan authored
While here, this CL also marks some IndexedDBContextImpl data members const. No functional changes are introduced. Change-Id: I45d4b887d6a9fcf6a3719cc32e745837594dd4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609904Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840445}
-
Martin Kreichgauer authored
It's more accurate, since we generally don't care which kind of off-the-record context we're dealing with. (The exception to this is when instantiating platform authenticators, which may be available in Incognito but not Guest mode e.g.). Also change plumbing of the off-the-record bit in AuthenticatorRequestDialogModel to flow with the TransportAvailability struct. Bug: 1157651 Change-Id: I31485c734547b74b7d0e46534e0da5cbe4f1a00f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587503 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#840444}
-
Jeremy Roman authored
Bug: 1007635 Change-Id: I84efa1eb7b59fb8906b94ca6c05d24bbdf565fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600383 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840443}
-
