GitLab

The callstack refers to the old preprocessor, which is long gone.

BUG=60656
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/22377003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217030 0039d316-1c4b-4281-b951-d872f2087c98

BUG=263984
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/22601007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217029 0039d316-1c4b-4281-b951-d872f2087c98

include/gpu/gl is not normally part of the skia include path; don't
add it to include_dirs when building skia inside chromium. References
to gl headers have been fixed to qualify the path properly.

BUG=

Review URL: https://chromiumcodereview.appspot.com/22736003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217027 0039d316-1c4b-4281-b951-d872f2087c98

Regression introduced by crrev.com/216268
Symptom is errors like:
TypeError("argument of type 'NoneType' is not iterable",)

BUG=270148
TEST=manual
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/22879002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=147070
TBR=cimamoglu@google.com

Review URL: https://codereview.chromium.org/22577010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217025 0039d316-1c4b-4281-b951-d872f2087c98

The code in webkit/support/ is only used by webkit_unit_tests, which
never needs to support accelerated 2d canvas or threaded compositing.
This removes some dead code related to those features formerly used by
DumpRenderTree.

Review URL: https://chromiumcodereview.appspot.com/22311010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217024 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/22862003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217023 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217021 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=155925:155928&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/22838002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217020 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217019 0039d316-1c4b-4281-b951-d872f2087c98

R=reed@google.com

Review URL: https://codereview.chromium.org/22860003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217018 0039d316-1c4b-4281-b951-d872f2087c98

BUG=270297
TEST=Manual tests on Lumpy

Review URL: https://chromiumcodereview.appspot.com/22453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217016 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217014 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217013 0039d316-1c4b-4281-b951-d872f2087c98

This is no longer necessary with the new network connect code.

BUG=249532
R=gauravsh@chromium.org

Review URL: https://codereview.chromium.org/22761002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217012 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217011 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217010 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217009 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217008 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141757


As far as I see, after migrating 

BootTime.Total                                                                   
BootTime.Firmware                                                                
BootTime.Kernel                                                                  
BootTime.System                                                                  
BootTime.Chrome

to chromeos, struct chromeos::BootTimesLoader::BootTimes becomes empty. So I've dropped it completely and all references to it.


Probably class BootTimesLoader  should also be renamed as it doesn't load any times anymore, but instead reports time marks.


Please review.

Review URL: https://chromiumcodereview.appspot.com/22262004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217006 0039d316-1c4b-4281-b951-d872f2087c98

 - race in CommandLine::HasSwitch (issue 268946)
 - false positive in getaddrinfo/freeaddrinfo (issue 270675)

BUG=268946,270675
TBR=timurrrr@chromium.org

Review URL: https://codereview.chromium.org/22843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217004 0039d316-1c4b-4281-b951-d872f2087c98

Removed RunningInProduction and changed SessionServiceTestHelper to flush IO tasks when service is deleted.

BUG=261414

Review URL: https://chromiumcodereview.appspot.com/22363005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217003 0039d316-1c4b-4281-b951-d872f2087c98

R=mark@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22859002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217002 0039d316-1c4b-4281-b951-d872f2087c98

BUG=264078
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/22339012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217001 0039d316-1c4b-4281-b951-d872f2087c98

This implements the flingScroll, pageUp and pageDown AwContents methods
using the UI-thread scrolling mechanism.

BUG=None
TEST=AndroidWebViewTest
Android-only change, ran through trybots.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217000 0039d316-1c4b-4281-b951-d872f2087c98

All location providers now run in the "Geolocation" thread started by
GeolocationProviderImpl, so this todo is obsolete.

BUG=60739

Review URL: https://chromiumcodereview.appspot.com/22821002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216999 0039d316-1c4b-4281-b951-d872f2087c98

This prepares for the next commit, which adds automatic resolution of client certificates which doesn't require a manual trigger by the user anymore.

The only functional is that flimflam::kOpenVPNClientCertSlotProperty is not set anymore, because it was never supported by Shill and leads to errors with Service::SetProperties.

BUG=234983, 126870
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/22588002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216997 0039d316-1c4b-4281-b951-d872f2087c98

Part of this code will be moved into a layered component, and these DEPS checks
will make sure no new dependencies are introduced.

BUG=271392
R=mnissler@chromium.org

Review URL: https://codereview.chromium.org/22799003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216996 0039d316-1c4b-4281-b951-d872f2087c98

R=pfeldman

Review URL: https://chromiumcodereview.appspot.com/22638017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216995 0039d316-1c4b-4281-b951-d872f2087c98

Screenshots in bug.

BUG=270020
R=dubroy@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22855002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22536006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216993 0039d316-1c4b-4281-b951-d872f2087c98

On bookmark edit dialog, text fields gets logical focus
first, then NativeTextFieldViews gets real win32 focus,
in which case InputMethodTSF fails to set focused
TextInputClient for TSF.

This CL adds calling InputMethod()->OnFocus() when
NativeTextFieldViews (which is a TextInputClient as well)
gets focus, to make sure InputMethodTSF can properly
pass focused TextInputClient to TSF.

BUG=265337

Review URL: https://chromiumcodereview.appspot.com/21751002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216992 0039d316-1c4b-4281-b951-d872f2087c98

This allows for tests which rely on CertLoader::IsHardwareBacked returning true.

BUG=NONE
R=agl@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/22407013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216991 0039d316-1c4b-4281-b951-d872f2087c98

$./build/sanitize-png-files.sh -o2 ui/resources
Processed 127 files (out of 661 files) in 03:03:17s
Result : 166368 => 151663 bytes (14705 bytes : 8 %)

TBR=msw@chromium.org
BUG=271299

Review URL: https://codereview.chromium.org/22843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216990 0039d316-1c4b-4281-b951-d872f2087c98

Hook up the use_system_skia gyp flag to make it possible to try building
against the system version of Skia in the Android WebView.

BUG=
R=djsollen@google.com, mkosiba@chromium.org, robertphillips@google.com

Review URL: https://codereview.chromium.org/22435002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216989 0039d316-1c4b-4281-b951-d872f2087c98

ConfigureServiceForProfile was only used for WiFi as Shill didn't support other types before https://gerrit.chromium.org/gerrit/63651.

This change is helpful for Ethernet EAP policy as well, because Shill will automatically select the EthernetEAP service if the network type is EthernetEAP.

BUG=265592, 217524
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/22689003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216988 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=TRUE
TBR=akuegel@chromium.org
BUG=269006

Review URL: https://chromiumcodereview.appspot.com/22838003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216987 0039d316-1c4b-4281-b951-d872f2087c98

Currently the omnibox assumes that all matches that score at least
1200 must be inlineable / able to be shown in the omnibox.  This
is a sizable constraint on every omnibox provider.

This change creates a field trial for a new behavior: have the omnibox
providers score matches however they want, then have the omnibox
itself reorder matches as necessary to put an inlineable result first.

This change does three main things:
* this change adds a field to AutocompleteMatch to indicate whether
a match is allowed to be a legal default match.  (there's a distinction
between inline_autocomplete_offset and allowed_to_be_default_match
-- see earlier discussion on this changelist; that's why this change
adds that new field.)
  - this change also has to set the field appropriately in every provider.
* this change makes AutocompleteResult do the reordering as necessary
  (when the field trial is enabled)
* when the field trial is enabled, this change bypasses the code in
Shortcuts, HistoryQuick, and SearchProvider that enforce the constraint
relevance >= 1200 implies inlineable, thereby allowing those
providers to deliver more accurate relevance scores.
* this change revises and adds tests as necessary.

In addition to the pile of tests, I have tested it interactively to
verify that it improves the ordering of matches in the
settings on my personal profile where I hoped it would.

BUG=252531
R=hfung@chromium.org, msw@chromium.org, pkasting@chromium.org

Review URL: https://codereview.chromium.org/18878007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=271431
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/22819002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216985 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216984 0039d316-1c4b-4281-b951-d872f2087c98