- 02 Jun, 2020 15 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3fb1d569defc..5c91cb1c2f1d 2020-06-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I6639b984ef36942a339f8975732054f20ac490e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225704Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773920}
-
Renjie Tang authored
Bug: 1088365 Change-Id: Ib5d66b482cba23ae85f44de653caedd3a491c88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225349Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773919}
-
Dale Curtis authored
This is allowed by all other streams and should be harmless. R=tguilbert Fixed: 1090119 Change-Id: If9cd5a2a251a37a370b19bfdc541a2bb2eb28377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225592 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#773918}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6169aca6f508..5891b0910066 2020-06-01 cclao@google.com Vulkan: acquire swapchain image should use COLOR_ATTACHMENT_OUTPUT_BIT 2020-06-01 amaiorano@google.com Enable CopyTextureVariationsTest.CopyTexture on VK 2020-06-01 jmadill@chromium.org Vulkan: Move "null" buffer to RendererVk. 2020-06-01 lehoangq@gmail.com Metal: Fix array of structs containing array of samplers bug. 2020-06-01 msisov@igalia.com move duplicated SwapControlData to rendergl_utils. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1084458,chromium:1086532 Tbr: ynovikov@google.com Change-Id: I4d8eaa10aa665bcea0a8fe78c4e28b78c494e0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225703Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773917}
-
shrekshao authored
TBR=kbr@chromium.org Bug: 1088465, 1090059 Change-Id: I82793e2cd0c243566e8943019f66f0dee91b1c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225586Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#773916}
-
shrekshao authored
Given that Issue 949321 is fixed, re-enable the test to get a symbolized stack trace can be pursued. TBR=kbr@chromium.org, kainino@chromium.org Bug: 969013 Change-Id: I6962adfef6ca3d01bd907535cbda2ec0391cfe6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225469Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#773915}
-
Thomas Guilbert authored
This newly added test is timing out. TBR=sergeyu@chromium.org Bug: 1090159 Change-Id: I5dcc92935e12664770a17ce9f70ec03c3c9710bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225595Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#773914}
-
John Delaney authored
A number of flaky timeouts are seen in browsertests, both in test harness tear down and during test execution when waiting on asynchronous output from the storage layer. This CL bumps the task priority for the conversion storage task runner from BEST_EFFORT to USER_VISIBLE. It also adds an empty test body to a test with the feature enabled, to verify that the issue is indeed in test harness setup if this fix does not work. This feature is not enabled currently, so this should have no performance impact. Bug: 1087775,1058199,1080764,1058199,1087406,1084201 Change-Id: I7322f9d8139ab14bccbf8dd71365cfda7514cdcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225739Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#773913}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I5b2158a0af43c64055c3ea60dd74f490e579548f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222070Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773912}
-
Brian Sheedy authored
Switches all remaining uses of expected colors in the GPU pixel tests to regular pixel tests. Initially, these are set to use the very permissive Sobel algorithm so that images are auto-triaged until enough data is collected to calculate suitable less permissive parameters. The tests have grace periods defined until June 22nd, so any flakes that are not caught by the permissive algorithm will not affect the bots. Bug: 1078914 Change-Id: Ia59bba2d5117b66a537b4be3894cc9b2725ead56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219585 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#773911}
-
Josh Simmons authored
Bug: 1087123 Change-Id: I7265a9c10261881c196e6e7969ef9937097e1272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223109 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773910}
-
Greg Thompson authored
BUG=1086769 Change-Id: I546e95c9eb0a2bdf2e9f670412b27a2a46977401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222729 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#773909}
-
Jeevan Shikaram authored
When opening a web app from ARC++, if the web app is associated to a web-only TWA, we want to close the ARC++ associated with the web app. Bug: 1026230 Change-Id: If223f638ba361956a486c52007b953301a78c9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220114Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#773908}
-
Nate Chapin authored
* Remove default constructors for Document and HTMLDocument. Replace them with static CreateForTest() helpers. * Add DocumentInit::ForTest(), which (when DCHECK is enabled) flags the DocumentInit as being for a test case. * DCHECK that every user of DocumentInit calls exactly one of WithDocumentLoader(), WithExecutionContext(), or ForTest(). Change-Id: Ifb40826f2069371959bad386dea40fd039e6b11e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224991Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#773907}
-
Jesse McKenna authored
This change updates vscode.md and launch.json5 (a configuration file containing recommended settings) noting that the "type" setting in launch.json needs to be "cppvsdbg" on Windows in order to use the Visual Studio debugger. Attempting to debug on Windows using the default settings provided in launch.json5 results in error "unable to determine path to debugger". Change-Id: I8a8871adc25f6b7bb9a8dd536a19c342e5badf0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225780Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#773906}
-
- 01 Jun, 2020 25 commits
-
-
Asanka Herath authored
Metrics from these histograms continue to be useful as Chrome's usage in enterprise fluctuates. Bug: 1089001 Change-Id: I470924bf84550f94ddbe2350ec154dc4b7abf744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225509 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#773905}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie75327ebc50700cf78bb2f87a44dbc0c85cb4909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225705Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773904}
-
Julian Watson authored
If file is local but unshared display message: IDS_FILE_BROWSER_UNABLE_TO_OPEN_WITH_PLUGIN_VM_DIRECTORY_NOT_SHARED_MESSAGE. If file is on an external drive (usb/Google Drive) display message: IDS_FILE_BROWSER_UNABLE_TO_OPEN_WITH_PLUGIN_VM_EXTERNAL_DRIVE_MESSAGE TBR=timloh@chromium.org Bug: 1049453 Change-Id: I98a35e51b98d11537c0a675b0a1a28645b60ccfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217512 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#773903}
-
Katie D authored
This was mentioned in a UX review thread. OS settings for setting, ensured no longer visible on browser settings. Bug: 1055150 Test: Checked chrome://histograms for metric, tried searching Change-Id: Ia49ff8362f95cefc7c5732b79885e60d6963fd19 AX-Relnotes: Moves setting, but behind a flag. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222636Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#773902}
-
Matthew Denton authored
Bug: 1015134 Change-Id: I7cf982dae2f62be1987c24f0a8c822a4733cb7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155824 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773901}
-
Alex Gough authored
Metrics indicate that even outliers do not require more than two pages (8k). This change conservatively reduces the reserved size to six pages. A follow-on CL will remove the plumbing used to collect the metric. Tests: existing sandbox and chrome tests. Bug: 1059129 Change-Id: Id5c95cb5d3bf0e1b500732cf65927a7053d2856b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225256Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#773900}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I5dfffbc63839358c44749da6fa611bea0efb1a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225147Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#773899}
-
Jun Kokatsu authored
This change removes innerHTML usage in chrome://webrtc-internals and use template element instead. Bug: 41905 Change-Id: I7fc9be4c3e577addaca240d8a0eb5cf1b0b66dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208950 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#773898}
-
Xiaohan Wang authored
GetCdmOrigin() makes a sync call to the browser during CDM creation in the CDM service in the utility process. Since CDM creation is an async process, by the time GetCdmOrigin() is called, the render frame host hosting that call may already be gone, causing GetCdmOrigin() failure. In this case we should just ignore the error instead of the CHECK which would cause a crash in the CDM process. Bug: 1088352 Change-Id: I0298ed3a0421a0baa9c6d11fc2921f4446fd2d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225347Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773897}
-
Aaron Leventhal authored
AX-Relnotes: n/a Bug: 1088287 Change-Id: Icdcd84e938596727e8969fd93da6239e7be90e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225583 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#773896}
-
Marijn Kruisselbrink authored
Also replace remaining frame ids with GlobalFrameRoutingId rather than two separate ints to make it slightly harder to write buggy code. Bug: 1087205 Change-Id: Ie3d8c109f316cf157295eaf5524597cc3ad3a1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220271 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#773895}
-
Yoshifumi Inoue authored
This patch changes |selection_test()| to be able to accept |AsyncFunction| as tester to use |chrome.gpuBenchmarking.pointerActionSequence()| for using mouse event in tester. Note: This patch is a preparation of http://crrev.com/c/2224485. Bug: 707656, 679977 Change-Id: I8e32f043ec64d5f0b32655018fbc171e69831581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224483 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773894}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iec8e0cdb0eaf912a9b1663bd42b3ff2b22267cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225483Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773893}
-
Kai Ninomiya authored
Bug: 1069302 Change-Id: Iaa4a7ed6f20d4e625dbf9127d325121b1d56fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223092 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#773892}
-
Chong Gu authored
Adds ~5 minutes of run time and bot time per builder Bug: 1090068 Change-Id: I6cc6fde064a4b0a459a937debbc0777adb67cf9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225507 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#773891}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/da87b8d8b0a1..d8eca133b4b1 2020-06-01 rharrison@google.com Rolling 5 dependencies (#1078) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I174f03caab5077821d927677da0d97810533edef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225697Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773890}
-
David Schinazi authored
I've noticed this log on the quic.rocks server and I think including the string in this log will facilitate debugging. R=zhongyi@chromium.org Change-Id: Iaf0744e3325310989ccac1dc216cf33162b1ed14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225481 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773889}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I17bb9621e7319df7eba6504ebc2fa11935abbe97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225346Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773888}
-
Lei Zhang authored
Point it at pdf/OWNERS. Change-Id: I8c2dcc590b16c614170214566e72fa99e29d33c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223459Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#773887}
-
Kurt Horimoto authored
This was previously handled by a WebStateDelegateTabHelper instance method that was bound with a weak pointer. If the WebState is destroyed before the completion callback is executed, this means that the WebKit-provided completion block will not be executed since the weak pointer makes the callback a no-op. This CL moves this logic into a standalone C function that will execute the WebKit callback regardless of whether the WebState has been destroyed. Bug: 1087858 Change-Id: Id1a8ccfbead397d04b923b04e069589ea8e83967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225461 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#773886}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/67e50a6b5c59..43182bccce1d 2020-06-01 scroggo@google.com Remove SkBitmapRegionDecoder and SkBRDAllocator 2020-06-01 jvanverth@google.com Create ring buffer for managing D3D uniforms. 2020-06-01 csmartdalton@google.com Map the 's' key in CanvasKit viewer to force animation 2020-06-01 reed@google.com Revert "gms for SkParagraph" 2020-06-01 herb@google.com Move makeOp to SubRun 2020-06-01 fmalita@chromium.org [skottie] Pull SkottieProperty.h from Skotti.h 2020-06-01 herb@google.com Make flags private 2020-06-01 reed@google.com gms for SkParagraph 2020-06-01 johnstiles@google.com Revert "Allow printf-style formatting to be used in SK_ABORT." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I52023345b33118ba0330c26391339300cb7d4d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225696Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773885}
-
Robert Liao authored
This helps prepare for removing set_owned_by_client(). Change-Id: I3ab63431717d6df8bd826c1ce404df9be751b127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222912 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773884}
-
Taylor Bergquist authored
Bug: 1082513 Change-Id: Ic7b628f2a81b461bd9b7649e47f9d81619e21eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220700Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#773883}
-
Tom Anderson authored
The previous rebuild only updated libraries in /lib/x86_64-linux-gnu, however, /usr/lib/x86_64-linux-gnu needs to be updated too. BUG=1086636 R=thestig CC=thakis Change-Id: I3ec3dac90ee7c145f361b5af7705953b7834d5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225743 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#773882}
-
Xiaocheng Hu authored
We used to have LargestImage/TextPaint UMA, which were removed by crrev.com/c/2080815 in favor of the combined LargestContentfulPaint. This patch adds the two metrics back, but only reported when the page contains page preloading. This helps us understand how the feature FontPreloadingDelaysRendering affects text paint timings vs. image paint timings. Bug: 1040632 Change-Id: Icbddc33b85fc5a017a33435e4103a4532814d42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208256 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#773881}
-