- 16 Dec, 2020 40 commits
-
-
Emily Stark authored
Change-Id: Iafa21bda8d69d50dd5f78667ab6d21c616748fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595514Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#837744}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/772ccd850137..0e7eec75ab9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidbienvenu@google.com,smcgruer@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: davidbienvenu@google.com,smcgruer@google.com Change-Id: Ibb9eb2ef06bdc50daf382bab8c05480777284574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595995Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837743}
-
Cheick Cisse authored
This change only handles links but we will add support for images and images link later. Bug: 1140387 Change-Id: I83289a9deefbe346343bc3649ffa2c015bd20ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584604 Commit-Queue: Cheick Cisse <cheickcisse@google.com> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837742}
-
David Black authored
Since holding space only supports a specific list of allowed volumes, its welcome banner should only be shown on those volumes which the feature supports. Note that the holding space banner is also explicitly disallowed from showing on Drive per UX request. Bug: 1154347 Change-Id: I89e0c14ec9a6d1ec01700bd084e769d349243330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594314 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#837741}
-
David Bokan authored
https://crrev.com/ff530f772caac made explicit that this callback is a RepeatedCallback. We forgot to change the associated Bind call. Bug: 1152268 Change-Id: I1b9320ed117a2a2426e8a80ac02ea7ba41901fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595592 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#837740}
-
Sushanth Rajasankar authored
There are crashes in GetLastPresentedFrameMetadata(), due to a null |current_frame_|. This is probably happening when a pending call to VideoFrameCallbackRequesterImpl::OnExecution() runs after HTMLVideoElement creates a new WebMediaPlayer, and the first frame is not not yet available. This CL fixes the issue by using a WeakPtrFactory to invalidate pending OnExecution() calls, when HTMLMediaElement gets a new WebMediaPlayer. VideoFrameCallbackRequesterImpl should automatically call RequestVideoFrameCallback() on this new player when it is created, rescheduling the OnExecution() calls when the first frame becomes available. Bug: 1158160 Change-Id: I4c4228aa9d9769f728d639a94f067ccf84eb1151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585917Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Sushanth Rajasankar <Sushraja@microsoft.com> Cr-Commit-Position: refs/heads/master@{#837739}
-
Richard Coles authored
Change-Id: I1f42684060ee5416c8e68ad639e37f69b943c7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590868 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#837738}
-
Xiaohui Chen authored
Clean up launched feature flag. Bug: None Change-Id: I205696223fd6db4136220f145c5237273df07037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590709Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837737}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0c031adc5339..0da7da798b33 2020-12-16 treehugger-gerrit@google.com Merge "trace_to_text: add an option to convert perf profiles to pprof" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7085cd5a81165187edfa1e24fa4197fb8401c429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837736}
-
Yi Gu authored
Bug: 1152282 Change-Id: I9f0e5c0082634d3389cd3af49cda522e08a0e8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590058Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837735}
-
Gavin Williams authored
Histogram records the number of pages scanned in a successful scan. Bug: 1059779 Change-Id: I19b326432cfc4f8ff95b3f23354a3cd39a72b592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588648Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#837734}
-
Robert Ogden authored
When the network process encounters an error when setting up the tunnel connection, it sends that information to the proxy configurator. That will determine a reasonable Retry-After value, either from headers, or a random value between 1m-5m. Also adds Histograms to track the responses from the proxy. A Retry-After header is accepted on any non-200 response code since the proxy is a Google owned service with its own protocol. Bug: 1136114 Change-Id: If44786869268f22db7b836ebadf29b624c6cfd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587713 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#837733}
-
Jamie Madill authored
Re-land includes missing headers directory. This replaces several grouped dependencies with one meta-repo. The meta-repo will allow us to group multiple inter-dependent deps rolls into one single roll. This solves the problem of separate rollers breaking because of the inter-dependencies. It also allows ANGLE and Chrome to share common bits like the README and .gitignore files. Bug: angleproject:5390 Bug: 1153258 Change-Id: I22cefb1bfeeec656c2dbb173701a87a6db9cb8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593888 Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#837732}
-
Leonard Grey authored
Also removes ref counting since the dialog is never reused (plumbing for this was added in r174683 but both current uses are one shots). Bug: 1152274 Change-Id: I8ca68395f5fa0596d81af8abe92b536eb1129b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593929 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#837731}
-
Sigurdur Asgeirsson authored
Add missing sequence checks where the compiler complained. Change-Id: I0b8a61b41720709d01d28796c57f71e4635dbcd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590325 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#837730}
-
Regan Hsu authored
PhoneHub features will be set to FeatureState::kNotSupportedByChromebook if the current logged in user is secondary. Fixed: 1156309 Change-Id: Iea97c13c3fa2fe9edc103b00df8aa21b9447cef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590492 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#837729}
-
Robert Sesek authored
Bug: 915934 Change-Id: I0c67c1d1ddc446581783c3322be9da97652eb84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595594Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#837728}
-
Adam Langley authored
This color reflected the current practice in Play Services, but doesn't look good in dark mode. The default color works well for text and changes automatically to match the theme. BUG=1002262 Change-Id: Ib9d852f17eeec096ea4e11ce670782b2ecc6d702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596111 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#837727}
-
dpapad authored
Formatting is a left-over from the Polymer2->3 migration. Bug: 965770 Change-Id: Ic9eb1bd3a1d9139f68866f606fe17cb14a3d4f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595522 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#837726}
-
Nick Burris authored
* Now that ExternalAuthUtils is provided as a singleton instance, remove AppHooks' instance and related methods. * This is patch 5/5 for providing ExternalAuthUtils as a singleton instead of from AppHooks. Change-Id: I4278d4a6663a1d8a48314ffa2b812df722e93e12 Bug: 1154371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587240 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#837725}
-
Rakina Zata Amni authored
The kFrameTreeNodeStateReset value was removed in crrev.com/c/2536467, and the value (36) was later on incorrectly reused for a different NotRestoredReason, kNavigationCancelledWhileRestoring. This CL changes the value for kNavigationCancelledWhileRestoring to 41 so that we won't get confused on which reason was actually logged. Change-Id: I776717c88a02920b429f1949048e3a0771aa17b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592282Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#837724}
-
Thiabaud Engelbrecht authored
Some naming in ClientDiscardableSharedMemoryManager is inconsistent. This CL addresses this issue. Bug: 1157471 Change-Id: I5e76e44979706c6d4def9864686084f75dba4f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587788Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#837723}
-
Trent Begin authored
The network health components are used both in //chrome and //chromeos. Strings that are required in both locations need to be moved to //chromeos to prevent a layering violation. This change adds a new location for these shared strings and moves them there. Bug: chromium:1142857 Change-Id: I2cb497ae5df82c9718f34c15ac939e0921c69174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586971 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#837722}
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: Ia16c6612c254187e31951027cfb4284d494dde44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594287Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Cr-Commit-Position: refs/heads/master@{#837721}
-
Darin Fisher authored
Bug: 1141261 Change-Id: I9161da382aa7e2ca9eb630c5b79a065862fccbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593815Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#837720}
-
Scott Violet authored
BUG=none TEST=none Change-Id: Id233a340a9513fee590c76f35cf23a1395fbaf0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594427Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#837719}
-
Yusuke Sato authored
BUG=None TEST=try Change-Id: I9ecee3fa64eb3192adcf62b8ce5e43324d04edf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594449Reviewed-by:
Willie Koomson <wvk@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#837718}
-
Leonid Baraz authored
For all parameterized Storage tests added a new dimension: encryption enabled/disabled - now the same opening/writing/reading/reopending is tested with and without encryption. Fixed few minor mistakes, found with the test. Bug:b:170054326 Change-Id: I72df7e96b7163a5b1f7a3f43553b11ac73c15472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587505 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#837717}
-
Maggie Chen authored
The new range is between 5ms to 5s. The old range can't give us a good picture of the time it takes to finish the GPU initialization on each platform. Bug: 1153866 Change-Id: If52c1c50a9da7746d2a0ffa36b38bac1d72a9fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590696Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837716}
-
Ali Juma authored
This removes safe-browsing-real-time from about:flags since the feature is enabled by default and has shipped to 100% of Stable. This also removes safe-browsing-available from flag-metadata.json. This flag was removed from about:flags in a previous CL, but the flag-metadata.json entry was left behind. Bug: 1028755 Change-Id: I62b90e18594f906d3bc7e87392fe2afcd35f8f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595609 Auto-Submit: Ali Juma <ajuma@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#837715}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/4dbefed1b355..958f1e8ca769 2020-12-16 jophba@chromium.org Port/Rewrite of Chrome's RPCBroker 2020-12-16 miu@chromium.org Fix some places that became microseconds but are supposed to be millis. 2020-12-15 jophba@chromium.org Fix Android senders by accepting 0 sequence number. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I1659995c0ff1579158784a01826cddac765ee3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595992Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837714}
-
Morten Stenshorne authored
This used to crash, because we ignored layout abortions on floats, and would attempt to use the fragment (which is nullptr). Bug: 829028 Change-Id: I04c44030d33182fd3020e8091228668d7f8a7190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592805Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#837713}
-
Xida Chen authored
As a result of this convert, the PendingTaskInfo::task is converted to a base::OnceClosure. This is a code health CL, no behaviour change is expected. Bug: 1152278 Change-Id: I1bb1434f01b35818336a37bed6687ab71b1dfaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593480 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#837712}
-
Nick Diego Yamane authored
Early calls to Widget::SetBounds() for native windows with the same size (but changing origin location, for example) may lead to "host resized" event being propagated to widget's views tree when it shouldn't. Which leads to tricky side effects, such as crbug.com/1151092 under Wayland, for example. This avoids it by making sure initial bounding rectangle is cached at WTHPlatform when creating the PlatformWindow instance. R=sky@chromium.org Bug: 1151092 Change-Id: I476dc11ef336e8443c83dfa874d160a1a6a9581f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593547Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#837711}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608119279-b562d5ec97263b932edf0a2d650ba22af7f72930.profdata to chrome-mac-master-1608141458-a5500324610cca8317ad489f360bbb6633944839.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6083dfb96f2875792893845a53625214fd4ba300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595493Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837710}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608119279-7581a2bc471fb45383c585f2e908653a380f92f3.profdata to chrome-linux-master-1608141458-ce789808658cedde2d9d2bce7c84c9a07b9d1c0e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I87ce43caf28befb9cc0cc9508767b39be28ab6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595494Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837709}
-
Vidhan authored
PersonalDataManagerCleaner is responsible for applying address and credit card fixes and cleanups once on browser startup provided that the sync is enabled or when the sync starts. This CL factors out everything related to fixes and cleanups of address and credit card from the PersonalDataManager and moves them to the newly created PersonalDataManagerCleaner class. Change-Id: Ib6ed35b1237576c04dc6fe3fce8d8792cc07f3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584811Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#837708}
-
Xinghui Lu authored
Cache duration may be misconfigured. We should evict these caches to prevent false positive. Bug: 1156896 Change-Id: I4bc464113dc460319d7256919fb377f5d89bedf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583467Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837707}
-
Gavin Williams authored
Scanning: http://screen/BtSb3TZ6LzDiU7A Single image scanned: http://screen/BjGPJ8kxDBW2maR Multiple images scanned: http://screen/4NVszFMDFdS8FWr Bug: 1059779 Change-Id: I60f80431690e7d2c4d8732c95c01762587c200bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594325Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#837706}
-
Joe Downing authored
During a recent service outage, most of our hosts came back online but some did not. Looking at the logs, the hosts which failed to come online were treating HTTP 500 errors as 'UNAUTHENTICATED' which is a permanent error that caused the hosts to go offline. Instead of returning UNAUTHENTICATED in this case, UNAVAILABLE should be returned. This is a retryable error and is handled as such in the various classes which use the ProtobufHttpClient class. Change-Id: Idcfe98082f382b4053dfd6dbb2b4570621375f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595521Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#837705}
-