GitLab

BUG=none
R= mkearney@chromium.org, smain@chromium.org, binji@chromium.org, binji@google.com, kalman@chromium.org
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/483163002

Cr-Commit-Position: refs/heads/master@{#292305}

The selection handle was wrongly set to left handle instead of center.
Corrected it. Also added test case to verify that the paste popup is
shown when long pressed on empty input with some text in clipboard

BUG=407185

Review URL: https://codereview.chromium.org/499393002

Cr-Commit-Position: refs/heads/master@{#292304}

Removing hacky code that sends made up data to V8 to trick it into running
GC more often. This was added a long time ago and it is unlikely it is
actually helping things anymore. Removing this code also eliminates
WebMediaPlayerImpl's dependency on V8 which helps with moving this code
to media/blink.

BUG=408338

Review URL: https://codereview.chromium.org/512033002

Cr-Commit-Position: refs/heads/master@{#292303}

BUG=n/a
TEST=should pass all existing tests (no behavioral change)

Review URL: https://codereview.chromium.org/515493002

Cr-Commit-Position: refs/heads/master@{#292302}

device_data_manager shouldn't include event.h as they are in different
targets and we don't want event_base depending upon event.

BUG=none
TEST=none
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/512553003

Cr-Commit-Position: refs/heads/master@{#292301}

BUG=404868
TEST=perf fyi bot

Review URL: https://codereview.chromium.org/508363002

Cr-Commit-Position: refs/heads/master@{#292300}

This CL allows clients to specify a minimum cross axis size when using
a BoxLayout.

BUG=406983

Review URL: https://codereview.chromium.org/494273003

Cr-Commit-Position: refs/heads/master@{#292299}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/507053002

Cr-Commit-Position: refs/heads/master@{#292298}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/506153002

Cr-Commit-Position: refs/heads/master@{#292297}

Move SocketsTcpUnitTest as the first test to use it.

BUG=397164

Review URL: https://codereview.chromium.org/461273003

Cr-Commit-Position: refs/heads/master@{#292296}

This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.

There are 4 major parts to this CL:
1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.

BUG=351636

Review URL: https://codereview.chromium.org/459553003

Cr-Commit-Position: refs/heads/master@{#292295}

This is the media/ portion of a reverted CL: https://codereview.chromium.org/459603003/

BUG=349320

Review URL: https://codereview.chromium.org/516543004

Cr-Commit-Position: refs/heads/master@{#292294}

These issues came up while running for a few days with the
flag --enable-remote-core-animation.

Fix flashes of old frames by hooking up the DiscardBackbuffer (which
happens when being made non-visible) to re-set the CAContext and
CALayer (so the browser gets a new one with new content for the next
frame).

Add support for disabling vsync by using setNeedsDisplay to draw.

Change the backpressure mechanism to rely on the browser to apply
backpressure in its compositor via the cc:: output surface.

Add a ScopedSetGLToRealGLApi structure to ensure that we are talking
to the real GL API while in the CoreAnimation callback.

BUG=312462

Review URL: https://codereview.chromium.org/516643002

Cr-Commit-Position: refs/heads/master@{#292293}

+rsesek for crash key/value OWNERS.

R=scottmg,ananta,cpu
TBR=rsesek@chromium.org
BUG=399233

Review URL: https://codereview.chromium.org/508393002

Cr-Commit-Position: refs/heads/master@{#292292}

This CL allows specification of the profile to show the app list for when
launching the app list via the command line.

Currently --show-app-list always uses the last used app list profile, but we
want to allow testers to more easily load the app list for a particular
profile.

On Windows, this can be used for making shorcuts to a particular profile's
app list but this will always bind to the main shortcut due to the app id.

BUG=400874

Review URL: https://codereview.chromium.org/500333002

Cr-Commit-Position: refs/heads/master@{#292291}

These files will be used in Athena.

BUG=408373
R=calamity@chromium.org, oshima@chromium.org
TEST=no functional change

Review URL: https://codereview.chromium.org/512943003

Cr-Commit-Position: refs/heads/master@{#292290}

This is hacky, and a stopgap while we wait on property plumbing.

BUG=none
TEST=manual on link_freon
NOTRY=true

Review URL: https://codereview.chromium.org/514943003

Cr-Commit-Position: refs/heads/master@{#292289}

Revert of Initialize the now_funciton to the HighResNowWrapper in case High Res is supported (patchset #7 of https://codereview.chromium.org/446203002/)

Reason for revert:
It causes a Canary crash

https://code.google.com/p/chromium/issues/detail?id=408354

The added static initializer causes a crash in libpeerconnetion used by WebRTC

Fix to reland: remove static initializer.

Original issue's description:
> We have noticed a clock shift when QPC was deployed. It shows as a regression on the perf bots
> https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-win8-dual&tests=startup.warm.dirty.blank_page%2Fwindow_display_time&rev=286928
>
> It is not a real regression, the initial_time and initial_ticks are not properly initialized when switching to HighResolution (i.e. QPC).
> This CL initializes the now_function to the HighResNowWrapper instead of setting it to RolloverProtectedNow then to the HighResNowWrapper.
>
> By doing that, we avoid getting an incorrect initial_time and initial_ticks using the RolloverProtectedNow and avoid having to reinitialize.
>
> BUG=158234
>
> Committed: https://chromium.googlesource.com/chromium/src/+/10c40c221c314e41add0a5b4df1ee7467681a430

TBR=jar@chromium.org,willchan@chromium.org,maruel@chromium.org,thakis@chromium.org,jam@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=158234

Review URL: https://codereview.chromium.org/516693002

Cr-Commit-Position: refs/heads/master@{#292288}

sysconf via get_nprocs_conf glibc function calls opendir() which calls
openat() syscall, make them gracefully fail with EPERM instead of killing with SIGSYS.

This fixes crash trying to start chrome tracing when running
application with BareMetal with recent glibc.

BUG=407516
TESTED=launched BareMetal NaCl app and started chrome tracing and doesn't crash.

Review URL: https://codereview.chromium.org/509783003

Cr-Commit-Position: refs/heads/master@{#292287}

are being put in place with a very basic management scheme

The current ash implementation of the LowMemoryObserver polls
"/dev/chromeos-low-mem" to find if we are running out of memory.
After discussion with semenzato@ we decided that that is not precise
enough and we should rather poll the system memory information. Going
forward this has multiple benefits:
 1. it does not require special kernel handling.
 2. it also gives us information about GPU memory on chromeOS which
    will come handy once we are adding more sophisticated management.

Beside that, this CL adds the ResourceManager which hooks itself into
several components to detect changes in Activity's and their ordering
as well as memory pressure.

Note: The current management implementation itself is really primitive
and needs to be improved.

TBR for the DEPS file

BUG=381212, 403782
TEST=MemoryPressureTest.*, ResourceManagerTest.*
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/513523002

Cr-Commit-Position: refs/heads/master@{#292286}

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/511033002

Cr-Commit-Position: refs/heads/master@{#292285}

The weak fling should be handled and end the gesture session for
issue 406197. Also, fling handling turns out to check closest
state instead of last_state_. Otherwise there could be a chance
to enter an inconsistent state from the visual.

Also, the area of "closest to minimized" is too small, so I put
50px static height for this.

BUG=406197, 407890
R=oshima@chromium.org
TEST=athena_unittests, manually

Review URL: https://codereview.chromium.org/507653005

Cr-Commit-Position: refs/heads/master@{#292284}

BUG=394531
NOTRY=true

Review URL: https://codereview.chromium.org/512703005

Cr-Commit-Position: refs/heads/master@{#292283}

https://codereview.chromium.org/499623002/ adds timing diagnostics to
DomDistiller. Report histograms for these to help measure real-world
perf.

Also includes a boolean histogram for distillability based on code from internal repo.

Review URL: https://codereview.chromium.org/501553002

Cr-Commit-Position: refs/heads/master@{#292282}

BUG=

Review URL: https://codereview.chromium.org/514453003

Cr-Commit-Position: refs/heads/master@{#292281}

Skia makes no guarantees about the contents of a newly allocated
SkBitmap. Consequently, it's possible that the bitmap allocated for the
overscroll effect isn't zeroed before the effect itself is painted.
Prevent related issues by always clearing the allocated SkBitmap's
contents (to fully transparent) before painting the effect.

BUG=408225

Review URL: https://codereview.chromium.org/484373004

Cr-Commit-Position: refs/heads/master@{#292280}

We just added a new error code to ChromeOS's update_engine so also
update histograms.xml.

BUG=chromium:406546
TEST=Validated the xml, pretty print succeeded.

Review URL: https://codereview.chromium.org/514003002

Cr-Commit-Position: refs/heads/master@{#292279}

BUG=408294
TBR=dpranke

Review URL: https://codereview.chromium.org/510153003

Cr-Commit-Position: refs/heads/master@{#292278}

Picks up https://codereview.chromium.org/508343002

BUG=82385
TBR=rnk@chromium.org

Review URL: https://codereview.chromium.org/515773002

Cr-Commit-Position: refs/heads/master@{#292277}

Revert of Adding Select Action Bar Unit test case for input (patchset #3 of https://codereview.chromium.org/506423003/)

Reason for revert:
Failed compile on Android builders.

Original issue's description:
> [Android] Add unit tests for SelectActionBar appearance
>
> The SelectActionBar currently lacks test coverage. Add several test
> cases covering the appearance of the bar when interacting with an input
> field.
>
> Committed: https://chromium.googlesource.com/chromium/src/+/0bc56569817a24acea46748c599d77b59157d84d

BR=jdduke@chromium.org,aurimas@chromium.org,ajith.v@samsung.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/514493004

Cr-Commit-Position: refs/heads/master@{#292276}

(This removes the one place where we did. Sadly, there's no way to
assert that a lock isn't held by the current thread.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/488003006

Cr-Commit-Position: refs/heads/master@{#292275}

R=wtc@chromium.org

Review URL: https://codereview.chromium.org/511543006

Cr-Commit-Position: refs/heads/master@{#292274}

This reverts HidService to a singleton instance, adding two gross
and presently hard-to-avoid properties:

1. Its instance getter takes a UI message loop proxy
2. Its lifetime is bound by the message loop of its origin thread

The purpose of this is to preserve the necessary threading discipline
required by both the chrome.hid API implementation and the
permission_broker DBus client while ensuring that the HidService is
created and destroyed on the same thread.

BUG=401234

Review URL: https://codereview.chromium.org/464753002

Cr-Commit-Position: refs/heads/master@{#292273}

BUG=403597

Review URL: https://codereview.chromium.org/490193003

Cr-Commit-Position: refs/heads/master@{#292272}

BUG=144491

Review URL: https://codereview.chromium.org/440813002

Cr-Commit-Position: refs/heads/master@{#292271}

Instad of generating exported validateFooRequest(),
validateFooResponse() methods, a pointer to a validation
functions is added to the generated Stub and Proxy class
prototypes. For example, given an interface Foo, with
client interface FooClient:

  FooStub.prototype.validators = [validateFooRequest];
  FooProxy.prototype.validators = [validateFooResponse];

Note that if interface Foo has no callbacks, then
FooProxy.prototype.validators is an empty array.

The router validates incoming messages using these functions
and validateMessageHeader().

BUG=407181

Review URL: https://codereview.chromium.org/488173006

Cr-Commit-Position: refs/heads/master@{#292270}

Sysfs related functionality should have never been a separate Platform. There
should just be one Platform at a time.

BUG=

Review URL: https://codereview.chromium.org/509043002

Cr-Commit-Position: refs/heads/master@{#292269}

BUG=405642

Review URL: https://codereview.chromium.org/490033002

Cr-Commit-Position: refs/heads/master@{#292268}

BUG=407874,407861

Review URL: https://codereview.chromium.org/507873002

Cr-Commit-Position: refs/heads/master@{#292267}

Revert of Re-enable memory tests. Fixed sign-in issue. (patchset #3 of https://codereview.chromium.org/491863003/)

Reason for revert:
Failing on bots. Looks like we forgot to commit the archive.

Traceback (most recent call last):
  File "/b/build/slave/Android_Nexus5_Perf/build/src/tools/perf/../telemetry/telemetry/value/failure.py", line 39, in _GetExcInfoFromMessage
    raise Exception(message)
Exception: Page set archive doesn't exist.

http://chromegw/i/chromium.perf/builders/Android%20Nexus5%20Perf/builds/1480/steps/memory.mobile_memory/logs/stdio

Original issue's description:
> Re-enable memory tests. Fixed sign-in issue.
>
> Re-recording other tests may be required.
>
> BUG=370977
>
> Committed: https://chromium.googlesource.com/chromium/src/+/383ffaab6b5fac34b950d9faaab637cc75907aca

TBR=skyostil@chromium.org,starodub@google.com
NOTREECHECKS=true
NOTRY=true
BUG=370977

Review URL: https://codereview.chromium.org/511023002

Cr-Commit-Position: refs/heads/master@{#292266}