GitLab

TBR=acondor@chromium.org

Bug: 890380
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibce268155e198a855e6815bced44578001b8279e
Reviewed-on: https://chromium-review.googlesource.com/1252083Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595170}

Bug: 876587
Change-Id: I340c12102a697d6f1b710594111536de564a338c
Reviewed-on: https://chromium-review.googlesource.com/1239354
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595169}

This CL includes:
- Enable feature for deleting corrupted passwords
- Enable feature for preventing overwriting the encryption key
- Disable feature that recovers passwords for Sync users (covered
    with the new feature)
- Update tests

Bug: 791541
Change-Id: I1726515dbd74ad2fa64ef1abf419e88c65d48bf0
Reviewed-on: https://chromium-review.googlesource.com/1240300
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595168}

We have num_of_active_touches_for_test in both TouchActionFilter and
InputRouterImpl class which are used in InputRouterImplTest only. This
CL makes InputRouterImplTest a friend class to TouchActionFilter so that
we can just access its private member.

This CL is a code cleanup, there is no behavior change introduced.

Bug: None
Change-Id: I768a5e293f5c16d1f1d39af7e2abf161f35e669d
Reviewed-on: https://chromium-review.googlesource.com/1246274Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595167}

This reverts commit f7e423bf.

Reason for revert:

This was a speculative fix, thinking that perhaps WillClose() wasn't getting called. But it is, and all the correct calls are being made (see https://bugs.chromium.org/p/chromium/issues/detail?id=880210#c16) so this code only complicates things.

Original change's description:
> Make sure to unblock a WebContents during a mass dialog closure.
> 
> BUG=880210
> 
> Change-Id: I44e80bc0866fef5370936db3f2cb4d3eacf620f2
> Reviewed-on: https://chromium-review.googlesource.com/1241094
> Reviewed-by: Leonard Grey <lgrey@chromium.org>
> Reviewed-by: Mike Wittman <wittman@chromium.org>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594135}

TBR=avi@chromium.org,wittman@chromium.org,lgrey@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 880210
Change-Id: Ibbd669649add66e0bc4052eb6b04c845ffb40f38
Reviewed-on: https://chromium-review.googlesource.com/1249389Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595166}

The cleanup was already done in https://codereview.chromium.org/92903003
but the associated comment wasn't removed. Also fix a comment typo I
spotted in the original CL.

Bug: 290992
Change-Id: I27fdd333169234f3ac2816f96bda2c94d0bb21f2
Reviewed-on: https://chromium-review.googlesource.com/1252162Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595165}

Highlighting was previously added to buttons with anchored widgets. This is not the desired effect for promo buttons. This change makes the highlighted function overridable and removes the button highlight for the feature promo bubbles.

Bug: 888462
Change-Id: I79077bf9e7f30543eee6ae87db0785e9a0e08051
Reviewed-on: https://chromium-review.googlesource.com/1246144
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595164}

Using wpt-import in Chromium 10a65146.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25463

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
cbiesinger@chromium.org:
  external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: Ifa85ef7ed34ebed1c59a1839ced1db8da4ebfd4d
Reviewed-on: https://chromium-review.googlesource.com/1251984
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595163}

Bug: 867770

Change-Id: If1d986bfc6f77320d04701dac341c4a8f6f0fda2
Reviewed-on: https://chromium-review.googlesource.com/1250094
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595162}

This CL adds ApiCompatibilityUtils.createLayerDrawable and
LayerDrawableCompat. createLayerDrawable creates LayerDrawableCompat on
Android K and earlier versions and falls back to regular LayerDrawable
on newer versions. LayerDrawableCompat overrides mutate() method to work
around an issue in LayerDrawable.mutate() when the bounds of child
drawables aren't properly copied during the mutation. This issue would
force ImageView to appear empty if it contains a LayerDrawable and this
drawable is mutated.

Bug: 890317
Change-Id: I3479a304917df1873645ccfda7102475981eff5b
Reviewed-on: https://chromium-review.googlesource.com/1251544Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595161}

In an attempt to make login failures easier to debug, update
several messages describing progress and errors to include
string descriptions of numeric codes:

  Policy validation failed: 2
  Session manager operation failed: 5
  Failed to retrieve cros policies. Reason: 5
  Resolved state to: 13

Bug: 888520
Change-Id: I8c331c6af7f68dd2e0aa7cdfc98336f4af27f9c2
Reviewed-on: https://chromium-review.googlesource.com/1249730Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595160}

This is a reland of 5cae37b5

Two tests that were changed from Failure to Crash turned out
to be flaky, they do not crash on linux-xenial-rel.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/3698

Original change's description:
> [LayoutNG] Make constraint space for column balancing intermediate
>
> Fragment caching and paint needs to know if fragments created
> for a constraint space are for the regular layout that are to
> be painted, or it's for intermediate computation.
>
> Since the layout results for column balancing should not be
> painted, this patch marks so.
>
> This change alone doesn't fix all weird paint data
> inconsistencies when block fragmentation is turned on. Other
> issues need further investigation.
>
> Bug: 714962
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
> Change-Id: I14d44ca10fd23726f2c08be45b10c2b0abe16bf7
> Reviewed-on: https://chromium-review.googlesource.com/1250685
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595051}

TBR=mstensho@chromium.org

Bug: 714962, 890326
Change-Id: I3ed406ee0ab34f63e3c5b6a7352dac44274014f9
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/1251682Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595159}

Bug: 875173
Change-Id: Ifd08a9fe6c6ba08af9f98f92570f523987959e5a
Reviewed-on: https://chromium-review.googlesource.com/1250170Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595158}

This is a reland of d54e0de4

Original change's description:
> [Autofill] Browser Tests for Sign-in After Local Save.
> 
> Adding browser tests for the sign-in after local save flow. This includes user-action sign-in metrics, the sign-in promo, and the manage cards prompt.
> 
> Bug: 855186
> Change-Id: I8c1d15f79e6915230860d7f0f2529a10c01559b7
> Reviewed-on: https://chromium-review.googlesource.com/1196918
> Commit-Queue: Manas Verma <manasverma@google.com>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Jared Saul <jsaul@google.com>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592227}

Bug: 855186
Change-Id: Id7258331f021a1f69dd84f7f6e6fc77b01f0885d
Reviewed-on: https://chromium-review.googlesource.com/1241558Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#595157}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6ff2f64702dc..f0aa6f4e3a57


git log 6ff2f64702dc..f0aa6f4e3a57 --date=short --no-merges --format='%ad %ae %s'
2018-09-28 jaebaek@google.com Fixed Validator adjacency bug for OpPhi (#1922)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@f0aa6f4e3a57

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I78346971e87db385689ea12bb6666c6d5f9c5b9f
Reviewed-on: https://chromium-review.googlesource.com/1251983Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595156}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8241a7599974..82b404766db2


git log 8241a7599974..82b404766db2 --date=short --no-merges --format='%ad %ae %s'
2018-09-28 chowes@google.com Fix symlink to build_dlc script
2018-09-28 saklein@chromium.org cros_choose_profile: remove unused argument
2018-09-28 saklein@chromium.org build_stages.InitSDKStage: update chroot


Created with:
  gclient setdep -r src/third_party/chromite@82b404766db2

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I6e27b62cb504b4ab991850a84fb9d308a4eaa9c1
Reviewed-on: https://chromium-review.googlesource.com/1251986Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595155}

Additional ones to follow.

Bug: 867548
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2181ea6891f17692d74765ff7f806420b43e8983
Reviewed-on: https://chromium-review.googlesource.com/1226368
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595154}

https://boringssl.googlesource.com/boringssl/+log/fb86b888ef1c1265719208fd6c27a53ceb4920f7..13fd627449cefbae7576d4b145cb24fac303fc7d

BUG=890115

Change-Id: Id0a70faca0e68750a73551abf2ab79dc09a970e4
Reviewed-on: https://chromium-review.googlesource.com/1251333
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595153}

TBR=smut

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id72e1a333e00d9bc21dfdbdcce9bde2928b5aa1a
Reviewed-on: https://chromium-review.googlesource.com/1252082
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595152}

Change-Id: I83b5fb8ff7219d5846d85ebd3f8e1e9ba695b6c5
Reviewed-on: https://chromium-review.googlesource.com/1251381Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595151}

According to spec, network's tray icon size changed from 16dip to 20dip,
and we no longer have 2dip padding around network icons.

Also, because of that, new we can remove 1dip y-axis adjustment of
|top_left| badge e.g. "LTE" for cellular network.

For detail, see the screenshot in the bug.

TEST=manual
BUG=889589

Change-Id: Ib5eee3d05116e9deff936e6cb5287de9ac68a2de
Reviewed-on: https://chromium-review.googlesource.com/1250381Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595150}

Move the musicManagerPrivate API out of extensions code and into apps
code. This includes the API implementation, schema definition, features
entries, and API permission info.

TBR=gab@chromium.org (comment update in chrome_pref_service_factory.cc)
Bug: 877240

Change-Id: Id4bec073d3f9698682f40720852843fa03347900
Reviewed-on: https://chromium-review.googlesource.com/1220326
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595149}

- Adds the correct link for the network file shares help page. The content
on the target page is still being updated.

Bug: chromium:889830
Change-Id: I583ed05c144d5938c4c9acdadb4515e1828bc8f3
Reviewed-on: https://chromium-review.googlesource.com/1249824Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595148}

From https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL:
The URL.createObjectURL() static method creates a DOMString containing a
URL representing the object given in the parameter. The URL lifetime is
tied to the document in the window on which it was created. The new
object URL represents the specified File object or Blob object.

These URLs have blob: scheme.

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I6da3069663e735ce89977b15cfee7933a3c20ea1
Reviewed-on: https://chromium-review.googlesource.com/1250163Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595147}

This will guard https://skia-review.googlesource.com/c/skia/+/157522
for layout test changes.  They should be many but all tiny.

Change-Id: I6cd7785227ac04ea6a921e9fb4bc119b1e94ae4f
Reviewed-on: https://chromium-review.googlesource.com/1251540
Commit-Queue: Mike Klein <mtklein@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595146}

Bug: 887502
Change-Id: Ic6fd77dc9b067aabfbb22e50519e756fe1caa51f
Reviewed-on: https://chromium-review.googlesource.com/1252001Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595145}

This should return nullptr (and not DCHECK).
Follow up of https://chromium-review.googlesource.com/c/chromium/src/+/1249207

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id0635b701ea491e15a7240d2c639ae8ddd001086
Reviewed-on: https://chromium-review.googlesource.com/1251462
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595144}

This test failing is because:

1. In cc gen property tree, we create non-scrollable scroll node for scrollbar
   and set it as child of a no scrollable scroll node.
2. In LayerTreeHostImpl::IsInitialScrollHitTestReliable, we return false
   (fallback to main thread scroll) when it does not have a closest_scroll_node
   (scroll node and it's ancestor nodes do not scrollable).
3. In blink gen property tree, we do not create the scroll node for scrollbar so
   closest_scroll_node is the scroll node of scrollable which owns the
   scrollbar. Then the scrolling process in impl thread and scroll on the
   scrollable.

In this patch we return scroll fallback to main thread with scrollbar scrolling
reason if the scroll hit testing layer is scrollbar and from touch before
LayerTreeHostImpl::IsInitialScrollHitTestReliable.

Bug: 884846
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia1b2bb996879b4de75b5f84a7a94c73676bbcb23
Reviewed-on: https://chromium-review.googlesource.com/1243164Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595143}

It should not get the primary account as argument but instead,
directly retrieve it from the SigninManagerFactory. It's being done in
preparation for the migration to IdentityManager in
https://crrev.com/c/1245784.

Apart from that it was decided to rename the API to
GetSecondaryAccountsForSignedInProfile in order to better reflect
the fact that the profile must be signed in.

Change-Id: Ib897c8d9a2cc585fb442c4ae7aff62455b381339
Reviewed-on: https://chromium-review.googlesource.com/1248742Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#595142}

Brings in changes in wpt/tools/ in this range:
https://github.com/web-platform-tests/wpt/compare/ab64b78a8f...c757432db5

Change-Id: Id7dd54c33be9db5478d1278a5c96d735f7aebc2e
Reviewed-on: https://chromium-review.googlesource.com/1249141
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595141}

Bug: b/115843337
Test: Manual Test
Change-Id: Ifd96410a48e85345cb77c6ef1b967df03b0f06ad
Reviewed-on: https://chromium-review.googlesource.com/1237514Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595140}

Bug: chromedriver:1998
Change-Id: I6ae25aaff9bb6a5811fed81c858250f2fbc34472
Reviewed-on: https://chromium-review.googlesource.com/1244615Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595139}

With this, any changes to the filesystem a test makes will only last
for as long as the VM is alive. Since we launch+shutdown for every
test, this perfectly isolates consecutive tests from one another. No
more out-of-disk errors!

Bug: 887753
Change-Id: Ifdf4af22e288583135cfe99d363eb3e79045e08d
Reviewed-on: https://chromium-review.googlesource.com/1252005Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595138}

This enum was used in a metric which have been removed for some time
now.

Bug: 456119
Change-Id: I9483787580dd86c5eb494febac049bc1aca342b8
Reviewed-on: https://chromium-review.googlesource.com/1251583Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595137}

Bug: 884144
Change-Id: Idf9634bd70ce37fb8b0dfdc51e5c2a5aa3d3847d
Reviewed-on: https://chromium-review.googlesource.com/1251767Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595136}

CrostiniAppIconLoader should use the passed-in icon size
instead of from AppListConfig.

Bug: 880979
Change-Id: I20840e4eced66ea2320149c57ebda4a9c8226341
Reviewed-on: https://chromium-review.googlesource.com/1251961Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595135}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce4c48bb2fa0..928526013073


Created with:
  gclient setdep -r src-internal@928526013073

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I9b352590ed3f948be6c0ca284fcffda323b80d4d
Reviewed-on: https://chromium-review.googlesource.com/1250953Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595134}

Replace instance of SigninManagerBase with one of IdentityManager
and update calls accordingly.

Bug: 889882
Change-Id: I4e76d223a1b8a6bc328cb97e1624d2c4d7532fae
Reviewed-on: https://chromium-review.googlesource.com/1251532Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#595133}

This CL adds TextAppearance.UpdateMenuItem and replaces hardcoded
textColor and textSize values in update_menu_item.xml.

Bug: 727723
Change-Id: I1b085d973502143e9a4a44dcbd1013d20386f01c
Reviewed-on: https://chromium-review.googlesource.com/1251539Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595132}

Remove redundant check for "use_libfuzzer" introduced in 6376140d.
This check is redundant and causes build failures because it stops
/OPT:NOLLDTAILMERGE from being used.

Bug: 884545
Change-Id: Ifb665751ff568ff557c4a896aca2d3b3f7a97dd3
Reviewed-on: https://chromium-review.googlesource.com/1249734Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595131}