- 24 Dec, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e12496a4a055..5fbf78cd8c92 Created with: gclient setdep -r src-internal@5fbf78cd8c92 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I53a0a9b0a5537c5eafb168992401499feeb3d817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981217Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727338}
-
Wei Lee authored
Design doc: go/cros-camera:dd:perf-test-metrics-cca The CL on Tast should depends on this CL: https://crrev.com/c/1880561 Bug: b/141518806 Test: tast run [DUT] camera.CCAUIPreview Change-Id: I943d683106c80046abf507b63179e5885b4a19bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880995 Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#727337}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3ace0d74bcbe..9a6abaf515ac git log 3ace0d74bcbe..9a6abaf515ac --date=short --first-parent --format='%ad %ae %s' 2019-12-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@9a6abaf515ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I357a3a71add2666eb85ed32a8285d078caf7e662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981216Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727336}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I38ecae21140dfecfdc0df66ce515a53db255ed52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980492Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727335}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9dbae35fa02d..e12496a4a055 Created with: gclient setdep -r src-internal@e12496a4a055 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie15650bcb1de6228f427bcf61104d15a615ddad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981215Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727334}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: If2e7ed81a3107f70d61e187538a0443d712b7e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981253 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#727333}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e2fc92ca28ef..c41f2e56623a git log e2fc92ca28ef..c41f2e56623a --date=short --first-parent --format='%ad %ae %s' 2019-12-23 khushalsagar@chromium.org Disable UniformBufferTests on Windows 7 / D3D11 / NVIDIA. Created with: gclient setdep -r src/third_party/angle@c41f2e56623a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1037644 Tbr: cnorthrop@google.com Change-Id: Ia5e77f7882bace35432d0cf745969f262304aac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727332}
-
Saman Sami authored
We seem to continuously have issues with clients not setting up the root render pass correctly. Add a DumpWithoutCrashing should help us investigate such issues when they arise. Bug: 1034876 Change-Id: I9818b83b0ca785483365856c7044edf871a09321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980791Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727331}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f515dbaeefec..232b8b8bcbc2 git log f515dbaeefec..232b8b8bcbc2 --date=short --first-parent --format='%ad %ae %s' 2019-12-24 fancl@chromium.org Reverting the queue concurrency limit Created with: gclient setdep -r src/third_party/catapult@232b8b8bcbc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1035930 Tbr: oysteine@google.com Change-Id: Ib11519e5ea485c29f842a0e1d98a4979394b8d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981213Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727330}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be3b4fd9e742..9dbae35fa02d Created with: gclient setdep -r src-internal@9dbae35fa02d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie758fffb44ac494dab6c183d84fdb04ef7440722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981211Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727329}
-
Yuzu Saijo authored
This test fixes a ServiceWorker and bfcache integration test so that the script waits for clients.claim() instead of ready. This is a follow-up change for https://crrev.com/c/1959238 Bug: 1036751 Change-Id: I378764ae24dc9a64f8a86e96395b7f3c47c0527a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980255 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#727328}
-
Navid Zolghadr authored
Change-Id: If8d9e962ba907a670e3ee82bf64a30d48bdf5348 Bug: 1030176, 939691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980524Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#727327}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dda54b59351e..f515dbaeefec git log dda54b59351e..f515dbaeefec --date=short --first-parent --format='%ad %ae %s' 2019-12-24 fdegans@chromium.org Disable CacheTemperatureTests.testEnsureHotAfterColdAndWarmRun on all platforms. Created with: gclient setdep -r src/third_party/catapult@f515dbaeefec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:960552 Tbr: oysteine@google.com Change-Id: I4c3060f3af0b268d359d81c3aa747138302e6fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727326}
-
Mike Dougherty authored
This allows breadcrumb events to be associated with a particular Browser instance so that they can be differentiated. Events are logged based on WebStateListObserver callbacks on the Browser's underlying WebStateList. Bug: 1003922 Change-Id: I348b103f8971a88350cf4091ef7e97604a89f882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974612 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#727325}
-
Demetrios Papadopoulos authored
The rule disallows == in favor of ===, and != in favor of !==, which matches the Google JS styleguide (which Chromium's JS styleguide inherits from). Bug: 720034 Change-Id: I9af03dd3a7fbd7d7b906a5b0e73786973657634e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980213Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#727324}
-
Demetrios Papadopoulos authored
|allowexternalscript| is not needed when no inline scripts exist to begin with. These occurrences must have been copy/pasted from other cases where |flattenhtml| is used instead. Bug: 986596 Change-Id: I21d81a0278cd3cd63a4015b8ced6aea87b8bb6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980212 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#727323}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a2d7225c0fc1..3d3150c89c5f git log a2d7225c0fc1..3d3150c89c5f --date=short --first-parent --format='%ad %ae %s' 2019-12-24 herb@google.com Internalize color offset calculation to SubRun Created with: gclient setdep -r src/third_party/skia@3d3150c89c5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I3e582170deb0c070ff413d8422de9b9224399665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727322}
-
Gary Kacmarcik authored
Extend expiration for this metric beyond M81 until the end of 2020. Change-Id: Ied7d4947c14cad3a108e2293f72627cd26b90a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981191 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#727321}
-
Gyuyoung Kim authored
This CL replaces .mojom.h includes with .mojom-forward.h in some sub-directories of third_party/blink/public/common to reduce the pre-processed size of header files and shorter build time. The sub-directories are following, - third_party/blink/public/common/feature_policy - third_party/blink/public/common/loader - third_party/blink/public/common/manifest This CL has no behavior changes. Bug: 1001360 Change-Id: Iad4d88a05d0a8166dba76027006adb08514c88f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980334Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#727320}
-
Zhenyao Mo authored
BUG=1037113 TEST=bots R=magchen@chromium.org Change-Id: I17a8850477bf43010ad7c6febb059d6b4a34071e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981189Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#727319}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/070d459567f5..be3b4fd9e742 Created with: gclient setdep -r src-internal@be3b4fd9e742 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1037612 Tbr: jbudorick@google.com Change-Id: I821160919c391172fb9495ebdb891d8bc25a0091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981039Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727318}
-
Gustavo Sacomoto authored
This CL also fixes a memory leaked previously fixed here: https://chromium-review.googlesource.com/c/chromium/src/+/1961211 but reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1978419 Bug: 1036841 Change-Id: I583ae8f0fd999b3fbe77b922a7a5ca12d5cc6cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980869 Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727317}
-
Gyuyoung Kim authored
This CL cleans up unnecessary mojo/public/cpp/bindings/binding.h includes in //media. Bug: 955171 Change-Id: I79b71fcf3453e49ef0d4909c7a71d3521f33ae62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977894Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#727316}
-
Will Cassella authored
The WebXrGamepadModule has been stable for quite some time, so the feature flag has been removed. Change-Id: Icf57f11a357c299480e7e08c50260b2949aeafa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980891Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#727315}
-
Dongheun Kang authored
Bug: none Change-Id: I117fcb0d9936ea73ad92fb9d5e9d4f180b42817e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974714Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#727314}
-
Zhenyao Mo authored
BUG=719213 TEST=manual R=magchen@chromium.org Change-Id: I259ec8e0db3d586b9cbd9bd025c874a8930d31bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980558Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#727313}
-
Eugene But authored
TBR=jlebel@chromium.org Bug: 1037676,1036840 Change-Id: I552d7cec1cab40b5ef9dae9271bb956a625fd71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981141Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#727312}
-
Eugene But authored
TBR=ajuma@chromium.org Bug: 1037663 Change-Id: I1fa106686e7cfedbbd43be0dc8b67917f74555b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981137 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#727311}
-
Peter K. Lee authored
Reduce dependencies on Translate internals - Refactored some constants out into their own targets - Stopped using LanguageDetectionDetails where simple alternatives exist - Use url.SchemeIs() - Use executeJavaScript:error: from ChromeEarlGreyAppInterface - TranslateAppInterface setUp needs to be passed switch for HttpServer Bug: 987646 Change-Id: I4c47b9abca4a64d09a267b526dadc87cb10fe76b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979768 Commit-Queue: Peter Lee <pkl@chromium.org> Auto-Submit: Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#727310}
-
Ian Struiksma authored
Test sign_in_pass/yahoo is failing on the bot. The log trace says: [25304:1:1220/102408.382835:FATAL:vector.h(1673)] Check failed: Allocator::IsAllocationAllowed(). Cannot reproduce locally, but crbug.com/1036593 looks like it is related. Disabling this test case with reference to the bug. Bug: 984664,1036593 Change-Id: I16a0f95af24b639f6fca0c5a0fc760980889c4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981121Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#727309}
-
Eugene But authored
TBR=olivierrobin@chromium.org Bug: 1036840,1037681 Change-Id: Ie0800e1856562015fe143e42bf8bc13140d981b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981144Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#727308}
-
Kurt Horimoto authored
The previous implementation of these tests relied on asynchronous view controller presentation as well as implementation details of InfobarCoordinator and InfobarContainerIOS. This CL updates these tests to instead directly call the public API of the tab helper. It also uses FakeInfobarIOS so that full InfobarCoordinator objects no longer need to be constructed for the tests to operate. Bug: none Change-Id: I09bc28758761d2c2c5068300b965cf565557e39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974579 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727307}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I7aa4c8198669e5597517be0ebe63ca2a8c43310c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980750Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#727306}
-
Oystein Eftevaag authored
NOTRY=true TBR=crouleau@chromium.org BUG=1037687 CC=rmcilroy@chromium.org Change-Id: Ic8f9c6ec9cd23636b024fba277ae25bb8d7cc193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980615Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#727305}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I342f8d52f6adc86ae6eb53ead89a56a50085e05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981034Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727304}
-
Gyuyoung Kim authored
This CL replaces .mojom.h with .mojom-forward.h in some sub-directories of chrome/browser/chromeos to reduce the pre-processed size of header files and shorter build time. The sub-directories are following, - chrome/browser/chromeos/chrostini - chrome/browser/chromeos/extensions - chrome/browser/chromeos/file_manager This CL has no behavior changes. Bug: 1001360 Change-Id: I328a62f1b269139a0138d8e7fbaf677e9590bddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974307Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#727303}
-
Jason Lin authored
Bug: 999950 Change-Id: I03ce5446f7eb0468a9c24b084b37b039a6fe2fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952045Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#727302}
-
Oystein Eftevaag authored
This pageset has been failing since it got added. NOTRY=true TBR=crouleau@chromium.org BUG=1037687 CC=rmcilroy@chromium.org Change-Id: I6e34c9f1f61276ab0715bc022d04afd37d777b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980215Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#727301}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/07f0f019e397..e2fc92ca28ef git log 07f0f019e397..e2fc92ca28ef --date=short --first-parent --format='%ad %ae %s' 2019-12-23 syoussefi@chromium.org Vulkan: Fix swiftshader device selection Created with: gclient setdep -r src/third_party/angle@e2fc92ca28ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I1fe26e778b49e35fcc9ea4d5f80a24e7b6e9f2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980935Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727300}
-
Demetrios Papadopoulos authored
The rule disallows == in favor of ===, and != in favor of !==, which matches the Google JS styleguide (which Chromium's JS styleguide inherits from). Bug: 720034 Change-Id: Id257bce33e681ad227ff5bd4212b1f8d3c28b867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980214Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#727299}
-