- 17 Jul, 2010 40 commits
-
-
thestig@chromium.org authored
BUG=21461 TEST=GTK dialog matches Windows dialog. Review URL: http://codereview.chromium.org/2813060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52815 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Review URL: http://codereview.chromium.org/3028009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52814 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=49404 TEST=none TBR=ahendrickson Review URL: http://codereview.chromium.org/3037007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52813 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
TBR=sargrass BUG=none TEST=chromeos builder goes green TBR=csilv@chromium.org Review URL: http://codereview.chromium.org/3032006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52812 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Avoid flashing when resizing plugins that use PaintManager. Copy the bitmap from the old backing store to the new one so that we have something to display until the plugin repaints. Credit to Darin for tracking this down and the suggested fix. Review URL: http://codereview.chromium.org/2834052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52811 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=48883 TEST=Exercise Personal Stuff page via --enabled-tabbed-options Review URL: http://codereview.chromium.org/2819046 TBR=sargrass@google.com Review URL: http://codereview.chromium.org/3012007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52810 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52809 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=6574 TEST=None Review URL: http://codereview.chromium.org/2850031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52808 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
Certain decorations like the keyword-search bubble let mouse events fall through to the field, as indicated by an i-beam cursor. This change causes decorations next to the text area to be aggregated into the text-area's cursor rect. BUG=41612 TEST=Keyword-search bubble shows I-beam cursor. TEST=Location icon and star and page actions show arrow. Review URL: http://codereview.chromium.org/2825048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52807 0039d316-1c4b-4281-b951-d872f2087c98
-
stoyan@chromium.org authored
Review URL: http://codereview.chromium.org/2824057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52806 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
--host-resolver-parallelism=XXX This is a useful debugging tool, since for some users too many parallel DNS requests results in spurious DNS failures from their resolver. BUG=44489 Review URL: http://codereview.chromium.org/3019007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52802 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
Revert 52799 - Add support for parsing certificate formats other than raw, DER-encoded certificates - specifically formats that represent collections of certificates. The certificate format can now be specified as an explicit format, or as a bit-mask of formats that are acceptable/expected, with the first parsable format winning. This is one half of a commit to address BUG #37142, with the second half involving connecting this through the X509UserCertHandler and the actual UI. R=wtc BUG=37142 TEST=X509CertificateParseTest* and PEMTokenizerTest.* Review URL: http://codereview.chromium.org/2819018 TBR=rsleevi@chromium.org Review URL: http://codereview.chromium.org/2812064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52801 0039d316-1c4b-4281-b951-d872f2087c98
-
rogerta@google.com authored
function to send pings to google for two reasons: - I thought that chrome's own rlz pings would send all rlz information for all other products installed on the machine - I did not want to allow an extension to DoS google by sending too many rlz pings It turns out that the rlz library itself makes sure that a given product's pings are never sent out more than once per day, as is required for rlz, so there is no DoS danger by exposing a ping function. Also, I was wrong in thinking that chrome's rlz pings would send out all rlz information about other products installed on the machine: it sends out the other products rlz strings, but it does not send out the other products rlz event information. This makes sense since there are signatures and brand codes and other information that cannot be determined by chrome for the extensions. So adding a new rlz chrome extension function to expose sending pings. BUG=None TEST=See particular extension using this api Review URL: http://codereview.chromium.org/3029001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52800 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
Add support for parsing certificate formats other than raw, DER-encoded certificates - specifically formats that represent collections of certificates. The certificate format can now be specified as an explicit format, or as a bit-mask of formats that are acceptable/expected, with the first parsable format winning. This is one half of a commit to address BUG #37142, with the second half involving connecting this through the X509UserCertHandler and the actual UI. R=wtc BUG=37142 TEST=X509CertificateParseTest* and PEMTokenizerTest.* Review URL: http://codereview.chromium.org/2819018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52799 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
Cleanup removes all of the AutocompleteTextFieldIcon-based stuff from the cell implementation. BUG=none TEST=content settings still appear at the right times and places. TEST=content settings can be clicked on and the popup is positioned right. Review URL: http://codereview.chromium.org/2888014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52798 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=26443 TEST=trybots Signed-off-by:
Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3020010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52797 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=none TEST=none TBR=tony Review URL: http://codereview.chromium.org/3018007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52796 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
TBR=sargrass BUG=none TEST=chromeos builder goes green git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52795 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/2943006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52794 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
TBR=senorblanco,ojan Review URL: http://codereview.chromium.org/3046003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52793 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
No code change. BUG=26730 TEST=none Review URL: http://codereview.chromium.org/3005006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52792 0039d316-1c4b-4281-b951-d872f2087c98
-
gavinp@google.com authored
This CL helps chrome respect the SETTINGS header MAX_CONCURRENT_STREAMS. Note that this means that SpdySession::CreateStream can now return ERR_IO_PENDING, so it requires a callback. There's a noted TODO that if an http_network_transaction dissapears betweeen STATE_SPDY_GET_STREAM and STATE_SPDY_SEND_REQUEST I don't know if we end up with an orphan stream in our spdy_session. As well, spdy_test_util.cc had a lot of functions with default arguments; I didn't fix them all, but the functions I modified no longer take default arguments and meet the coding standard. I'd like to circle back at some point and possibly make the tests call SpdyFramer directly: these test utils seem sometimes more trouble than they're worth if the framer was a bit more convenient for direct use. BUG=34750 TEST=net_unittests Spdy.ThreeGets* Review URL: http://codereview.chromium.org/2919011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52791 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
disk cache fails (now on an async world). BUG=49216 TEST=net_unittests Review URL: http://codereview.chromium.org/2812062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52790 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
Rename Principal->CertPrincipal, Policy->CertPolicy, both of which are merely syntatic fluff. Rename Fingerprint->SHA1Fingerprint, which is more important since those using the fingerprint, such as the unit tests, were truly hardcoded against SHA-1 fingerprints, and if the fingerprint ever changed, wouldn't cause errors until run time. R=wtc BUG=None TEST=Compilers stay green Review URL: http://codereview.chromium.org/2815048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52789 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@google.com authored
BUG=49389 Review URL: http://codereview.chromium.org/2854050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52788 0039d316-1c4b-4281-b951-d872f2087c98
-
sargrass@google.com authored
BUG=48883 TEST=Exercise Personal Stuff page via --enabled-tabbed-options Review URL: http://codereview.chromium.org/2819046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52787 0039d316-1c4b-4281-b951-d872f2087c98
-
georgey@chromium.org authored
Added inferred labels implementation. Label inferred from the person name + differences in other fields to distinguish entries. Also added it to generated previews. TODO: adjust indices in the Credit Cards. TEST=unit tested. BUG=none Review URL: http://codereview.chromium.org/2835026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52786 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
BUG=48725,39508 Review URL: http://codereview.chromium.org/2840038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52784 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
Review URL: http://codereview.chromium.org/2824058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52783 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=none TEST=right click on new tab button should do nothing rather than crash in debug. Review URL: http://codereview.chromium.org/3005014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52782 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
ClientSocketHandle::GetLoadState is only valid when the handle doesn't have a socket. And we repeat the DoTunnelConnectComplete state when when need to restart the http proxy with authentication - after the transport_socket_handle_ has been assigned the http proxy socket. BUG=41408 TEST=amended SSLClientSocketPoolTest.DoProxyAuth Review URL: http://codereview.chromium.org/2856043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52781 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
In ChromeFrame if window.open is received for a pending external tab, i.e. which has not received a connect from the host browser, currently we end up crashing chrome due to dereferencing a NULL automation channel. Ideally we should queue all IPC messages destined for a pending tab and send them out once we receive a connect. However that solution is tricky as the messages carry the tab handle as one of the arguments which is only available when we receive a connnect for the tab. The AutomationHandleTracker gives out these handles and is per automation provider. We may have different automation provider instances in the case of IE8 and hence we cannot pre compute the tab handle. Current solution is to add a NULL check around the offending code path which would basically drop the new contents notification. Fixes bug http://code.google.com/p/chromium/issues/detail?id=49188 Bug=49188 Review URL: http://codereview.chromium.org/3021002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52780 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
BUG=47895 TEST=none Review URL: http://codereview.chromium.org/2996006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52779 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
It is currently off by default and one must pass in a flag (--enable-search-provider-api-v2) to use it. Api details are in the bug. BUG=38475 TEST=ui_tests --gtest_filter=SearchProviderTest.TestIsSearchProviderInstalled Review URL: http://codereview.chromium.org/2823042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52778 0039d316-1c4b-4281-b951-d872f2087c98
-
arv@chromium.org authored
BUG=43312 TEST=Open bookmarks manager. There bookmark list items should not longer be underlined on hover and clicking them should only select them. Review URL: http://codereview.chromium.org/2813059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52777 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
the backend creation when the cache goes away. BUG=49193 TEST=net_unittests Review URL: http://codereview.chromium.org/3016006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52776 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
Added two new crashes to the reliability tests known crashes. These occur consistently in ChromeFrame reliability test runs. Bugs=49271,49384 TBR=amit Review URL: http://codereview.chromium.org/3026005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52775 0039d316-1c4b-4281-b951-d872f2087c98
-
dmaclach@chromium.org authored
TEST_F(CollectedCookiesTest, FAILS_TestDoubleDisplay) and TEST_F(CollectedCookiesTest, FAILS_NavigateAway) because they were causing issues in the build waterfall. http://code.google.com/p/chromium/issues/detail?id=49386 TEST=none BUG=none Review URL: http://codereview.chromium.org/3008007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52774 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
Test is TemplateURLPrepopulateDataTest_ProvidersFromPrefs TBR=oshima BUG=49086 TEST=none Review URL: http://codereview.chromium.org/2843056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52773 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=none TEST=compile works again (not sure why it was only failing for me and a few others) Review URL: http://codereview.chromium.org/3018006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52772 0039d316-1c4b-4281-b951-d872f2087c98
-