- 09 Jul, 2018 40 commits
-
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ee7c8c3f3769..245c7310a74e git log ee7c8c3f3769..245c7310a74e --date=short --no-merges --format='%ad %ae %s' 2018-07-09 thestig@chromium.org Roll third_party/freetype/src/ 125b84800..b532d7ce7 (64 commits) Created with: gclient setdep -r src/third_party/pdfium@245c7310a74e The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I78acf3fd21e79b2380262aff4a87d4755e35d54d Reviewed-on: https://chromium-review.googlesource.com/1129559Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573439}
-
Kenneth Russell authored
Allow jobs to run on both 10.12.6 and 10.13.5. Bug: 856799 Tbr: ynovikov@chromium.org Change-Id: Iaec9bd5229af369aec58ae44b9bef036210ba163 Reviewed-on: https://chromium-review.googlesource.com/1129539 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573438}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a7788c48..27f6e148 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7385db185a6ab7449daa7c64711dad6695fe4ee2 Reviewed-on: https://chromium-review.googlesource.com/1129383Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573437}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8fbd9d96e68b..d7890bca9b35 git log 8fbd9d96e68b..d7890bca9b35 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 tobine@google.com Skip noop draws in the frontend 2018-07-09 lucferron@chromium.org Vulkan: Flip on Y, fix for MaxTextureSizeTests 2018-07-09 lucferron@chromium.org Vulkan: Fix how the viewport is calculated with Y flip 2018-07-09 jmadill@chromium.org Allow constexpr initialization of PackedEnumMap. Created with: gclient setdep -r src/third_party/angle@d7890bca9b35 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie71e721c2cfdaa544a441e4d82fb42e7ce46851d Reviewed-on: https://chromium-review.googlesource.com/1129639Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573436}
-
Jeremy Roman authored
It has no callers and is therefore dead code. Change-Id: Id7888a8898607ac844460bf429cc81f682b56a5f Reviewed-on: https://chromium-review.googlesource.com/1126520Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573435}
-
Lei Zhang authored
Use base::debug::Alias() to prevent ICF from combining Chromium's port of sk_abort_no_print() with similar functions. BUG=860850 Change-Id: I3c45d7aa567c2bdd2098a355cbf2e56a8e82bb34 Reviewed-on: https://chromium-review.googlesource.com/1128459Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#573434}
-
Min Qin authored
When Creating a download item from history db, the item might have already imported from the in-progress db. So this DCHECK is no longer correct BUG=842245 Change-Id: Iff0c7f77f33bd910ba42602a526c914d0e12bcd7 Reviewed-on: https://chromium-review.googlesource.com/1129366Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573433}
-
Dmitry Gozman authored
There was a single BackgroundTaskRunner::PostOnBackgroundThread function in platform/threading, which makes sense to be in scheduler. Change-Id: Ibe0a53d6875c43cda0915bf8de5c15085fda12c5 Reviewed-on: https://chromium-review.googlesource.com/1128543 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573432}
-
Martin Kreichgauer authored
This adds the DeleteWebAuthnCredentials method which deletes WebAuthn credentials that have been created under a given browser profile and in a given time interval. Bug: 678128 Change-Id: I7f7b54b099c8d5cd622c70d16a510cf16f8948e6 Reviewed-on: https://chromium-review.googlesource.com/1123627 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#573431}
-
Theresa authored
* Updates EnabledStateMonitor to use a new unified consent helper method that determines whether URL-keyed anonymized data collection is enabled * Updates the EoC settings screen to open the new sync and personalization screen when unified consent is enabled. * Updates EoC settings screen text when toolbar button is enabled. BUG=829457,859564 Change-Id: I727043abeaed33d68b179e9bef8d40b1f074a0a5 Reviewed-on: https://chromium-review.googlesource.com/1124970 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#573430}
-
Alex Newcomer authored
This reverts commit 1c822163. Reason for revert: Linker failures: obj/ash/app_menu/app_menu/notification_menu_view.o:notification_menu_view.cc:function ash::NotificationMenuView::NotificationMenuView(ash::NotificationItemView::Delegate*, message_center::SlideOutController::Delegate*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&): error: undefined reference to 'vtable for views::MenuSeparator' ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function Bug: 861885 Original change's description: > cros: Add a double separator above context menu notifications > > Add and remove a double separator with NOTIFICATION_CONTAINER. > > Bug: 843761 > Change-Id: I45fb095079aaaf108a9a18958ab4e431072e588d > Reviewed-on: https://chromium-review.googlesource.com/1121243 > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573418} TBR=jamescook@chromium.org,msw@chromium.org,newcomer@chromium.org Change-Id: I10ce18a75e80116fa8d7a530d18e979a2dfbb395 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843761 Reviewed-on: https://chromium-review.googlesource.com/1129661Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#573429}
-
Khushal authored
This reverts commit 2200b6d9. The change inadvertantly disabled an optimization for low-end Android devices that releases all GPU memory when the application has been backgrounded. The optimization works by releasing all non-WebGL GpuChannels. Since this change moved the GrContext ownership to a shared object cached in the GpuChannelManager instead of per GpuChannel, it is necessary to explicitly destroy it in the channel manager during cleanup. R=ericrk@chromium.org, piman@chromium.org Bug: 860506, 854416 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3f6754ce939c3f815b13a3f96cd4414f5c8a3449 Reviewed-on: https://chromium-review.googlesource.com/1129548Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#573428}
-
Devlin Cronin authored
The PermissionsUpdater is responsible for updating permissions for both granted optional permissions and runtime-granted permissions (and for revoking permissions from each set). However, there are some subtle distinctions between these sets - optional permissions affect both granted and runtime-granted permission sets in preferences, whereas runtime-granted permissions only affect runtime-granted permissions. This is intentional in order to help isolate the experimental behavior for runtime host permissions. In order to properly isolate (and better document) these sets, introduce separate methods for granting/revoking optional permissions and granting/revoking runtime permissions. Update callers and tests to use the new methods, and add more test coverage to ensure that adding optional permissions affects both runtime-granted and granted permissions, whereas granting/revoking withheld permissions only affects runtime-granted permissions. Bug: 848448 TBR=atwilson@chromium.org (simple method rename in c/b/background) Change-Id: I05ac756ca87eb60cbb1a461f6d5384bcec7da15a Reviewed-on: https://chromium-review.googlesource.com/1124876Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573427}
-
Jamie Madill authored
These tests are quite flaky. Unsure of the root cause. Disable them until we can triage the failures. This should help clear up flakiness on the ANGLE CQ. Bug: 861814 Change-Id: I69c405731ee0cfe9bcb176a6ff82e0ce4ab4c1ae Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1129388Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bea867a76a73..f6618d3f745e git log bea867a76a73..f6618d3f745e --date=short --no-merges --format='%ad %ae %s' 2018-07-09 simonhatch@chromium.org Dashboard - Add Ben as an owner 2018-07-09 chiniforooshan@chromium.org Telemetry: frame times in TBMv2 2018-07-09 cphlipot0@gmail.com Android systrace: Fix printf/scanf format compiler warnings Created with: gclient setdep -r src/third_party/catapult@f6618d3f745e The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:760553 TBR=sullivan@chromium.org Change-Id: If76b6d155d063591fee6621b5d9fd8d42a13d163 Reviewed-on: https://chromium-review.googlesource.com/1129381Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573425}
-
Jeremy Roman authored
Part of reducing the differences between the AudioNode connect/disconnect variants. Bug: 856641 Change-Id: I51cab0acd1b6ae8463dedd3b02b30e3b80dabbc7 Reviewed-on: https://chromium-review.googlesource.com/1126411Reviewed-by:
-
Kevin McNee authored
The current logic for reusing the zoom bubble for extensions 1) prevents an extension initiated zoom change from reusing the zoom bubble even when the bubble is showing for a previous zoom change by the same extension, and 2) attributes a user initiated zoom to an extension if the extension recently initiated a zoom change. The logic for reuse is now essentially, allow reuse if the attribution hasn't changed. Bug: 849704 Change-Id: Ia4935fa84e30ab263772500f7ca566c0f5fc29be Reviewed-on: https://chromium-review.googlesource.com/1124945 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#573423}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values: 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Additionally there are done some other trivial cleanups. Change-Id: If313108d6055ac2bf1eb0933abacaad3996c9724 Reviewed-on: https://chromium-review.googlesource.com/1127367Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#573422}
-
Koji Ishii authored
Following bot results are included. 7655 7656 7659 7664 7671 7680 7683 7687 7697 12 lines were removed and 10 lines were deflaked by consecutive results since 7649. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I59805929c4f94d914f833f3386131a4c27464092 Reviewed-on: https://chromium-review.googlesource.com/1127905 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#573421}
-
Andrew Grieve authored
Change-Id: I461eccdec572979b00e076422a3589f6dbcff760 Reviewed-on: https://chromium-review.googlesource.com/1129840Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#573420}
-
Peter Mayo authored
This new test fails when using enable-blink-gen-property trees. This is the intersection of two newly launching features and may block the second one, whichever that happens to be. Bug=861824 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib632eaa5377a7a5040597e8837dfa99e06883da0 Reviewed-on: https://chromium-review.googlesource.com/1129396Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#573419}
-
Alex Newcomer authored
Add and remove a double separator with NOTIFICATION_CONTAINER. Bug: 843761 Change-Id: I45fb095079aaaf108a9a18958ab4e431072e588d Reviewed-on: https://chromium-review.googlesource.com/1121243 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#573418}
-
Wez authored
Similar to the OS_POSIX && !OS_FUCHSIA sites that need cleaning up, we have a few sites which still use OS_POSIX || OS_FUCHSIA incorrectly, in this case the ProcessUtilTests concerned with kill() / signals. Bug: 854721 Change-Id: Id7896b1ca3ff3da3db6e6444eabc49bf9218de4b Reviewed-on: https://chromium-review.googlesource.com/1129632 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Lan Wei authored
Because Mac sometimes does not send the tablet events when a stylus is approaching the tablet, it just sends mouse events. We have to always check the mouse events' subtype to decide if it is a stylus input or a mouse input. Bug: 854354 Change-Id: Ibda91bf7c0970778b486ee4e0d7cb14650e18952 Reviewed-on: https://chromium-review.googlesource.com/1124984Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#573416}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7b9a39fe. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21128 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy mkwst@chromium.org: external/wpt/mixed-content rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-basic-card external/wpt/payment-request TBR=kereliuk No-Export: true Change-Id: Ibcc9ba57d01f2ef4bc11e36f6d92eff08c22855f Reviewed-on: https://chromium-review.googlesource.com/1129371 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#573415}
-
Morten Stenshorne authored
This fixes some tests that depended on the correct value here when reading out the margins via getComputedStyle(). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I1f836ea8dc1243f1f2a1b36e69ba8d397417e3a2 Reviewed-on: https://chromium-review.googlesource.com/1127893 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#573414}
-
Xiaoqian Dai authored
Previously the threshold we were using to create/destroy scrim is the same with the threshold to show indicators and scale down the source window, this might cause a problem when dragging the dragged window back toward to the top of the screen: the dragged window might be merged back to the source window during the animation of the source window bounds change, which then cause a flashness during dragging. See before https://drive.google.com/open?id=1KETJtvc8GgQfZ7KhskqSaamoe5v8fz_m and after https://drive.google.com/open?id=1_BeuzPtLPg8qNb1apJlaW2yDvZop5phZ Bug: 823769 Change-Id: I349a1902543f0d334ebf8e8631dc1bdf31d5e396 Reviewed-on: https://chromium-review.googlesource.com/1119371 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima OOO (7/3 - 7/9) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#573413}
-
kristipark authored
The favicon img already returns an icon background, so we only need to render the background if the img fails to load. This will be the gray fallback monogram instead of the default missing favicon image. Screenshot: https://screenshot.googleplex.com/a7PLVx5dahf.png Bug: 859376 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8dd376d435059803f7f8cd1bc64a4b3242f50027 Reviewed-on: https://chromium-review.googlesource.com/1123171 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#573412}
-
Theresa authored
BUG=861810 Change-Id: I26ddbc6dde99e3c26407e4fedfe379833c2ecd73 Reviewed-on: https://chromium-review.googlesource.com/1129389Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/68eaa07bdfa0..916c76140064 git log 68eaa07bdfa0..916c76140064 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 hjd@google.com perfetto-ui: Add state holder 2018-07-09 hjd@google.com perfetto-ui: Fix copyright headers 2018-07-09 hjd@google.com perfetto-ui: Allow PascalCase component names Created with: gclient setdep -r src/third_party/perfetto@916c76140064 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:111101304 TBR=perfetto-bugs@google.com Change-Id: I35f1be9b54fd487b4962c11ca418b4ea11de679d Reviewed-on: https://chromium-review.googlesource.com/1129379 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573410}
-
Kyle Qian authored
This CL includes the implementation class for the abstract class HashUtils defined in the Nearby library. It implements a string-based interface for MD5 and SHA-256 hashing. Because the actual Nearby library has yet to be merged into the CrOS directory, this CL includes stand-in Nearby abstract classes under the temporary directory //chromeos/components/nearby/library. This directory will be removed after the Nearby library gets imported to //third_party (in-progress CL: https://chromium-review.googlesource.com/c/chromium/src/+/1113198). Bug: 861813 Change-Id: I41dc7d74d5913ae8168041c82d3cacf70628ce19 Reviewed-on: https://chromium-review.googlesource.com/1119492 Commit-Queue: Kyle Qian <kyleqian@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#573409}
-
James Cook authored
OopAsh mode (enabled with --enable-features=OopAsh) on CrOS was crashing at start because the Ozone/Drm DRM and cursor services were not accessible to the Ash/WS2 host. In this change, the WS2 service is extended to add and bind these interfaces. Tested by hand by running on device (chell): sudo -u chronos ./chrome --enable-features=OopAsh \ --user-data-dir=/home/chronos --homedir=/ --login-manager BUG=850168 TBR=tsepez@chromium.org Change-Id: I9b6a195f1f5fcce64174eb8e851561c70861dc81 Reviewed-on: https://chromium-review.googlesource.com/1121830 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
Updated the privacy document (approved by msramek: https://docs.google.com/document/d/1BNQ5nLOtPuwP7oxr9r-XKNKr5iObXEiA_69WXAvuYAo/edit?usp=sharing) Bug: 775644 Change-Id: If9e16711af2d27a7209366a61883997e865c9b50 Reviewed-on: https://chromium-review.googlesource.com/1126332Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#573407}
-
James Wallace-Lee authored
This is a reland of db409e20 Original change's description: > Truncate string attributes in the accessibility tree > > Adds the helper function > BlinkAXTreeSource::TruncateAndAddStringAttribute, which truncates string > attributes when Blink's tree is serialized for accessibility. String > attributes are truncated at BlinkAXTreeSource::kMaxStringAttributeLength > bytes, currently set to 10000 bytes. > > Bug: 644805 > Change-Id: Ibd1af03a77814aa524dcb067ad1be3f3f4291c8b > Reviewed-on: https://chromium-review.googlesource.com/1113946 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570818} Bug: 644805 Change-Id: If084733234602882bbd37fc1891e49011b12ada8 Reviewed-on: https://chromium-review.googlesource.com/1129399Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#573406}
-
Michael Thiessen authored
These flags are old and no longer needed, so should be removed. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iad382b68937e084358f6d2bc9417a25aa1ecbfc5 TBR=jam@chromium.org Change-Id: Iad382b68937e084358f6d2bc9417a25aa1ecbfc5 Reviewed-on: https://chromium-review.googlesource.com/1128247Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#573405}
-
Dominic Mazzoni authored
Previously firing a notification only worked when an AccessibleNode had an element. Add a quick fix to ensure it works even when it doesn't. Bug: 761901 Change-Id: I0ec6723e748947d94f1207f72f38ec94f0f6b335 Reviewed-on: https://chromium-review.googlesource.com/962862 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#573404}
-
Victor Vasiliev authored
crypto::HKDF was originally written for QUIC and has QUIC-specific assumptions in it, and hence it's moved into the QUIC codebase. The new API is just a thin wrapper around BoringSSL's HKDF implementation. I intend to do the same to crypto::HKDF itself, but for now it's parked in QUIC platform impl directory. Change-Id: Ie60072dab4570bc840d9e6aaa5b1fef72fb387a2 Reviewed-on: https://chromium-review.googlesource.com/1122698 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#573403}
-
Troy Hildebrandt authored
When selecting the Leave option in the Leave Incognito Mode dialog that launches an intent to the Play Store, Chrome crashes if the store is disabled/uninstalled. This fix checks whether the intent can be handled before showing the dialog, and just avoids showing the dialog if not. It also removes the need to check for ActivityNotFoundExceptions, and instead performs this check first. Tests are added to test behaviour with the Play Store installed and uninstalled. Bug: 820709 Change-Id: Ic6fec319887f77368262e825a95c419c1644b81b Reviewed-on: https://chromium-review.googlesource.com/1113900Reviewed-by:
-
David Black authored
Reminders is classified a web deep link, so it automatically will open in the AssistantWebView (though we are only providing placeholder content for the time being). Onboarding will be wired up in a follow up CL. This CL: - Adds IsAssistantOnboardingDeepLink API. - Adds IsAssistantRemindersDeepLink API. - Adds ParseDeepLinkParams API. Some deep links, like onboarding, will have parameters and so I've added a method to parse parameters from a provided deep link and to return them in a provided map. - Adds unit tests. Bug: b:110986528 Change-Id: Ic17c625bd4b6869a256e1df09b4740fd2b6f1ee0 Reviewed-on: https://chromium-review.googlesource.com/1121581Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#573401}
-
Finnur Thorarinsson authored
This is the first step towards implementing a contact picker for Chrome for Android, broken down into multiple steps for easier reviewing. First part includes simply showing a toast with the message "Not implemented" when text/json+contacts is supplied as an accepted file type. Includes a Finch tie-in and a flag to turn this on manully ("Enable new contacts picker" in chrome://flags. Bug: 860467 Change-Id: Ibbb2a3da6b5d60702bf833129bfbdebd38d03803 Reviewed-on: https://chromium-review.googlesource.com/1127023 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#573400}
-
